GitLab

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8586048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111067 0039d316-1c4b-4281-b951-d872f2087c98

This renames aura::WindowObserver's OnPropertyChanged()
method to have the word "window" in its name, as all of the
class's other methods do.

BUG=none
TEST=built it

Review URL: http://codereview.chromium.org/8621003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111066 0039d316-1c4b-4281-b951-d872f2087c98

GTK 2.24 deprecated all sorts of raw access to object internals in preparation
for GTK3.

BUG=79722
TEST=compiles
TBR=tony,jam

Review URL: http://codereview.chromium.org/8588068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111065 0039d316-1c4b-4281-b951-d872f2087c98

- To measure dropped frames/second.
- To calculate extrapolation of the utilization to play the test video.

Note: Moving Netflix helper functions to a separate class, so they can be reused easily for other Netflix tests.
Review URL: http://codereview.chromium.org/8562006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8620007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111062 0039d316-1c4b-4281-b951-d872f2087c98

This fixes InputMethodMenuButtonTest and
AccessibilityMenuButtonTest, which were failing due to the
same NULL-status-area problem as the tests fixed by r110851
and r111006.

BUG=103482,103492
TEST=ran them for both aura and non-aura chrome os

Review URL: http://codereview.chromium.org/8625004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8550010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111060 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111059 0039d316-1c4b-4281-b951-d872f2087c98

TBR=steveblock


Review URL: http://codereview.chromium.org/8619004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111058 0039d316-1c4b-4281-b951-d872f2087c98

This was split out of http://codereview.chromium.org/8588067/.

BUG=none
TEST=none, but this does make testing easier.


Review URL: http://codereview.chromium.org/8561031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16558
TEST=none
Signed-off-by: Simon Que <sque@chromium.org>

R=satorux@chromium.org,stevenjb@chromium.org,thakis@chromium.org


Review URL: http://codereview.chromium.org/8616003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105056
TEST=Check perf timers, should be back to pre-110853 values.

Review URL: http://codereview.chromium.org/8623007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111055 0039d316-1c4b-4281-b951-d872f2087c98

It looks like it's going to be a little while before chromeos::SystemNotification gets implemented, so I'm marking this test as disabled on Aura for now.  I've got a bug assigned to myself to turn it back on when the notifications are ready.

BUG=104471
TEST=browser_tests FileBrowserNotificationsTest

Review URL: http://codereview.chromium.org/8625006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111054 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8618003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111053 0039d316-1c4b-4281-b951-d872f2087c98

See RFC 5952. I might have even implemented it mostly correctly.

BUG=103969,103968
TEST=ui_tests {PPAPITest,OutOfProcessPPAPITest}.NetAddressPrivate (DescribeIPv6)
TBR=dmichael@chromium.org

Review URL: http://codereview.chromium.org/8590006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111052 0039d316-1c4b-4281-b951-d872f2087c98

Downloads that are flagged as malicious based on content will have a danger type of DANGEROUS_CONTENT.

BUG=102540
TEST=Downloading something flagged as malicious by the SafeBrowsing service shows a warning dialog in the downloads page.


Review URL: http://codereview.chromium.org/8558029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8588067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111050 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, InputMethodMenu might crash with DCHECK if the following conditions are all met:
- Debug build
- An instance of InputMethodMenu or InputMethodMenuButton is created before the first SetImeConfig() call is made. Note that aura_shell::Shell::Init() does this.
- More than 1 layout IDs are passed to SetImeConfig(). Currently, on Chrome (or on browser_tests) start up, 5-6 layouts (Qwerty, Dvorak, ..) are passed by default.

BUG=chromium:103503
TEST=ran try


Review URL: http://codereview.chromium.org/8569011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111049 0039d316-1c4b-4281-b951-d872f2087c98

R=pkotwicz@chromium.org
BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8547014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8603013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111047 0039d316-1c4b-4281-b951-d872f2087c98

This is the believed cause of recent DownloadTest.*nownSize flakiness.

BUG=104310


Review URL: http://codereview.chromium.org/8468028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111046 0039d316-1c4b-4281-b951-d872f2087c98

Now all channels are created using CreateStreamChannel() as they should be!

Review URL: http://codereview.chromium.org/8587053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=SavePageBrowserTest.RemoveFromList browser_test

Review URL: http://codereview.chromium.org/8618010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111044 0039d316-1c4b-4281-b951-d872f2087c98

Revert 111040 - Reland 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation.

Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.

PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.

I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.

I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Original Review URL: http://codereview.chromium.org/8060045
Review URL: http://codereview.chromium.org/8620006

TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/8625003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8619007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111042 0039d316-1c4b-4281-b951-d872f2087c98

Removing code that --force-compositing-mode on all pages including WebUI.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8562007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111041 0039d316-1c4b-4281-b951-d872f2087c98

Reland 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation.

Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.

PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.

I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.

I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Original Review URL: http://codereview.chromium.org/8060045
Review URL: http://codereview.chromium.org/8620006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111040 0039d316-1c4b-4281-b951-d872f2087c98

Deleting a profile can leave the user in a state where their last used profile pionts to a deleted profile. This can lead to crashes when the user opens a new window or uses the menu bar.

Fix was to update the last used profile when deleting a profile.

BUG=104957
TEST=Created 3 profiles, with just one window open deleted the active profile. Verified that File -> New Window opened a window to the next profile. Verified that Users -> Customize customized the next profile.


Review URL: http://codereview.chromium.org/8592006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111039 0039d316-1c4b-4281-b951-d872f2087c98

Use a real .jar because chrome ends up displaying a plain/text .jar file as text.

BUG=104886
TEST=pyauto test: testDeclineDangerousDownload

Review URL: http://codereview.chromium.org/8626001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/8573024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76647,100914
TBR=glider

Review URL: http://codereview.chromium.org/8630001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111035 0039d316-1c4b-4281-b951-d872f2087c98

They pretty much all seem to have started with this CL:
http://src.chromium.org/viewvc/chrome?view=rev&revision=110286

Improvements:
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=110489&graph=total_byte_r
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=150&rev=110489&graph=total_op_r
http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=100&rev=110489&graph=vm_peak_r
http://build.chromium.org/f/chromium/perf/xp-release-single-core/intl1/report.html?history=50&rev=110490
http://build.chromium.org/f/chromium/perf/linux-release/intl1/report.html?history=250&rev=111012
http://build.chromium.org/f/chromium/perf/linux-release/dom_perf/report.html?history=300&rev=111012 (no real change, just increased the range)
http://build.chromium.org/f/chromium/perf/linux-release-lowmem/bloat-http/report.html?history=200&rev=111009

TBR:cmp
Review URL: http://codereview.chromium.org/8622003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111034 0039d316-1c4b-4281-b951-d872f2087c98

This commit adds a check to verify that the NEXT_ID, PREV_ID and
PARENT_ID fields of nodes in the database point to the IDs of other
existing nodes.  The syncable::Database code assumes that this invariant
always holds and seems to do a good job of maintaining it.  This change
ensures that the invariant holds at the time the data is loaded from
disk.

There exist some corrupt databases that cause the directory to behave
unpredictably, since the code assumes the databsae is correct when it is
read from disk.  We can't do anything to fix those databases now that
they've been written, but we can detect the corruption and recreate the
affected databases.

This check is implemented using a set of hash maps, so the cost of the
check should scale well with the number of nodes (it's O(n)).  The
per-node cost of this check also seems cheap compared to the disc
access.  In release mode, loading 5000 nodes from a (probably in-cache)
sqlite database took 53ms, while the check took 9 ms.

BUG=101048
TEST=Manual.  Corrupted the database with external sqlite tool, verified
that the database was deleted and re-created next time Chrome was loaded.

Review URL: http://codereview.chromium.org/8475017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111033 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8620003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102903
TEST=compile

Change-Id: Ifabfb3a0903358ec36bc2eabcccd6d3129972e7f

R=backer@chromium.org,dnicoara@chromium.org


Review URL: http://codereview.chromium.org/8598018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99665
TEST=everything compiles.


Review URL: http://codereview.chromium.org/8589033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111029 0039d316-1c4b-4281-b951-d872f2087c98

TBR=steveblock

Review URL: http://codereview.chromium.org/8592007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=apatrick,gman
Review URL: http://codereview.chromium.org/8619003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111027 0039d316-1c4b-4281-b951-d872f2087c98

35 tests fail because we are setting the localized text for the string userEmail to the logged in email for a user, but in the test environment there is no logged in user.

BUG=105049
TEST=Various browser tests, including DownloadTest.ChromeURLAfterDownload

Review URL: http://codereview.chromium.org/8624004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111026 0039d316-1c4b-4281-b951-d872f2087c98