- 18 Sep, 2020 40 commits
-
-
Guillaume Jenkins authored
The virtual/omt-worker-fetch/external/wpt/xhr/ xhr-timeout-longtask.any.worker.html test is consistently failing on Mac with the following error: "xhr-timeout-longtask.any.worker.html is a all-pass testharness test, but has an extra baseline file. Please remove [the baseline file]." Based on that message, this change removes the baseline file. Bug: 1129910 Change-Id: Ia4462140d9efbc86b12cf679170bd6f5ee26e42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418985Reviewed-by:Aleks Totic <atotic@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#808522}
-
Erik Chen authored
These tests only run on Linux, not on ChromeOS devices. Change-Id: If22d19f0cdcb95efd412d7c099df05361413350f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419007 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808521}
-
Hai Bi authored
In addition to reboot reason, we also need to know if the component has restarted either gracefully or ungracefully. Currently this only applies to Fuchsia. bug: b/168066307 Test: Added unit test Change-Id: Ib0d4882396ce75aae305f0cf42f779343793911c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399132 Commit-Queue: Hai Bi <bihai@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808520}
-
Erik Chen authored
X11 includes should be guarded by USE_X11, not OS_LINUX. Change-Id: I4a5e666bbb01ddb41861d26b9cf999c8cc1e08a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419006 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
NGPhysicalFragment::ScrollableOverflowForPropagation() had an important different compared to LayoutBox::LayoutOverflowRectForPropagation() as it was not including the border box when computing the overflow for propagation. This was causing issues in some cases calculating the overflow of replaced elements in LayoutNG, legacy was working fine. This patch changes AdjustScrollableOverflowForPropagation() to also include the element's border box. Note that we cannot do this for ruby boxes as they have some special behavior (see crbug.com/1082087 and r784709 for details). We need new rebaselines for the following test fast/replaced/border-radius-clip.html This is because when you scroll down you can see the border of the embed object (which was hidden before). BUG=1128984 TEST=css/css-overflow/overflow-replaced-element-001.html Change-Id: I038ccb46db7e00a922e33a387cf10e3c805b81c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414313Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#808518}
-
My Nguyen authored
Strings approved in http://go/cros-lang-settings-ux-writing Currently search by countries isn't supported yet, so removing it from the placeholder Allow customising cr_search_field's search input width to allow for longer placeholder. Mock: http://go/cros-lang-settings-ux-slide#slide=24 Current view: http://screen/8xKZWAVmwCA7Rit Bug: 1113439 Change-Id: I4a8c05c5b0e35df020275145ee32c827d7d27817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416211Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808517}
-
dpapad authored
- Add aria-label and title attributes were missing. - Fix incorrect aria-label$=... assignments where no Polymer bindings are involved. Bug: 1123470 Change-Id: I0d6c33c9338a1494d47e249bd71885f4614566fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418471 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808516}
-
Matthew Denton authored
The syscall broker has unittests in //sandbox/linux/syscall_broker/broker_process_unittest.cc, but these test direct IPC to the broker, and don't use a BPF policy and so aren't integration tests. This CL adds a suite of integration tests that mirror the unittests. This makes it easier to test the user notifier syscall broker, which is even more in need of integration tests since the kernel itself sends the syscall arguments to the broker, rather than a custom signal handler. The integration tests use a new macro BROKER_TEST, built on top of the existing BPF_TEST and SANDBOX_TEST infrastructure. It runs each test with each combination of |fast_check_in_client_| = (true, false), and method of making a syscall (direct IPC, direct syscall, libc lib functions). Bug: 1117351 Change-Id: If1c050f55722487fea51cb479558916983c44985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360802 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#808515}
-
Jimmy Gong authored
MessageSender is responsible for sending serialized proto messages to the remote device. Bug: 1106937 Test: unit_tests Change-Id: I6caa3c77c34b7437ea6798ab680411aa0697ee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415371 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Ankit Kumar 🌪️ authored
Replace usage of PP_Point to gfx::Point in test files. Bug: 1101101 Change-Id: I1f7031e5b1845e0c8f063f3bfbcee877ff591c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413689 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808513}
-
Christopher Cameron authored
Retrieve the IOSurface backing a CVPixelBuffer and, if it exists, construct a GpuMemoryBufferHandle to send via OnIncomingCapturedExternalBuffer. Bug: 1125879 Change-Id: I541285d6ccf08d71c93bc29cce2ed39f00c34cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412994Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#808512}
-
Behdad Bakhshinategh authored
This reverts commit 5f450a37. Reason for revert: Build went green before suppression was needed. Original change's description: > Suppress timed out test (browse:news:washingtonpost) > > Skip system_health.memory_mobile/browse:news:washingtonpost:2019 to prevent time out on android-go > > TBR=jonross@chromium.org > > Bug: 1129885 > Change-Id: I8c6a6dd0e17a2256a0acee15d60dc8a9b154bd5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418321 > Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808488} TBR=jonross@chromium.org,behdadb@chromium.org Change-Id: I3a205cbe1d3e3b239564d308d670a694031e2759 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419571Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808511}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600430187-d29b7adeb10d561801760f89eec79cec9539af2e.profdata to chrome-linux-master-1600451996-5d0e4e7b2c6ce44a4ee6fbde79bf678531b4af8e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Idf1f417b0359c7893a068374c3e8016975ced0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808510}
-
Dave Tapuska authored
Agent Clusters can be different even if the origins are the same. BUG=961448 Change-Id: I1cfc8d7c386735b6c718ba6da5d932d5b459980d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416263 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808509}
-
Mehran Mahmoudi authored
This CL will change the current startup behaviour for FDT. Instead of blocking the tab restoration and initializing the FDT, we'll do both in parallel. Bug: 1129478 Change-Id: I0b4adc42960434ae38d62cb9fa763f94ae9ad14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416929 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808508}
-
Jao-ke Chin-Lee authored
As part fixing washed out colors due to changes to a combination of chromaticity and luminosity changes, color spaces were pinned to sRGB for SDR content instead of using the full native color space to boost saturation. Now that other fixes have stabilized the situation, use the native color space. Bug: b:158126931 Change-Id: I57140d31897a3aaf5d8a4debeff99e4db5ea76d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415269 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#808507}
-
Akihiro Ota authored
Bug: 1127037 Change-Id: Icde8546beba54334b08a2a6af1ea49b3824a5ac2 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406542Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#808506}
-
danakj authored
This causes v8 to crash, instead we pass no 3rd argument at all, which it will handle gracefully as an undefined. R=ishell@chromium.org Bug: 1093391 Change-Id: I1fdfe64bef348062495e2d5d6db940f36f2db982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419141Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c01b26490a54..1da25e510364 2020-09-18 cwallez@chromium.org Add -Wduplicate-enum and -Wrange-for-analysis If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id62c96aa95be764071c1388f59237f1ea41ffb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419242Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit dcefb79d. Reason for revert: Broke win-archive-rel https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17700 Original change's description: > Roll DevTools Frontend from eed20333dd52 to b3859e8d65e6 (4 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eed20333dd52..b3859e8d65e6 > > 2020-09-18 tvanderlippe@chromium.org Reland "Remove support for remote modules" > 2020-09-18 andoli@chromium.org [ts] Typecheck components/ImagePreview.js with TypeScript > 2020-09-18 aerotwist@chromium.org Adds remote base helper > 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingSettingsTab.js with TypeScript > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1011811 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Icb5d63b8951ec5e54dedc1c8fe8e4580fcfd9877 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419248 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#808487} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6438356ecd6b02352eda3d5552072bae1ce05615 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418803Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#808503}
-
Ben Pastene authored
include_unwind_tables was removed from this bot a while ago when binary size metrics were spun up for fear that the tables would inflate the binaries. However, we don't actually ship linux-chromeos binaries, so their size metrics aren't very representative. Plus, the lack of the tables makes sheriffing more difficult since test failures won't produce full stack traces. Adding the tables back to the bot should make sheriffing it easier. Bug: None Change-Id: I67e042dfd1640d014fad62b741966ee211bb557f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419002Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808502}
-
Sunny Sachanandani authored
This pixel test relies on using a raw YUV file in the Chromium checkout for the fake video capture device. This doesn't work when the test runs on another device than the test harness like for Android and ChromeOS. TBR=zmo@chromium.org,behdadb@chromium.org Bug: 1129879 Change-Id: Iaf0d410d7a83ea06c9add4696ee4ad7de8794d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419334Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
Paul Moy authored
Expose a new routine through cros_healthd's ServiceConnection. This routine runs memtester on all of the device's available memory (except for 200MB reserved for the OS) to check that the device's memory is working correctly. The routine is modeled after crosh's memory_test. Long-term, crosh's memory_test will be migrated to this new implementation. The migration is blocked on cros_healthd becoming available on all boards, which should be done in a couple of weeks. This is part of an effort to consolidate all existing diagnostic routines into cros_healthd. Bug: chromium:1113897 Change-Id: I3bb25c1f04c1394e541af9c3c9ef66b8ae6ecd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412956Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808500}
-
Daniel McArdle authored
net_backoff_entry_serializer_fuzzer found a test case that causes the second deserialize step in TestDeserialize() to fail. We CHECK that the return value is truthy, but it is nullptr. Prior to this CL, BackoffEntrySerializer::DeserializeFromValue() would return nullptr when the parsed absolute release time was negative. There are two reasons for removing this less-than-zero comparison: (1) It complicates the fuzzer's logic for predicting the return value. (2) The value comes from TimeBase::ToInternalValue(). We should not assume we understand the internal representation of a time value. Bug: 1113344 Change-Id: I1e1e9d5a422d116e2f9682bab42b2acefb5a0fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398902 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#808499}
-
Marc Treib authored
The commandline param --gaia-config allows specifying a json file that overrides various Gaia-related URLs. This CL adds support for overriding the Sync URL via the same file. Bug: 1129493 Change-Id: Ieb1fee4b32f247acb69fde659c2c0c9564bcb130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418334Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808498}
-
Raphael Kubo da Costa authored
Even after r807421 those tests are presenting some occasional flakiness in the form of timeouts and, in a few cases, crashes in other parts of the stack. Clean up the code a little bit to make the code easier to follow and perhaps reduce the chance of timeouts: * send_message_to_frame() does not need to be an async function. * Use t.add_cleanup() to a few tests to make sure any iframe we add is properly removed even if an error occurs. * Remove all calls to the assert_*() functions from both the code path used by initialize_generic_sensor_tests() as well as generic_sensor_mocks.js, so that we no longer need to include testharness.js in the iframe handler page. * Make the onmessage handler in the iframe page also send a reply when errors occur. Bug: 1073865 Change-Id: Id6f682c95212d7ad9662f8aadad31c866752b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418333 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808497}
-
Alexander Cooper authored
It was discovered that the XRSessionModeRequest data was incorrectly labeled; however, the data source for this has (for quite a while), been the same as the XRSessionMode enum. This change converts the enum value to the properly labeled XRSessionMode enum, and removes the enum that is now no longer used (XRSessionModeRequest). Change-Id: I2177243f7d387f846b43b77e1996320677485978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410356 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#808496}
-
Michael Hansen authored
Invalidate send and receive surfaces to make sure we start or stop advertising based on suspend and resume events. This introduces the LockScreenStatusManager to encapsulate Chrome OS-specific observers. Bug: b:166174379 Bug: 1119993 Change-Id: I26f715be5affcbce14711ab9aeeb6c9b005ce23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412477 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#808495}
-
chrome://flagsAdrienne Walker authored
Bug: 582750 Change-Id: I915211564079f2619e04fd10c5164ea30f63b663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415209 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#808494}
-
Ted Meyer authored
for device 0x0166 with the 9.18.13.* drivers (3788 is the last patch number that is crashing) Bug: 1038006 Bug: 1126834 Change-Id: I0ec11b6b9f824f88d29cedea1ef79572fd3d6168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415138 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808493}
-
Carlos IL authored
Change-Id: Ic473c2bdc1e06214c292afcf9c2e25c1d5d93830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417449 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#808492}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac3fc4afea5d..ce9efee28b62 2020-09-18 bpastene@chromium.org cros_test: Clobber stateful when flashing the DUT. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com,bpastene@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com,bpastene@google.com Change-Id: I8a97d41c60ab071a75e04b1f6253b6506e241dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419244Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Icd698f3ab4cdd8febec55a0b87054da8fb7d7be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419261Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#808490}
-
manukh authored
Previously, there were overloads accepting values of std::string, int, and base::Time. This CL adds 1 more overload accepting values of base: :string16 in order to not require callees to convert with base: :UTF16ToUTF8(). Change-Id: I376faf110770c3db142ddefb55995858a37d8ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417306Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#808489}
-
behdad authored
Skip system_health.memory_mobile/browse:news:washingtonpost:2019 to prevent time out on android-go TBR=jonross@chromium.org Bug: 1129885 Change-Id: I8c6a6dd0e17a2256a0acee15d60dc8a9b154bd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418321Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808488}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eed20333dd52..b3859e8d65e6 2020-09-18 tvanderlippe@chromium.org Reland "Remove support for remote modules" 2020-09-18 andoli@chromium.org [ts] Typecheck components/ImagePreview.js with TypeScript 2020-09-18 aerotwist@chromium.org Adds remote base helper 2020-09-18 tvanderlippe@chromium.org Typecheck mobile_throttling/ThrottlingSettingsTab.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icb5d63b8951ec5e54dedc1c8fe8e4580fcfd9877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419248Reviewed-by:
-
Ben Pastene authored
The current builder_group is proving difficult due to recipe reasons. A whole new builder_group should be easier. Bug: 1129540 Change-Id: Iee101b7f915ec158d3b761408a36e6fc62c4da21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419134Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#808486}
-
Piotr Bialecki authored
Add 2 samples leveraging prototype implementation of depth API. Change-Id: I94514a905d694f168983f1afa9a9d4424a385188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417064 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#808485}
-
Sami Kyostila authored
This patch adds support for interned data in typed trace points. This helps to reduce trace size for frequently repeated data. As an example, an interning index for base::Location could be defined as follows: struct InternedLocationIndex : public perfetto::TrackEventInternedDataIndex< InternedLocationIndex, perfetto::protos::pbzero:: InternedData::kSourceLocationsFieldNumber, Location> { static void Add(perfetto::protos::pbzero::InternedData* interned_data, size_t iid, const Location& location) { auto* loc = interned_data->add_source_locations(); loc->set_file_name(location.file_name()); loc->set_function_name(location.function_name()); loc->set_line_number(location.line_number()); } }; A corresponding typed trace point using the index could look like this: TRACE_EVENT("cat", "Name", [](perfetto::EventContext ctx) { auto* log = ctx.event()->set_log_message(); size_t iid = InternedLocationIndex::Get(&ctx, FROM_HERE); log->set_body_iid(iid); } Bug: b/156727531 Change-Id: I5a78784be688071f7373ac1655b1ce74428f7b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410117 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#808484}
-
Mason Freed authored
The synchronous parser previously had a fixed token budget. This CL enables Finch experimentation on the number of tokens for that budget. If no Finch is enabled, the budget stays the same, 500. Bug: 1128608 Change-Id: I5a0d21833a3b254188dce86fc019a494ce3e3dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412827Reviewed-by:
Richard Townsend <richard.townsend@arm.com> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#808483}
-
