- 04 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d21a8fb4dbe..d5886280043b 2020-12-04 kimanh@chromium.org [LMI] Add keyboard navigation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ff8b952e24706d02013581a642f57b258db7b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833867}
-
Norman Rosas authored
metadata from OWNERS files in the next repos: //components/cast... //components/certificate.. //components/chrome_cleaner //components/client... Bug: 1113033 Change-Id: I67561c5b8a8796ca6307fd088855d24ac089e317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564389 Auto-Submit: Norman Rosas <normando@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#833866}
-
Fabrice de Gans-Riberi authored
Open Screen does not end the Cast Streaming session on MessagePort disconnect. This change ends the session on the receiver end when the Cast Streaming MessagePort disconnects. This is a necessary change to unit test the Cast Streaming Receiver. Bug: 1110490 Change-Id: I272da7bad03c5f7efa31d3a8eb30f3ebdfe49f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572167 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833865}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4fd38346d19724d48a07aa5e9f87749f775bc4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575576Reviewed-by:
-
Jeffrey Kardatzke authored
When the VaapiVideoDecoder was released, if it was using the CdmContext it would have a callback associated with the CDM. Upon destruction of the decoder, that callback would be destroyed automatically which makes a call into the CDM. The CDM is being destructed on another thread, so there was a race and this could cause a crash. The fix is to maintain a CdmContextRef in the decoder which keeps the CDM alive until the decoder is destroyed. BUG=b:153111783 TEST=Page refresh 10 times in a row w/ CDM did not crash Change-Id: I0c6f19753b324e7d89db0bd79f6108d5de27ffa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572262 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833863}
-
Victor Costan authored
This CL fixes issues I missed while reviewing https://crrev.com/c/2467899. * Use base::SequenceChecker instead of making thread-hostile checks. The quota client doesn't need to run on the IO thread, it just needs to run on the same sequence as NativeIOContext. * Replace the deprecated DISALLOW_COPY_AND_ASSIGN() macro with deleted copy constructor and assignment operator. * Remove qualifier (storage::QuotaClient::) from QuotaClient callback types. This reduces churn when QuotaClient becomes a mojo interface. * Remove unused GetClientTypeFromOwner() declaration. * Remove self-#include in header. No functional changes are introduced. Bug: 1137788, 1016065 Change-Id: I34f59e128e877358d16f197bc6e6f0ac79de5df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570318 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833862}
-
Nasko Oskov authored
Interstitial pages no longer work as overlays, they are just regular error pages. This makes the PAGE_TYPE_INTERSTITIAL value in PageType obsolete, therefore this CL removes it from the codebase. Bug: 1077074 Change-Id: I9487bc97018b0f832f6d5b70cda04ea217bc8031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570126Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833861}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/46df5d14ee80..30f45a6f043f 2020-12-04 vmiklos@collabora.co.uk Add FPDFAnnot_GetLine() API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I61ab716e018bcbe36948826e03a1f6596e575e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575219Reviewed-by:
-
Jarryd authored
This change is the beginning of the implementation of the integration test system for the desktop PWA system. Design doc: https://docs.google.com/document/u/1/d/1Gd14fjwA4VKoRzL2TAvi9paXwyh36ehlS4gbpUmUeeI/edit# Bug: 1145240 Change-Id: Iaa6f7620e40d137ab8e771446bcead23ad7f93ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536138Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833859}
-
Tommy Li authored
This CL changes the last_mod parameter to use base::Time and renames it to be last_modified. It also updates all the callsites, with no functional change, just a cleanup. Bug: 1022775 Change-Id: I8c82d11727c20bfddff42342500f905149a468a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575043 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833858}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/d5148db386ce..bbb828223e9c $ git log d5148db38..bbb828223 --date=short --no-merges --format='%ad %ae %s' 2020-11-25 jonathan.wright Update libjpeg-turbo to v2.0.90 (2.1 beta1) Created with: roll-dep src/third_party/libjpeg_turbo This CL also updates our expected test results to reflect the modified block-smoothing algorithm in the libjpeg API library, introduced in libjpeg-turbo 2.0.90 (2.1 beta1.) Bug: 922430 Bug: b/135180511 Bug: 919548, 1145581 Change-Id: I156c67564f783362634d02551336c5e1cd9e47b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564483 Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Reviewed-by:
Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#833857}
-
Ben Pastene authored
It's failing with "not supplied via -var or -varsfile" errors, which are a KI when running tast tests on Chrome bots. This disables the test while we work on supporting these types of tests. No-try'ing to speed up LKGM updates. No-try: True Bug: 1115622 Change-Id: Ia6d7e42ee9f8321bda920bf958feac1de758f029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575372 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833856}
-
David Bienvenu authored
This is the list of directories excluded from presubmit checks for base::Bind, base::Closure, and base::Callback. Bug: 1007788 Change-Id: Iea98671c4fcaeab39697429fd7526cae0ad2da5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575196Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833855}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I2e78b4bef26a6448cffb9d0bb0c9aec8c6ef1574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573129Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#833854}
-
Trevor Perrier authored
This CL adds all possible Android locales and those in l10n_util to the CL3DLanguageCode enum values. Bug: 1133736 Change-Id: Ie7a2f4a0d8ffe52c8fe88157e8df41020afa2bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569853 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833853}
-
Nicolas Dubus authored
- cpu_profiler_->StartProfiling() now returns a status enum, of either kStarted, kAlreadyStarted, or kErrorTooManyProfilers. This change throws an exception and returns a nullptr when either kAlreadyStarted or kErrorTooManyProfilers is returned R=acomminos@fb.com, npm@chromium.org, petermarshall@chromium.org, ulan@chromium.org Change-Id: Ie9c6df3c836119064c30fffc54ee7f21f34d9eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549465Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Nicolas Dubus <nicodubus@fb.com> Cr-Commit-Position: refs/heads/master@{#833852}
-
Andrew Grieve authored
Bug: None Change-Id: I3473e5798ea1b790a22adecd033777637aca023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574829 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#833851}
-
Liquan (Max) Gu authored
In PaymentUiService, the way to get the selected payment app is through mPaymentMethodsSection, in spite of the fact that getSelectedPaymentApp() is available. This CL is to replace these mPaymentMethodsSection usages with getSelectedPaymentApp(). This will help moving the payment app management logic out of PaymentUiService. Bug: 1155614 Change-Id: I870d9b24f3cc78e007817c7b67bf9ca0639ccf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574598 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833850}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibd5feccf0a802824695a4165252d501b43d2feaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575338Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#833849}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/extensions. Bug: 1113033 Change-Id: I7bbea659093e20086f9ac7eca7419cd50129b061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572786 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#833848}
-
Liquan (Max) Gu authored
This CL adds PaymentUiService#showShippingAddressError() to encapsulate the UI logic so as to simplify the boundary between the UI and the business logic. Bug: 1155582 Change-Id: I144785eb833da259a6752f2f20d193f5f61c2e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572909 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Bottom controls UI was enabled only on tabbed chrome UI but a bug in https://crrev.com/c/2567077 caused it to run for other UI modes as well. This CL partially reverts the changes in the CL and let the root ui coordinator for tabbed mode handle the initialization again. Bug: 1154485, 1142286, 1154582 Change-Id: I834958fd6d3e620d928064a800c2499bb0deba6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569435Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#833846}
-
Alison Maher authored
This change updates the field_group of all the internal forced colors properties to "*" to ensure that they are all stored in a rare data structure. Bug: 970285 Change-Id: Ibfdac0b40980824e79eab51f9f42e807d94eda97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566691Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833845}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/079a95bc7240..b28382109909 2020-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I8e233de31470988fa8d18e1b4efb6f43350757e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575437Reviewed-by:
-
Jeroen Dhollander authored
Previously the Quick Answers view was added first to the context menu, causing it to jump as items were added/removed to the menu. Bug: b/173569669 Test: Manually deployed and verified we no longer get multiple |OnBoundariesChanged| events. Change-Id: I6b8e52b7e24f653dcf033eb218c26b61f4de86e4 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567183Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833843}
-
Trent Begin authored
This change groups the network diagnostic routines into similar categories to simplify the UI. This brings the app in closer alignment to the original Chrome App. https://screenshot.googleplex.com/9TA8y5z4gDKC3hB Bug: chromium:1142857 Change-Id: I6336106a0d6b945012d6e6c93b98f1f0a46fca8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561294 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833842}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607082643-9d7584569e97498303bfc8f363e6d14838d94e40.profdata to chrome-linux-master-1607104719-553836ec892e604b847a609e48d12198e967747c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ice7fe7207ba4acb9b2ed520c51409bddd3f9553f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574902Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607082643-ec3aa91ed6cc9a4e56961da34010bfe7d1bfcfad.profdata to chrome-mac-master-1607104719-e1d1a8dd7fb3b6aba7965596c29afef7497a651e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie443972e14285fb4ded29a1c784d90d768b7722b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575107Reviewed-by:
-
Yann Dago authored
Create a new ClearBrowsingDataOnExitList that takes a list of browsing data to delete when chrome shuts down. In case the data was not properly deleted at shutdown, an attempt to delete them will be made at the next startup. This policy will keep the browser alive until the browsing data is properly deleted. This policy has no effect unless the SyncDisabled policy is active. BYPASS_POLICY_COMPATIBILITY_CHECK=<BrowsingDataLifetime had a bug in 88> Bug: 1026442 Change-Id: Iea425b9f9a61086fda118a28746bbf77853b65eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440238 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#833839}
-
Becca Hughes authored
Change-Id: I33bbb1cca27e8973414a6520b7c76cf1135949b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575038Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#833838}
-
Sophie Chang authored
Bug: 1112500 Change-Id: I1fdb815bf0614055e4195529f52d3e33498193c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569849 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Eugene But authored
Move kRemoveProtectionFromPrefFile check to a later stage when Finch is actually initialized. Before this change kRemoveProtectionFromPrefFile chekh would always return false. Bug: None Change-Id: I4cb5eeb5b96760572ffa34146b15b9361fb7cd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568217 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833836}
-
Avi Drissman authored
Chromium requires 10.11, so now SDK constants can be used. Bug: 1153883 Change-Id: Ie4c206873adc1f5aca6682cf1623de316086f17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572697 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#833835}
-
Gordon Seto authored
Extract fetching pending eSIM profiles logic into esim-manager-utils. This is to avoid duplicate logic when querying for eSIM profiles in the settings page in follow-up CL crrev.com/c/2572748. Bug: 1093185 Change-Id: I0181c48f704fab518124ef2422ef38814206b86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570545 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Matthew Jones authored
This reverts commit 79b4e301. Reason for revert: Suspected cause of test failures on android-lollipop-arm-rel: https://ci.chromium.org/ui/p/chromium/builders/ci/android-lollipop-arm-rel/5950/overview ThreadCacheTest.PeriodicPurgeStopsAndRestarts ../../base/allocator/partition_allocator/thread_cache_unittest.cc:525: Failure Value of: ThreadCacheRegistry::Instance().has_pending_purge_task() Actual: false Expected: true Original change's description: > [PartitionAlloc] Don't perform expensive allocations to fill the thread cache. > > Bug: 998048 > Change-Id: Ie18db70f78188e4541aa4d5a0f44da2ce166524e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569664 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833771} TBR=lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,bartekn@chromium.org Change-Id: I2a9cbb1bbd2b4ca3eae9580c510f88f05edeadb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575003Reviewed-by:
-
Tom Sepez authored
Broken at https://chromium-review.googlesource.com/c/chromium/src/+/2417091 The build configuration that provides the PDF_ENABLE_XFA symbol does not appear to be present for files at the pdf/ directory level, only for those at the pdf/pdfium/ directory level. To avoid requiring these definitions at a higher level (since this minimizes recompilation when the value changes), add a helper function in pdf/pdfium/ to return this information. Change-Id: I2499816aa9e5ac08c7064a961d2ed4f70c7772f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575042 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#833832}
-
Matthew Mourgos authored
This change is in preparation of multipaste related VK API changes, where the ChromeVirtualKeyboardDelegate will need to be a ClipboardHistoryControllerObserver. This will allow the VK to observe clipboard history changes. Bug: 1099318 Change-Id: I5535d45255b137219cf76b76f6d94c9bfb5ca9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573636Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Chris Mumford authored
IndexedDBContextImpl had the following two member variables: IndexedDBDispatcherHost indexed_db_factory_; std::unique_ptr<IndexedDBFactoryImpl> indexeddb_factory_; The first name was confusing. Renamed to: IndexedDBDispatcherHost dispatcher_host_; to avoid confusion. Bug: none Change-Id: Iaefb0e077f94ea2e1639a4c7aeb28a29f9a3ffab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575037Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#833830}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b917ab64e84b..2d21a8fb4dbe 2020-12-04 cjamcl@chromium.org Add WATCHLISTS entry for lighthouse 2020-12-04 bmeurer@chromium.org [LMI] Add support for inspecting WebAssembly.Memory objects. 2020-12-04 tvanderlippe@chromium.org Port pretty-printing layout tests to Karma 2020-12-04 kimanh@chromium.org [LMI] Show signed/unsigned values next to each other, if different 2020-12-04 tvanderlippe@chromium.org Improve formatting of do-while loop 2020-12-04 tvanderlippe@chromium.org Fix permissions for test scripts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202,chromium:1155566,chromium:983851 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3f64c8136baa665dfdbaafad82c370ae754d2d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575216Reviewed-by:
-
Stephen McGruer authored
Using wpt-import in Chromium 1aa111f7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mstensho@chromium.org: external/wpt/css/css-break external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/css-contain external/wpt/css/css-grid yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ic7dc1808879a15bc57c0b4d65d22a323780a9a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572988Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#833828}
-
