GitLab

Recent change (crrev.com/398263002) broke the slide show mode and we cannot
enter the slide show mode from the mosaic view due. The CL adds null check to
fix it.

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/403733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284042 0039d316-1c4b-4281-b951-d872f2087c98

Correct comment, and change ptr argument to const ref in
CacheNewServerConfig.

Merge internal change: 70794754
https://codereview.chromium.org/398643003/


Allow QUIC clients to accept STK/SCFG updates on an existing connection.

Merge internal change: 70794017
https://codereview.chromium.org/393953011/


To be used in internal change: 70123647 when processing a mid-connection
update of SCFG/STK.

QUIC: Factor out updating cached server config into a new method.

Merge internal change: 70736560
https://codereview.chromium.org/398623003/


Adding logging to quic for tracegraf

This should not change behavior. set_logging_visitor is only used in a
test and will be done in a followup CL.

Adding logging to quic in a protobuf that will be used by tracegraf (not
yet used in production).

Merge internal change: 70735705
https://codereview.chromium.org/398683002/


Reduce the scope of a spurious WARNING log when processing strike
register errors to something that truly shouldn't happen.  Also change
log level to DFATAL.

Merge internal change: 70716413
https://codereview.chromium.org/391283003/


Enable Kathleen Nichols min rtt algorithm with a 1 minute window in
QUIC's BBRTcpSender.

Merge internal change: 70683520
https://codereview.chromium.org/394023005/


Moving the work currently done in the QuicSession constructor to
Initialize().

This is worthwhile because currently it's possible for virtual functions
to be called from under the stack of the QuicSession constructor, which
is confusing and annoying to debug.  Example: if a bad config (without
SetDefaults called) is passed to the quic server session, it calls
SetFromConfig which calls SetIdleNetworkTimeout which calls
CheckForTimeout which can technically call SendConnectionClose which
calls CloseConnection which calls visitor->OnConnectionClosed() on the
session, which still doesn't have a good vtable.

As it turns out, this puts the internal server in an inconsistent state
which causes all sorts of other annoying to debug things.  This can be
solved by never giving an invalid config (heh) or, say, not doing a ton
of complicated work in a constructor in the first place.

This hopefully will also make some unit testing earlier as you don't
have to do quite as much work in test classes.

Moving work from the QuicSession constructor to InitializeSession()

Merge internal change: 70661792
https://codereview.chromium.org/393953009/


Change QUIC's pacing sender to send at 1.25x the estimated bandwidth
during congestion avoidance, instead of 2x.

Merge internal change: 70658053
https://codereview.chromium.org/393943004/


Populate FasterExtraStats for QUIC requests
if --faster_stats_extra_logging != 0

Merge internal change: 70419510
https://codereview.chromium.org/396533003/


Fix a newly introduced bug in QUIC's PacingSender where burst_tokens_
would never be set back to 10 after the initialization, because
OnCongestionEvent is never called with bytes_in_flight of 0.

Merge internal change: 70371419
https://codereview.chromium.org/397513002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/391383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284041 0039d316-1c4b-4281-b951-d872f2087c98

NavigatorContentUtils is stable feature. So, we don't need to keep this command line flag.

BUG=343941

Review URL: https://codereview.chromium.org/400613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/390083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284039 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add WorkerThread based methods for start/stop of worker threads. (https://codereview.chromium.org/393283003/)

Reason for revert:
Breaking blink bots.

Original issue's description:
> Add WorkerThread based methods for start/stop of worker threads.
> 
> This patch adds notification methods for start/stop of worker threads which accept a WorkerThread parameter. This is needed in order to move the worker threads in blink to use WebThread instead of its own version.
> It also adds support for shared timer to WebThreadImpl.
> 
> BUG=301515
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284008

TBR=jochen@chromium.org,sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=301515

Review URL: https://codereview.chromium.org/404753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284038 0039d316-1c4b-4281-b951-d872f2087c98

This was originally part of https://codereview.chromium.org/384023002/, but was taken out because Rietveld choked on the binary file moves. (Which it is still doing here, so I have to dcommit this one.)

BUG=385113
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/405433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284036 0039d316-1c4b-4281-b951-d872f2087c98

I'm moving events parameter from the results of Timeline.stop command to Timeline.stopped event.

BUG=394780

Review URL: https://codereview.chromium.org/399943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284035 0039d316-1c4b-4281-b951-d872f2087c98

A common usage of InterfacePtr is:
(1) Create a new InterfacePtr instance.
(2) BindToProxy() is called to bind the interface pointer to an implementation.
(3) Immediately, the message pipe handle underneath the interface pointer is detached and sent over another message pipe.

In step (2), currently we do all the setup work for the interface pointer: construct Router and Connector instance, post task to start watching the message pipe handle, etc. All the work is thrown away at step (3).

With this CL, the proxy setup work won't be done until actual read/write is needed.

BUG=394883
TEST=None

Review URL: https://codereview.chromium.org/400043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284034 0039d316-1c4b-4281-b951-d872f2087c98

 * Add the keyboard handler to modify the viewport's offset values.

 * Make the viewport class generate CSS transform expressions including the
   offset value.

BUG=245926
TEST=manually
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/398283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284033 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/)

Reason for revert:
Speculative revert to fix XP bots.

XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677

This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it.

Original issue's description:
> Migrate accessibility from RenderView to RenderFrame and RVH to RFH.
> 
> In preparation for out-of-process iframes, move almost all accessibility
> functionality from RenderView to RenderFrame, and from RVHI and RWHI
> to RFHI.
> 
> In addition, the accessibility mode is moved to WebContents, and changing
> the mode triggers changing it on all frames.
> 
> BUG=368298
> R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994

TBR=dmazzoni@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/407493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284032 0039d316-1c4b-4281-b951-d872f2087c98

Introduce ContainerParams to control the container's behavior

Next Steps:
* Add explicit z-order priority and add check to catch violation.
* Refactor init process and add unit test


BUG=394121
TEST=This depends on the app_shell's initialization. I'll work on refactoring so that test/shell/main uses the same initialization process and add test.

Review URL: https://codereview.chromium.org/404563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394655
TEST=manually
R=fukino@chromium.org

Review URL: https://codereview.chromium.org/403723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284030 0039d316-1c4b-4281-b951-d872f2087c98

It currently generates invalid code, see
http://llvm.org/bugs/show_bug.cgi?id=20354

BUG=none

Review URL: https://codereview.chromium.org/393193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349211
TEST=Existing tests pass.

Review URL: https://codereview.chromium.org/398163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284028 0039d316-1c4b-4281-b951-d872f2087c98

Its last client disappeared in https://codereview.chromium.org/373643002/

BUG=none

Review URL: https://codereview.chromium.org/395403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284027 0039d316-1c4b-4281-b951-d872f2087c98

This allows an app to determine whether a window created with
"transparent_background" will work as expected.

This also allows the app to detect when "transparent_background" might
stop working, e.g. when Windows changes from Aero to Classic.

This also fixes the bug where "transparent_background" windows
created in Classic render as black rectangles.

BUG=260810

Review URL: https://codereview.chromium.org/375183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303491

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283225

Review URL: https://codereview.chromium.org/392533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284025 0039d316-1c4b-4281-b951-d872f2087c98

This makes things much more clearer and in order with the rest of
strings/grit targets.

BUG=323025
TEST=None
R=tony@chromium.org,lcwu@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/398873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284024 0039d316-1c4b-4281-b951-d872f2087c98

The AdvancedMockContext previously did not override registerComponentCallbacks
and unregisterComponentCallbacks. The implementation of these methods in
Context calls getApplicationContext before delegating the call to it, and since
AdvancedMockContext returns |this| in getApplicationContext, this leads to a
loop.

This CL adds overrides for these two methods that make the calls to the base
context instead, which will typically either be a MockContext or the target
context being instrumented.

BUG=394464

Review URL: https://codereview.chromium.org/404553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284023 0039d316-1c4b-4281-b951-d872f2087c98

It's only implemented and used if NSS (or later OpenSSL) provide the
certificate information. The check was checking against use_openssl rather than
use_openssl_certs.

BUG=394959

Review URL: https://codereview.chromium.org/399143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284022 0039d316-1c4b-4281-b951-d872f2087c98

In Yosemite, the fullscreen button replaces the zoom button. We no longer need
to swizzle the method that returns the origin of the fullscreen button.

BUG=388772

Review URL: https://codereview.chromium.org/402753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284021 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284020 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces NetworkingPrivateDelegate and moves (almost) all extension API specific code into a common NetworkingPrivateApi class.

The ChromeOS specific Delegate is now in networking_private_api_chromeos.cc (now a profile keyed service).

The Windows/Mac specific Delegate is now in networking_private_service_client.cc. networking_private_api_nonchromeos.cc has been deleted.

BUG=392708

Review URL: https://codereview.chromium.org/378103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284019 0039d316-1c4b-4281-b951-d872f2087c98

Also enhance SmartClipProviderTest to emulate what OEM will do.

BUG=388961
TEST=passed SmartClipProviderTest

Review URL: https://codereview.chromium.org/391813006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284018 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284017 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178381:178409&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/399323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284016 0039d316-1c4b-4281-b951-d872f2087c98

This patch handled opening of already  blocked popups,
here it creates the webcontents and load the url in the
webcontents and invokes AddNewContents() of
ChromeWebContentsDelegateAndroid class so that it will notify
the application to add a new tab.

BUG=

Review URL: https://codereview.chromium.org/368983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284015 0039d316-1c4b-4281-b951-d872f2087c98

This patch stores the state of active installs in the InstallTracker
for global access. This allows various install initiators to check for
duplicate installs before proceeding.

Install progress bars in the app launcher can be initialized with the
state of an active install.

BUG=393854
TEST=unit_tests, browser_tests
For manual testing steps, please see bug.

Review URL: https://codereview.chromium.org/389613006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284014 0039d316-1c4b-4281-b951-d872f2087c98

The experiment is no longer active, marking the PLT histograms as obsolete.

BUG=386888

Review URL: https://codereview.chromium.org/392823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284013 0039d316-1c4b-4281-b951-d872f2087c98

The 'L' release of Android will remove __system_property_get from the NDK.
Until we can replace all calls of __system_property_get, this CL adds a
temporary work-around for builds compiled against the 'L' API.  The workaround
involves creating a stub __system_property_get, which uses dlsym to dynamically
load the address of the real __system_property_get symbol in libc.so (which is
still available as a hidden symbol on the devices libc.so dispite having been
removed from the NDK).

BUG=392191,393903

Review URL: https://codereview.chromium.org/393923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284012 0039d316-1c4b-4281-b951-d872f2087c98

This is currently unused and not necessary in future Chromecast code.

R=lcwu@chromium.org,jam@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/396213009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284011 0039d316-1c4b-4281-b951-d872f2087c98

List the dependent extensions under the shared module and change message
from generic policy message to be more specific for shared modules
to explain why the extension cannot be disabled or uninstalled.

BUG=393670

Review URL: https://codereview.chromium.org/403593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284010 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/396303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284009 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds notification methods for start/stop of worker threads which accept a WorkerThread parameter. This is needed in order to move the worker threads in blink to use WebThread instead of its own version.
It also adds support for shared timer to WebThreadImpl.

BUG=301515

Review URL: https://codereview.chromium.org/393283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284008 0039d316-1c4b-4281-b951-d872f2087c98

N.B. I had to move the sawbuck_provider in the .wxs out of the
installation directory. Even though it only contains registry changes,
candle will complain if it is not inside a directory, but the
application directory is platform specific, whereas sawbuck_provider is
always 32-bit.

BUG=394467

Review URL: https://codereview.chromium.org/398173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284007 0039d316-1c4b-4281-b951-d872f2087c98

Broke gles2_conform_test on chromium.gpu.fyi bots. See Issue 393677 for details.

> gles2_conform_test: update expectations for CrOS Atom.
> 
> BUG=393677
> TEST=Ran without the pci id on daisy which bypassed the tests.
> 
> Review URL: https://codereview.chromium.org/393223002

TBR=ihf@chromium.org

Review URL: https://codereview.chromium.org/403573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394908
R=oshima@chromium.org, sadrul@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/404613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284005 0039d316-1c4b-4281-b951-d872f2087c98

[chromedriver] Reenable ParseCapabilities.MobileEmulationDeviceName, since it no longer depends on files generated from Blink sources.

BUG=392430

Review URL: https://codereview.chromium.org/399173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374932
TBR=jam
TEST=manual

Review URL: https://codereview.chromium.org/392273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284003 0039d316-1c4b-4281-b951-d872f2087c98

The flag is used for testing purpose, and was left out.
Flywheel protection is on when flag is on or setting is on.

BUG=381896

Review URL: https://codereview.chromium.org/398853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284002 0039d316-1c4b-4281-b951-d872f2087c98