Commits · 9d43955551544e2954c4e085c8b34c866543f38e · eriksson monteiro / tangled

02 Dec, 2011 40 commits

Remove suppression. This has been fixed in WebKit and rolled into Chrome. · 9d439555

simonjam@chromium.org authored Dec 02, 2011

BUG=104749
TEST=valgrind bots

Review URL: http://codereview.chromium.org/8775065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112768 0039d316-1c4b-4281-b951-d872f2087c98

9d439555

Fix use-after-free. OnChildDied deletes the current object, so we shouldn't... · 91980ff2

jam@chromium.org authored Dec 02, 2011

Fix use-after-free. OnChildDied deletes the current object, so we shouldn't call member functions afterwards. I'm refactoring this code in another cl, but figured I'd fix this separately to make things clearer.
Review URL: http://codereview.chromium.org/8776041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112767 0039d316-1c4b-4281-b951-d872f2087c98

91980ff2

Restrict extension features based on the extension type. · 84dae96d

jstritar@chromium.org authored Dec 02, 2011

BUG=101992, 104103
TEST=existing, ManifestTest

Review URL: http://codereview.chromium.org/8654001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112764 0039d316-1c4b-4281-b951-d872f2087c98

84dae96d

Improve GPU tests to fail when GPU drawing fails. · 198e0c44

jbates@chromium.org authored Dec 02, 2011

Changed the accelerated html pages to use raf to draw multiple frames. Changed the webgl and canvas2d pages to draw onscreen rather than offscreen to make sure the compositor draws the page.

BUG=105785,104142

Review URL: http://codereview.chromium.org/8692013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112763 0039d316-1c4b-4281-b951-d872f2087c98

198e0c44

Fix race condition disconnecting hosts. · 0059eb96

jamiewalch@chromium.org authored Dec 02, 2011

Also, remove a couple of unused functions and rename some to be more meaningful following the recent refactoring.

BUG=102441
TEST=Manual


Review URL: http://codereview.chromium.org/8775021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112762 0039d316-1c4b-4281-b951-d872f2087c98

0059eb96

Widen leak suppression in V8. · 8b6d53c7

rnk@chromium.org authored Dec 02, 2011

TBR=glider@chromium.org
BUG=99304
TEST=less flakiness on valgrind bots

Review URL: http://codereview.chromium.org/8776062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112761 0039d316-1c4b-4281-b951-d872f2087c98

8b6d53c7

Update WATCHLIST to point to ui/views/* instead of views/* · 9d15515d

tfarina@chromium.org authored Dec 02, 2011

BUG=105968
TEST=python ~/depot_tools/watchlists.py ui/views/
R=nirnimesh@chromium.org
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/8776027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112760 0039d316-1c4b-4281-b951-d872f2087c98

9d15515d

Revert 112743 - [Sync] Make syncer commands avoid posting tasks on threads with no work to do · 5010bbf7

akalin@chromium.org authored Dec 02, 2011

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

This patch includes a speculative fix for the perf regression introduced by the last time this was landed (112178).

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178

Review URL: http://codereview.chromium.org/8637006

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8771044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112759 0039d316-1c4b-4281-b951-d872f2087c98

5010bbf7

Exclude LoadtimesExtensionBindingsUITest which are crashing on Mac Valgrind bot. · 0c75e08b

rnk@chromium.org authored Dec 02, 2011

TBR=simonjam@chromium.org
BUG=106117
TEST=mac valgrind bots go greener

Review URL: http://codereview.chromium.org/8776061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112756 0039d316-1c4b-4281-b951-d872f2087c98

0c75e08b

Make panels not show on top when there is an app running in full screen mode. · a5238b91

prasadt@chromium.org authored Dec 02, 2011

BUG=102731
TEST=Manual steps in the bug report.

Review URL: http://codereview.chromium.org/8686012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112755 0039d316-1c4b-4281-b951-d872f2087c98

a5238b91

Revert 112693 - committed before review was done - Landing 8688002:... · c761a5fd

jam@chromium.org authored Dec 02, 2011

Revert 112693 - committed before review was done - Landing 8688002: PPB_TCPSocket_Private/PPB_UDPSocket_Private are exposed to Browser

Review URL: http://codereview.chromium.org/8688002
Patch from Yuri Gorshenin <ygorshenin@chromium.org>.

TBR=dpolukhin@chromium.org
Review URL: http://codereview.chromium.org/8775063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112754 0039d316-1c4b-4281-b951-d872f2087c98

c761a5fd

Suppress a race on Mac that was likely introduced in shared_memory.cc in r112570. · f659c695

rnk@chromium.org authored Dec 02, 2011

TBR=mcgrathr@chromium.org
BUG=106197
TEST=tsan bots go greener

Review URL: http://codereview.chromium.org/8776056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112753 0039d316-1c4b-4281-b951-d872f2087c98

f659c695

Fix gyp-explain.py if dump.json doesn't exist. · 68a2062e

thakis@chromium.org authored Dec 02, 2011

BUG=none
TEST=Run with no dump.json around.

Review URL: http://codereview.chromium.org/8770056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112752 0039d316-1c4b-4281-b951-d872f2087c98

68a2062e

Add PyAuto tests for triggering browser/page action. · 8fc361fe

frankf@google.com authored Dec 02, 2011

BUG=chromium:104530
TEST=PyAuto tests

Review URL: http://codereview.chromium.org/8587004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112751 0039d316-1c4b-4281-b951-d872f2087c98

8fc361fe

Add comment that directory reader isn't implemented out of process. · a367e281

brettw@chromium.org authored Dec 02, 2011

Remove code. We can add this back when we actually need it.

Review URL: http://codereview.chromium.org/8775038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112750 0039d316-1c4b-4281-b951-d872f2087c98

a367e281

Fix a possible renderer hang due to an WebAccessibilityObject becoming invalid. · eca9b518

dtseng@chromium.org authored Dec 02, 2011


BUG=106016
TEST=manual


Review URL: http://codereview.chromium.org/8772006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112749 0039d316-1c4b-4281-b951-d872f2087c98

eca9b518

Add exports needed for glue to build as a component. · 51678ad7

dpranke@chromium.org authored Dec 02, 2011

This adds WEBKIT_GLUE_EXPORT, WEBKIT_PLUGINS_EXPORT, and WEBKIT_EXTENSIONS_EXPORT macros that are used by the files in
webkit/{glue,plugins,extensions} to show what needs to be exported from a DLL.

R=darin@chromium.org
BUG=98755
TEST=waterfall stays green.

Review URL: http://codereview.chromium.org/8741006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112748 0039d316-1c4b-4281-b951-d872f2087c98

51678ad7

Split a portion of BufferedResourceLoader into a separate class ActiveLoader. · 8470f469

scherkus@chromium.org authored Dec 02, 2011

ActiveLoader encapsulates an active WebURLLoader and takes care of maintaining deferred status, references to parent object, and automatic cancelation during teardown.

As a result of fixing the imbalanced reference counts to BufferedResourceLoader there were a few use-after-free bugs due to doing work after executing callbacks. The ordering has been updated to ensure that no more work is done after executing callbacks.

BUG=100914

Review URL: http://codereview.chromium.org/8667002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112747 0039d316-1c4b-4281-b951-d872f2087c98

8470f469

Implement 3-stage minimize animation for Panels on OSX. · 270e8dc3

dimich@chromium.org authored Dec 02, 2011

Fast close to titlebar only -> pause on titlebar-only -> slow minimize.

Also, moved close button 1 px lower so it doesn't show up when panel is minimized.

BUG=104645

Review URL: http://codereview.chromium.org/8773030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112746 0039d316-1c4b-4281-b951-d872f2087c98

270e8dc3

Add "Instant:" prefix to Instant preview tabs in the Task manager. · a15905af

sreeram@chromium.org authored Dec 02, 2011

BUG=105130
TEST=Open Task Manager. Enable Instant. Type a query into the omnibox. Observe that the Instant preview is listed as "Instant: ..." instead of "Tab: ...".

Review URL: http://codereview.chromium.org/8759009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112745 0039d316-1c4b-4281-b951-d872f2087c98

a15905af

Flush stdout when printing perf values for ChromeOS in pyauto perf tests. · 26f71307

dennisjeffrey@chromium.org authored Dec 02, 2011

The pyauto-based perf tests output perf results in a special format, which
are extracted from stdout and stored for graphing purposes.  I encountered
a case where one of these specially-formatted perf output lines was broken
up by other, interleaved output, causing the perf value to be missed when
the output was parsed to search for perf values.  I believe that flushing
stdout immediately after printing each perf output line should fix this
problem.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8772022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112744 0039d316-1c4b-4281-b951-d872f2087c98

26f71307

[Sync] Make syncer commands avoid posting tasks on threads with no work to do · 932a7c83

akalin@chromium.org authored Dec 02, 2011

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

This patch includes a speculative fix for the perf regression introduced by the last time this was landed (112178).

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178

Review URL: http://codereview.chromium.org/8637006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112743 0039d316-1c4b-4281-b951-d872f2087c98

932a7c83

Reunite PanelStrip::AddPanel and its internals. · 64688e49

jennb@chromium.org authored Dec 02, 2011

Was causing confusion with code within the file calling the helper functions directly.

Also put back accidentally deleted line and re-enabled NoOverlapping test.

BUG=None
TEST=Panel*Test.*

Review URL: http://codereview.chromium.org/8772029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112742 0039d316-1c4b-4281-b951-d872f2087c98

64688e49

Suppress race in OnSetProfilerStatus introduced in r112571. · 1191aa09

rnk@chromium.org authored Dec 02, 2011

TBR=rtenneti@chromium.org
BUG=106196
TEST=greener tsan bots

Review URL: http://codereview.chromium.org/8769047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112741 0039d316-1c4b-4281-b951-d872f2087c98

1191aa09

Convert file ref private to use new registration. · ac12399c

brettw@chromium.org authored Dec 02, 2011

This removes some manual registration code. It should also make FileRef private
work in process, it didn't look like it was being registered for in-process use
before.

Review URL: http://codereview.chromium.org/8772027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112740 0039d316-1c4b-4281-b951-d872f2087c98

ac12399c

Upstream: Media implementation for Android. · f2e1da2a

michaelbai@chromium.org authored Dec 02, 2011

- This CL makes media_unittests linked.
- The audio_track_output_stub_android.cc is in place of
  audio_track_output_android.cc because the Java environment is not
  avaliable yet.
- Also changed to dependence on '../third_party/ffmpeg/ffmpeg.gyp'
  only if os is not Android in media.gyp.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8718014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112739 0039d316-1c4b-4281-b951-d872f2087c98

f2e1da2a

Enable GL_CHROMIUM_post_sub_buffer for osmesa · 4297bea8

backer@chromium.org authored Dec 02, 2011

Small changes to WGC3DInProcessImpl to pass the extension up to WebKit.

BUG=none
TEST=with https://bugs.webkit.org/show_bug.cgi?id=67341 and --use-gl=osmesa


Review URL: http://codereview.chromium.org/8772021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112738 0039d316-1c4b-4281-b951-d872f2087c98

4297bea8

Update .DEPS.git · f8530b79

chrome-admin@google.com authored Dec 02, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112735 0039d316-1c4b-4281-b951-d872f2087c98

f8530b79

Revert r112684 'Update v8 to version 3.7.12.2'. · 46948c5f

ulan@chromium.org authored Dec 02, 2011

Reason: performance regression on Linux LowMem PageCycler Intl1.
Original CL: http://codereview.chromium.org/8772038/


BUG=
TEST=


Review URL: http://codereview.chromium.org/8770049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112734 0039d316-1c4b-4281-b951-d872f2087c98

46948c5f

Open the RestoreOnStartupURLs on first login, if specified by the admin. · f31af370

joaodasilva@chromium.org authored Dec 02, 2011

This makes sure the user gets what the admin configured instead of the Welcome
pages, on first login.

BUG=chromium-os:23463
TEST=First login on an enterprise ChromeOS device (with a managed user of the same domain) won't show the Welcome pages when the admin has specified Startup URLs for the user.

Review URL: http://codereview.chromium.org/8713017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112733 0039d316-1c4b-4281-b951-d872f2087c98

f31af370

Trim chrome/browser/DEPS after the recent refactorings. · c7791877

jam@chromium.org authored Dec 02, 2011

BUG=98716
Review URL: http://codereview.chromium.org/8776040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112732 0039d316-1c4b-4281-b951-d872f2087c98

c7791877

Exclude the TCP PPAPI tests introduced in r112693 on Mac valgrind also. · e6633269

rnk@chromium.org authored Dec 02, 2011

TBR=dpolukhin@chromium.org
BUG=104535
TEST=mac vg bots go green

Review URL: http://codereview.chromium.org/8770052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112731 0039d316-1c4b-4281-b951-d872f2087c98

e6633269

Add jstritar to extension watchlist. · 735d18fa

jstritar@chromium.org authored Dec 02, 2011

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8770050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112730 0039d316-1c4b-4281-b951-d872f2087c98

735d18fa

Suppress uninits in layout tests from WebKit roll. · 14ec8d58

rnk@chromium.org authored Dec 02, 2011

TBR=vsevik@chromium.org
BUG=106183
TEST=WebKit layout valgrind bots greener

Review URL: http://codereview.chromium.org/8776052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112729 0039d316-1c4b-4281-b951-d872f2087c98

14ec8d58

Selecting first item in the directory. · 1ee80d1e

serya@chromium.org authored Dec 02, 2011

BUG=chromium-os:21709
TEST=none


Review URL: http://codereview.chromium.org/8770045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112728 0039d316-1c4b-4281-b951-d872f2087c98

1ee80d1e

Fix Aura build break. · 09a2d441

jbates@chromium.org authored Dec 02, 2011

TBR=avi

Review URL: http://codereview.chromium.org/8772049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112727 0039d316-1c4b-4281-b951-d872f2087c98

09a2d441

Add more flexible handling of what is considered a google home page. · 1e1f7378

rogerta@chromium.org authored Dec 02, 2011

BUG=http:b/5609053
TEST=See unit tests for valid and invalid URLs.

Review URL: http://codereview.chromium.org/8728004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112726 0039d316-1c4b-4281-b951-d872f2087c98

1e1f7378

Widen leak suppression for intermittent WebKit leak. · a8946f90

rnk@chromium.org authored Dec 02, 2011

TBR=bashi@chromium.org
BUG=96568
TEST=greener vg bots

Review URL: http://codereview.chromium.org/8775056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112725 0039d316-1c4b-4281-b951-d872f2087c98

a8946f90

Fixing missed reference to old nacl sdk DEPS. · 0986560f

bradnelson@google.com authored Dec 02, 2011

BUG=None
TEST=None
R=noelallen@google.com

TBR
Review URL: http://codereview.chromium.org/8772048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112724 0039d316-1c4b-4281-b951-d872f2087c98

0986560f

Add TraceAnalyzer support for START/FINISH events and JSON error logging · 94d42f05

jbates@chromium.org authored Dec 02, 2011

Review URL: http://codereview.chromium.org/8682027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112723 0039d316-1c4b-4281-b951-d872f2087c98

94d42f05