- 06 Sep, 2018 40 commits
-
-
Markus Heintz authored
Bug: 865902 Change-Id: Iaa2d643eb4cf679511573a6816849db925d346f5 Reviewed-on: https://chromium-review.googlesource.com/1206811 Commit-Queue: Markus Heintz <markusheintz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589173}
-
Eric Seckler authored
Also reenables the test on Chrome OS, where it was previously flaking. Bug: 879984 Change-Id: Ida0391c7114afd77b7cb9ec8c2f9b00d8cc275b5 Reviewed-on: https://chromium-review.googlesource.com/1204330 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#589172}
-
Ulan Degenbaev authored
Bug: 880585 Change-Id: Ifd9107ef7fe6eabd8876063e47274275d9e1f55c Reviewed-on: https://chromium-review.googlesource.com/1206332Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589171}
-
Ken Rockot authored
This intentionally CHECK-fails when shared memory allocation fails on BigBuffer construction in the case where the buffer is would be too large for IPC if inlined. This allows such cases to be disambiguated from other large-IPC failures. Bug: 872237 Change-Id: I518dbea3007094a3136bfa1449f85eaefbbc7171 Reviewed-on: https://chromium-review.googlesource.com/1208719Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#589170}
-
Oliver Chang authored
TBR=eugenis@chromium.org Change-Id: Ic95108d1e2c3fcec56fbe6de208b73262666f5ce Reviewed-on: https://chromium-review.googlesource.com/1210322Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#589169}
-
Bence Béky authored
Send one extra setting with a random reserved identifier and random value in the initial SETTINGS frame. Send a short frame of a random reserved type, with random flags and payload, after every SETTINGS and HEADERS frame sent, on the same stream. The two behaviors are gated by separate field trials. Send the same greased settings identifier and value on every connection. Send the same greased frame type, flags, and payload on every connection. This is to prevent the retry logic from hiding bogus servers. Reserved settings identifiers and frame types are described at https://tools.ietf.org/html/draft-bishop-httpbis-grease-00. Bug: 841264 Change-Id: Ie1bd1e4f106bf64020f45171e350d37a10815bc8 Reviewed-on: https://chromium-review.googlesource.com/1207750 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#589168}
-
Sylvain Defresne authored
Minor cleanups of AccountTrackerService: - fix style issues (automatically using clang-format) - use standard algorithms, C++11 auto and for loops - use FILE_PATH_LITERAL to declare path component constants Bug: none Change-Id: I89d0fdb08a974b2542183beaf030d68d952b6af6 Reviewed-on: https://chromium-review.googlesource.com/1196366 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589167}
-
W. James MacLean authored
A number of changes have landed recently that may eliminate the flakieness seen in this test. This CL re-enables the test, but feel free to revert this if the flakes continue. Bug: 833380 Change-Id: Id1b94654a197d77af2ffdfbfdbf13c83ac485261 Reviewed-on: https://chromium-review.googlesource.com/1209962Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#589166}
-
Armando Miraglia authored
The audio_processing_sample_rate is currently only used in media_stream_audio_processor.cc however this will be needed for crbug/731170 to define valid constraints. This CL turns the definition of such variable into a more generally available static constant. Bonus: I am associating a new bug to the comment written on top rather than keep it assigned to a specific user. BUG=731170 Change-Id: Ib69fed0a44dfa7a11732221b7ef5d143c739abfd Reviewed-on: https://chromium-review.googlesource.com/1209702Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#589165}
-
Andrei Pascovici authored
Fixes an issue where the visibility change was not percolated to the DialogOverlay, which prevented resuming DRM playback on certain cast systems as described in the internal bug. Bug=b:78571682 Test=made sure the repro steps actually work w. the CL Change-Id: I7b2f06a5b4c4eb1fd4ffd32a587444e49d1ffcf8 Reviewed-on: https://chromium-review.googlesource.com/1204718 Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589164}
-
Marina Ciocea authored
Sandboxing flag should be enabled through field trial config instead: https://cs.chromium.org/chromium/src/testing/variations/fieldtrial_testing_config.json Change-Id: Ic34d3b1b5b52275bbee644e2a763cc50fed127da Reviewed-on: https://chromium-review.googlesource.com/1209546Reviewed-by:
-
Nico Weber authored
Also move mac_views_browser out of declare_args so that it can no longer be forced to false, and add a comment saying that this variable is supposed to go away. Bug: 832676 Change-Id: Ie2a6340715d45aa913db77595f0d578aea899ca4 Reviewed-on: https://chromium-review.googlesource.com/1209982Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589162}
-
Anthony Vallee-Dubois authored
This CL changes the backoff behavior from "backoff after N consecutive declines/ignores" to "backoff after N declines/ignores unless accepted once" Bug: 840367 Change-Id: I18d3d1ac10da566d55950a62f705dc1da3efa587 Reviewed-on: https://chromium-review.googlesource.com/1208711Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#589161}
-
Anthony Vallee-Dubois authored
Bug: 865500 Change-Id: I51eec8d3cbd6bd474af8d3b5275a433899f232fc Reviewed-on: https://chromium-review.googlesource.com/1207131Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Instead it should use ResourceRequest::SetReferrerString and ResourceRequest::SetReferrerPolicy. Bug: 863769 Change-Id: I4de47bae9aa259ace5ffb5bbdd17d6cf423931d7 Reviewed-on: https://chromium-review.googlesource.com/1203474 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#589159}
-
Yutaka Hirano authored
Bug: None Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib487fee40beaac941b74c090d31133b12d61ea4a Reviewed-on: https://chromium-review.googlesource.com/1203517 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#589158}
-
kokihoon authored
Use ContainsValue() instead of std::find() in chromecast/base Bug: 561800 Change-Id: Ie439f157c6b4bf51a8be41ad12a2653cf1289a13 Reviewed-on: https://chromium-review.googlesource.com/1203513Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#589157}
-
Fabio Tirelo authored
A follow-up CL will delete the "Autofill and payments" page and move "Addresses and more" and "Payment methods" into the main Settings page. Moving "Payment apps" into the "Payment methods" as a separate step to make CLs easier to review. Screenshots (Googlers only): https://drive.google.com/open?id=1QMBcQKZ_O2aaxLs5OFf3zfyY7JSgcxgX Bug: 860526 Change-Id: I57a107a15a7f8aab94a1125e79e6616957eaa49a Reviewed-on: https://chromium-review.googlesource.com/1199684Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
Difference in tests are due to separators between suggestions and footer are not sent in the suggestions list (we already did that on Android). A follow-up CL will delete the feature and all the code that depends on it. Bug: 831603 Change-Id: If2415782182ea7c0deb6d848ed7ae4f4964216f1 Reviewed-on: https://chromium-review.googlesource.com/1204835Reviewed-by:
-
Marc Treib authored
This adds "PrimaryAccount" to the names (in preparation for supporting secondary accounts), and also makes the SignIn/SignOut names symmetric. TBRing trivial call site update in ukm_browsertest.cc TBR=bcwhite Bug: 871221 Change-Id: I136a4e91154a736d58ca67c060c66a09aed8a458 Reviewed-on: https://chromium-review.googlesource.com/1209605 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#589154}
-
Yutaka Hirano authored
With this CL, some request headers that used to be treated as CORS-safelisted are not CORS-safelisted any more. Specifically, - "accept", "accept-language" and "content-language" have a stronger check on its value - All headers whose value exceeds 128 bytes are treated as not CORS-safelisted - If the sum of value length of CORS-safelisted headers exceeds 1024, then all of them are treated as not CORS-safelisted. This CL also implements https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header. This is for https://github.com/whatwg/fetch/pull/736. Bug: 824130 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib12a7dbff6367717a43130ae59304dca55b7bf4e Reviewed-on: https://chromium-review.googlesource.com/1196563 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL re-enables regression tests for WebAssembly.instantiateStreaming. See the bug link for the fixes themselves. R=haraken@chromium.org Bug: chromium:860637 Change-Id: I0aee6004c524f4e81adf68891d78341bacbc2237 Reviewed-on: https://chromium-review.googlesource.com/1209742Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589152}
-
Aldo Culquicondor authored
Hover events don't get processed if the source is not set. This change shouldn't affect scrolling performance metrics. Bug: 880879, 877580 Change-Id: I07ae28fcfdebfee77eab57e5659d1150745b6e9a Reviewed-on: https://chromium-review.googlesource.com/1207651Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589151}
-
Wojciech Dzierżanowski authored
Save for remapping hosts according to the rules, MappedHostResolver should be a transparent wrapper around the "real" resolver. Thus, it must forward all HostResolver methods to the real resolver. Change-Id: I34deed523b3cb690d450599c89bfd7f2184e843d Reviewed-on: https://chromium-review.googlesource.com/1209402 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#589150}
-
Denis Kuznetsov authored
All Non-AD enrollment steps, except for authentication: Device requisition, License type, device attributes Bug: 854101 Change-Id: I36eb5abae6865f3a7b5c73ada4620fbb6a70d352 Reviewed-on: https://chromium-review.googlesource.com/1120527Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#589149}
-
Daniel Bratell authored
Quick fix to unbreak jumbo builds. In https://chromium-review.googlesource.com/c/chromium/src/+/1205976 a copy of IsShuttingDown was added and this patch changes the code to instead use the original version. TBR=kinuko@chromium.org,nhiroki@chromium.org Bug: 715632 Change-Id: I2451fcaa009ec6403827cdb05cd3b47112c4681b Reviewed-on: https://chromium-review.googlesource.com/1209703Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589148}
-
Eric Robinson authored
This reverts commit 5e2fc13c. Reason for revert: Discovered that this is flaky under Windows and Linux.memory. Will reproduce there. Original change's description: > Re-enabling Cross Origin Verification. > > I've run this test using the Linux Release (with dcheck) 1000 times locally, > and run 3 dry runs here. I haven't been able to reproduce the flakiness > observed initially. I'm unsure if there was an underlying issue that was fixed > or if I need to run on some additional architecture. I plan to re-enable this > and monitor the run tracker so I have a better idea how to address the > flakiness if it still exists. > > Bug: 874443 > Change-Id: Ic3a839fd28a105b1b761ddffca5363803b357cc9 > Reviewed-on: https://chromium-review.googlesource.com/1203933 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: Eric Robinson <ericrobinson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588858} TBR=csharrison@chromium.org,ericrobinson@chromium.org Change-Id: I68c86ba816e4e555eee18fc3e744542d80cf7ec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874443 Reviewed-on: https://chromium-review.googlesource.com/1209983Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#589147}
-
Maja Kabus authored
Added Idlharness tests for Trusted Types interfaces. Removed "Worker" from "Exposed=(...)" in TrustedXXX .idl files. Bug: 739170 Change-Id: Id8834affcdded63f3ebb9ebd4d288cfd01ef24a8 Reviewed-on: https://chromium-review.googlesource.com/1204150 Commit-Queue: Maja Kabus <kabusm@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#589146}
-
Boris Sazonov authored
This CL fixes enabling/disabling UMA reporting from UnifiedConsentService. chrome::android::SetUsageAndCrashReporting method is added that calls to Java PrivacyPreferenceManager and updates "metrics_reporting" shared preference that is the source of truth for UMA reporting. Bug: 879546 Change-Id: Ia0e2de860bc46a33b716d827d3101a0e060d2721 Reviewed-on: https://chromium-review.googlesource.com/1199084 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589145}
-
Finnur Thorarinsson authored
Bug: 881109, 734095 Change-Id: Ic530a30c653c202c279bf4074022a122cfcba2ac Reviewed-on: https://chromium-review.googlesource.com/1209485 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#589144}
-
Markus Heintz authored
This reverts commit 5bf6f1b1. Reason for revert: "compile" error on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2790 "Android CFI" Original change's description: > [Autofill Assistant] Bind the script tracker with the controller. > > With this change, the controller tells the script tracker to run checks > when necessary, calls the UI controller to choose a script to run and > run the script that was chosen. The implementation of the UI controller > for choosing the script is not included into this change. > > Integration is preliminary, just to get something to get started until > we have a usable UI to try it out. The UI part, implementing script > selection, is missing from this change. > > Change-Id: I867bec0e554dfdd87fc2f95e7c9088391621c5c9 > Bug: 806868 > Reviewed-on: https://chromium-review.googlesource.com/1194034 > Commit-Queue: Stephane Zermatten <szermatt@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589135} TBR=gogerald@chromium.org,mcarlen@chromium.org,szermatt@chromium.org Change-Id: I260f91338731718a99a91cf96add11311739040e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1209922Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589143}
-
David Roger authored
Bug: 873739, 873644 Change-Id: I02e0819130678a1398106f0d0faf8068456e28dc Reviewed-on: https://chromium-review.googlesource.com/1196451 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589142}
-
Marc Treib authored
- Update some comments for accuracy - Remove unused methods and includes - Add some "const"s Bug: none Change-Id: Ia45237757b101af7ff0886dadff9ef9e622a2cc2 Reviewed-on: https://chromium-review.googlesource.com/1208526 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mikel Astiz authored
We agreed to prefer the ShouldXXX convention for new code. This patch renames previously existing tests accordingly, prior to adding new ones in follow-up patches, to avoid violating the local consistency principle. Bug: 830535 Change-Id: Idb9f87f06ff1e4d886f0c4d3d34180e43eca29f2 Reviewed-on: https://chromium-review.googlesource.com/1209483 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#589140}
-
Fredrik Söderquist authored
To have a chance of seeing what might be problem here (if it still exists) we need some historical data, since there appear to be no obvious issues with the test as such. Bug: 805292 Change-Id: Iccbb92e2a324533858ee42802eaa2fa7ebc2240c Reviewed-on: https://chromium-review.googlesource.com/1209363Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589139}
-
Daniel Vogelheim authored
(Follow-up to cl 1165351.) Bug: 751996 Change-Id: I37b57e239dced37fc5390d5db4b42cdc8be7466d Reviewed-on: https://chromium-review.googlesource.com/1177607 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#589138}
-
Mythri Alle authored
V8 also stores code caches for inline scripts in the html resources. This cl updates ResourceLoader to fetch cached code for inline scripts in MainResources. Bug: chromium:880212, chromium:812168 Change-Id: I822453b52897aac292444df20e50937d8198064d Reviewed-on: https://chromium-review.googlesource.com/1208391Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589137}
-
David Roger authored
It is suspected (from external data) that calls to Gaia in general, and ListAccounts in particular, have an abnormally high network failure rate. This CL adds Chrome metrics to measure the failure rate of ListAccounts, to see if the phenomenon can be observed through Chrome metrics: "Gaia.AuthFetcher.ListAccounts.NetErrors" Additional histograms are added to track the failure rate of ListAccounts depending on system uptime and process uptime, because one of the hypothesis is that network requests are generally more likely to fail on system or process startup, and ListAccounts requests tend to be done at startup. The Signin.ListAccounts.Failure histogram now also records success, so that it can be used to compute failure rates. "Gaia.AuthFetcher.Multilogin.AuthErrors" is also added to track success rate for OAuth2 multilogin, which needs to be monitored as it is ramped up. Bug: 876306 Change-Id: I3feb3a48ba43b79559fe1aacd78ce51eb0b86a38 Reviewed-on: https://chromium-review.googlesource.com/1195463Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
With this change, the controller tells the script tracker to run checks when necessary, calls the UI controller to choose a script to run and run the script that was chosen. The implementation of the UI controller for choosing the script is not included into this change. Integration is preliminary, just to get something to get started until we have a usable UI to try it out. The UI part, implementing script selection, is missing from this change. Change-Id: I867bec0e554dfdd87fc2f95e7c9088391621c5c9 Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1194034 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#589135}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 37ae5d1a. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24162 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I49095b178555d204524cc2286910fad57c1b6166 Reviewed-on: https://chromium-review.googlesource.com/1208199 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589134}
-
