- 08 Oct, 2019 40 commits
-
-
Mario Sanchez Prada authored
Convert the remaining references to this interface using the old mojo types in tests. Bug: 955171, 978694 Change-Id: I2b4bb0701f3d932b830c06be945ea1e0cdb643f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840691Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#703645}
-
Dominik Röttsches authored
In issue 976737 renderer fallback was moved to being purely based on DirectWrite API calls to remove an outdated and hard to maintain hardcoded list. On Windows 8.1 and 10 we use DWrite API in the renderer directly, which in turn calls to our proxied classes, where out of process calls are cached, compare the implementation in content/child/dwrite_font_proxy/font_fallback_win.cc. On Windows versions below that we were moving to a new OOP API call which was uncached. This turns out to trigger performance regressions on extremely fallback heavy tests such as html5_full_render, which contains a big list of characters that need fallback, as well as the loading.desktop test for ruten.com.tw, which specifies a Latin font as primary font even though the page is in Taiwanese. Add a LRU cache implementation which maps from a String to a Vector of SkTypefaces against which we can buffer the fallback calls. The cache is optimise to move the most recently used local and font up so that they are cheaper to access for subsequent fallback calls. This CL has been locally shown to improve loading.desktop ruten_warm at a 26% improvement for timeToFirstContentfulPaint:layout. Due to issue 1011728 it was not possible yet to verify this on Pinpoint. Issue: 1005234 Change-Id: I5cfc1f9ee9bc7557009d9b396816eed6aa9c2ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841333 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703644}
-
Abhijeet Kandalkar authored
This CL converts |mojom::TracedProcessRequest| to |mjo::PendingReceiver<mojom::TracedProcess>| to use new mojo types. Bug: 955171, 978694 Change-Id: Ife8d61ee2e18f81857fda8376992082fb1f28cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838891Reviewed-by:
-
Yifan Luo authored
Bug: 1012190 Change-Id: Id5029e303d1fc5e171f8efdd2946ffe5eeef52bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844823Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#703642}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I153acefddfbb1d7e757c9d146f26437f0b3a102f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703641}
-
Thomas Tangl authored
Bug: 995720 Change-Id: I4e0779618f75c607f9c93cda928ec9c1c8cc9ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845230 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#703640}
-
Mythri A authored
Fix for this landed here: https://chromium-review.googlesource.com/c/chromium/src/+/1800855 Bug: chromium:1003268 Change-Id: Ibf7056e406239b85275bb31e24ed39dd34577169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844970 Auto-Submit: Mythri Alle <mythria@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703639}
-
Jérôme Lebel authored
Adding EarlGrey test to swipe to dismiss in advanced sign-in view. Bug: Change-Id: Ia9b53cf8ad29e721890ccb337bb2b2e4c670fd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835506Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#703638}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/23293e8fa45f..5365f6a6b59d git log 23293e8fa45f..5365f6a6b59d --date=short --no-merges --format='%ad %ae %s' 2019-10-08 risan@google.com Increase timeout for tast_vm_canary_informational Created with: gclient setdep -r src/third_party/chromite@5365f6a6b59d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ica7ef91f52951a44bf6e75ccf5cf213e393ccc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846789Reviewed-by:
-
Mihai Sardarescu authored
During the Chrome sign-in flow, if the user chooses to clear the cookies when switching their primary account, then the following actions take place (in the following order): 1. All cookies are cleared. 2. The user is signed in to Chrome (aka the primary account set) 2.a. All requests to Gaia page will include Mirror header. 2.b. Account reconcilor will rebuild the Gaia cookies having the Chrome primary account as the Gaia default web account. The Gaia sign-in webpage monitors changes to its cookies and reloads the page whenever they change. Reloading the webpage while the cookies are cleared and just before they are rebuilt seems to confuse WKWebView that ends up with a nil URL, which in turns translates in about:blank URL shown in the Omnibox. This CL works around this issue by waiting for 1 second between steps 1 and 2 above to allow the WKWebView to initiate the reload after the cookies are cleared. Bug: 1003578 Change-Id: I8dc460854b3047b515c0401bc4e2f233a3fcfa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844975Reviewed-by:Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#703636}
-
Mostyn Bramley-Moore authored
Change-Id: I1777730958e0e36fb65450abe2178669a6e29996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845216Reviewed-by:
-
Jan Krcal authored
This CL introduces two kill-switches that guards showing user email on startup and on sign-in in the avatar button. This way, we simplify the launch by decoupling the visual changes in the button (the master feature) from the individual trigger points. This CL also tweaks the startup trigger by only showing the pill for multi-profile or multi-account users. Bug: 1009441 Change-Id: I4f097b385a8469fc59d94494f5528fbefeda8b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831771 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Dan Elphick authored
Allows us to measure how much time is spent collecting source positions now that this is only done when an exception is symbolized or at the point debugging is enabled. Bug: v8:8510 Change-Id: Id3368778eb8c14776bc664b62ea263a5d3348def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845215 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703633}
-
Michael Olbrich authored
crrev.com/c/1732747 removed the support for UYVY but the list of valid buffer formats was not updated. As a result GetBufferFormatFromFourCCFormat() hits NOTREACHED() for DRM_FORMAT_UYVY. Remove DRM_FORMAT_UYVY from the list of valid buffer formats to fix this. Change-Id: Ic9687bbe399e957db81f7ae4e39e63f7b12ab69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824262Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#703632}
-
Clemens Arbesser authored
Not sure how this one fell through the cracks. Bug: 806868 Change-Id: Id94a4b8b6550aba450d32175012f4c72d1216de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844825 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#703631}
-
Colin Blundell authored
Part of the elimination of the legacy IPC system. Bug: 1007300 Change-Id: Ia0f3a49c09156d5a66cf8b7075c08f954d78e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833822 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#703630}
-
David Roger authored
Change-Id: Iff7379af735fbace57075d9b920a8873bb073da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840431Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#703629}
-
chrome://dinoEdward Jung authored
The dino is shifted up when ducking to close the gap. Over many crashes the dino would shift more and more to the right. This CL resets the x position on restart. Bug: 1001938 Change-Id: I1a2c83070c3dfc80811fec4d08876db1102734e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840211Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#703628}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in services/test to the recommended methods/types. Bug: 1007831 Change-Id: I63e66235a875bc298c784c743f4422adc58184c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837833 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Fergal Daly authored
It's unclear why it needs it this time after https://crrev.com/c/1835683 but it does. Even before this change the scroll was happening before the scroller had finished unlocking everything it would have, so it seems reasonable and future-proof to give it plenty of time. Bug: 1011376 Change-Id: I799e93d01b8252dca4ebf567e6fb9c58da944c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846221Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703626}
-
Yoshisato Yanagisawa authored
Linux Chromium build uses headers and libraries in debian sysroot instead of system's to provide hermetic build environment. To compile simple chrome with Goma, builidng like this improve cache hit ratio because we can expect compile happens in hermetic way. Bug: 1003264 Change-Id: If7c5f80b5d732635f0b178efca0b9d4ca4a5c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846427Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#703625}
-
Albert J. Wong authored
Orignal CL in: https://chromium-review.googlesource.com/c/chromium/src/+/1824321 Prior CL blew up because: https://bugs.chromium.org/p/chromium/issues/detail?id=1011283 Original Description: Currently ShouldCreateWebContents() does 3 separate things (1) Tells WebContentsImpl::CreateNewWindow() to suppress default popup creation logic. (2) Signals to the embedder that a window creation has been attempted (3) Allows the embedder to signal back, via use of the global routing_id maps, that a new WebContents has been created and needs partial initialization inside the content layer. This is super complex, especially since only one delegate uses (3). The new API creates 2 functions: bool IsWebContentsCreationOverridden() WebContents* CreateCustomWebContents() Breaking up the API makes it cleaner. If the WebContents initialization logic can get changed to absorb the single odd use case in (3) then CreateCustomWebContents() could be changed to have a void return type making the API even simpler. Bug: 545684 Change-Id: I894ae320b55fa410d6469ff07350f4a953952f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846477 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#703624}
-
Ankit Kumar 🌪️ authored
Promises are used in the document load pipeline. The promise is used for toggling between annotation mode. At the initial load of the document the promise is not needed. If the initial document load fails, the promise is rejected and there is no error handler as no entity requires this promise and no error handler is implemented. This throws an error in the Inspect console "Uncaught (in promise) undefined". This CL fixes the usage of promises in the document load pipeline. We only use promises when it is needed by an entity. Bug: 1001979 Change-Id: I7c3a4b6da49a71e343616142917e56247d426f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792404Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703623} -
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/08a5ac41e4a8..496c95ad404c git log 08a5ac41e4a8..496c95ad404c --date=short --no-merges --format='%ad %ae %s' 2019-10-08 dberris@chromium.org Follow-up Refactoring to 'Avoid Means' 2019-10-08 dberris@chromium.org Decrease Job Frozen Threshold 2019-10-08 simonhatch@chromium.org Pinpoint - Add UI to select measurement/statistic Created with: gclient setdep -r src/third_party/catapult@496c95ad404c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1011273,chromium:1011728,chromium:1005961 Change-Id: I41dd3a012efc831c11058d272ad77dc82fd802a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847098Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6da708e46496..66bd5d4deb12 Created with: gclient setdep -r src-internal@66bd5d4deb12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I826c1bf0e681a4cf19eb8725c7c33afb187fe28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703621}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8eb8385e2efc..720988d878a1 git log 8eb8385e2efc..720988d878a1 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 mchiasson@gmail.com Fixed compilation issue on clang 6.x Created with: gclient setdep -r src/third_party/dawn@720988d878a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I605b212e645380b4b12691e436d6bf71e40e5deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845886Reviewed-by:
-
Patrik Höglund authored
This reverts commit d95c3033. Reason for revert: Breaks the ClearDropTarget test: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/53031 Original change's description: > Don't invoke DropTarget's callback on destructor > > When BrowserRootView is being destroyed, we shouldn't call callbacks from > DropTarget. It might be already destroyed. > > Bug: 1001942 > Change-Id: Iddecc9334d814f9154d44ff32473c5fa167b3b23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844001 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703352} TBR=pkasting@chromium.org,sangwoo108@chromium.org Change-Id: Ie5bb03a7a2623a95cbd765e8f2935f6bb7ae3ce3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845758Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703619}
-
Rune Lillesveen authored
For shadow dom V0, <content> elements which are not inside shadow trees are not active insertion points and do not take part in shadow distributions. They are part of the flat tree and otherwise behave as any other elements. Call RecalcDescendantStyles to compute styles for its descendants. TEST=accessibility/table-row-role-crash.html TEST=fast/dom/shadow/content-element-outside-shadow.html TEST=fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content.html TEST=fast/dom/shadow/shadow-insertion-point-rendering.html Bug: 972752 Change-Id: I0037f5c3a1dc6d0f7746aa7e0eb9b118212e2047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846431Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#703618}
-
Jan Wilken Dörrie authored
This change implements wide string overloads to string_split.h and string_util.h. Since these functions are not supposed to be used by Cross-Platform code it is guarded by correpsonding #ifdef guards. Furthermore, this change performs some minor code clean-ups and performance improvements. Bug: 911896 Change-Id: I579b55a398307c890b30a027699b74a9afb1a77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823851 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#703617}
-
Jan Krcal authored
This CL adapts the default border color of toolbar button to be the same as the border color of ToolbarIconContainerView. Bug: 1011314 Change-Id: I25f4e0f64adf0338266dc25c52d12e3b20db8eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845226 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
We see some breakage on M78, so we are disabling the feature. After merging this change to M78 I will revert this change. Bug: 1006292 Change-Id: Ie56d2ac5cdd6ed8ea0fdf8c124a3f01c24731eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846832 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703615}
-
Hirokazu Honda authored
CreateGpuMemoryBufferHandle() creates GpuMemoryBufferHandle from media::VideoFrame(). The fds and metadata are come from untrusted processes, e.g., ARC++ and renderer process. We must validate GpuMemoryBufferHandle. Bug: None Test: video_encode_accelerator_unittest on eve Change-Id: I74faf5f9a38562d7120cc09d76dbaeb0d67515eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839323 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703614}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d7c56db..d140f412 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1128a26e20c17328743cb6594f65f7d842649659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846547Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703613}
-
Hajime Hoshi authored
BackForwardCache: Add metrics to record why RenderFrameHost prevented the page from BackForwardCache This adds new metrics for eviction by back-forward navigation: BackForwardCache.DisabledForRenderFrameHostReason. This records the reason why the render frame host is prefented from entering back-forward cache. For example, the frame used a disallowed feature for back-forward cache. The original form of the reason is a string, and this histogram records them as integers by StringPieceHash. Bug: 1001087 Change-Id: Id6906b90dbefbcb4a79aa1fa959877a0cce3a582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828786 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703612}
-
Miyoung Shin authored
This change converts WebUsbService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I03f8d6b061eed920ffd68305702f73fff66fe871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844005Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Adam Rice authored
Apply backpressure to blink::WebSocketChannel before the WebSocketStream handshake starts, rather than after it completes. This avoids a race condition where more of the first message is read than should be. Also fix flakiness in the external/wpt/websockets/stream-tentative/backpressure-receive.any.js by doubling the size of message used. BUG=1002780 Change-Id: I915c71a4b81b95375b7c4c584f7782d5336cba85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844911Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#703610}
-
Peter Boström authored
Replaces trivial cases of kHighlightPathKey with installing generators. Follow-up CLs will deal with creating new generators for more-complex cases. Bug: chromium:1007546 Change-Id: Id5911c450a3a8da43eb3cce4051265da6a995f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841660 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#703609}
-
Patrik Höglund authored
Example failures: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/27728 Tbr: tangltom@chromium.org Bug: 1012167 Change-Id: Ia708a9b3471d987f0d8897e4d9b2051d5c6a31fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845753Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a28cf7c08061..dd88df5d116c git log a28cf7c08061..dd88df5d116c --date=short --no-merges --format='%ad %ae %s' 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 036463457e5f..ae022faf53b9 (2 commits) 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 78225ef2..5c41949c (382 commits) Created with: gclient setdep -r src/third_party/skia@dd88df5d116c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None,chromium:None Change-Id: I409e6cde75fa624dd81cae43439154ba4ba2cc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846713Reviewed-by:
-
Hiroki Nakagawa authored
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - https://github.com/w3c/css-houdini-drafts/pull/958 - https://github.com/w3c/css-houdini-drafts/pull/967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606}
-
