- 20 Feb, 2019 40 commits
-
-
liberato@chromium.org authored
ordering="prefix" turns out to be not the right thing. The variant name is intended to be at the end, such as: Media.Learning.MediaCapabilities.DroppedFrameRatioTask.BaseTree Change-Id: Ib71ede8b9214edd08f6c25c1e1a771158309ece1 Reviewed-on: https://chromium-review.googlesource.com/c/1477751Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#633785}
-
Elly Fong-Jones authored
TBR=rohitrao@chromium.org Bug: 933827 Change-Id: I9c4b3e2f8f1088cb5a2c78a6aed500a682874edd Reviewed-on: https://chromium-review.googlesource.com/c/1478488Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#633784}
-
Marc Treib authored
instead of ProfileSyncServiceMock. In general, it's always preferred to use SyncService rather than ProfileSyncService, and in particular there's no need for a mock here. Bug: 910518 Change-Id: I7515ae070a7859ae767ec66acced9e0d5ec0e521 Reviewed-on: https://chromium-review.googlesource.com/c/1477680 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#633783}
-
Dirk Pranke authored
This reverts commit 258ed8d5. Reason for revert: Suspect this introduced memory leaks and broke https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20Leak/30388 Original change's description: > Synthetic input waits on compositor display > > This CL makes synthetic input - the kind used in web tests and > telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame > has been submitted by the renderer and displayed by the display > compositor before resolving the completion callback. This means client > code that wants to wait until any observable side-effects of this input > is visible to further input need only wait on the gesture's completion > callback. > > To give a motivating example: suppose we wish to write a test that > scrolls an out-of-process iframe into view and clicks on a button in the > frame. The code might look something like this: > > gpuBenchmarking.smoothScroll(1000, () => { > gpuBenchmarking.tap(0, 0); > }); > > This code contains a race today. The callback for smoothScroll is > invoked as soon as the ScrollEnd is received in the renderer. However, > until a new compositor frame is submitted from the renderer, the tap > may occur against stale hit testing geometry. This is a major source of > flakiness in our tests. > > This CL fixes the problem by forcing the renderer to perform a full > redraw at the end of each gesture. The redraw produces a compositor > frame and we invoke the callback once the compositor frame is displayed. > We do this by reusing the RequestPresentation mechanism in RenderWidget. > RequestPresentation required two modifications to work in web tests > which use a single thread proxy with no scheduler: > > - LayerTreeHost::Composite needs to check the forced redraw flag to > determine whether we need to raster, otherwise it won't produce a > frame > - RequestPresentation must request a main frame since there's no > scheduler to perform the commit, which is what SetNeedsForcedRedraw > requests. > > The timing change exposed an issue in the > overlay-play-button-tap-to-hide.html test so this CL also cleans that > test up to listen to the animation changes in media controls properly. > > Finally, it's possible we may get input in a RenderWidget that's not > currently displayed. e.g. A click event sent via ChromeDriver causes a > TouchStart followed by a TouchEnd. The TouchStart causes a window.open > which opens and focuses a new tab. The TouchEnd then happens on the > background tab. In this case, we should resolve the callback rather than > waiting on a CompositorFrame that'll never come. See ChromeDriver test > testNetworkConnectionTypeIsAppliedToAllTabs for an example of this. > > Bug: 902446 > Change-Id: Ib2dddee08400dfa1137c674c47c0d7106961162f > Reviewed-on: https://chromium-review.googlesource.com/c/1390329 > Reviewed-by: Saman Sami <samans@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633753} TBR=danakj@chromium.org,bokan@chromium.org,dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org Change-Id: I7a479a4af8fbec4b4452ff6d9d7b5b9df246f4a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902446 Reviewed-on: https://chromium-review.googlesource.com/c/1479370Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#633782}
-
Benoît Lizé authored
Memory metrics for ParkableStrings are only reported for background compression. This adds reporting for foreground compression as well, 5 minutes after a renderer starts tracking its first parkable string. Bug: 924164 Change-Id: Iac04e86101e132fa9d67c6cfd25b16e2bce89fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1474663Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#633781}
-
Saman Sami authored
This used to be not possible in Skia, but that has been fixed recently. Bug: 933441 Change-Id: I21442bfad311ac2aa1bb73bd57737e0e0332096f Reviewed-on: https://chromium-review.googlesource.com/c/1478937Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#633780}
-
Lukasz Anforowicz authored
Google Translate executes its scripts inside "isolated worlds". This is quite similar to how extension content scripts execute and has a consequence of using |request_initiator| set to the origin of the isolated world (rather than to the origin of the page where the script was injected). This is problematic for 2 reasons: 1. It leads to renderer kills, when an AppCache verifies |request_initiator| using CPSPI::CanAccessDataForOrigin. 2. It leads to incompatibility between |request_initiator| and |request_initiator_site_lock| which can also cause wrong/harsh security decisions (e.g. CORB blocking of otherwise benign requests). This CL addresses the problems above, by making sure that requests initiated by the Translate's "isolated worls" will use a separate URLLoaderFactory. - For injecting and selecting the factory on the renderer side, the same mechanism is used as for extension content scripts (i.e. URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is populated for the origin associated with the "isolated world"). - For simplicity and to avoid races, the separate URLLoaderFactory is sent from the browser to the renderer process in the same, single IPC that triggers script injection into an isolated world (i.e. in translate::mojom::Page::Translate method). As a side effect, this CL also causes Translate's requests to go directly to the NetworkService (rather than to the AppCache's AppCacheSubresourceURLFactory). This seems desirable. Bug: 925457 Change-Id: I6227f9d8a43329510f4fae37ab9429c9dbf59f48 Reviewed-on: https://chromium-review.googlesource.com/c/1441277 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#633779}
-
Lutz Justen authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5949b3349ded..274866056499 $ git log 5949b3349..274866056 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 ljusten system_api: Add kerberos service proto 2019-02-04 ljusten kerberos: Stub out D-Bus service 2019-02-14 zuan system_api: Ran gn format on BUILD.gn 2019-01-29 chirantan system_api: Make params a repeated field in StartPluginVmRequest 2019-02-08 lamzin system_api: add peak shift policy to power manager 2019-01-31 yshavit bluetooth: add suspend/resume infrastructure per powerd guidelines 2018-10-12 chinglinyu debugd: support stopping a running perf profiler session. Created with: roll-dep src/third_party/cros_system_api BUG=chromium:933798 Change-Id: Idd980b0c267d0e00685ada8a5d7e30944c5c8e89 Reviewed-on: https://chromium-review.googlesource.com/c/1478894 Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#633778}
-
Ryan Sturm authored
Change-Id: I5d259c9103c8e6d2853673ab6d31e956e4724f84 Reviewed-on: https://chromium-review.googlesource.com/c/1474836Reviewed-by:
-
Tim Volodine authored
The following tests are passing: -ClientOnPageStartedTest.testBrowserInitiatedRedirectHangingNavigation -ClientOnPageStartedTest.testRendererInitiatedRedirectHangingNavigation BUG=893572,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ia376d146c02c22a4db8e3fdc217e129652c970d6 Reviewed-on: https://chromium-review.googlesource.com/c/1478879 Auto-Submit: Tim Volodine <timvolodine@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The FileManager tests have been rewritten to use browser side injection. This feature can now be removed. Change-Id: If9780de594d26c93f6f80ee2adf558ff5811df98 Reviewed-on: https://chromium-review.googlesource.com/c/1473404 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#633775}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9eb094567b2a..e8ab7db4d4da git log 9eb094567b2a..e8ab7db4d4da --date=short --no-merges --format='%ad %ae %s' 2019-02-20 chiniforooshan@chromium.org Tracing: handle empty list of ranges Created with: gclient setdep -r src/third_party/catapult@e8ab7db4d4da The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931766 TBR=sullivan@chromium.org Change-Id: Ie4478b8bccb17feeb432d6a3f2f67a52fbb7d1c9 Reviewed-on: https://chromium-review.googlesource.com/c/1477403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633774}
-
Avery Musbach authored
The present CL was originally for Issue 926602, but has become focused on code refactoring (Issue 932207), with a low-risk fix for Issue 926602 separated out into CL 1471013. The refactoring in the present CL seems to have incidentally fixed the additional functional problem shown in this video (an ugly animation): https://photos.app.goo.gl/xGnVGQgexPgxMpRcA Bug: 932207 Change-Id: Ia191e7d3495c09ec07237c57596de43106e7d548 Reviewed-on: https://chromium-review.googlesource.com/c/1446368 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#633773}
-
Madeleine Barowsky authored
Changes return type of DecodeToYUV from bool to void and passes errors through Failed(). Bug: 900589 Change-Id: If9e9b81d1516eeb7504f79e67a9a77cad4c36151 Reviewed-on: https://chromium-review.googlesource.com/c/1477814 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#633772}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc42944741bc..c74512c7ff9e git log bc42944741bc..c74512c7ff9e --date=short --no-merges --format='%ad %ae %s' 2019-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8f79d388784c..f4b99b674a1b (1 commits) 2019-02-20 mtklein@google.com update NDK to r19b 2019-02-20 brianosman@google.com Use upper case hex in viewer's zoom window 2019-02-20 herb@google.com Break up InitDistanceFieldPaint 2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c74512c7ff9e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: If283bae26101aa21fa30055e1684d9328f71df63 Reviewed-on: https://chromium-review.googlesource.com/c/1477405Reviewed-by:
-
Wez authored
Recent updates to fidlc added a |bytes| synonym for the |vector<uint8>| type, to improve readability of protocols which need to handle sequences of octets that are not necessarily UTF-8 encoded (e.g. binary data or strings using other character encodings). Change-Id: I3a25086db9ffd5fffe6622b58e7cbd07364531aa Reviewed-on: https://chromium-review.googlesource.com/c/1476410 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#633770}
-
danakj authored
These 2 values are almost redundant, but the places that use PhysicalPixelViewportSize() don't actually care about the differences so remove the first and just keep ViewRect(). Moves the method on RenderWidget to be private. R=avi@chromium.org, pdr@chromium.org Bug: 912193 Change-Id: Iea0516a7392c2657c261b4bf3b8b7186a117e81e Reviewed-on: https://chromium-review.googlesource.com/c/1477768 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#633769}
-
Robbie Gibson authored
This is a reland of e07980a1 The original CL collided with another one that used this enum case. Original change's description: > Rename ClipboardURLProvider to ClipboardProvider > > ClipboardURLProvider now provides matches for text and images on the > clipboard as well as URLs. Therefore, we should rename it to just > ClipboardProvider. > > Bug: 923443 > Change-Id: I43ab8036cf2b0c564ebc3588b4c2324628ab2ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/1445401 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Cr-Commit-Position: refs/heads/master@{#632681} Bug: 923443 Change-Id: Iccbf43e55637330c2a8817b24386e70c755874b6 Reviewed-on: https://chromium-review.googlesource.com/c/1475758 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Navid Zolghadr authored
In an earlier change we changed all WTF maps to std maps to account for all the values in the key range (i.e. PointerId). But the solution of using WTF with a bigger type as key (in this case int64_t) is better than using std map. Bug: 921325 Change-Id: Ice58c0fb55ab12138467de9f18fadc33b0815215 Reviewed-on: https://chromium-review.googlesource.com/c/1477755Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#633767}
-
Dave Tapuska authored
In change d6703f91 the entire visibility state is provided, however it would cause hidden->hidden transitions. To correct this we really should just replicate the state into web_contents entirely because it has the same states. BUG=932059 Change-Id: I67895d97e7da5ea5903fe7e9bd7d03fc38a03113 Reviewed-on: https://chromium-review.googlesource.com/c/1478935Reviewed-by:
-
Natalie Chouinard authored
Remove some unnecessary compilation dependencies. Bug: 918983 Change-Id: I8521a212443c35a541c7eedb9b5adc0327c4b5f7 Reviewed-on: https://chromium-review.googlesource.com/c/1478176Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#633765}
-
Tommy Nyquist authored
As much as David wants fame by printing his name in everyone's logcat, let's be real, we need to save these bytes for APK size savings. Change-Id: Icceb0a3ac93ce0171efc7fd3227570f38aae4081 Reviewed-on: https://chromium-review.googlesource.com/c/1475693 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#633764}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/106dac4e61d8..e1834d8c6d38 Created with: gclient setdep -r src-internal@e1834d8c6d38 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I09898e35dc53db51c9bcbe0f06aeadec4b64e6ea Reviewed-on: https://chromium-review.googlesource.com/c/1477881Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633763}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=rockot@google.com Bug: 714018 Change-Id: I6d57907a3aa4886b00851416b9ea002a39c9c5f9 Reviewed-on: https://chromium-review.googlesource.com/c/1475639 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#633762}
-
Elly Fong-Jones authored
Bug: 922690 Change-Id: I6bb402f10f65be1225a3c9c1c4954c364e53dafb Reviewed-on: https://chromium-review.googlesource.com/c/1478497 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#633761}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/80496f42a525..5994ae2a0450 git log 80496f42a525..5994ae2a0450 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 stevenperron@google.com Start SPIRV-Tools 2019.3 2019-02-20 stevenperron@google.com Finalize SPIRV-Tools 2019.2 2019-02-20 9856269+sarahM0@users.noreply.github.com OpAtomicLoad, OpAtomicStore, OpAtomicExchange can operate on int or float value. Except for Vulkan environment that only operates on int value. (#2385) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5994ae2a0450 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I75861df5c10e562f8e7f19ad2e4a5fe40796b189 Reviewed-on: https://chromium-review.googlesource.com/c/1478936Reviewed-by:
-
Guido Urdaneta authored
This CL moves MediaStreamAudioRenderer, MediaStreamVideoRenderer and MediaStreamRendererFactory from content/public/renderer to blink/public/platform/modules/mediastream All three interfaces get a Web prefix since they are intended to remain in public/platform, as they come form content/public/renderer. This is a straightforward move and rename and all changes outside third_party/blink are mechanical (#include, namespace and type name updates). Bug: 921006 Change-Id: I1568e58ccaf8d4581ce8bc4ebdae199c3e67366d TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1450128 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Antonio Gomes authored
Preparation CL that allows conversion of use cases like AccountReconcilorTest to use IdentityTestEnvironment simple ctor form. BUG=926890 Change-Id: If362cc071e193df1c988d8508b6682b84cc65fbc Reviewed-on: https://chromium-review.googlesource.com/c/1477820Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#633758}
-
Antonio Gomes authored
This is a preparation CL that merges DiceTestSigninClient functionality (see account_reconcilor_unittest.cc) into TestSigninClient. Next, IdentityTestEnvironment ctor will be updated to take a SigninClient instance, given that AccountReconcilor still needs a custom SigninClient instance. BUG=926890 Change-Id: Ib45d650b24ac1fe4681b9ef5c9f224c74a3bd847 Reviewed-on: https://chromium-review.googlesource.com/c/1477818Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Veranika Liaukevich authored
Change-Id: Icea85f0dd89c8547726e8a70343f6272c7a3b9d1 Reviewed-on: https://chromium-review.googlesource.com/c/1478485 Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#633756}
-
Sorin Jianu authored
This change is mechanical. It enables NetworkFetcherFactory, which is injected by the embedder, and which creates instances of NetworkFetcher. Bug: 929167 Change-Id: I0246974ab18697dbfda49031666f04811e7b1bcf Reviewed-on: https://chromium-review.googlesource.com/c/1476323Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#633755}
-
Askar Aitzhan authored
sign in screen), perhaps because of push client network stopped working from server side Before: Invalidations stopped working on Device level (public session, After: Invalidations works on Device level Change-Id: I64118538057ac3185dc17cc0cacd68c18f9e2a3f Bug: 932106 Reviewed-on: https://chromium-review.googlesource.com/c/1478793 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#633754}
-
David Bokan authored
This CL makes synthetic input - the kind used in web tests and telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame has been submitted by the renderer and displayed by the display compositor before resolving the completion callback. This means client code that wants to wait until any observable side-effects of this input is visible to further input need only wait on the gesture's completion callback. To give a motivating example: suppose we wish to write a test that scrolls an out-of-process iframe into view and clicks on a button in the frame. The code might look something like this: gpuBenchmarking.smoothScroll(1000, () => { gpuBenchmarking.tap(0, 0); }); This code contains a race today. The callback for smoothScroll is invoked as soon as the ScrollEnd is received in the renderer. However, until a new compositor frame is submitted from the renderer, the tap may occur against stale hit testing geometry. This is a major source of flakiness in our tests. This CL fixes the problem by forcing the renderer to perform a full redraw at the end of each gesture. The redraw produces a compositor frame and we invoke the callback once the compositor frame is displayed. We do this by reusing the RequestPresentation mechanism in RenderWidget. RequestPresentation required two modifications to work in web tests which use a single thread proxy with no scheduler: - LayerTreeHost::Composite needs to check the forced redraw flag to determine whether we need to raster, otherwise it won't produce a frame - RequestPresentation must request a main frame since there's no scheduler to perform the commit, which is what SetNeedsForcedRedraw requests. The timing change exposed an issue in the overlay-play-button-tap-to-hide.html test so this CL also cleans that test up to listen to the animation changes in media controls properly. Finally, it's possible we may get input in a RenderWidget that's not currently displayed. e.g. A click event sent via ChromeDriver causes a TouchStart followed by a TouchEnd. The TouchStart causes a window.open which opens and focuses a new tab. The TouchEnd then happens on the background tab. In this case, we should resolve the callback rather than waiting on a CompositorFrame that'll never come. See ChromeDriver test testNetworkConnectionTypeIsAppliedToAllTabs for an example of this. Bug: 902446 Change-Id: Ib2dddee08400dfa1137c674c47c0d7106961162f Reviewed-on: https://chromium-review.googlesource.com/c/1390329Reviewed-by:Saman Sami <samans@chromium.org> Reviewed-by:
-
Antonio Gomes authored
Code now uses the new identity::AccountsCookieMutator APIs. BUG=926886 Change-Id: I900ba3666c4520766a5824297f6beb5d8fe3a706 Reviewed-on: https://chromium-review.googlesource.com/c/1477811Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#633752}
-
gogerald authored
The target element may be there but may not be interactive. Bug: 806868 Change-Id: Ia89f7e52421cf61ffa87271565b6a5ed75603d42 Reviewed-on: https://chromium-review.googlesource.com/c/1476544 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#633751}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The warnings this avoids is: third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:3688:18: error: declaration shadows a local variable [-Werror,-Wshadow] unsigned length; ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:3658:13: note: previous declaration is here GLsizei length = 0; ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:5234:31: error: declaration shadows a local variable [-Werror,-Wshadow] ScopedTexture2DRestorer restorer(gl); ^ third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc:5190:27: note: previous declaration is here ScopedTexture2DRestorer restorer(this); Bug: 923510 Change-Id: Idef0b7f4b47aad7c0199d9e11571dc93d1c94429 Reviewed-on: https://chromium-review.googlesource.com/c/1477679 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: -
Joe Downing authored
The SecurityKeyResponseTimeout test is flaky on MacOS as the timeout observed can vary by a couple hundred milliseconds which makes the test flaky. The original timeout was just a 'sensible' value so we can increase that value so the test is more consistent. BUG=933522 Change-Id: I9ca78270c7446760022e97a4b477b6bc7074dcee Reviewed-on: https://chromium-review.googlesource.com/c/1478253 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#633749}
-
Becky Zhou authored
Bug: 933492 Change-Id: I48fc19c185ebb0581045668d07e057fb12130521 Reviewed-on: https://chromium-review.googlesource.com/c/1478106 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
sangwoo.ko authored
When gfx::Animation::ShouldRenderRichAnimation() returns false, we shouldn't do heavy animation. In favor of this, disable the following animations: * find bar * info bar * download shelf * bookmarks bar While doing this, fix a bug in gfx::SlideAnimtion::Hide(). As the previous comment mentioned, we should pass 1.0 to AnimateToState() in order to skip to the end of animation. The parameter represents the progress of each animation, not the value. Bug: 8944 Change-Id: Ifc7d3ea8a5379d41f37cafa5a3094a0fe4555dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1457697Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#633747}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The warning this avoids is: third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc:1200:20: error: declaration shadows a local variable [-Werror,-Wshadow] for (auto const& transport_iterator : dtls_transports_by_mid_) { ^ third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc:1187:8: note: previous declaration is here auto transport_iterator = dtls_transports_by_mid_.find(mid); ^ Bug: 923510 Change-Id: Ia9e1734c1bd1aa42bf4b13f6d2b43fe28b6ed511 Reviewed-on: https://chromium-review.googlesource.com/c/1478872 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
