- 20 May, 2020 40 commits
-
-
Yash Khandelwal authored
Tab key press will now use SetSequentialFocusNavigationStartingPoint to put focus navigation to the start of selection. Bug: 1075683 Test: TextFragmentAnchorBrowserTest.TabFocus added Change-Id: I6611b75d142f6d38792387e8dfd9f41fed418544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191336Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yash Khandelwal <yakhande@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770668}
-
James Cook authored
Some of the tests assume that OS sync is enabled, which is not the default. Explicitly enable OS sync in test setup. This is preparation for making SplitSettingsSync on-by-default. Bug: 1013466 Change-Id: Icf0f2ff92083702d6f7a1fcc9fde0ce54569d9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210626Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#770667}
-
Timothy Gu authored
This is a reland of eb686109 Reland changes: Remove stale ".uuid" output file from BUILD.gn. Original change's description: > Update fontconfig cache key handling > > Since If6853404f1e87de4f95a24f6231282543814bd63, the "uuid" variable has > been referring to the MD5 of a fixed string. Update the comment as such, > and remove the now-unneeded .uuid file writing. > > Also update test_fonts/README.chromium as the manual UUID change is no > longer necessary or effective. > > Bug: 767754 > Change-Id: I07a9b10a631e755877cbcb7df40a53359329f8a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209397 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Timothy Gu <timothygu@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770287} Bug: 767754 Change-Id: I6ec0ad451e9e84e1d42060df658dd49494227edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209760 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#770666}
-
Toni Barzic authored
BUG=1072738 Change-Id: I29686d6cc7e2ca36fead0c0bb43e0b7ffb9f8827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210092 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Illia Klimov authored
This patch adds TabSpecificContentSettings::Delegate into ContentSettingsUsagesState. ContentSettingsUsagesState::GetDetailedInfo verifies if ContentSettings is under embargo so that the dialog no longer incorrectly claims that the setting will be cleared after the page is reloaded. Added method TabSpecificContentSettings::Delegate::GetEmbargoSetting to get ContentSetting of embargoed origin. Bug: 1068162 Change-Id: I6cbd3cfedff0072b16b2c2ae07188e2564b1d69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165744 Commit-Queue: Illia Klimov <elklm@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770664}
-
Lijin Shen authored
Move some multi-display related function to api compatibility packages. 1. Guarded by android version check 2. So that can be accessed on other base package Bug: 1081894 Change-Id: I087c846758a0a894fbf03e7fbdcaa49c3811569a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204679 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#770663}
-
Carlos Knippschild authored
Affected histograms: * Net.ErrorPageCounts.SuggestionClicked * Net.ErrorPageCounts.SuggestionPresented * OfflinePages.MhtmlLoadResult.async_loading * OfflinePages.MhtmlLoadResult.auto_async_loading * OfflinePages.MhtmlLoadResult.bookmark * OfflinePages.MhtmlLoadResult.browser_actions * OfflinePages.MhtmlLoadResult.custom_tabs * OfflinePages.MhtmlLoadResult.download * OfflinePages.MhtmlLoadResult.last_n * OfflinePages.MhtmlLoadResult.ntp_suggestions * OfflinePages.MhtmlLoadResult.suggested_articles * OfflinePages.MhtmlLoadResultUntrusted * OfflinePages.PrefetchStore.StoreEvent * OfflinePages.SavedPageCountUponQuery Bug: 1084043, 1084044, 1084100, 1084101 Change-Id: Ia5c04f55cca7529de0bca9b8744de3ccb5cf174b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207574 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#770662}
-
Rune Lillesveen authored
Applying the minimum font-size to the device pixels would not give the expected result, either for using zoom for DSF, or applying page zoom. I added the documentation for the settings based on what I found on stackoverflow: https://stackoverflow.com/questions/52943595/cannot-understand-android-webview-documentation The behavior changes for both the non-"logical" setting in that we will still apply a minimum font-size even if the zoomed font-size would have become larger than the minimum font-size in device-pixels. That is, if we have a minimum font-size of 20px and two elements, one with a 10px font-size and the other with a 20px font-size, they will both be rendered at 40 device pixel size at 200% zoom. This changes the behavior for the logical setting when we have a page zoom factor which is lower than 100%, where we also now just adjust the CSS px font-size before zooming is applied. The logical setting is only exposed via the Android WebView API or via a hand-edited config file. The minimum font-size setting the chrome://settings is the non-"logical" one. If the settings object is null, return the font-size without minimum sizes applied instead of the not-so-useful 1px return we had. Bug: 1082127 Change-Id: Idc03bf37fb7d39206ad4d4dc50eef01b56a69ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199134Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589976000-662c96b2b7dcbccd935f47b39ee73fe1b7f0b5b4.profdata to chrome-mac-master-1589990279-037dea0eb6fc46c134bcb3d90d9f61194c559337.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic053f93fd1256d1e3553856fe25ea86cd118135f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210641Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770660}
-
Clark DuVall authored
This test is flaky, see bug for details. Bug: 1080708 Change-Id: Iea61c27cc41b1945345d495b98542fe583c4e588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210495 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#770659}
-
Dirk Pranke authored
Now that there's a build@chromium.org list, this CL updates the various TEAM= entries in the OWNERS files to reflect that. R=agrieve@chromium.org, thakis@chromium.org, mark@chromium.org Change-Id: I8c41a604dd89aa20c9b381090701eff699c1d302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209616Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#770658}
-
Haiyang Pan authored
This reverts commit d95d2248. Reason for revert: Breaks a couple of android waterfall builders. See http://shortn/_hPfWWZKt4R Original change's description: > Query Tiles : Integration test > > This CL adds end-to-end Integration tests for query tiles. The network > layer is substituted by a embedded test server that serves a fake > server response. Added omnibox javatests that use this mechanism to > test the full flow. > > Bug: 1083807 > Change-Id: Ida65dd9e093ce2311def892158c6bbe4de1fe3c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206153 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770512} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: I0846a937db1db2f8bca7f7eca40717c43e018cf6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210745Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#770657}
-
Thomas Lukaszewicz authored
Prior to this patch |web_view_| was owned by the |web_view_container_| data member of the SimpleWebViewDialog class. This patch has |web_view_container_| own the |web_view_| up until it is added as a child to the SimpleWebViewDialog, at which point the web dialog asserts ownership of the |web_view_|. This eliminates the use of set_owned_by_client() which the Views team is in the process of deprecating. Bug: 1044687 Change-Id: I5bfc0f7f212d039b79565fa7b44298ea5dde8dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199875Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#770656}
-
Mike Jackson (EDGE) authored
Reverting the parameterization part of this test made in this change: https://chromium-review.googlesource.com/c/chromium/src/+/2206298 Per feedback (here: https://chromium-review.googlesource.com/c/chromium/src/+/2204261) submitting a separate change to explicitly disable BMO flag for this test to unblock BMO in ToT. A follow up change should create a fork of this test for BMO using TestWebAppRegistryController. Bug: 1082854 Change-Id: Iefe65655c959d683c1466f65f107d4192f984678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209618Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770655}
-
Joey Arhar authored
When the encoding attribute of an <xsl:output> tag is not a valid encoding according to WTF::TextEncoding, this dcheck is hit: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/dom/document.cc;l=6499;drc=2f11470d7ad8963a9add116df64d2edd1b85d3a4?originalUrl=https:%2F%2Fcs.chromium.org%2F This patch avoids hitting that dcheck by skipping the call to Document::SetEncodingData when the encoding is not valid. Bug: 1077182 Change-Id: I5a21010ff01af5d0fda4932b121e6c21e50b2058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208290 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770654}
-
Tomasz Wiszkowski authored
This is the final CL wrapping up the support for Suggestion Headers. We intentionally not re-build the entire list here to allow focus or scroll position to remain the same after update. Bug: 1073671 Change-Id: I30e526e01207c8a56d332f140622f72eb42a5d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204272Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#770653}
-
Jihwan Marc Kim authored
The nesting of CookieInclusionStatus inside CanonicalCookie is a holdover from when it was just an enum. There's really no great reason to keep it that way, so we should unnest it and move it to its own file. TBR=boliu@chromium.org, avi@chromium.org, droger@chromium.org, alexmos@chromium.org, ajgo@chromium.org, mrefaat@chromium.org, agl@chromium.org, blundell@chromium.org TBRing reviewers: boliu: Please review changes to android_webview/ avi: Please review changes to chrome/ droger: Please review changes to component/signin/ alexmos: Please review changes to content/ ajgo: Please review changes to fuchsia/ mrefaat: Please review changes to ios/ agl: Please review changes to net/ blundell: Please review changes to services/ Bug: 1080767 Change-Id: Ieb9570ceeecd9ae3c2025ad46387aaef820995e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203171Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#770652}
-
Kai Ninomiya authored
Changes in this CL: - Roll external/wpt copy of CTS build to master branch - Roll wpt_internal copy of CTS build to glsl-dependent branch - Update expectations (with some broad skips) - Remove running EVERY test with both worker=0 and worker=1 - Run a few operation tests explicitly with worker=1 - Remove 'results' textarea from cts.html (following upstream) Bug: 1083478, 1069953 Bug: 1069302 Cq-Do-Not-Cancel-Tryjobs: true Change-Id: I4b9b9f87d080b40577e7f4aeaf5f4a250b31e6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200094 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#770651}
-
dpapad authored
Specifically: - cr_checkbox_test.js - cr_container_shadow_test.js - cr_dialog_test.js Bug: 1000989 Change-Id: I8f6f24b966f3158f53035a3326e89e7404659d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209244 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770650}
-
Xiyuan Xia authored
Add AnimationThroughputReporter to report throughput for layer animations. To use it, create an instance with relevant LayerAniamtor and a report callback when setting up animations. The callback will be invoked after animation finishes if there is enough data and no animation is aborted. Bug: 1021774 Change-Id: Ib3029671660c58c29308f7ab2f02052f6ae94b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055691Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770649}
-
Maks Orlovich authored
Just needs to be updated to match the spec changes --- it currently bundles both x86 and x86-64 into "x86" hint value. Bug: 1084527 Change-Id: Iec8074f420612ee406a3a82be747b0687c12b02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208536Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#770648}
-
Xing Liu authored
This reverts commit e4d36bfb. Reason for revert: breaks download stream compile, might be build issue. please do "gn check target". https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879764778699702672/+/steps/compile/0/stdout Original change's description: > Add simple info bar to opt-out for conditional tab strip > > This CL adds an info bar for conditional tab strip to allow user to > opt-out the feature. Some behavior of the info bar: > > * It will show after three consecutive sessions of dismissals. > * If user clicks the "Don't show again" button, conditional tab strip > will never show for this user in later sessions. > * If user clicks the "Show later" button, conditional tab strip > will show again for this user in later sessions, and the info bar will > never reshow. > * If user clicks the dismiss button to dismiss the info bar, the info > bar will reshow after another three consecutive dismissal, but the > limit times of info bar showing is two, i.e. 6 consecutive sessions of > dismissal. > * When the info bar shows, the undo snackbar will not show. > > Note that this is the simple version of info bar that we want, in that > it is tied to one tab and cannot live across tab navigation. > > Bug: 1076295 > Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770632} TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org Change-Id: Id57987bdbf4cb0bb461e9b3ee44f636fa9db330e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1076295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209899Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770647}
-
Ian Kilpatrick authored
Previously we didn't have a flag for elements which were painted atomically. Now we do! Use this flag, instead of the IsAtomicInline flag. Change-Id: I33732fa995d928fc5f7d4e2984711d231a471ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210001Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#770646}
-
Anders Hartvoll Ruud authored
Enforce a limit on how many dependencies a single entry can hold. It's common to define hundreds of custom properties at :root, and we do not want to cache such entries for memory reasons. I've experimented with YouTube and other sites, and 8 dependencies is enough to catch ~90% of all cases, while avoiding extremes such as 137 dependencies (which was observed for YouTube). Bug: 1057072 Change-Id: Ia92d6c53a29bb3784a491fc2efbcef228d5a8caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208985 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770645}
-
Albert Chaulk authored
Bug: b/156272300 Test: None Change-Id: I19bf284742e8ad98ec6854754aa39cc83632318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199704 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#770644}
-
Wei Li authored
Sticky key overlay view is always created and used along with the overlay widget. It is better to be owned by the widget instead of using set_owned_by_client() to maintain the ownership. BUG=1044687 Change-Id: If179b9316b25d3d21ed03166aece9fdcea4b5c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207575Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#770643}
-
Nico Weber authored
No intended behavior change. Bug: 1084623 Change-Id: Id435f5affaa6980b5f1625d95c87967d45264501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207585 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#770642}
-
Nick Burris authored
Ensure comment nodes don't create an editing block boundary. This allows find-in-page as well as text fragments to match text that spans inline nodes that are separated by inline HTML comments, e.g. we expect to be able to match "abcdef" in the following block. <span>abc</span><!--comment--><span>def</span> Bug: 982055 Change-Id: Ie1cd2d9d1837e052e29abc3f4ebbf7e609401367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204631Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Change-Id: Ic4ab63b66ca8c2bf6ba53ea37136fe9cb268310e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210480 Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#770640}
-
Ken Rockot authored
This bundles mojo_core.dll into the normal Chrome release installer to be installed alongside chrome.dll. Fixed: 1082446 Change-Id: Iba03bca2f05d56f6a12396ba781547c3ebb7abe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208354Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#770639}
-
Stepan Khapugin authored
The first scene should not show the overlay when there's no blocking UI. Bug: 1084493 Change-Id: I9d760dc12e5bb07f797f488d470f17484d4080ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210244Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770638}
-
Koji Ishii authored
This patch adds a sequence number of fragments generated for a |LayoutObject|, to use as the fragment ID for |PaintController::SetFragment()|. The |PaintController| changes are in r770260 <crrev.com/c/2207948>. Bug: 982194 Change-Id: I8e811ad763dc842e19c44dfe5216a54a9b6a8527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209774Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770637}
-
Hiroshi Ichikawa authored
I'm leaving a project which touches Chromium, so I want to remove myself from the owners. I was the only owner of //tools/licenses.py, so this means that we need to rely on owners of //tools to review this file. I hope it's OK since the file receives roughly 1 CL per month, mostly with a trivial change to add directories to the whitelist which is part of this file. But let me know if this is not preferred. I will seek for an alternative owner in that case. Change-Id: I2067fada5c3d0a629b0ff0065cc5be1c4c3dc347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210032 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#770636}
-
Danan S authored
Not focusing on the password field after incorrect entry was causing A11Y issues, as described in the bug. Bug: 1070750 Change-Id: Ib725c528e69e3733fd06cb50e587607b31ae60aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209990 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#770635}
-
Clark DuVall authored
This adds isNavigationEntryMarkedToBeSkipped() to NavigationController which allows the client to check if an entry will be taken into account by goBack(). Will look into whether we need some sort of notification for when entries are marked/unmarked as skipped. Bug: 1082208 Change-Id: I3b5652e01c76677623d3edb3b97638a4df496fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209591 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Christopher Cameron authored
To justify investing in mechanisms to avoid compiling shaders, we are going to need data comparing shader compile and link head to head. Previously, I had been using the same histograms for both, and time-slicing them. Now I need both. Leave this as just doing link -- a future patch will test compile as well. Also, stop doing this testing in the browser process -- it didn't make a difference. Bug: 974219 Change-Id: Idc35e195515991cd919ef9cde3b75a92e50a7b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208266 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770633}
-
Yue Zhang authored
This CL adds an info bar for conditional tab strip to allow user to opt-out the feature. Some behavior of the info bar: * It will show after three consecutive sessions of dismissals. * If user clicks the "Don't show again" button, conditional tab strip will never show for this user in later sessions. * If user clicks the "Show later" button, conditional tab strip will show again for this user in later sessions, and the info bar will never reshow. * If user clicks the dismiss button to dismiss the info bar, the info bar will reshow after another three consecutive dismissal, but the limit times of info bar showing is two, i.e. 6 consecutive sessions of dismissal. * When the info bar shows, the undo snackbar will not show. Note that this is the simple version of info bar that we want, in that it is tied to one tab and cannot live across tab navigation. Bug: 1076295 Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770632}
-
Peter Kasting authored
Instead, have the ExtensionDialog or ExtensionPopup create this and ensure it's properly owned by the Views hierarchy. Bug: 1044687 Change-Id: I988473f274a0b0f7434ba85e4874932e8cb45cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207803 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#770631}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9adfd61269a0..52fe4b9946f7 2020-05-20 shaochuan@chromium.org Cleanup NYC PFQ configs and related constants 2020-05-20 mmortensen@google.com Port get_all_firmware_versions from cbuildbot/build_stages. 2020-05-20 richardfung@google.com Remove master-arc-dev container targets 2020-05-20 dhaddock@chromium.org cros_update: Save the logs dir earlier. 2020-05-19 amusbach@chromium.org deploy_chrome: Warn before deploying to device with mismatched board 2020-05-19 khmel@chromium.org arc: Fix misprint in upreving runtime artifacts. 2020-05-19 lamontjones@chromium.org commands: proper encoding in MarkChromeAsStable 2020-05-19 bpastene@chromium.org device: Replace usage of RemoteDevice with ChromiumOSDevice. 2020-05-19 bpastene@chromium.org cros_chrome_sdk: Update cache links when a non-default component is used. 2020-05-19 seanabraham@chromium.org constants: enhance the reasoning for not doing retries 2020-05-19 khmel@chromium.org arc: Move master UprevAndroid and AndroidMetadata after slave sync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Icd8064c287c61299d35a81b3fbd3401eae3efc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210384Reviewed-by:
-
Dan Harrington authored
Change-Id: I72d01908dd17cf2ac66ee26eb314e1cb8b22f55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208296Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#770629}
-
