- 20 Nov, 2017 40 commits
-
-
Erik Chen authored
The original CL added a javatest and its dependencies to the apk_under_test. This causes the dependencies to be stripped from the instrumentation_apk, which causes issue. This CL updates the build configuration so that the javatest and its dependencies are only added to the instrumentation_apk. This is a reland of e0b4355f Original change's description: > Add Android OOP HP end-to-end tests. > > This CL has three components: > 1) The bulk of the logic in OOP HP was refactored into ProfilingTestDriver. > 2) Adds a java instrumentation test, along with a JNI shim that forwards into > ProfilingTestDriver. > 3) Creates a new apk: chrome_public_apk_for_test that contains the same > content as chrome_public_apk, as well as native files needed for (2). > chrome_public_apk_test now targets chrome_public_apk_for_test instead of > chrome_public_apk. > > Other ideas, discarded: > * Originally, I attempted to make the browser_tests target runnable on > Android. The primary problem is that native test harness cannot fork > or spawn processes. This is difficult to solve. > > More details on each of the components: > (1) ProfilingTestDriver > * The TracingController test was migrated to use ProfilingTestDriver, but the > write-to-file test was left as-is. The latter behavior will likely be phased > out, but I'll clean that up in a future CL. > * gtest isn't supported for Android instrumentation tests. ProfilingTestDriver > has a single function RunTest that returns a 'bool' indicating success. On > failure, the class uses LOG(ERROR) to print the nature of the error. This will > cause the error to be printed out on browser_test error. On instrumentation > test failure, the error will be forwarded to logcat, which is available on all > infra bot test runs. > (2) Instrumentation test > * For now, I only added a single test for the "browser" mode. Furthermore, I'm > only testing the start with command-line path. > (3) New apk > * libchromefortest is a new shared library that contains all content from > libchrome, but also contains native sources for the JNI shim. > * chrome_public_apk_for_test is a new apk that contains all content from > chrome_public_apk, but uses a single shared library libchromefortest rather > than libchrome. This also contains java sources for the JNI shim. > * There is no way to just add a second shared library to chrome_public_apk > that just contains the native sources from the JNI shim without causing ODR > issues. > * chrome_public_test_apk now has apk_under_test = chrome_public_apk_for_test. > * There is no way to add native JNI sources as a shared library to > chrome_public_test_apk without causing ODR issues. > > Finally, this CL drastically increases the timeout to wait for native > initialization. The previous timeout was 2 * > CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL, which flakily failed for this test. > This suggests that this step/timeout is generally flaky. I increased the timeout > to 20 * CriteriaHelper.DEFAULT_MAX_TIME_TO_POLL. > > Bug: 753218 > Change-Id: Ic224b7314fff57f1770a4048aa5753f54e040b55 > Reviewed-on: https://chromium-review.googlesource.com/770148 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517541} Bug: 753218 TBR: brettw@chromium.org Change-Id: Ic6aafb34c2467253f75cc85da48200d19f3bc9af Reviewed-on: https://chromium-review.googlesource.com/777697 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517850}
-
Fernando Serboncini authored
Bug: 786995 Change-Id: Ifd48a214d84503e571abd6da6884dd17cfa90a3b Reviewed-on: https://chromium-review.googlesource.com/779639Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517849}
-
Patrik Höglund authored
WebRTC api:video_frame_api is splitting into two targets, and all targets that include i420_buffer.h must depend on a new target api:video_frame_api_i420. This CL fixes that for Chromium. Bug: webrtc:7504 Change-Id: Ic383a5592a5b01a4463565326fe4fecd2fc96829 Reviewed-on: https://chromium-review.googlesource.com/776715Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#517848}
-
Bence Béky authored
* Remove duplicate includes. * Include spdy_session.h for SpdySession::TimeFunc. * s/NULL/nullptr/ * Ever since https://crrev.com/199633019 landed three and a half years ago, |expected_status| argument of CreateSpdySessionHelper() is unused. Remove it, and remove the inaccurately named TryCreateSpdySessionExpectingFailure(). * Move |this_header| and |this_value| declaration closest to their first use in AppendToHeaderBlock(). The compiler should be smart enough to optimize this. * In the same method use implicit pointer to bool conversion in DCHECKs. * Purge naked news in favor of MakeRefCounted<> or make_unique<>. * s/expected_error/expected_status/ for consistency. * Use TestCompletionCallback::GetResult() [1] in CreateSpdySessionHelper() instead of inlining it. [1] https://cs.chromium.org/chromium/src/net/base/test_completion_callback.h?l=72 Bug: Change-Id: Id5bc3f37f068f78901afbf8fb027cc6c63744b22 Reviewed-on: https://chromium-review.googlesource.com/775868 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#517847}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: I951cb50ed4e72ab5d77cab812627a3b7967d70a3 Reviewed-on: https://chromium-review.googlesource.com/776782Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#517846}
-
Jérôme Lebel authored
The SigninPromoViewMediator should be in charge of registering and using: - prefs::kIosBookmarkSigninPromoDisplayedCount - prefs::kIosBookmarkPromoAlreadySeen Also, once the sign-in promo view has been seen too much by the user, it should not set prefs::kIosBookmarkPromoAlreadySeen to true. kIosBookmarkPromoAlreadySeen should be used only for the close button. Some views could have a max number of views, without a close button. This work is to prepare the clean up for the sign-in promo view in the settings (crrev.com/c/774519). Bug: 772050 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id7f7cfc1146afbec552aaa159b628caac691d105 Reviewed-on: https://chromium-review.googlesource.com/776780Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#517845}
-
Theresa Wellington authored
BUG=781994 Change-Id: I45f50f44ccb7ac510255f8659d77713f95962b86 Reviewed-on: https://chromium-review.googlesource.com/777941 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517844}
-
Jayson Adams authored
https://chromium-review.googlesource.com/769238 cleans up the TabView initialization code but the reordering causes the TabView to never receive a pointer to its closeButton. This cl ensures closeButton creation occurs before TabView creation. Bug: 786326, 786387 Change-Id: Id1fce1b8dcd1014ae015b7806df3541981d08253 Reviewed-on: https://chromium-review.googlesource.com/777394Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/master@{#517843}
-
Ehsan Karamad authored
This CL removes the mentioned classes from the autofill client implementation. The PageClickTracker logic used to observe RenderView to get information about user clicks and gesture taps inside form elements. Since AutofillAgent is now a RenderFrameObserver, most of the notifications are directly received from the RenderFrame of the owner WebLocalFrame, or from inside blink through WebAutofillClient interface. Therefore, PageClickTracker code is no longer necessary. Furthermore, currently PageClickTracker is simply a state machine to determine clicks inside a form control element where all its inputs come from AutofillAgent and its only listener (PageClickListener) is the same AutofillAgent. To support the current tests for PageClickTracker, a few test only state variables are added to AutofillAgent. Eventually, the tests should be diligently modified to remove the need for such variables. Bug: 712754 Change-Id: I44e16ba0b10909f84377bb5e7c78a5266786e898 Reviewed-on: https://chromium-review.googlesource.com/773450 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517842}
-
Mathieu Perreault authored
Bug: 784550 Test: browser_tests --gtest_filter=PaymentRequestIframeTest.CrossOriginIframe Change-Id: I89800dd1d9e73804cd93f77ec2b8122d861ccef6 Reviewed-on: https://chromium-review.googlesource.com/779082Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#517841}
-
Alex Clarke authored
Bug: 783898 Change-Id: Ifa0fcbe77bbf9ca952cbd873cca14e3b6e0c7ad0 Reviewed-on: https://chromium-review.googlesource.com/765974 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517840}
-
Becca Hughes authored
Add double tap gesture recognition to MediaControlOverlayPlayButton so it can detect double tap gestures on the side and jump accordingly. Adds LayoutTests as a virtual test suite so they are tested with the modern media controls flag on. BUG=779989 Change-Id: I6e62f88bc51794b21132ec0532cdbd8c5ccbb677 Reviewed-on: https://chromium-review.googlesource.com/757138 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#517839}
-
Egor Pasko authored
Remove the ModernLinker since it becomes unused. Also remove the possibility to set the linker differently in tests. Public document explaining the motivation: https://goo.gl/kWnHYr BUG=719977 (google-internal) Change-Id: I5b9b85817093b36127fa4a607bced57b4350a5b8 Reviewed-on: https://chromium-review.googlesource.com/538582 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517838}
-
Victor Costan authored
This is a follow-up of https://crrev.com/c/771510 and finishes the replacement of the std::string ("Set-Cookie:" HTTP header line) argument with net::CanonicalCookie in network delegates that give embedders an opportunity to block cookies. This CL removes duplicate parsing of Set-Cookie: HTTP header lines, which was an opportunity for bugs. Bug: 756093 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibe4ea727cb55665f1973483345c97e4b2122b7ea Reviewed-on: https://chromium-review.googlesource.com/775606Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
The overlay should show when the video is tapped or interacted with. Bug: 785322 Change-Id: I9ac249005cf08723c35fc6885070c7ec90234aae Reviewed-on: https://chromium-review.googlesource.com/774459Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#517836}
-
David Bokan authored
When RLS is turned on, children of the root layer now have a composited scrolling ancestor. This causes them to use their unclipped bounding rects to test overlap. It turns out overlap testing inside composited scrollers is somewhat buggy (https://crbug.com/783532). In order to prevent regressing existing behavior, this CL makes an exception for children whose composited scrolling ancestor is the root layer. In that that case, we use the clipped rects. This is necessary so that overlap testing is performed against other clipped rects (see comments in OverlapMap::Add for how clipped vs unclipped comparisons work). However, since the root layer is now a scrolling layer, this would break overlap testing for boxes that are offscreen. This CL additionally makes overlap test-related clipping ignore the root layer so that the clipped_absolute_bounding_box for the root layer is actually unclipped, as pre-RLS. The newly added test covers this case. Bug: 783532 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5e302f3f29775d829b94593e8053025c5da0f980 Reviewed-on: https://chromium-review.googlesource.com/742506Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517835}
-
Anita Woodruff authored
- I no longer think this TODO to remove the DCHECK is necessary: It's appropriate to DCHECK since we should only ever create a channel if the old status is UNAVAILABLE, or the same as the new status (to handle the possibility that two code paths try to create a channel at the same time, e.g. during channel migration). Bug: 700377 Change-Id: I0554d2962051863a6c38a9f9ccb262f905f6a241 Reviewed-on: https://chromium-review.googlesource.com/544842 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 761994 Change-Id: I7eb1f7e457eb3a1d23f734c15ba1dc898ade4e52 Reviewed-on: https://chromium-review.googlesource.com/779423Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517833}
-
Dmitry Gozman authored
This is a preparation step to migrate DevTools for shared workers to Mojo. Drive-by: rewrite the test to use new DevToolsAgentHostObserver. Bug: 776009 Change-Id: Ia1f3f4952e8d8ac834a36f94c680cb81e7c50e0e Reviewed-on: https://chromium-review.googlesource.com/777740 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#517832}
-
Renee Wright authored
Also change CSSPropertyValue to take a CSSProperty instead of a CSSPropertyID. This is part of Project Ribbon. This is the first patch in a series which will replace CSSPropertyID with CSSProperty references in the style engine wherever possible. The next patches will propagate this change further out into the rest of the animation directory, and CSSPropertyValueSet. Bug: 779939 Change-Id: I3f30c52a06185933a591d60f080803af72369d72 Reviewed-on: https://chromium-review.googlesource.com/765620 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#517831}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0cb35c7..9a932274 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I37a2a6d49f117149ef0a5c793f2843f49c5cd887 Reviewed-on: https://chromium-review.googlesource.com/779241Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517830}
-
Charles Harrison authored
This CL slightly alters the timestamp in Navigation.TimeToURLJobStart to include synchronous time spent before (potentially) starting the request. This change makes the metric more precisely capture the time until the request reached the network stack. Bug: 779914 Change-Id: I0eaf1fe7380cb6a14a2fbe328f431e35bb82efa3 Reviewed-on: https://chromium-review.googlesource.com/774938Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#517829}
-
Gauthier Ambard authored
The selectedTabChanged method was only calling cancelOmniboxEdit. This CL moves the call to the LegacyToolbarCoordinator instead of implementing this fowarding call to all implementation of the protocol. Bug: 784785 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibcf52e95bb33b19b30665d9f4268efd3b11d6d07 Reviewed-on: https://chromium-review.googlesource.com/779400Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517828}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 525bd4d1. With Chromium commits locally applied on WPT: 23705631 "service worker: Upstream sandboxed iframe test to WPT." Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5671 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=lukebjerring No-Export: true Change-Id: I9e1a633a388916def7cb1c2d0aece50d5df7c5eb Reviewed-on: https://chromium-review.googlesource.com/777904 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517827}
-
Jonathan authored
Fix filter files. They were incorrectly setting the test suite to only one test TBR=kylechar@chromium.org TEST=viz_content_browsertests Bug: 760181 Change-Id: I2a1af50f7cbaf9f5a24ba3e3083448f0b70a21b9 Reviewed-on: https://chromium-review.googlesource.com/779222Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#517826}
-
Greg Thompson authored
This prevents showing the toast to the user a second time in these cases. BUG=786918 R=skare@chromium.org Change-Id: I8858e7cb1acc247c011494cd4d446a75f19e18a9 Reviewed-on: https://chromium-review.googlesource.com/778844 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517825}
-
Mike West authored
https://github.com/w3c/webappsec-credential-management/pull/114 shifts the restriction on nested usage of `navigator.credentials.{get,store}` from a complete prohibition to one which applies more narrowly to `PasswordCredential` and `FederatedCredential`. This patch aligns Blink's behavior with the spec: 1. The nested-context restriction applies only to `get()` and `store()` operations that request `password` or `federated` credential types. `preventSilentAccess()` and `create()` can be called anywhere. 2. Nested contexts that are same-origin with all of their ancestors are carved out from the exclusion above. So, `example.com` embedded in `not-example.com` will trigger a rejection, while `example.com` embedded in `example.com` will not. 3. Nested usage triggers a `NotAllowedError` as opposed to the current `SecurityError`. Bug: 785172 Change-Id: If0e75d7b84e91ed7f0eaf1220e90a1c307a85312 Reviewed-on: https://chromium-review.googlesource.com/771190 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#517824}
-
Peter Kotwicz authored
This CL: - Clarifies which tests test that a CCT is launched and which do not - Adds testing that the toolbar is hidden/shown in test cases where the toolbar should be shown instead of launching a CCT. - Removes deceptively named assertOffOrigin() which does not assert but instead waits for a condition to be met. Instead: - Changes WebappNavigationTest#waitFor() to wait till the tab for an activity has been created - Uses ChromeTabUtils#waitForTabPageLoaded() BUG=None Change-Id: If588dcc4ae2a9341221eb64ac7184bb5b75efd33 Reviewed-on: https://chromium-review.googlesource.com/777903 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#517823}
-
Justin Cohen authored
Only dismiss omnibox on user initiated drags. Bug: 785482 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iebf1d46b3f170e2130c62b51c0adade9f4b9c3fc Reviewed-on: https://chromium-review.googlesource.com/777442Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517822}
-
Justin Cohen authored
Bug: 784841, 786552 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9469e3b2d69135ff7e39977ef0f50b7cb4ac72a4 Reviewed-on: https://chromium-review.googlesource.com/777585Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517821}
-
Sylvain Defresne authored
Remove deprecated code from WebStateObserver. It no longer track the observed WebState and it is the responsibility of the client code to call AddObserver/RemoveObserver on the WebStates. Bug: 775684 Change-Id: I380212c35e8165fc69b3c0252f78e4a925632024 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771712 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517820}
-
Peter Kotwicz authored
This CL: Makes the lightweight/non-lightweight first run dialog - be announced as "Chrome First Run Experience" by Talkback - be listed as "Chrome First Run Experience" in Android Recents on Android-Pre-L BUG=766844 Change-Id: Id5567400dc6dbcc467cb773d3e7a4037860537f7 Reviewed-on: https://chromium-review.googlesource.com/775857Reviewed-by:
-
Mark Cogan authored
This CL moves the UI implementation out of BeforeTranslateInfobar. There's quite a lot going on here, but the basic interactions are straightforward: - Since UI doesn't belong in browser/translate, chrome_ios_translate_client now takes a language selection handler on initialization, and the before-translate infobar uses that handler to request language selection from the user. That involves passing a context object (LanguageSelectionContext) and a delegate for the UI to signal when language selection is complete. - The language selection handler passed into the translate client is an instance of LanguageSelectionCoordinator, owned by the BVC. This is a long-lived coordinator, repeatedly started and stopped by the LanguageSelectionHandler method call. It creates a new view controller and mediator instance each time it's invoked. - The view controller used for this isn't presented; it's a contained child of the BVC, but it's "presented" and "dismissed" using a from-the-bottom animation. This animation, along with the logic of adding and removing a child view controller, and positioning the child inside the BVC, is handled by a generic 'presenter' interface. - The presenter interface doesn't specify any particular positioning or animation; this is defined by the VerticalAnimationContainer implementation. This is passed into the coordinator by the BVC; effectively the BVC dictates how the child is presented, and the coordinator doesn't know about it. There's a delegate protocol so the coordinator knows when dismissal is completed. - The view controller uses the mediator as a data source for language names, and this relationship is set up over the consumer interface. On one hand, this feels like a fairly straightforward refactor that gets UI code out of browser/translate. On the other hand, it's creating five classes and six protocols to move ~200 lines of code. An argument could be made that more of the code in before_translate_infobar_controller should move into the mediator; I suspect that will need to wait until we have better patterns for refactoring infobars. I do think the presenter pattern here is something we can use in general to better encapsulate child view controller positioning and animation without needing to build specific support for it in coordinators. One issue here is that the coordinator is long-lived and acts as the language selection handler. This is intentional, to keep code out of the BVC. An argument could be made that the BVC should be the handler, and it should directly start/stop the coordinator. Bug: 785388 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ied9da19bb88cabd1e14b67689052597186e190e8 Reviewed-on: https://chromium-review.googlesource.com/764327Reviewed-by:
-
Colin Blundell authored
ConstructAboutInformation_DEPRECATED() is ... deprecated. This CL moves the ConstructAboutInformation unittest away from using it, which is trivial. Bug: 783144 Change-Id: Ie492afe35dba907e556870b799bcb58ac094a7b7 Reviewed-on: https://chromium-review.googlesource.com/769008Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#517817}
-
Colin Blundell authored
sync_ui_util::ConstructAboutInfo_DEPRECATED() is ... deprecated. This CL ports ProfileSyncServiceHarness away from it, having PSSHarness directly supply its cached account info to ConstructAboutInfo(). Bug: 783144 Change-Id: I6bff37d2e39244dfdcb853980783d1e9cada36bd Reviewed-on: https://chromium-review.googlesource.com/768875Reviewed-by:
-
Sylvain Defresne authored
Convert TestRedirectObserver to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Also remove TestRedirectObserverUserDataWrapper by using WebStateUserData. Bug: 775684 Change-Id: I85e965e8c99dd5dd848082c305619aaff5b6a5ca Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771690 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Kush Sinha authored
Change-Id: Ibd3291ac69042141ad9809021abcb6d7a18b27cf Reviewed-on: https://chromium-review.googlesource.com/779186Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#517814}
-
Sergei Datsenko authored
Clean up render tests structure and require virtual time exhaustion as an indication of rendering completion. Change-Id: I62a7ed9389facaab223ab3ddebb80496ece5c203 Reviewed-on: https://chromium-review.googlesource.com/776517Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4f2b219..b0cb35c7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I36f4ac2649017d565dacb62b3b4b3afa5cf6cfd5 Reviewed-on: https://chromium-review.googlesource.com/778780Reviewed-by:
-
Sylvain Defresne authored
Convert BrowserListSessionServiceWebStateListObserver to observe the active WebState directly and remove dependency on deprecated methods of WebStateObserver. Bug: 775684 Change-Id: I5c6a4478515c657d077180b6de263ac531930d4d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771671 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
