GitLab

This test is currently failed on this bot because of memory leak
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak

Bug: 606367
Change-Id: Ie7b7ee195cfbfa4afc51bada69f5e2a471f537f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637697Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664878}

The region is in surface space not in display space.

Bug: None
Test: Run "wayland_fullcreen_client --transform=90" and touch surface.
Change-Id: I982ce55e92236a07ee441d6cb38c872a86c786d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636600
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664877}

Change-Id: I843a4e6d667c7b86dfd95c092414bb478d9f860b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637048
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664876}

On Desktop add a shortcut to the Google Search page to the
list of most visited tiles if the user does not have
custom links. If the user already has the maximum number
of MV tiles the last one will be replaced with this new
shortcut.

Bug: 962558
Change-Id: I6f3bf15f380cf02292ad738d65bf125c739dd68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626955Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664875}

Enable the experiment and remove fieldtrial config.

Bug: 823071
Change-Id: Icfc5dcd411e4e92e9a9ead96bcd51bea2fa39aea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634839
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664874}

See design at http://go/cros-devicesync-v2-scheduling.

The added DeviceSync logic has nearly identical behavior to
Enrollment scheduling. The notable difference is that DeviceSync v2
does not make periodic requests.

Support for InvokeNext processing is added. ClientDirectives received
from CryptAuth may contain an InvokeNext field specifying that an
Enrollment and/or DeviceSync request should be made after the current
Enrollment or DeviceSync attempt finishes successfully. These
subsequent requests are handled internally by the scheduler.

Bug: 951969
Change-Id: Ib8b4ed98ee8f3e493379c20bd14e1ce5473aaac7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630030
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664873}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/31adc7db3619..f404713905ef


git log 31adc7db3619..f404713905ef --date=short --no-merges --format='%ad %ae %s'
2019-05-30 saklein@chromium.org cros_uprev: Simplified cros_mark_as_stable.
2019-05-29 seanabraham@chromium.org chromeos-config: Disable moblab-generic-vm-pre-cq tests


Created with:
  gclient setdep -r src/third_party/chromite@f404713905ef

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I1f7312486c7bc48cf340b29e391d208e6e3252c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637308Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664872}

This CL makes changes to the files, so they compiled without errors
with EG2. Updated EG1 build target with proper EG1 defined.

This CL does not add files to EG2 target, because tests are failing
due to EG2 helper absence.
Relanding reverted: https://crrev.com/c/1632591

Patch 2 remove changes from forms_egtests.mm which broke slim-nav bot.

Bug: 922813
Change-Id: I1efbe63abdb7d5624d16af479e4fe68621272d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637034Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664871}

Sometimes coverage data might not be generated on device due to wrong configs or tests and command will fail to pull data or remove data.
Don't throw exception so that runner can still print result.

Bug: 843307
Change-Id: Ie08cf676ca1ca2fb0d3ed4a087d31042c0f0a0ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636568Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#664870}

This reverts commit 35454c17.

Reason for revert: crbug.com/968645

Original change's description:
> Use shared images in CopyVideoFrameYUVDataToGLTexture
> 
> Use an explicit shared image allocation for the intermediate texture
> that is used in both the source and destination GL contexts.
> 
> Bug: 882547
> Change-Id: Ibd37bb16a1a43860976c9b35feadd576e099df4d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633530
> Auto-Submit: Antoine Labour <piman@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664539}

TBR=sandersd@chromium.org,piman@chromium.org

Change-Id: I7e277608fa156f91f9c12f8d98498d770397d9ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 882547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637683Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664869}

InMemoryDB is usually reserved for Guest and Incognito accounts. But
recent experiments by liberato@ hinted (noisy stats, other factors may
be responsible) that forgetting all your data at the boundary of each
browsing session might be good for prediction quality. Lets see :)

Bug: 968331
Change-Id: I6803a206266bf7ff6c39d4f6b4c12534c391900d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636475Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664868}

This reverts commit c6bc9419.

Reason for revert: Caused compile error on bots. 

Original change's description:
> Added XR session request consent dialog for Android
> 
> The consent dialog strings - title, body, button texts - are all shared
> between Android and Windows.
> 
> Bug: 963637, 962755
> Change-Id: I4d3f090db1ee2487f305b6993b2851c112df594c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620695
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Carlos Pizano <cpu@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664808}

TBR=ddorwin@chromium.org,mthiesse@chromium.org,cpu@chromium.org,klausw@chromium.org,billorr@chromium.org,tiborg@chromium.org,sumankancherla@chromium.org

Change-Id: I0dc662ef94d94aec48d1ea303299f6c066f702b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 963637, 962755, 968680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637374Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664867}

This is to match TextView's behavior, see b/122818072.

TextView passed its locale to TextSelection/TextClassification, this
locale is from an inner mTextPaint object, TextPaint is a subclass
of android.graphics.Paint.

The default locale in android.graphics.Paint is set to
LocaleList.getAdjustedDefault(). [1]

Note that there is still a gap between WebView and TextView since
TextView has API to set locale, but WebView doesn't.

[1] https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/graphics/java/android/graphics/Paint.java#491

Bug: b/122818072, 710505
Change-Id: Iaaf07656e7c852f30ac0b5ae76108583fc5105da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636311Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664866}

In the label experiment on desktop, a LabelFormatter is not created a
surprising number of times.

I suspect this is due to the condition that forms have a name field, so
I am removing this condition in hopes of increasing the number of times
a LabelFormatter is successfully created.

Bug: 968207
Change-Id: Ic41bfe2025f720d2385071c96f956ba7c1f0c141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635633
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664865}

This module does not have actual tests yet.

Notable changes:
 - add ios_chrome_ui_eg2tests_module module
 - add ios_chrome_ui_eg2tests_module to ios/chrome/test/earl_grey2:all_tests
   target

This CL follows the same pattern as https://crrev.com/c/1628171

Bug: 866147
Change-Id: Iaac2b480054e221e8b3b9b8a8b07292608e27742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636483Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664864}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e18325d988a5..b4f93115c39b


Created with:
  gclient setdep -r src-internal@b4f93115c39b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com

Change-Id: I56d5ce87b17ec3903b28fa25793f748a609b701b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637410Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664863}

This patch fixes the top and bottom of inline boxes for the
`top` and `bottom` values of `vertical-align` not to include
their paddings.

The spec[1] says align with the top/bottom of boxes. Line
box in CSS is special that paddings are included to draw
background and borders, but are not included when computing
their heights[2]. All impls agree that the top/bottom in this
case is the latter; i.e., not to include paddings.

[1]: https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align
[2]: https://drafts.csswg.org/css2/visudet.html#inline-non-replaced

Bug: 968438
Change-Id: I034d0390e3695e8a3fcc737f94fc5561e16cd617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637006
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664862}

Bug: 968586
Change-Id: I30437e802a3fccfa6658dc7ae2a49911a5be11f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636719
Auto-Submit: John Budorick <jbudorick@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664861}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9779b146cdfe..3acbc749e4a6


git log 9779b146cdfe..3acbc749e4a6 --date=short --no-merges --format='%ad %ae %s'
2019-05-30 ehmaldonado@chromium.org gclient: Make it possible to set target_rev to a commit hash.
2019-05-30 borenet@google.com [git-cl] Fix crash in "git cl upload"


Created with:
  gclient setdep -r src/third_party/depot_tools@3acbc749e4a6

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:956807
TBR=agable@chromium.org

Change-Id: I51fb1d0031a2861e13bfec855c9ef42f4276b8dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637311Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664860}

The OT token is required in order to load a pexe from the open web;
otherwise the same existing rules apply (e.g. pexes can be loaded by
extensions, or when the --enable-nacl flag is used).

The logic for determining whether the plugin is allowed to load (and
what to do when it isn't) is hooked in to the existing logic (e.g.
for the open web vs extensions, nacl vs pnacl, etc).

Bug: 918374

Tbr: falken@chromium.org
Change-Id: Icfc674dfa3d6e6d501d5a03c6f531a451a3a2903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633994
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664859}

Prior to this CL, composited animations on the backdrop-filter property
were not implemented. This CL plumbs them through to CC. It also includes
many more tests, both cc_unittests and WPT tests, for animated
backdrop-filter.

Bug: 965512
Change-Id: Id2dd86024a93cb326903923b458a20a63ffcb1b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636632Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664858}

Change-Id: If93e959f82073fb6f1ad6dd22dd21979300c2e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627708
Auto-Submit: Clifford Cheng <cliffordcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664857}

This makes it so that inspector_protocol instantiations within
Chromium stop using the copy of the encoding library in the template -
that is, third_party/inspector_protocol/lib/encoding_{h,cpp}.template -
and use the C++ library directly instead. This is done
by having third_party/inspector_protocol/lib/Values_cpp.template
include it, which is configured in the
inspector_protocol_config.json.

Change-Id: Ia38fa2b36585ae90d2889946cae346e168dc5f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634423
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664856}

Add a No thanks used only by Payments Autofill. So when we want to override strings
with Finch overrides no other usages will be affected.

Bug: 961082
Change-Id: I85519146a5b4b3b88c65065e2378aba15c6e6971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610308Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664855}

Bug: 968566
Change-Id: I48867b1c932d41c2654b9529fe41a86d8ab2bab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637504Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664854}

Tested using CronetSampleApk, which crashes without this fix:

ninja -C out/Debug-x86/ cronet_sample_test_apk
out/Debug-x86/bin/run_cronet_sample_test_apk

Bug: 968172
Change-Id: I6cd3662b145e920464654b2af50c44801280ee1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636560Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664853}

I'm hoping this will make Milo's colors make sense again.

Currently if a benchmark fails completely and provides no
test_results json, then we will ignore that
output and not surface it in the merged output.json. This
fixes that.

Bug: 947100
Change-Id: I42259ae6c3597586da4c35b1f2bea76f1972529f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637037Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664852}

This patch makes sure we honour all VirtualAuthenticator options
instead of silently ignoring most of them.

Bug: 826936
Change-Id: I34e81b5d11ced056226d6e36588a0e0ca1074cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632729
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664851}

Transient XRInputSources need to be added and removed from the input
source list as they are needed.  This exposes two helper methods on
XRSession to add/remove a transient source, and updates the canvas input
provider to call those methods when sending events.

Bug: 968229
Change-Id: I49e0313217a9d1526722c8a9f1e57f1141d3ee3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635775Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664850}

All supporting code now assumes STYLE_TEXTBUTTON, so we no longer need
this enum or supporting code.

BUG=642920

Change-Id: I4817a8383f9e6470f2950767ea5a2f5805a5755c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636481
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664849}

FTL currently returns raw email address so NormalizeJid() seems to work
out of the box. But they do plan to change it to a more aggresive
canonical form, which will cause users with email addresses with dots
fail to generate signatures or validate sender/receiver.

This CL implements the new normalization logic that will be used when
normalizing an FTL ID.

Bug: 968368
Change-Id: Ic7fa27e183124096563a6a7b4e337479e7edbb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636594
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664848}

This is missed from the earlier patch.
In reduced mode, only InProgressDownloadManager will be created.
As a result, we should call OnDriverReady() when it is initialized.
This doesn't affect existing code when reduced mode is not enabled
for DownloadService though. As we will always create DownloadManagerImpl
when creating the download service.

BUG=942770

Change-Id: Ic6b54ccc47b8764796bf54eb086099d1c638cc6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636814
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Auto-Submit: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664847}

WebVR apps could potentially transfer ArrayBuffers that were in use by native code.
This CL prevents that by either ensuring that buffers have not been transferred before
writing to them, or preventing the WebApp from moving the internal buffer at all.

Additionally, ArrayBufferView did not null out its base_address_ member when neutering.
This CL adds that, so that unchecked reads and writes cause a null pointer dereference
instead of a (much more) severe use-after-free scenario.

Bug: 957516
Change-Id: I5dbadab03f96d6f742cd41cec16d5c7423cc9b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636091
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664846}

This will allow graph observers to immediately know the page
visibility in the OnNodeAdded() function.

Bug: 910288
Change-Id: Ib369b4dc36447a408b0fc4971ed01779ef42df1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637579
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664845}

External component extensions are loaded through the external provider
mechanism. These external extensions, by default, have a lower fetch
priority. For external policy extensions, we increase the priority. Do
the same for external component extensions, and add a test.

Bug: 965686

Change-Id: Ied58e08f403d574c4b6e8f7bdc484db90f926018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627783
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664844}

Prior to this patch, during simplified layout we'd calculate the block-size
of a table-cell the same as any node. This missed the specific table-cell
logic within the NGBlockLayoutAlgorithm.

This moves this logic down into the ComputeBlockSizeForFragment method.

Bug: 968016
Change-Id: Idb4d76bb199d1690705e1f24d9de3ea53e2c8af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637219Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664843}

When running the condition for the AutofillOffNoServerData feature,
I added a check to see if Autofill's client-side heuristics were
predicting a CVC field. If they do, then we won't overwrite the type to
"Unknown", as that breaks the CVC filling flow when unmasking server
cards via the CVC prompt.

Testing:
Added unit tests
Manually tested on the problematic website.

Bug: 968036
Change-Id: I9fa010d148fd168bd8c0348e93e18edf903db88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636256
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664842}

This is a followup to https://crrev.com/c/1614282 which adds more
expectations to verify the contents of sandboxed <iframe>s and ensures
the documents are empty.

Bug: 963641
Change-Id: I5106aff83c25b3f9e0d5a6239ef24f8351529530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637218Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664841}

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=newcomer@chromium.org

Bug: 616447
Change-Id: I8cfb4b77da06edc6ed251bcad917f6e4369fc7f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636063
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664840}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=bajones@chromium.org

Change-Id: Icf167d4cc8395db1bad4cc2252b4acb8bbb5c691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635613Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#664839}