GitLab

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676

Review-Url: https://codereview.chromium.org/2281943002
Cr-Commit-Position: refs/heads/master@{#415681}

BUG=642534

Review-Url: https://codereview.chromium.org/2291193004
Cr-Commit-Position: refs/heads/master@{#415680}

This is unused and no longer needed. We can revive it from git history if
we need it again.

BUG=641996
TEST=compiles

Review-Url: https://codereview.chromium.org/2298603002
Cr-Commit-Position: refs/heads/master@{#415679}

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/BkPSl0Oey8k/BqJ3_ck0BAAJ

BUG=569690

Review-Url: https://codereview.chromium.org/2217763003
Cr-Commit-Position: refs/heads/master@{#415678}

BUG=3333

Review-Url: https://codereview.chromium.org/2298023002
Cr-Commit-Position: refs/heads/master@{#415677}

This CL implements the new <fit-content> track size which is defined as
follows: "Represents the formula min(max-content, max(auto, argument)),
which is calculated similar to auto (i.e. minmax(auto, max-content)), except
that the track size is clamped at argument if it is greater than the auto
minimum."

From the parsing POV fit-content was implemented as a new type of function
which only takes one argument. That forced us to refactor some code because
minmax() was the only allowed function for <track-size>s so far.

The implementation key is a new attribute in GridTrack called growthLimitCap
which is precisely the attribute of fit-content(). Some parts of the track sizing
algorithm were adapted to this change like for example the sorting of tracks by
growth potential (we need to consider the caps).

BUG=618972

Review-Url: https://codereview.chromium.org/2287113004
Cr-Commit-Position: refs/heads/master@{#415676}

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.

BUG=642028

Review-Url: https://codereview.chromium.org/2296973003
Cr-Commit-Position: refs/heads/master@{#415675}

BUG=621773

Review-Url: https://codereview.chromium.org/2293203002
Cr-Commit-Position: refs/heads/master@{#415674}

Losing network connection while prerendering can show up as an Unsupported Scheme failure
currently as it sees a special data URL in path toward rendering an error page. We don't want
a flakey network connection fail a background load request on just a single try, so for now,
we will treat this specific error type as a cancel rather than a failure so that it is subject
some limited retrying. The down side, is that for some page that has a repeatable redirect
to an unsupported scheme, we will waste some retries on it that we otherwise could skip.

Ideally, we could get a different final status code from the prerenderer if it could clearly distinguish a network failure condition but it does not currently have such knowledge.

BUG=642025

Review-Url: https://codereview.chromium.org/2294933003
Cr-Commit-Position: refs/heads/master@{#415673}

https://chromium.googlesource.com/skia.git/+log/4bcd62e3313d..982e7c502f44

$ git log 4bcd62e33..982e7c502 --date=short --no-merges --format='%ad %ae %s'
2016-08-31 mtklein switch CQ over to GN_Android compile bots
2016-08-31 senorblanco Screenspace AA tessellated GPU path rendering.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2296223002
Cr-Commit-Position: refs/heads/master@{#415672}

https://chromium.googlesource.com/angle/angle.git/+log/d5da505..ad10a4a

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2298593003
Cr-Commit-Position: refs/heads/master@{#415671}

with a number of needed utility functions.

Apologies for the size of this CL; some of the utility implementations ended up being
fairly involved.

This CL:

(1) moves ExecuteJavascript out of web_view_matchers to be a public utility function
in web_view_interaction_test_util.

(2) Add web_view_actions and shell_actions for new action providers.

(3) Adds ios/testing/earl_grey/matchers for non-web-specific matchers.

(4) Adds a "verified action" wrapper that will inject a mousedown event handler and
a script callback handler to watch for it, so that UIKit actions that ought to trigger DOM
events can be verified.

(5) Adds a BoundingRectOfElementWithId() utility to find where (in webview bounds
coordinates) an element is.

(6) Adds a method that long-presses a webview element to trigger (or not) a context
menu.

(7) Adds matchers for finding elements in context menus, and finding an element to
tap that will dismiss the context menu. The latter encapsulates the differences between
iPad and iPhone.

(8) Adds header guards to shell_matchers.h and web_view_matchers.h (!)

(9) Changes a bunch of std::string params for utility methods to be references.

(10) (finally) Implements the upstreamable context menu tests, adding a test for simply
triggering the context menu.

BUG=

Review-Url: https://codereview.chromium.org/2275303004
Cr-Commit-Position: refs/heads/master@{#415670}

The range, when navigating to dynamic widgets, sometimes detaches entirely from the document and only re-appears as a result of future events. Since we're observing children changed for active descendant changed, filter out events that result in a range pointing to a null node.

BUG=641213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2296013002
Cr-Commit-Position: refs/heads/master@{#415669}

The CL broke some websocket layout tests, will reland once that's
worked out.

This reverts commit 398c105e.

Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.

BUG=624462, 637017
Committed: https://crrev.com/398c105ea8391473126021104554d70fda08324b
Cr-Commit-Position: refs/heads/master@{#415643}
TBR=eroman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2297263002
Cr-Commit-Position: refs/heads/master@{#415668}

It's a fairly thin wrapper on a HeapHashSet, and the two non-trivial functions
are each only called from a single place in ResourceFetcher. Inline them there.

BUG=

Review-Url: https://codereview.chromium.org/2296923002
Cr-Commit-Position: refs/heads/master@{#415667}

Changes include:
- Omitting trailing period and colons from labels/headers.
- Omitting "optional" text from labels and adding group subheading to indicate optional fields.
- Shorten some strings.

Used camelCase for new string per presubmit guidelines for i18n-content.

BUG=640604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2293673002
Cr-Commit-Position: refs/heads/master@{#415666}

If the output is saved to a file properties.txt, you can generate a
visual representation using dot:

$ dot -Tsvg properties.txt > properties.svg

Sample output:

http://jsbin.com/jajuyuyixo/edit?output

R=pdr@chromium.org,wangxianzhu@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2252273006
Cr-Commit-Position: refs/heads/master@{#415665}

To be used by BrowsingDataRemover when the user chooses to delete data
for a particular site.

This is implemented as a new method HostCache::ClearForHosts() as opposed
to extending the existing HostCache::clear(), as clear() has a lot
of callsites and thus it seems to be useful to keep this more specific
version.

On the other hand, the fact that there are many callsites of clear()
also means that in many cases it's acceptable to clear the entire cache
even if clearing less would be sufficient. In that sense, this CL might
be unnecessary and it might be acceptable for BrowsingDataRemover to also
clear the entire cache even if the user only needs to delete data for one
site.

TBR=achuith@chromium.org
BUG=589586

Review-Url: https://codereview.chromium.org/2298173002
Cr-Commit-Position: refs/heads/master@{#415664}

This is happening due to a Refresh called from a task group
which process_id is zero.

I am not sure if calling Refresh when process_id is still
zero should be supported. Perhaps that is an issue in
TaskManagerImpl / TaskGroup code, I think
https://crbug.com/521197 might be related. For now the
quick fix is move the DCHECK a bit further in the code so
it doesn't get triggered in that case.

BUG=642482

Review-Url: https://codereview.chromium.org/2293293002
Cr-Commit-Position: refs/heads/master@{#415663}

BUG=632460

Review-Url: https://codereview.chromium.org/2206283003
Cr-Commit-Position: refs/heads/master@{#415662}

Use std::move and delete unnecessary functions.

BUG=None

Review-Url: https://codereview.chromium.org/2292203003
Cr-Commit-Position: refs/heads/master@{#415661}

Update code in net to use JavaRef when calling Java methods via JNI,
instead of passing bare jobject. Various function parameter types are
converted from jobject to JavaRef to enable calls to obj() higher up the
call chain to be removed.

BUG=506850

Review-Url: https://codereview.chromium.org/2301553002
Cr-Commit-Position: refs/heads/master@{#415660}

ExceptionStatePlaceholer was out-dated.  This CL updates it according
to the latest ExceptionState, adding throwRangeError and
rethrowV8Exception.

BUG=

Review-Url: https://codereview.chromium.org/2298753002
Cr-Commit-Position: refs/heads/master@{#415659}

No change, just re-ordering. Really this time.

TBR=chrishtr@chromium.org
BUG=636475

Review-Url: https://codereview.chromium.org/2295213002
Cr-Commit-Position: refs/heads/master@{#415658}

Review-Url: https://codereview.chromium.org/2267173003
Cr-Commit-Position: refs/heads/master@{#415657}

Changes to show security level instead of EV cert and animate it away. Dangerous site levels are not animated.

BUG=622531

Review-Url: https://codereview.chromium.org/2144903004
Cr-Commit-Position: refs/heads/master@{#415656}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/051fb8c6..3e5d344f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2301543003
Cr-Commit-Position: refs/heads/master@{#415655}

The site in question is known to have high CPU usage, even though there appears
to be no visual changes to the site.

BUG=640398, 638365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2271793003
Cr-Commit-Position: refs/heads/master@{#415654}

BUG=638963

Review-Url: https://codereview.chromium.org/2278043003
Cr-Commit-Position: refs/heads/master@{#415653}

https://pdfium.googlesource.com/pdfium.git/+log/87dffc031547..21ce1a68bb9f

$ git log 87dffc031..21ce1a68b --date=short --no-merges --format='%ad %ae %s'
2016-08-31 npm Update gn args in README so it includes is_component_build
2016-08-31 jaepark Use enum class for subtypes of CPDF_Annot.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2298763002
Cr-Commit-Position: refs/heads/master@{#415652}

R=jochen@chromium.org
BUG=chromium:630217

Review-Url: https://codereview.chromium.org/2236443002
Cr-Commit-Position: refs/heads/master@{#415651}

Also updates the route from /siteSettings/plugins to /siteSettings/flash

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2296983002
Cr-Commit-Position: refs/heads/master@{#415650}

https://chromium.googlesource.com/skia.git/+log/272b311298d7..4bcd62e3313d

$ git log 272b31129..4bcd62e33 --date=short --no-merges --format='%ad %ae %s'
2016-08-31 egdaniel Add some copy support for vulkan msaa

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2297203002
Cr-Commit-Position: refs/heads/master@{#415649}

Revert of Filter out credentials with non-matching schemes (patchset #1 id:1 of https://codereview.chromium.org/2298733002/ )

Reason for revert:
Patch is crashing tests on windows bots.

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52229

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52229/steps/browser_tests%20on%20Windows-7-SP1/logs/AutofillEditAddressWebUITest.testFieldValuesSaved

Original issue's description:
> Filter out credentials with non-matching schemes
>
> PasswordFormManager::ProcessMatches currently happily accepts credentials from
> PasswordStore with a different PasswordForm::Scheme than the observed form has.
> However, it still has a DCHECK against it later (in the Autofill* methods), so
> it is clearly not expecting these, rather than mixing the schemes being by
> design.
>
> And it should not be by design. Especially, if the saved credential is a
> non-HTML one, and should be filled in a HTML form. Mixing them makes the
> non-HTML credential vulnerable against (injected attacker's) JavaScript
> accessing them.
>
> This CL filters out credentials with non-matching scheme from the batch coming
> from the PasswordStore. Given the absence of DCHECKs in release builds, this
> actually changes the behaviour for Chrome users, but the change is a desired
> one.
>
> BUG=640897
>
> Committed: https://crrev.com/da597b2f777ea4ac768164bee01f39a90fba3c65
> Cr-Commit-Position: refs/heads/master@{#415622}

TBR=mkwst@chromium.org,dvadym@chromium.org,vabr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640897

Review-Url: https://codereview.chromium.org/2298263002
Cr-Commit-Position: refs/heads/master@{#415648}

When there are multiple BidiRun in a line (multiple inline elements,
whitespace collapsing, or RTL,) setLogicalWidthForTextRun has
O(#BidiRun * #WordMeasurement), resulting similar characteristics as
O(n!) for the line length.

This patch fixes this for LTR.

For RTL, we could improve up to log2(N) by using binary search, or
better by using fast index for LineLayoutText for multiple elements
case. It was once tried but removed due to its complexity, we can do it
if they came up as real cases.

Following performance tests are now 10-20x faster. The amount of text
for these tests were increased by 12x, matching to
long-line-nowrap.html.

PerformanceTests/Layout/long-line-nowrap-collapse.html
PerformanceTests/Layout/long-line-nowrap-spans-collapse.html

BUG=583711, 642345

Review-Url: https://codereview.chromium.org/2285053002
Cr-Commit-Position: refs/heads/master@{#415647}

This CL:
* Uses Mus' IMEServer to do the IME logic in InputMethodMus.
* Adds unittests to test InputMethodMus.
* Starts test_ime_driver on mus+ash session startup.
* Modifies test_ime_driver to not-handle non character events.

BUG=548407

Committed: https://crrev.com/aa4f90ab72b60fd90e048b1e18193c30f0462d77
Review-Url: https://codereview.chromium.org/2230393002
Cr-Original-Commit-Position: refs/heads/master@{#414748}
Cr-Commit-Position: refs/heads/master@{#415646}

Splitting scrollbars into multiple fragmentainers is only problematic in
interactive media. We don't need to impose any such pagination restrictions
when printing, since printing is non-interactive,

BUG=641983

Review-Url: https://codereview.chromium.org/2298193002
Cr-Commit-Position: refs/heads/master@{#415645}

BUG=

Review-Url: https://codereview.chromium.org/2292203004
Cr-Commit-Position: refs/heads/master@{#415644}

Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.

BUG=624462,637017

Review-Url: https://codereview.chromium.org/2253653002
Cr-Commit-Position: refs/heads/master@{#415643}

Migrate the last two features (render widget and settings) from blimp/client/features to blimp/client/core.  This required adding support for BlimpCompositorDependencies throughout blimp/client/core and exposing a CompositorDependencies class in the constructor of BlimpClientContext as well.

BUG=611105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2292723003
Cr-Commit-Position: refs/heads/master@{#415642}