- 28 Dec, 2019 18 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/726986fab08b..f77838c9ed9f git log 726986fab08b..f77838c9ed9f --date=short --first-parent --format='%ad %ae %s' 2019-12-28 hypan@google.com Add reference binaries for android app bundles Created with: gclient setdep -r src/third_party/catapult@f77838c9ed9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986990 Tbr: skyostil@google.com Change-Id: I536a8a085c5cb69acfbcff3cf0e5621c2bda1c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983500Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727670}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I62a36fc558389e61047f263d02477a71a74b70ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982935Reviewed-by:
-
Tarun Bansal authored
Bug: 1037033 Change-Id: I29827fadfdb4fbdfc5e2ca6b252cacc043119d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983351Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727668}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f2dc05978f1d..8ac79125c052 git log f2dc05978f1d..8ac79125c052 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d814fc7e..9986f224 (727531:727633) Created with: gclient setdep -r src/third_party/webrtc@8ac79125c052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I33121717c0b0a3d52be03182e2464f36975e3bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982937Reviewed-by:
-
Peng Huang authored
GLSurface clients expect GLImages used by previous frame can be reused after a new frame is swapped, so the client may start issuing GL commands against the GLImage in the SwapBuffers callback. So GLSurfaceEGLSurfaceControl should set read fence of GLImage first, and then run the SwapBuffers callback. Bug: 1036566 Change-Id: I38b3d14b68bb8dc93fb8a042782faaf9a54cb4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979629Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727666}
-
Andrey Kosyakov authored
This fixes more tests that became flaky due to asynchronous destruction of HeadlessWindowTreeHost (https://crrev.com/c/1977741) TBR=kvitekp@chromium.org, kylechar@chromium.org Bug: 1037652, 1034954, 1036627 Change-Id: I29b2490d9f1f49157dd1207c4b0bae0507b0c405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983540Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727665}
-
Emily Stark authored
(This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1978898, with a different test that relies on a slow HTTP response instead of a long one, to avoid OOMing some trybots.) With HTTP auth committed interstitials enabled, extensions were getting notified of each auth request twice: once when LoginHandler is first called to cancel the auth request and show a blank error page, and again when LoginHandler is called after committing the error page to show a login prompt on top of it. In common operation, the second extension dispatch was a no-op, because the request had been destroyed already by the second entry into LoginHandler. But, there was a race ticked by long response bodies. That is, it was possible that the second onAuthRequired event would be dispatched to an extension before the request was destroyed. The request was destroyed between the second dispatch and the extension's reply. When the extension replied,the WebRequestAPI would simply drop the reply for the now non-existent request, never returning control to LoginHandler so that it can proceed to show the login prompt. The fix is to ensure that auth requests are dispatched to extensions only once, on the first time LoginHandler is called, before the request is cancelled. Bug: 1034468 Change-Id: I735f9c76bce5788c5362d7d04e6f81fdcd9535d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978898Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#727041} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980766 Cr-Commit-Position: refs/heads/master@{#727664}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I685d7e499684c3bc4515a983f6a224dc2690eb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983447Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#727663}
-
Xiaocheng Hu authored
Bug: 1024767 Change-Id: I824e98765b2869ca9d674a17ef3e738ec9a01a1f NoTry: True Tbr: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983501Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/588c373aced1..ab693fffbdba Created with: gclient setdep -r src-internal@ab693fffbdba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I103e376cb84636225f4a6482b228fad5d8447a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983445Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727661}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/263d57d37615..726986fab08b git log 263d57d37615..726986fab08b --date=short --first-parent --format='%ad %ae %s' 2019-12-27 khokhlov@google.com Revert "Reland "[Telemetry] Make proto trace format the default"" 2019-12-27 chonggu@google.com Reland "[Telemetry] Add Fuchsia device support." 2019-12-27 khokhlov@google.com Reland "[Telemetry] Make proto trace format the default" Created with: gclient setdep -r src/third_party/catapult@726986fab08b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014642,chromium:1028612,chromium:1036638 Tbr: skyostil@google.com Change-Id: I6ee9250507587d0d469a492d05abb77b233ad053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983439Reviewed-by:
-
Xiaocheng Hu authored
Bug: 1038128 Change-Id: I2cb8c6575adea53ec8ae0b44949647fec7db8707 NoTry: True Tbr: mek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982938Reviewed-by:
-
Xiaocheng Hu authored
Test is flaky. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/85451 Bug: 1038156 Change-Id: Ice9b10b2acaedcba0ecf3463475d94962af27514 NoTry: True Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982936Reviewed-by:
-
Bailey Berro authored
- This CL delays the rendering of the arrangement section until |displays| is truthy to avoid the arrangement section flashing. Bug: 1022315 Change-Id: I36da215142ed8bafb739dbbdedaf9bfa4f2baf24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979115Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#727657}
-
Brandon Wylie authored
TBR= mlamouri@chromium.org Bug: 1038151 Change-Id: I46a30236c75694c7682cbadedce36c649ad064fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983448Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#727656}
-
Xiaocheng Hu authored
[Sheriff] Disable GooglePasswordManagerNavigationThrottleTestWithPasswordManager.PasswordsWithGPMAndSyncUserClickedLink Bug: 1029034 Change-Id: I4a3729f7435b1002b36d53140b5b3f5d31fec6b0 Tbr: vasilii@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982934Reviewed-by:
-
Andrew Xu authored
Enable the hotseat feature as default. Besides that, this CL does the following things: In annotation_feature_enabled_test.js and zcr_remote_shell_unittests .cc, the current tests assume that the shelf icon's size is 56x56 which is not always true under hotseat. So those tests are fixed by hard code. TBR=tbarzic@chromium.org,oshima@chromium.org tbarzic: chromeos_features.cc oshima: zcr_remote_shell_unittest.cc Bug: 1032702 Change-Id: I3b51893d4724e6f085fea8ca7c0b9b415e6cea4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974861Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727654}
-
Avery Musbach authored
Bug: None Change-Id: Iedec344fda56e80c083b31d968729cfc51b32d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983357Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#727653}
-
- 27 Dec, 2019 22 commits
-
-
Avery Musbach authored
Bug: None Change-Id: If9551bcc5b7d23affb1799adf821efa100df40ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983190Reviewed-by:
-
Avery Musbach authored
OverviewWindowDragController::DragResult values are only ever checked against kSuccessfulDragToSnap. Distinctions among the other values are for readability only. See the code review comment at [1]. So the present CL cleans it up with semantic meaning in mind, and not much concern about functionality. OverviewWindowDragController::CompleteNormalDrag is significantly simplified near the end. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1570218/3/ash/wm/overview/overview_window_drag_controller.h Bug: None Change-Id: I0ae77c4b7d8d4dfa5f01dfbcbd6990c8bd27a60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983349 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6a291685941..588c373aced1 Created with: gclient setdep -r src-internal@588c373aced1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1036426 Tbr: jbudorick@google.com Change-Id: I4708c5b71bcef8b32b9fe1b5c1b8f676999920b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982929Reviewed-by:
-
Tricia Crichton authored
When Timeout occurs running a command, return status 500 to client instead of 408. This cl restores compliance to the WebDriver spec. Bug: chromedriver:3291 Change-Id: Id48d08cace4dc6faf36270e130b859b179faa326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983340Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#727649}
-
Xiaocheng Hu authored
Test is flaky: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36522 Bug: 997786 Change-Id: I97f2e400e829b13859033767a257402325646cf3 NoTry: True Tbr: treib@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983441Reviewed-by:
-
John Abd-El-Malek authored
This allows production code to get to ProfileImpl from a BrowserContext, and tests to interact with it directly in future cls. Change-Id: I5f3c9899a661a3b05c67e1287467b3dbabf7f75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983255Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727647}
-
Tarun Bansal authored
These are no longer needed. Bug: 1037176,1037172 Change-Id: I894a8ae7a0e8a467ac1786f934daef58bc1dcc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983348 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#727646}
-
Christopher Cameron authored
The logic to add FocusManager observers was smeared across NativeWidgetMac and NativeWidgetMacNSWindowHost. Change this so that all of the logic is in NativeWidgetMac::SetFocusManager. In the process, cut-and-paste a handful of functionality over to NativeWidgetMac. This is part of the larger trend of merging NativeWidgetMac and NativeWidgetMacNSWindowHost (preserving the latter perhaps, only as mojo-implementing friend). The motivation for this is that, when reparenting a non-top-level NativeWidgetMac, we do not move the FocusManager observers, which causes ConstrainedWindowViewTest.TabMoveTest to crash. This patch should have no functional change. The next patch in the sequence will update the observers as needed. Bug: 957362 Change-Id: Id5a1d6183e446df647fa877239cb9dfb549e18a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983343Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#727645}
-
Caleb Rouleau authored
Handles post submission cl comment from https://chromium-review.googlesource.com/c/chromium/src/+/1982681/5 Bug: 921353 Change-Id: If536f622a2a1d8824e1d942fccf4abc02d808a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983346 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Flakes observed at https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/43474 Bug: 1038139 Change-Id: I7c5ac70294f3a438d31c069c61689cc7ad185b7d Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982932Reviewed-by:
-
Xiaocheng Hu authored
Flaky timeouts observed: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/85649 https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/457958 https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/457440 Bug: 1030551 Change-Id: I9bb0b3ba503965256a7f4225c0468eb470e78246 NoTry: True Tbr: tommycli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982931Reviewed-by:
-
haozhe authored
Both Chrome and Firefox pass all tests Bug: 1034538 Change-Id: I9f92d6b91fafacfc12e81a7bc5941a6e8e0e4868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974755 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727641}
-
Nicolás Peña Moreno authored
Currently, the test contains two async_tests, which is not good because they run in parallel so the tests can affect each other. The first test is redundant with buffer-layout-shift.html. The second test uses a helper function from EventTiming, so we import the script instead of copy-paste and we rename the test. Change-Id: Ibe6d200441a07c603bccf0858406cf2c4f1d37a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982710Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#727640}
-
Nicolás Peña Moreno authored
In this CL, some 'await waitForAnimationFrames(2)' are added to wait for the initial render of the test page before introducing the observer. This removes flakiness of these tests in WPT.fyi. Other cleanups are done in the test files. Bug: 1036013 Change-Id: Ic2631faf03ad00c8e32013c100c3b4ab867be2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982708Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81158535ed1b..5e976be7f0ca git log 81158535ed1b..5e976be7f0ca --date=short --first-parent --format='%ad %ae %s' 2019-12-27 brianosman@google.com Workaround MSVC 2019 code-gen bug in lighting image filter Created with: gclient setdep -r src/third_party/skia@5e976be7f0ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I4f4f6259a4f8171f7cef83998640755f5d56de43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982922Reviewed-by:
-
Pavel Yatsuk authored
This CL moves SnackbarView.java, Snackbar.java, SnackbarCollection.java, SnackbarManager.java. Tests will be moved in a separate CL. BUG=1028382 R=mdjones@chromium.org Change-Id: I847ce100b03fb3b4596ed02c2c32d2f8505ba4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974902 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#727637}
-
Brandon Wylie authored
TBR=cduvall@chromium.org Bug: 1035894 Change-Id: Ie212a40b4aa33390734e3871e68ab03d84cd1db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983347Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aca963f8ae30..a6a291685941 Created with: gclient setdep -r src-internal@a6a291685941 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I19a4ea780c96ec5d04689f5819692b26c4c30023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982921Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.86-1577097374-benchmark-81.0.4005.0-r1 to 81-3945.86-1577097374-benchmark-81.0.4008.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2685c0afde88d8a2a7da564a8e60b7a2792d1372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982927Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.0-1577100150-benchmark-81.0.4005.0-r1 to 81-3987.0-1577100150-benchmark-81.0.4008.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibdecb9a788de4aca4975fba7240c1fa1f398c778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982926Reviewed-by:
-
Matt Reynolds authored
A prior CL switched HidService::ConnectCallback from RepeatingCallback to OnceCallback, but did not correctly adapt the callbacks passed to PermissionBrokerClient::OpenPath on Chrome OS. OpenPath takes separate success and error callbacks, but both paths should ultimately call the same ConnectCallback. This CL uses base::AdaptCallbackForRepeating to convert the ConnectCallback to a copyable callback that can be bound to both the success and error callbacks. BUG=1036761 Change-Id: I5b39fd0df496e7a614d6a5be688d78653eb9f46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982860 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#727632}
-
Xiaocheng Hu authored
Tests disabled due to flaky failures at https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36521 Bug: 990362 Change-Id: I8a75c46e1868152216fe3cd34a579805fca871f1 NoTry: True Tbr: antrim@chromium.org, rsorokin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982923Reviewed-by:
-
