- 16 Jul, 2020 40 commits
-
-
Gang Wu authored
This reverts commit 5ae112d1. Reason for revert: still flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_apk%20(with%20patch)&tests=org.chromium.chrome.browser.omnibox.suggestions.SwitchToTabTest%23testSwitchToTabInSearchActivity Original change's description: > Reland "[Omnibox] Use ActivityState to check if we are in browser mode" > > This is a reland of be1e9636 > > Update the test to run on UI thread. > > Original change's description: > > [Omnibox] Use ActivityState to check if we are in browser mode > > > > > > In multi windows mode, check if we are in browser mode by WindowAndroid > > is not working, should check ActivityState instead. > > > > Bug: 1102640 > > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#786636} > > Bug: 1102640 > Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788816} TBR=tedchoc@chromium.org,gangwu@chromium.org Change-Id: Ie40eb459891875511457c2f0ddf86a8452db396e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301283Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788916}
-
Yoshisato Yanagisawa authored
For ease of enabling LUCI task service account to be used for accessing Goma backend, let me add gom_use_luci_auth property. Let me try to use that in Goma ToT builders to confirm it works. Bug: 1105814 Change-Id: I64451c11b8cec87b7a8390e66845801eceaa2448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299464Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#788915}
-
Peter Kasting authored
This adds a helper, UpdateLabels(), to set all labels' visibility, text, and style based on the current mode; this replaces the scattered pieces throughout other functions. The file name label's style changes based not on the mode but on the enabled state of the whole view; update that in the functions that set the view's enabled state. The above two changes mean that UpdateColorsFromTheme() now only deals with colors, and thus no longer need be called outside OnThemeChanged(). Renames |dangerous_download_label_| to the more accurate (and shorter!) |warning_label_|. For some reason UpdateMode() was also sometimes setting the file name label's Y coordinate. This is done in layout, and there's no reason to do it here. Bug: none Change-Id: Ib7b9b77cc8ba11af609d9e25328f9207da66f6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299141 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788914}
-
Karandeep Bhatia authored
This will ensure that finding the generated schemas is a log(num_schemas) * |number_of_api_providers| operation. We can then also remove the caching in ExtensionAPI, which should save memory for renderers. Note that since for the browser process, GetSchema is never called, ExtensionAPI::IsKnownAPI was a linear (in the number of schemas) operation (since |schemas_| is always empty). Now it'd be more efficient. This depends on the fact that our code generating logic generates schemas in sorted order. Add a static assert to ensure that it holds. Since std::is_sorted is not constexpr until c++20, modify base::STLIsSorted to be constexpr (at least for arrays which have constexpr std::begin and std::end since c++14). Example generated code: https://paste.googleplex.com/6322126191591424. BUG=None Change-Id: Ib463c7f8ca5f317ecf6900dc811fa902c72e92d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291265 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788913}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594771186-8c7f3834398f8caaba6f32c369440926161c5207.profdata to chrome-win64-master-1594814211-6e9c837aecb05743d0a6513baf4c13c15785a909.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I991e8e5791cf7dad743ef7d58958c3353f7ffd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788912}
-
Jason Lin authored
This CL updates the illustration used in the Plugin VM installer to the new asset. Bug: b:158009852 Change-Id: I3edcc1ce4e920c97a9ab3876f1bf9e7ae4fae66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263416Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#788911}
-
Peter Wen authored
Replaced chrome/* with chrome/browser/* in the direct deps allowlist. Will deal with chrome/browser/* directory in a later CL. Added exception for bundle_module headers since although they need to depend on their base_module_target's header directly, due to naming, it is not as easy to undo the special casing that currently exists for these targets (see the rules.gni comment about the "special group"). Almost 1 second faster for turbine headers, and given most of this CL is for test targets, probably a good ROI. Before: $ tools/android/build_speed/benchmark.py turbine_headers Summary gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.5s turbine_headers: 43.6s avg (43.5s, 43.7s) After: $ tools/android/build_speed/benchmark.py turbine_headers Summary gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.5s turbine_headers: 42.8s avg (42.8s, 42.8s) Bug: 1092528 Change-Id: I088b996e738248bd08650e453d904208128680f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300802Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788910}
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: Ibb9f902cfeff79013e542591a56c81b007bed015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291821 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Emily Stark authored
Textfield::OnBoundsChanged refits the RenderText's display rect to the local bounds. This undoes any simplified domain elisions that have already been applied. This can happen e.g. when a security chip or other omnibox decoration appears. In this CL, we override Textfield::OnBoundsChanged() to reapply any simplified domain elisions that have previously been applied. If an animation was in-progress when OnBoundsChanged() runs, we cancel the animation and abruptly transition to the end state. This might look a little odd, but it should be quite rare. Bug: 1102944 Change-Id: Ide5e4a890a5de0e0f092c545dd563106bee9825e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292456 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#788908}
-
Kyle Horimoto authored
The wrong browsePreload URL was added, so this CL fixes it. Bug: 1106173 Change-Id: I66ffd98d2dd6abc70ffb4c5f6921d6757ebb2531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301123 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#788907}
-
Adam Langley authored
This change contains all non-Blink parts of supporting the WebAuthn PRF extension: https://w3c.github.io/webauthn/#prf-extension Change-Id: I02fe58251ad6f4ca0ed3eb5aebbf08517903fd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293012 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#788906}
-
Noel Gordon authored
multi_menu.js and multi_menu_button.js need CSS stylistic variation in files-ng to account for the action bar tap-target gap. Current files-app uses CSS to do provide gap after CL:2298847, however that caused #tasks-menu to move too far down when used as a submenu. Add common util dep so we can switch on files-ng and change the margin top, depending on whether we are showing a submenu or not. Bug: 1066727 Change-Id: Iaa8fe321f6b1f55c619ab212c5812f2108d4d0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299672Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788905}
-
Nathan Zabriskie authored
Right now shared images make assumptions about the surface origin and alpha type of each image. This CL is a no op but follow up CLs will handle the piping on the service side and actually use it when creating shared images. Bug: 1034086 Change-Id: I7b16cc9f986bca71b245aaaff92337c2e92ac75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280228Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I20f0af471da9928006b1b0e699fc5bfd832f74c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301182Reviewed-by:
-
Andrew Grieve authored
Bug: 1041930 Change-Id: Ie22490b7e1f6ec3e6ef49ddbf9af2f028021f6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298939Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788902}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed9e5acd61d7..5fcb48536cce 2020-07-15 ehmaldonado@chromium.org Roll git to 2.27.0 on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1070694 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7941d3cffca204c6635f76a94291d0bd36c6ebad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301090Reviewed-by:
-
Kevin McNee authored
The logic for ignoring renderer initiated navigations without a user gesture is duplicated for renderer initiated back/forward. We now call |Navigator::ShouldIgnoreIncomingRendererRequest| which has this logic. Bug: None Change-Id: Id31f151d6220e1101e20f7bced0d9bd227ebf789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281108 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#788900}
-
Lijin Shen authored
Remove expired histograms: 1. BookmarkManager.NumDraggedInSession 2. BookmarkManager.NumReorderButtonInSession Bug: 1052939 Change-Id: I929b8140d89b9e351ab8c2069e416d2b0d0d3279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298722Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#788899}
-
Jinsuk Kim authored
This CL fixes a bug in FullscreenManager that handles a pending fullscreen operation getting active when the tab becomes user-interactive. Also added a test that passes when the patch is applied. Bug: 510282 Change-Id: Id328cc3bd1421de51503bc30a6b4dc5bd91a2c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298784 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Thanh Nguyen authored
Bug: 1105896 Change-Id: I426f48b4d15b767f4eed2f0a5433efcde7d7bb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299822 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788897}
-
Andrew Grieve authored
Bug: 1041930 Change-Id: I66b375158ba361cc14b791ee3a1542df2c3abf4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297987 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#788896}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ddc86ef759d8..c63cdce64c9e 2020-07-15 aninditaghosh@google.com Add query function to Python API for trace processor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0375a59ac5d1dd3795839f8bc70fc5cba277bcc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300866Reviewed-by:
-
My Nguyen authored
Bug: 1102561 Change-Id: I35e34c25cce707d801d2cbd706273ba172939d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283027 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#788894}
-
David Van Cleve authored
http://crrev.com/c/2270354 added a comment to net::HttpRequestHeaders::SetHeader explaining that the caller needs to guarantee that both arguments satisfy validity preconditions. This change copies the comment to SetHeaderIfMissing, which enforces the same preconditions. R=mmenke Bug: 1105745 Change-Id: I11c2c9e8329c349b3cd77c3dd673fc96ea34612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300603 Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#788893}
-
Tao Bai authored
Previously, the FocusNoLongerOnForm() was called after FormControlElementClicked() when focus was moved form a form to another, this made browser consider the focus is no longer on the new focused form, therefore, cancel the autofill. This wasn't an observable issue for Chrome because the autofill can still be triggered again by the following event, but caused WebView/WebLayer autofill be cancelled until the user touch the field again. This patch change the sequence, so the FocusNoLongerOnForm is always called before the FormControlElementClicked(). Also, changed tests which expected the extra focus change event. Bug: 1105254 Change-Id: I9f9e0da323631c91a6797d15138daa80a47f9aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296487Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#788892}
-
Tsuyoshi Horo authored
When there is a mismatch between the 'header-integrity' value of 'allowed-alt-sxg' link header of the cached main resource and the header integrity value of the cached subresource, Chrome will send a NEL report with "sxg.header_integrity_mismatch" type when navigating to the main resource if NEL reporting was setup. Bug: 1025074 Change-Id: I7c0ae0904a211e11b72bae95cfe2274eb9c5550a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237212Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#788891}
-
Andrew Grieve authored
Bug: 1041930 Change-Id: If407bc3418dbf0759d248baa7cdd7d4a3b6844a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297704 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788890}
-
Ryo Hashimoto authored
BUG=952745 TEST=build Change-Id: Iff885096cd09575837b21c71686e740490da83bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299682Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#788889}
-
Hidehiko Abe authored
In base::Process::WaitForExitWithTimeout, it is checked whether base sync primitives is allowed. Send to the thread with the trait. Bug: 1103798 Test: Ran locally, and no DCHECK error on lacros-chrome termination. Change-Id: Ie1d15d1ee949a6f7c06726ccb14c90b38fea96ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299947Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#788888}
-
Xianzhu Wang authored
It enables all blink runtime features with status:"test" or status:"experimental" defined in third_party/blink/renderer/platform/runtime_enabled_features.json5. For more information, https://groups.google.com/a/chromium.org/g/blink-dev/c/_COjLyfAEO0/m/1kC0sNuMAgAJ Change-Id: I5ec469d7f8b6cac3e793947e649cbb9f384158e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300832Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ifbede59a6fc5f0f5f81224b296458d0f4aa60886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300935Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788886}
-
Martin Kreichgauer authored
This allows us to get rid of base::Timer injection into AuthenticatorCommon, which tests used to wait for requests to time out. Also get remove a number of superfluous RunUntilIdle() calls, and of calls to OverrideLastCommittedOrigin() where SimulateNavigation() would suffice. Change-Id: I8cb4980d51efe43f59d828cde5f34ce67d38d928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299630 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#788885}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9549e829b5..d6108deaa5b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com,kristipark@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091004 Tbr: kinuko@google.com,kristipark@google.com Change-Id: I2b5be6d66179849b71330339ebaa1b5698bfe5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301080Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788884}
-
Charlene Yan authored
Translation instructions from http://g.co/chrome/translation which suggested screenshots even if the text is not rendered. Bug: 1018230 Change-Id: If9600a1583fdd2796d3516f9047c89e4d3ee1f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298522 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#788883}
-
Bartek Nowierski authored
This is a continuation of crrev.com/c/2291304, which renamed the class, but missed a few string references. Bug: 2291304 Change-Id: Iffa16cde342ad84b2ed77b9ca7c032d9b4c04115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299821 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Carlos IL authored
This CL addresses a leftover review comment from crrev.com/c/2292868 Bug: 1093103 Change-Id: I8012c60f9a23108763e7da362a551e3c77e6d7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300090 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#788881}
-
Peter Kotwicz authored
This CL: - Re-enables the 'AndroidNullableCheck' and 'NoRedundantFieldInitCheck' errorprone compiler plugins - Switches javax.annotation.Nullable imports to androidx.annotation.Nullable - Removes redundant member variable initializations BUG=1104558 TEST=errorprone_plugin:tests Change-Id: Id6196c7d89795fab490b7931f079f0cd03bbe71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291984 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#788880}
-
Tomasz Wiszkowski authored
Change-Id: I8c25d4aa54853d67017d04e9e03c0cf955902a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301179 Commit-Queue: Ender <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Ender <ender@google.com> Reviewed-by:
-
Evan Stade authored
A couple of notification related prefs are moved to //components/content_settings. Their registration remains in //chrome since other embedders don't use them yet. Bug: 1071603 Change-Id: Ic43ea701619c3764db899b4965db6e414638f016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288310 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
David Munro authored
Bug: chromium:1105298 Test: manual Change-Id: I521b8a28b75a1419848417885bfcc5e710413657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297070 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#788877}
-
