- 25 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ff7d06ba71fd..cfa4b4a65a57 git log ff7d06ba71fd..cfa4b4a65a57 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 eseckler@google.com Merge "processor: Handle chrome traces with clock_id but no ClockSnapshot" Created with: gclient setdep -r src/third_party/perfetto@cfa4b4a65a57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0074a4fa9fa48bf8ee7f607847c641dfd6db3846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709419}
-
Mario Sanchez Prada authored
Convert the remaining bits related to the viz::mojom::CopyOutputResultSender and viz::mojom::TextureReleaser interfaces to the new mojo types. Bug: 955171 Change-Id: Id1fd4e81e9c4708516ef03a9ec69d6b272a1fde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872065 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#709418}
-
Robbie McElrath authored
This metric records the number of consecutive times the WebView browser process starts with a stale seed. It's written when a fresh seed is loaded after previously loading a stale seed. Test: Manually verified with logging that the metric was written. Bug: 1010625 Change-Id: Iadedb45af08d59ecd6662472670f848e8e99a8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851126 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709417}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients for the viz::mojom::VideoDetectorObserver interface to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: Icb678b4070bc69045f901e4454565cd121fa8564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875262 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#709416}
-
Yuzu Saijo authored
This CL enables ServiceWorkerOnUI on BackForwardCache related trybots because BackForwardCache will be dependent on ServiceWorkerOnUI feature after the CL below: https://chromium-review.googlesource.com/c/chromium/src/+/1782247 Change-Id: I29f9a6c8d9abbc193f2236bd2e9a963e70df7407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863057Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#709415}
-
Wei Lee authored
This CL returns the window url when the window is created so that tests could distinguish between regular instance and intent handling instance. This CL is needed for adding corresponding tests in tast.camera.CCAUIIntent: https://crrev.com/c/1858065 Bug: b/139650048 Test: tast run [DUT] camera.CCAUIIntent Change-Id: I7eb0d06932bd1cddf6709f291897659dda0c5769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859420 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#709414}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/28fc8a61d004..57b9fe40c414 git log 28fc8a61d004..57b9fe40c414 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@57b9fe40c414 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7cc1bb0c9c8d8045267d874495fd4a3a5fee6e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880660Reviewed-by:
-
Armando Miraglia authored
After the launch on all platforms of the audio service, this code path is unused hence the associated metrics is not needed any longer. BUG=906934 Change-Id: I4e6527116a291fcbf681abd72ed81c73d17ccabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878768Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#709412}
-
Jose Dapena Paz authored
Add #include <vector> for using std::vector. This fixes GCC build. ./../chrome/browser/apps/launch_service/launch_manager.h:46:15: error: ‘vector’ in namespace ‘std’ does not name a template type static std::vector<base::FilePath> GetLaunchFilesFromCommandLine( ^~~~~~ Bug: 819294 Change-Id: I02ec3a2914a8fbe3aa0041017a0228f4b0ca1ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879289Reviewed-by:Alexey Baskakov <loyso@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#709411}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::GetTextBoxInfo()| to use |NGInlineCursor| to reduce usage of |NGPaintFragment| for preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: Ib37fae0241efaca73184710cc0af3050a041bde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880890 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709410}
-
Juan Antonio Navarro Perez authored
Flaky crashes in prediction_metrics_handler.cc NOTRY=true TBR=crouleau@chromium.org Bug: 1017661 Change-Id: I5a17d19a19231bbc2d5b36a7d20d12bd5c639ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879232Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#709409}
-
arthursonzogni authored
1) The test has been fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1816509 The fix was to flush the BackForwardCache to avoid the FrameHostInterceptor to miss "simulating RenderFrameHostCreated" on the RenderFrameHost in the BackForwardCache. 2) Flushing the cache became asynchronous, which caused the test to fail again. https://chromium-review.googlesource.com/c/chromium/src/+/1807321 In this CL, instead of flushing the BackForwardCache, we create the FrameHostInterceptor before the navigations. That way, it can correctly index every created RenderFrameHost. It won't have to simulate receiving RenderFrameHostCreated anymore. Bug: 1017605 Change-Id: I882d459e53a84331f4ec8dfaa4df1b07cc160c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878187Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709408}
-
Steve Becker authored
Updates postMessage() to clone FileSystemFileHandle and FileSystemDirectoryHandle objects for same origin targets. Including a FileSystemHandle object with a cross origin message fails by dispatching a 'messageerror' event instead of 'message' event. The change consists of four parts: (1) Updates V8ScriptValueSerializerForModules to serialize FileSystemFileHandle and FileSystemDirectoryHandle into blink::SerializedScriptValue, by following these steps: * Write a tag for the handle type (file or directory). * Write the name of the file or directory. * Creates a mojom::blink::NativeFileSystemTransferTokenPtr by calling blink:NativeFileSystemHandle::Transfer(). This token informs the storage::NativeFileSystemManagerImpl that a transfer is in progress. The NativeFileSystemManagerImpl creates a NativeFileSystemTransferTokenImpl to store the information required to clone the handle. * Stores the token in blink::SerializedScriptValue::native_file_system_tokens_. This array tracks all cloned FileSystemFileHandle. The blink::mojom::CloneableMessage struct is also updated to hold this array for MessagePort and BroadcastChannels. * Write the index of the token in the native_file_system_tokens_ array. (2) Updates V8ScriptValueDeserializerForModules to deserialize FileSystemFileHandle objects when creating clones for the message targets. This is the inverse of (1). Deserializing uses mojom::blink::NativeFileSystemManager to redeem the token, which creates the mojom::blink::NativeFileSystemFileHandlePtr or mojom::blink::NativeFileSystemDirectoryHandlePtr using the info stored by NativeFileSystemTransferTokenImpl. (3) Updates content::NativeFileSystemManagerImpl to support token transfers. To redeem a token, NativeFileSystemManagerImpl receives a mojo message that includes the token as well as a request for a handle interface like mojom::blink::NativeFileSystemFileHandlePtr. NativeFileSystemManagerImpl finds the token and then binds the request. Token redemption does not return any results. Token redemption should never fail, unless a render process is misbehaving. NativeFileSystemManagerImpl performs a few sanity checks before binding the mojo request, including a token existence check, a handle type check and an origin check. If any of the sanity checks fail, NativeFileSystemManagerImpl silently fails closing the redeemed FileHandle's pipe. (4) Adds a cross origin check to window and message port messaging. Most message targets, like dedicated workers, are same origin only. However, both windows and message port messages can go cross origin. When a cross origin message includes a FileSystemHandle, the message must fail with a 'messageerror' event to prevent cross origin access to the FileSystemHandle. Messaging between windows already included origin information before this change. This change adds a NativeFileSystem origin check before dispatching a message event to a window. The message event is replaced with a message error when a cross origin NativeFileSystem object exists in the message data. For message ports, no sender origin information existed before this change. This change updates the CloneableMessage structs to include a 'sender_origin' url::Origin property. Message ports use this property to perform the same cross origin NativeFileSystem check as the window. The NativeFileSystemManagerImpl performs an additional origin check before binding the FileSystemHandle mojo request. The NativeFileSystemManagerImpl cannot trust the postMessage() origin check performed in the render process. Bug: 955192 Change-Id: Ieeb76bd8102067d70c5d7719622ecd4930c3a88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791942 Commit-Queue: Steve Becker <stevebe@microsoft.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#709407}
-
Yi Su authored
This reverts commit 4fcce6d7. Reason for revert: SCBadgeTestCase.testBadgesVisible is failing consistently after this CL: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/5469 Original change's description: > [ios] Fix BadgeViewController interpretation of badgeState > > Since BadgeState is a mask, a direct equality comparison to > BadgeState values for the BadgeItem properties is not the correct > way to assess if a badge is accepted. > > To add testing support for this case, accepted a11y identifiers > for BadgeButtons are created, and they will be properly set > in setAccepted: in BadgeButton. > > Bug: 976901, 1016793 > Change-Id: Id17eb82e0764fbbf80b871df0b974fe148c2339f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872938 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709037} TBR=pkl@chromium.org,sczs@chromium.org,thegreenfrog@chromium.org Change-Id: I7cc7f67cbb24a962388c2079a71e9e168c32fdfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976901, 1016793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880029Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709406}
-
Oriol Brufau authored
In the other reftests the width of the marker text is not known, so the references have to rely on some tricks with the ::before pseudo-element. This patch adds a test that uses the Ahem font, so that the width of the characters is known. Then the result can be checked with a simpler reference file. Note it fails in LayoutNG due to the lack of scrollbar (bug 1012294), but it passes in legacy. Bug: 687946 Change-Id: I7fd0856e93d4e489af65b5c767ec81c109804c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879067 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#709405}
-
Jose Dapena Paz authored
GCC build fixes because of missing include of <memory>: ../../chrome/browser/ui/views/bubble_menu_item_factory.h:20:6: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<views::LabelButton> CreateBubbleMenuItem( Bug: 819294 Change-Id: I1c48566175e313e964e4a474daa444eb4fccf3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879229 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#709404}
-
Mikel Astiz authored
Trivially moves all helper functions and classes to the existing bookmarks_helper namespace. Bug: None Change-Id: I9947b8437bc28e84de0b905a3e1bd4e9ef3292af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879912 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#709403}
-
Markus Heintz authored
This reverts commit b3a546fe. Reason for revert: On Win and Linux rel builder and others: ninja explain: output gen/third_party/blink/renderer/bindings/core/v8/v8_example.cc doesn't exist https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898644624214693520/+/steps/compile_confirm_no-op/0/stdout Original change's description: > bind-gen: Support generation of function definitions. > > This is just a first step to support the code generation > of bindings callback functions. > > Introduces CodeGenerationContext for convenience, and > also demonstrates make_common_local_vars(). > > Bug: 839389 > Change-Id: I9ff49b4bfc6bd98e6b29687cc01f986c2baa01fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855325 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709389} TBR=peria@chromium.org,yukishiino@chromium.org Change-Id: I99f572736c546f5f7078c6653d963264e6622512 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879933Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709402}
-
Yutaka Hirano authored
This is a reland of 93e10d47. The original change was reverted due to a clusterfuzz report, but this CL seems innocent so I'm relanding this. Original change's description: > Introduce QuicTransport > > This is the first CL to implement QuicTransport. This CL > - creates a directory in blink, > - introduces a new blink runtime feature flag, and > - defines QuicTransport IDL interface behind the flag, > > Bug: 1011392 > Change-Id: Id432cee2b6d5df6ab4a4c3e8aa6828d5a7937dd9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868569 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707303} TBR=kinuko@chromium.org,ricea@chromium.org,yhirano@chromium.org,tkent@chromium.org Bug: 1011392, 1016436 Change-Id: Iad9e785cd5886c7b2d2e25fe55f3b5f327727f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880502 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#709401}
-
Richard Knoll authored
This collects metrics for the length of phone numbers and the number of digits in them. These are collected when shown to the user and when the user actually selects a device to send that number to a device. We also distinguish between the entry points of right and left click on links and text selections. The new metric name is built like this: Sharing.ClickToCallPhoneNumber{Length,Digits}. {LeftClickLink,RightClickLink,RightClickSelection}. {Sending,Showing} Bug: 1001033 Change-Id: I59ed705170153b8adcbe00021cedb5118f1cf27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878198Reviewed-by:David Jacobo <djacobo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709400}
-
Richard Knoll authored
This replaces the png versions with vector images. In a local debug build this saves about 15kb. Both vector images have the same content except their colors. This could potentially be further optimized using alpha blending so we only need the image once and it blends onto the background. Bug: 1013099,999976 Change-Id: Ic56b40c87dc5011a9babba787a3545b42df5d459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863025Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709399}
-
Jose Dapena Paz authored
GCC build fix as build fails with this: ../../base/profiler/register_context.h:31:1: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’? uintptr_t& AsUintPtr(T* value) { ^~~~~~~~~ intptr_t ../../base/profiler/register_context.h:110:3: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’? uintptr_t stack_pointer; ^~~~~~~~~ intptr_t ../../base/profiler/register_context.h:111:3: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’? uintptr_t frame_pointer; ^~~~~~~~~ intptr_t ../../base/profiler/register_context.h:112:3: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’? uintptr_t instruction_pointer; ^~~~~~~~~ intptr_t ../../base/profiler/register_context.h:115:8: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’? inline uintptr_t& RegisterContextStackPointer(RegisterContext* context) { ^~~~~~~~~ intptr_t ../../base/profiler/register_context.h:119:8: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’? inline uintptr_t& RegisterContextFramePointer(RegisterContext* context) { ^~~~~~~~~ intptr_t ../../base/profiler/register_context.h:123:8: error: ‘uintptr_t’ does not name a type; did you mean ‘intptr_t’? inline uintptr_t& RegisterContextInstructionPointer(RegisterContext* context) { ^~~~~~~~~ intptr_t Bug: 819294 Change-Id: I49567b00a6f021686c52053a22fb9c502c84f1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879908Reviewed-by:Mike Wittman <wittman@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#709398}
-
Takashi Toyoshima authored
Until today, 105 CLs were submitted, and 40 CLs were reviewed by me for platform/loader and OOR-CORS projects. Change-Id: Ia3051e06bc7d1e2604c3ee190a308e7d9ff5a5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880496Reviewed-by:
-
Hirokazu Honda authored
ScopedVAImage release()s the unique_ptr of ScopedVABufferMapping on destruction. However, release() doesn't execute ScopedVABufferMapping()'s dtor because it just passes someone the ownership. We should call reset other than release. Bug: 1018085 Test: camera.*JPEG Change-Id: Ifc4b2133b33b2c7b0f08c899cb714881f9ffbaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880891 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#709396}
-
Roman Sorokin authored
according to specs Bug: 1017117, 1017173 Change-Id: I1301d9fe730ba63234367f812175d02cc0def1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876349 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#709395}
-
Chih-Yu Huang authored
Currently only ChromeOS platform uses VideoFrameConverter. This CL moves the related files to //media/gpu/chromeos. BUG=chromium:1012587 TEST=gn check on kevin and eve TEST=ninja chrome on kevin and eve TEST=ninja media_unittests Change-Id: I73334bec4b9eee812c3b4c88f3a0230b5a003cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877493 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Shuo-Peng Liao <deanliao@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#709394}
-
James Cook authored
In particular, it doesn't depend on the mojo preferences service, so eliminate those includes. Forward declare a couple things in pref_service_syncable.h as well. Bug: none Test: compiles Change-Id: If7d70388fb5903fb932bd4928a993d1a80cea55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879568 Commit-Queue: Tim Schumann <tschumann@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#709393}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad5be17f5599..24a409611f24 git log ad5be17f5599..24a409611f24 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b2885bc4a40f..77fba58c9658 (16 commits) Created with: gclient setdep -r src/third_party/skia@24a409611f24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:None Change-Id: Icf604895d9dda00fa5ff0a9a2f871fbffc53c4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880867Reviewed-by:
-
Kenichi Ishibashi authored
Add two tests (localhost and 127.0.0.1) for module service workers. Bug: 954853 Change-Id: Ic530766c58807491e10c6de8b53cd047299891ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880500 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#709391}
-
Oriol Brufau authored
Parse ::marker as a valid pseudo-element, behind an experimental flag. The actual logic of ::marker will be implemented in follow-up patches. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8v7pouXxxAc Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo Bug: 457718 TEST=external/wpt/css/css-pseudo/parsing/tree-abiding-pseudo-elements.html TEST=external/wpt/css/css-scoping/slotted-parsing.html Change-Id: Ia4014afdbf5d0f2a642f349641140b03dfceee22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876407 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#709390}
-
Yuki Shiino authored
This is just a first step to support the code generation of bindings callback functions. Introduces CodeGenerationContext for convenience, and also demonstrates make_common_local_vars(). Bug: 839389 Change-Id: I9ff49b4bfc6bd98e6b29687cc01f986c2baa01fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855325Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709389}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/93afefce3091..e4822cdce35a Created with: gclient setdep -r src-internal@e4822cdce35a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iea8da03e8839c65761b131a6c00674a74c4fe2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880696Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709388}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/910988b619..33455d1c48 TBR=bmeurer@chromium.org Change-Id: Ibec0f9bf8069e58efaf0077e90686045def2d449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879251Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709387}
-
Roman Sorokin authored
Fixed: 1009510, 1009509, 1009511 Change-Id: I1697126d12d3822d19778c4930317118be76356a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878196Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709386}
-
Fergal Daly authored
DownloadRequestLimiterTest.HistoryBack DownloadRequestLimiterTest.HistoryForwardBack SafeBrowsingBlockingPageTest.NavigatingBackAndForth SafeBrowsingBlockingPageTest.PageWithMalwareResourceDontProceed SafeBrowsingBlockingPageTest.PageWithMultipleMalwareResourceDontProceed SafeBrowsingBlockingPageTest.PageWithMultipleMalwareResourceProceedThenDontProceed TaskTabHelperUnitTest.TestTaskIdBackButton Bug: 1015328 Change-Id: Ie1f0655f871496ba697ed8653be197103073450c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880499Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709385}
-
Kenichi Ishibashi authored
The previous version of this test had some issues and were the source of flakiness: * It used non-secure contexts and register() seemed not working. * It used a mock object for service_worker_unregister_and_register() and the mock object silently consumed rejections of register(). * It didn't wait for iframe loading completion. * It didn't clean up iframes. * It didn't handle error cases correctly and the test passed in an unexpected way. This CL rewrites the test to fix above issues: * Use secure contexts. * Use existing test helpers which provide better error handlings. As a consequence we stop using addressspace-test.js in the test but I think the new test is easier to read and understand. This CL should de-flake the test. Bug: 988074 Change-Id: I3d16c61742d819c08cadcff20a017b7336508efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877876 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie54fb81c1bfe0c9df8fad8e58c2f1b63183c8ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880693Reviewed-by:
-
Takashi Toyoshima authored
Current document does not explain an 'extraHeaders' use case to deceive the CORB inspection. This patch updates to explain this, starting from m72. Bug: 933893 Change-Id: I465a548de0450243d599937c20f442fa2a941017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878268 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#709382}
-
jchen10 authored
A workaround for vector-dynamic-indexing-swizzled-lvalue.html. Bug: 709351 Change-Id: I544583b26055a8ff2d62e81fcf06bbde769aa886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877817 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709381}
-
Meredith Lane authored
Please see attached bug. Appears to have been flaky for awhile. TBR=markusheintz Bug: 1018064 Change-Id: I350719fbc26fee88ae2f6cb9a1f6820fcaace6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880497Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709380}
-
