GitLab

Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001 of https://codereview.chromium.org/588493002/)

Reason for revert:
Linux Tests mojo_python_bindings_tests failure
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712

======================================================================
ERROR: testDefaultsTestSerializationDeserialization (bindings_serialization_deserialization_unittest.SerializationDeserializationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py", line 125, in testDefaultsTestSerializationDeserialization
    v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles)
  File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py", line 113, in Deserialize
    serialization_object.Deserialize(fields, data, handles)
  File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py", line 82, in Deserialize
    (_, version) = HEADER_STRUCT.unpack_from(data)
TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray

Original issue's description:
> mojo: Add deserialization to python structs.
>
> This is a reland of https://codereview.chromium.org/578263003 using
> buffer instead of memoryview, because on some early version of python
> 2.7, memoryview cannot be used with struct.unpack_from.
>
> BUG=415491
> R=sdefresne@chromium.org,cmasone@chromium.org
>
> Committed: https://crrev.com/37dd5f484593b1c8b92b825a9648edf7fb6944e6
> Cr-Commit-Position: refs/heads/master@{#295684}

TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415491

Review URL: https://codereview.chromium.org/584003002

Cr-Commit-Position: refs/heads/master@{#295689}

Revert of mojo: fix python unittests. (patchset #1 id:1 of https://codereview.chromium.org/586683002/)

Reason for revert:
Linux Tests mojo_python_bindings_tests failure
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712

======================================================================
ERROR: testDefaultsTestSerializationDeserialization (bindings_serialization_deserialization_unittest.SerializationDeserializationTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py", line 125, in testDefaultsTestSerializationDeserialization
    v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles)
  File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py", line 113, in Deserialize
    serialization_object.Deserialize(fields, data, handles)
  File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py", line 82, in Deserialize
    (_, version) = HEADER_STRUCT.unpack_from(data)
TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray

Original issue's description:
> mojo: fix python unittests.
>
> TBR=sdefresne@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/80ced42d624a1eec8e8a2f0c0c760ab576d65ead

TBR=sdefresne@chromium.org,qsr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/587653003

Cr-Commit-Position: refs/heads/master@{#295688}

This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/
Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.
Now, the import itself is asychronous and calls back on completion.

While there, this also removes the GMock of the importer.

This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925
  refs/heads/master@{#295534}
with the fixed destruction order in ONCCertificateImporterImplTest.

The fix was reviewed in
  https://codereview.chromium.org/589443002/

TBR=eroman@chromium.org
BUG=413219

Review URL: https://codereview.chromium.org/582413002

Cr-Commit-Position: refs/heads/master@{#295687}

Move PageTransition enumeration from //content/public/common to //ui/base
so that it can be used by iOS and layered components that are used on iOS.

BUG=372373
R=avi@chromium.org, ben@chromium.org, wfh@chromium.org
TBR=ben, nasko

Review URL: https://codereview.chromium.org/562603002

Cr-Commit-Position: refs/heads/master@{#295686}

TBR=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/586683002

Cr-Commit-Position: refs/heads/master@{#295685}

This is a reland of https://codereview.chromium.org/578263003 using
buffer instead of memoryview, because on some early version of python
2.7, memoryview cannot be used with struct.unpack_from.

BUG=415491
R=sdefresne@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/588493002

Cr-Commit-Position: refs/heads/master@{#295684}

Revert of Make ONCCertificateImporter async. (patchset #5 id:190001 of https://codereview.chromium.org/547553005/)

Reason for revert:
Use-after-free.
https://code.google.com/p/chromium/issues/detail?id=415916

Original issue's description:
> Make ONCCertificateImporter async.
>
> This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/
>
> Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.
>
> Now, the import itself is asychronous and calls back on completion.
>
> While there, this also removes the GMock of the importer.
>
> BUG=413219
>
> Committed: https://crrev.com/bc656c0e7b7bd67fb28e5a880d21b9510ebd3e3a
> Cr-Commit-Position: refs/heads/master@{#295534}

TBR=joaodasilva@chromium.org,eroman@chromium.org,pneubeck@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413219

Review URL: https://codereview.chromium.org/580283005

Cr-Commit-Position: refs/heads/master@{#295683}

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/578383005

Cr-Commit-Position: refs/heads/master@{#295682}

It was using chromium resources when it should have used chrome resources, and vice versa.

BUG=None

Review URL: https://codereview.chromium.org/575923004

Cr-Commit-Position: refs/heads/master@{#295681}

For idle times < 1000us, we sent notifications with 0ms. This patch
adds a check for idle_time_in_ms to be non-zero and re-enables the
feature by default.

R=jochen@chromium.org
BUG=414815

Review URL: https://codereview.chromium.org/583833002

Cr-Commit-Position: refs/heads/master@{#295680}

This changes to the new mirror of the third_party library liblouis,
necessary because the project moved to github from an svn repository on
code.google.com.  Since the git mirroring infrastructure doesn't support
excluding parts of the tree, this means adding some GPL files and some files
without license headers.  The whitelist in tools/checklicenses/checklicenses.py
has been extended as needed.

One braille table (Hindi computer braille) is not available in liblouis
and has been removed.  A follow-up CL will add support for new braille
tables added in this release.

BUG=341951
R=dtseng@chromium.org, phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/579623003

Cr-Commit-Position: refs/heads/master@{#295679}

Revert of [telemetry] Read MSRs from a separate privileged process. (patchset #3 id:40001 of https://codereview.chromium.org/578123002/)

Reason for revert:
Fails telemetry_unittests and telemetry_perf_unittests on XP Tests (2) http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/35314

Traceback (most recent call last):
  run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
    testMethod()
  testPowerMonitoringSync at tools\telemetry\telemetry\core\platform\platform_backend_unittest.py:16
    if not platform.CanMonitorPower():
  CanMonitorPower at tools\telemetry\telemetry\core\platform\__init__.py:248
    return self._platform_backend.CanMonitorPower()
  CanMonitorPower at tools\telemetry\telemetry\core\platform\win_platform_backend.py:313
    return self._power_monitor.CanMonitorPower()
  CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51
    if self._PackageEnergyJoules() <= 0:
  _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97
    return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) *
  ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347
    self._StartMsrServerIfNeeded()
  _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338
    sys.executable, parameters, elevate_privilege=True)
  LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293
    if elevate_privilege and not IsCurrentProcessElevated():
  IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80
    win32security.GetTokenInformation(token, win32security.TokenElevation))
error: (87, 'GetTokenInformation', 'The parameter is incorrect.')

Locals:
  handle : -1
  token  : <PyHANDLE:0>

[  FAILED  ] platform.platform_backend_unittest.PlatformBackendTest.testPowerMonitoringSync (3422 ms)

Traceback (most recent call last):
  run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
    testMethod()
  wrapper at tools\telemetry\telemetry\decorators.py:84
    func(*args, **kwargs)
  testMsrRuns at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor_unittest.py:19
    if not power_monitor.CanMonitorPower():
  CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51
    if self._PackageEnergyJoules() <= 0:
  _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97
    return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) *
  ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347
    self._StartMsrServerIfNeeded()
  _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338
    sys.executable, parameters, elevate_privilege=True)
  LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293
    if elevate_privilege and not IsCurrentProcessElevated():
  IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80
    win32security.GetTokenInformation(token, win32security.TokenElevation))
error: (87, 'GetTokenInformation', 'The parameter is incorrect.')

Locals:
  handle : -1
  token  : <PyHANDLE:0>

[  FAILED  ] platform.power_monitor.msr_power_monitor_unittest.MsrPowerMonitorTest.testMsrRuns (32 ms)
[----------] 1 test (32 ms total)

Traceback (most recent call last):
  run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
    testMethod()
  wrapper at tools\telemetry\telemetry\decorators.py:55
    func(*args, **kwargs)
  BenchmarkSmokeTest at tools\perf\benchmarks\benchmark_unittest.py:59
    self.assertEqual(0, SinglePageBenchmark().Run(options),
  Run at tools\telemetry\telemetry\benchmark.py:95
    page_runner.Run(pt, ps, expectations, finder_options, results)
  Run at tools\telemetry\telemetry\page\page_runner.py:429
    page, credentials_path, possible_browser, results, state)
  _PrepareAndRunPage at tools\telemetry\telemetry\page\page_runner.py:259
    finder_options)
  StartBrowserIfNeeded at tools\telemetry\telemetry\page\page_runner.py:54
    test.WillStartBrowser(possible_browser.platform)
  WillStartBrowser at tools\perf\measurements\webrtc.py:21
    self._power_metric = power.PowerMetric(platform)
  __init__ at tools\perf\metrics\power.py:31
    self._MeasureQuiescentPower(quiescent_measurement_time_s)
  _MeasureQuiescentPower at tools\perf\metrics\power.py:54
    if not self._platform.CanMonitorPower() or \
  CanMonitorPower at tools\telemetry\telemetry\core\platform\__init__.py:248
    return self._platform_backend.CanMonitorPower()
  CanMonitorPower at tools\telemetry\telemetry\core\platform\win_platform_backend.py:313
    return self._power_monitor.CanMonitorPower()
  CanMonitorPower at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:51
    if self._PackageEnergyJoules() <= 0:
  _PackageEnergyJoules at tools\telemetry\telemetry\core\platform\power_monitor\msr_power_monitor.py:97
    return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS) *
  ReadMsr at tools\telemetry\telemetry\core\platform\win_platform_backend.py:347
    self._StartMsrServerIfNeeded()
  _StartMsrServerIfNeeded at tools\telemetry\telemetry\core\platform\win_platform_backend.py:338
    sys.executable, parameters, elevate_privilege=True)
  LaunchApplication at tools\telemetry\telemetry\core\platform\win_platform_backend.py:293
    if elevate_privilege and not IsCurrentProcessElevated():
  IsCurrentProcessElevated at tools\telemetry\telemetry\core\platform\win_platform_backend.py:80
    win32security.GetTokenInformation(token, win32security.TokenElevation))
error: (87, 'GetTokenInformation', 'The parameter is incorrect.')

Locals:
  handle : -1
  token  : <PyHANDLE:0>

[  FAILED  ] BenchmarkSmokeTest.webrtc.webrtc_cases (766 ms)

Original issue's description:
> [telemetry] Read MSRs from a separate privileged process.
>
> This allows us to read MSRs on Windows Vista+.
> Also move ReadMsr into PlatformBackend.
>
> BUG=336558
> TEST=tools/telemetry/run_tests msr
>
> Committed: https://crrev.com/2156b0323c83d6f11e68344ecf7e7e0c833cfa14
> Cr-Commit-Position: refs/heads/master@{#295634}

TBR=tonyg@chromium.org,thestig@chromium.org,dtu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336558

Review URL: https://codereview.chromium.org/582123003

Cr-Commit-Position: refs/heads/master@{#295678}

Revert of Remove void** from disk_cache interface. (patchset #30 id:650001 of https://codereview.chromium.org/542733002/)

Reason for revert:
Introduced memory leaks on linux asan
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892:
Direct leak of 80 byte(s) in 2 object(s) allocated from:
#0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
#1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5
#2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
#3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
#4 0x2e3b0bf in Run base/callback.h:401:12
#5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
#6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
#7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
#8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
#9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
#10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
#11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
#12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
#13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
#14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Indirect leak of 64 byte(s) in 2 object(s) allocated from:
#0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
#1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5
#2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36
#3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11
#4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
#5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
#6 0x2e3b0bf in Run base/callback.h:401:12
#7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
#8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
#9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
#10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
#11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
#12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
#13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
#14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
#15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
#16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Indirect leak of 36 byte(s) in 1 object(s) allocated from:
#0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb)
#1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5
#2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121
#3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8
#4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8
#5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36
#6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11
#7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17
#8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17
#9 0x2e3b0bf in Run base/callback.h:401:12
#10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62
#11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3
#12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5
#13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565
#14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21
#15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3
#16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3
#17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5
#18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3
#19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308

Original issue's description:
> Remove void** from disk_cache interface.
>
> Enumeration and iteration were passing around void**. With this CL, we
> instead use an Iterator object.
>
> R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org
> BUG=413644
>
> Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342
> Cr-Commit-Position: refs/heads/master@{#295659}

TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,rvargas@chromium.org,pasko@chromium.org,piman@chromium.org,michaeln@chromium.org,cbentzel@chromium.org,gavinp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413644

Review URL: https://codereview.chromium.org/585833002

Cr-Commit-Position: refs/heads/master@{#295677}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/583023003

Cr-Commit-Position: refs/heads/master@{#295676}

BUG=331299

Review URL: https://codereview.chromium.org/583113002

Cr-Commit-Position: refs/heads/master@{#295675}

The Common Debian Build System (cdbs) is needed for
packaging .deb files in some configurations.

http://packages.ubuntu.com/search?keywords=cdbs
shows that it's available for all common Ubuntu
distributions.
On Precise and Trusty, the package is very small (~40kB),
so it shouldn't have much impact on users.

TESTED=ran install-build-deps.sh on Ubuntu Precise.
R=friedman@chromium.org

Review URL: https://codereview.chromium.org/531513002

Cr-Commit-Position: refs/heads/master@{#295674}

--force-device-scale-factor is kept for dev purpose.

BUG=None

Review URL: https://codereview.chromium.org/580083004

Cr-Commit-Position: refs/heads/master@{#295673}

This CL adds a UMA histogram for the amount of time taken to build the
app list.

BUG=415389

Review URL: https://codereview.chromium.org/580993003

Cr-Commit-Position: refs/heads/master@{#295672}

per the comment in apps_client.h

BUG=None
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/583583008

Cr-Commit-Position: refs/heads/master@{#295671}

Revert of Cleanup: Remove remaining generated extensions APIs on Android. (patchset #4 id:60001 of https://codereview.chromium.org/573933002/)

Reason for revert:
Android bot fails with error: gen/extensions/common/api/generated_schemas.cc: No such file or directory

Original issue's description:
> Cleanup: Remove remaining generated extensions APIs on Android.
>
> BUG=305852
>
> Committed: https://crrev.com/379f0be47f454cce5c912f25d1b3302ba679b472
> Cr-Commit-Position: refs/heads/master@{#295669}

TBR=yoz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=305852

Review URL: https://codereview.chromium.org/582933003

Cr-Commit-Position: refs/heads/master@{#295670}

BUG=305852

Review URL: https://codereview.chromium.org/573933002

Cr-Commit-Position: refs/heads/master@{#295669}

This pulls in the following Native Client changes:

r13749: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13750: (dyen) Added tests for remaining directory functions in irt_ext.
r13751: (uekawa) NonSFI mode: Make tests/common/register_set.h PIC-friendly
r13752: (uekawa) NonSFI mode: Add libcrt_platform for native/mixed linking.
r13753: (dschuff) Remove i686-hosted Linux build and start switching to new directory layout
r13754: (dschuff) export_header.py: Mangle include guards in exported headers
r13755: (bradnelson) Turning on goma on nacl bots.
r13756: (dbrazdil) Implemented the _exit() syscall in MinSFI.
r13757: (bradnelson) Disable goma on win7-32 bots because it doesn't suport that platform.
r13758: (mseaborn) Cleanup: Use NaClCopyInFromUser() in one case in mmap()
r13759: (dschuff) Update revision for PNaCl r13739->r13753

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/582213004

Cr-Commit-Position: refs/heads/master@{#295668}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b14e4a0..3c29c4d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/586593003

Cr-Commit-Position: refs/heads/master@{#295667}

BUG=415564

Review URL: https://codereview.chromium.org/586503002

Cr-Commit-Position: refs/heads/master@{#295666}

This CL is part of the refactoring of webview into extensions/, and the webview test infrastructure depends heavily on this. Webview tests will be added to extensions soon.

BUG=352290

Review URL: https://codereview.chromium.org/584513003

Cr-Commit-Position: refs/heads/master@{#295665}

ServiceWorkerContainer.unregister() is going away. This patch
updates ServiceWorkerBrowserTest.ImportsBustMemcache to use
ServiceWorkerRegistration.unregister() function.

BUG=404064

Review URL: https://codereview.chromium.org/579183002

Cr-Commit-Position: refs/heads/master@{#295664}

This CL improves the app list startup time on non-Linux platforms. A new
FontList object was being unnecessarily created on every AppListItemView
which forced recalculations of otherwise cached values.

This was most noticeable on ChromeOS where the app list is
rebuilt every time it is shown.

BUG=415389

Review URL: https://codereview.chromium.org/574983002

Cr-Commit-Position: refs/heads/master@{#295663}

The following supressions are no longer needed:
bug_293088
bug_298887
bug_299647
bug_310351
bug_312332
bug_327672
bug_329960
bug_331061
bug_333992

BUG=293088,298887,299647,310351,312332,327672,329960,331061,333992
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/583103003

Cr-Commit-Position: refs/heads/master@{#295662}

Currently if some option is selected from options menu then in that
case content view does not gain focus in operations(like prev,next ).
Added code to handle this.

BUG=414219

Review URL: https://codereview.chromium.org/573653003

Cr-Commit-Position: refs/heads/master@{#295661}

The following supressions are no longer needed:
bug_259188
bug_259303
bug_259789
bug_259799
bug_262875
bug_262934
bug_268258
bug_269201
bug_269844

BUG=259188,259303,259789,259799,262875,262934,268258,269201,269844
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/582983003

Cr-Commit-Position: refs/heads/master@{#295660}

Enumeration and iteration were passing around void**. With this CL, we
instead use an Iterator object.

R=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org
BUG=413644

Review URL: https://codereview.chromium.org/542733002

Cr-Commit-Position: refs/heads/master@{#295659}

The following supressions are no longer needed:
bug_246148
bug_246153
bug_247525a
bug_247525b
bug_247525c
bug_250533
bug_250688
bug_252209
bug_252228
bug_253797

BUG=246148,246153,247525,250533,250688,252209,252228,253797
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/587453004

Cr-Commit-Position: refs/heads/master@{#295658}

Previously, windows that have only one of maxWidth or maxHeight defined
could not be maximized by the user, but they would still snap when
dragged to the edge of the screen.

This changes WindowState::CanSnap to use CanMaximize which is false
when there is a maxWidth or maxHeight, or when the window is not
resizable.

BUG=412610, 408737

Review URL: https://codereview.chromium.org/557693002

Cr-Commit-Position: refs/heads/master@{#295657}

if some format is supported or not.IsReadbackConfigSupported
takes care of validating this.

BUG=376769, 415131

Review URL: https://codereview.chromium.org/570003002

Cr-Commit-Position: refs/heads/master@{#295656}

If user right clicks immediately on entering a bookmark button, then open the
folder without delay so that context menu appears over the folder menu.

BUG=168758
R=asvitkine@chromium.org

TEST=
1. Add a bookmark folder to Bookmarks Bar (folder1).
2. Add a subfolder (folder2) inside folder1.
3. Add few bookmarks to folder2.
4. Click on folder1 and immediately right click on folder2 and observe.
5. Context Menu should appear over the folder menu (folder contents window).

Review URL: https://codereview.chromium.org/581053002

Cr-Commit-Position: refs/heads/master@{#295655}

The following supressions are no longer needed:
bug_233541
bug_238547
bug_241044
bug_243132
bug_243753

BUG=233541,238547,241044,243132,243753
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/587563002

Cr-Commit-Position: refs/heads/master@{#295654}

Refactoring PasswordAutofillAgent::FillUserNameAndPassword for early return if password_element is not autocompleteable.

PasswordAutofillAgent::FillUserNameAndPassword function refactor done for early return as we chould check this at start only.

BUG=398436

Review URL: https://codereview.chromium.org/557703002

Cr-Commit-Position: refs/heads/master@{#295653}

Move declaration of AttachmentServiceProxyForTest's destructor to make
it clear the WeakPtrFactory is the last data member.

BUG=303818

Review URL: https://codereview.chromium.org/575383002

Cr-Commit-Position: refs/heads/master@{#295652}

and added proper history change notification on history data change.

BUG=None

Review URL: https://codereview.chromium.org/579753002

Cr-Commit-Position: refs/heads/master@{#295651}

The following supressions are no longer needed:
bug_180381
bug_184264
bug_222363
bug_222898
bug_224747
bug_225596

BUG=180381,184264,222363,222898,224747,225596
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/585783002

Cr-Commit-Position: refs/heads/master@{#295650}