GitLab

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25370
        Introduce ScriptEventListener to refactor away direct references to
        JSLazyEventListener in WebCore code.

        * GNUmakefile.am: Added ScriptEventListener to project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
        * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
            to ScriptEventListener.
        * bindings/js/JSLazyEventListener.h: Ditto.
        * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
        * bindings/js/ScriptEventListener.cpp: Added.
        * bindings/js/ScriptEventListener.h: Added.
        * bindings/v8/ScriptEventListener.cpp: Added.
        * bindings/v8/ScriptEventListener.h: Added.
        * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
        * html/HTMLBodyElement.cpp: Ditto.
        * html/HTMLButtonElement.cpp: Ditto.
        * html/HTMLElement.cpp: Ditto.
        * html/HTMLFormElement.cpp: Ditto.
        * html/HTMLFrameElementBase.cpp: Ditto.
        * html/HTMLFrameSetElement.cpp: Ditto.
        * html/HTMLImageElement.cpp: Ditto.
        * html/HTMLInputElement.cpp: Ditto.
        * html/HTMLObjectElement.cpp: Ditto.
        * html/HTMLScriptElement.cpp: Ditto.
        * html/HTMLSelectElement.cpp: Ditto.
        * html/HTMLTextAreaElement.cpp: Ditto.
        * svg/SVGElement.cpp: Ditto.
        * svg/SVGSVGElement.cpp: Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@42843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion

Reviewed by Geoff Garen

We now track the maximum extent of the RegisterFile, and when we reach the final
return from JS (so the stack portion of the registerfile becomes empty) we see
if that extent is greater than maxExcessCapacity.  If it is we use madvise or
VirtualFree to release the physical pages that were backing the excess.

git-svn-id: svn://svn.chromium.org/blink/trunk@42842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.

        Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
        https://bugs.webkit.org/show_bug.cgi?id=25355
        rdar://problem/6823543

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): Added a null check.



git-svn-id: svn://svn.chromium.org/blink/trunk@42841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Fix RenderSVGImage to dump with full bounds and style information.
        https://bugs.webkit.org/show_bug.cgi?id=25377

        No functional changes, we're just now including more info in render tree dumps.

        * rendering/RenderObject.h:
        (WebCore::RenderObject::isSVGImage):
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::isSVGImage):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::write):
        * rendering/SVGRenderTreeAsText.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Fix <rdar://problem/6761635>.
        
        Make sure to keep an extra reference to the instance proxy in case the plug-in host crashes while
        we're waiting for a reply.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::destroy):



git-svn-id: svn://svn.chromium.org/blink/trunk@42839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by NOBODY (chromium build fix).

        Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        * bindings/v8/V8AbstractEventListener.h:
        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::add):
        (WebCore::V8EventListenerList::remove):
        (WebCore::V8EventListenerList::clear):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::virtualisAttribute):
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        * bindings/v8/custom/V8CustomEventListener.h:
        (WebCore::V8EventListener::create):
        (WebCore::V8EventListener::virtualisAttribute):

git-svn-id: svn://svn.chromium.org/blink/trunk@42838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25373
        Popup menu has the wrong size when popped up near the edge
        of the screen

        * webkit/webkitwebview.cpp:
        (webkit_web_view_forward_context_menu_event): Let GTK place
        the popup menu instead of trying to do better and failing

git-svn-id: svn://svn.chromium.org/blink/trunk@42837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser

        <rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit

        Use better mp4 test file for media tests. The original mp4 file had an unusual
        edit (non-zero start time) which is not supported by all media engines. The new
        movie should also give more useful pixel test results.

        * media/content/test.mp4: Update the movie.
        * media/progress-event-total-expected.txt: Update test results to match movie duration and
        content changes.
        * media/progress-event-total.html: Ditto.
        * media/video-currentTime-set-expected.txt: Ditto.
        * media/video-loop-expected.txt: Ditto.
        * platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
        * platform/mac/media/video-aspect-ratio-expected.png: Ditto.
        * platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
        * platform/mac/media/video-controls-rendering-expected.png: Ditto.
        * platform/mac/media/video-display-toggle-expected.checksum: Ditto.
        * platform/mac/media/video-display-toggle-expected.png: Ditto.
        * platform/mac/media/video-empty-source-expected.checksum: Ditto.
        * platform/mac/media/video-layer-crash-expected.checksum: Ditto.
        * platform/mac/media/video-layer-crash-expected.png: Ditto.
        * platform/mac/media/video-transformed-expected.checksum: Ditto.
        * platform/mac/media/video-transformed-expected.png: Ditto.
        * platform/mac/media/video-zoom-expected.checksum: Ditto.
        * platform/mac/media/video-zoom-expected.png: Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@42836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Installed browser location is written to a slightly different registry key in that case.
        
        * FindSafari/FindSafari.cpp:
        (getInstalledWebKitDirectory):



git-svn-id: svn://svn.chromium.org/blink/trunk@42835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        When I moved the files I forgot to update the location of the image!

        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25343
        Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
        ignores blur.

        * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
         (WebCore::GraphicsContext::setPlatformShadow): Add check against
         blur before clearing looper.

git-svn-id: svn://svn.chromium.org/blink/trunk@42833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - Build fix.  Removed this test until I can figure out why it's failing.

        * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@42832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-24  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Initialize TextIterator::m_textLength to 0.

        This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).

        <https://bugs.webkit.org/show_bug.cgi?id=25335>

        Test: editing/selection/doubleclick-whitespace-img-crash.html

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::TextIterator):

LayoutTests:

2009-04-24  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Add a test for <https://bugs.webkit.org/show_bug.cgi?id=25335>.

        To pass, this test must not access invalid memory when run (won't necessarily manifest as a crash for failures).

        * editing/selection/doubleclick-whitespace-img-crash-expected.txt: Added.
        * editing/selection/doubleclick-whitespace-img-crash.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Source changes reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=22242

        Update WebKitSystemInterface for Mac with fixes for video controller drawing.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: svn://svn.chromium.org/blink/trunk@42830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25329
        Add indexed access method in v8 binding of ClientRectList.

        * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Use null for unspecified event listener attributes of XMLHttpRequest
        and XMLHttpRequestUpload in v8 binding.

        cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
        An event handler attribute, unless otherwise specified, can either
        have the value null or be set to a Function object.
        Initially, an event handler attribute must be set to null.

        Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html

        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Ditto.

LayoutTests:

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Verify XMLHttpRequest has correct attribute value by default.

        * fast/xmlhttprequest/resources/xmlhttprequest-default-attributes.js: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes-expected.txt: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes.html: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42828 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Gustavo Noronha.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the
        description of the enable-spell-checking property and correct the
        mentioning of the default language used.

git-svn-id: svn://svn.chromium.org/blink/trunk@42827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Speculative fix for leopard build-bot until I have a fix on leopard.

        * platform/mac-leopard/editing: Added.
        * platform/mac-leopard/editing/deleting: Added.
        * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        <rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException): Added a null check.



git-svn-id: svn://svn.chromium.org/blink/trunk@42825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein

        Currently working on a bug where a WebHistoryItem was being used after being dealloc'ed.
        I added this assertion to help catch the case as soon as it happens instead of random
        issues downstream.  Figured it's worth checking in by itself.

        * History/WebHistoryItem.mm:
        (core): ASSERT that the WebCore::HistoryItem inside this WebHistoryItem is supposed to have
          this WebHistoryItem as a wrapper.



git-svn-id: svn://svn.chromium.org/blink/trunk@42824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=23219

        Add support for transtions and animations of background-position, -webkit-background-size,
        -webkit-mask-position and -webkit-mask-size.

        Tests: transitions/background-transitions.html
               transitions/mask-transitions.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        Add a blend func for LengthSize.

        (WebCore::ensurePropertyMap):
        Add wrappers for the new properties.

        (WebCore::addShorthandProperties):
        Add a shorthand property for CSSPropertyBackgroundPosition to map to
        CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
        add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
        CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
        CSSPropertyWebkitMaskPositionY.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBackgroundXPosition):
        (WebCore::InheritedFlags::setBackgroundYPosition):
        (WebCore::InheritedFlags::setBackgroundSize):
        (WebCore::InheritedFlags::setMaskXPosition):
        (WebCore::InheritedFlags::setMaskYPosition):
        (WebCore::InheritedFlags::setMaskSize):
        Add setters for the properties that can be animated now.

git-svn-id: svn://svn.chromium.org/blink/trunk@42823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        Updating these pixel results to the generated results on Leopard.

        * platform/mac/editing/inserting/5510537-expected.checksum:
        * platform/mac/editing/inserting/5510537-expected.png:
        * platform/mac/editing/inserting/6703873-expected.checksum:
        * platform/mac/editing/inserting/6703873-expected.png:
        * platform/mac/editing/selection/select-all-iframe-expected.checksum:
        * platform/mac/editing/selection/select-all-iframe-expected.png:



git-svn-id: svn://svn.chromium.org/blink/trunk@42822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        Test: editing/pasteboard/paste-blockquote-after-blockquote.html

        When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
        But we should only merge here if the selection start was inside a mail blockquote.  This prevents against removing a 
        blockquote from newly pasted quoted content that was pasted into an unquoted position.  If that unquoted position happens 
        to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
        (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
        * editing/ReplaceSelectionCommand.h:

LayoutTests:

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        * editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Implement EditorClient::ignoreWordInSpellDocument,
        EditorClient::learnWord and EditorClient::getGuessesForWord. This
        enables the corresponding user actions.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::ignoreWordInSpellDocument):
        (WebKit::EditorClient::learnWord):
        (WebKit::EditorClient::getGuessesForWord):

git-svn-id: svn://svn.chromium.org/blink/trunk@42820 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Implement EditorClient::checkSpellingOfString; enabling spell checking
        to actually happen, this is the basis for other spelling functions.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::checkSpellingOfString):

git-svn-id: svn://svn.chromium.org/blink/trunk@42819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add enchant support for spell-checking-languages property to work
        properly.

        * GNUmakefile.am:
        * configure.ac:

WebKit/gtk

2009-04-24  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add spell-checking-languages property to WebKitWebSettings.

        * webkit/webkitprivate.h:
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_finalize):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):

git-svn-id: svn://svn.chromium.org/blink/trunk@42818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add enable-spell-checking property to WebKitWebSettings and implement
        EditorClient::isContinuousSpellCheckingEnabled and
        EditorClient::toggleContinuousSpellChecking to allow the UI to
        enable check as you type spell checking.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::isContinuousSpellCheckingEnabled):
        (WebKit::EditorClient::toggleContinuousSpellChecking):
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):

git-svn-id: svn://svn.chromium.org/blink/trunk@42817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Hausmann.

        Added Qt-specific expected result for color conversion.

        This is to compensate the lack of color profile in Qt to do
        color conversion, hence CMYK 0,0,0,1 always give pure black (#000)
        instead of very dark black.

        * platform/qt/fast/canvas/set-colors-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42816 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by Ariya Hidayat.

        Fix qdoc warning about link to QAction::isEnabled.

git-svn-id: svn://svn.chromium.org/blink/trunk@42815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ariya Hidayat.

        Added support for generating API docs in the Qt build using "make docs"

        Added code snippets and overview from the Qt sources references in the API docs.

git-svn-id: svn://svn.chromium.org/blink/trunk@42814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        Updating test to make it easier to see the blockquote in the results.

        * editing/pasteboard/paste-blockquote-into-blockquote-3.html:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

tests that use it can find it.

* platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.

git-svn-id: svn://svn.chromium.org/blink/trunk@42812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

order to restore greenness to the world once more.

* wtf/Platform.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42811 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: svn://svn.chromium.org/blink/trunk@42810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:  Remove a symbol that no longer exists.

git-svn-id: svn://svn.chromium.org/blink/trunk@42809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

JavaScriptCore:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::Hash::hash):
        (JSC::CallIdentifier::Hash::equal):
        (JSC::CallIdentifier::hash):
        (WTF::):
        * profiler/HeavyProfile.cpp: Removed.
        * profiler/HeavyProfile.h: Removed.
        * profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile
        (JSC::Profile::create):
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp:
        * profiler/ProfileNode.h:
        * profiler/TreeProfile.cpp: Removed.
        * profiler/TreeProfile.h: Removed.

WebCore:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
        heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
        displays flattened statistics for a particular function that ran during the profile, and each child
        of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
        nodes should show how much of the root nodes values came from it. For example, if you had the following to
        stacks take place during the profile:

        A ->calls 1 times-> B ->calls 2 times-> C
        D ->calls 4 times-> C

        The tree for the C root node would look like this:

        C -> B -> A
          -> D

        The number of calls values would look like this:

        C (6) -> B (2) -> A(2)
              -> D (4)

        What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
        "4 of the total C calls came from D".  Notice that the "A ->calls 2 time->" is completely ignored. This becomes
        particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
        is the reason that we would get things like 40000% previously with recursion.

        This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
        can't know exactly how many calls came from where, etc).

        * English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
        * inspector/JavaScriptProfile.cpp:
        (WebCore::ProfileClass):
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::getParent):
        (WebCore::getHead):
        (WebCore::getCallUID):
        (WebCore::ProfileNodeClass):
        * inspector/front-end/BottomUpProfileDataGridTree.js: Added.
        (WebInspector.BottomUpProfileDataGridTree):
        (WebInspector.BottomUpProfileDataGridTree.prototype.focus):
        (WebInspector.BottomUpProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
        (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
        (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
        (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid.prototype.insertChild):
        (WebInspector.DataGrid.prototype.removeChild):
        (WebInspector.DataGrid.prototype.removeChildren):
        (WebInspector.DataGridNode.prototype.set hasChildren):
        (WebInspector.DataGridNode.prototype.get hasChildren):
        * inspector/front-end/ProfileDataGridTree.js: Added.
        (WebInspector.ProfileDataGridNode):
        (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
        (WebInspector.ProfileDataGridNode.prototype.get data):
        (WebInspector.ProfileDataGridNode.prototype.createCell):
        (WebInspector.ProfileDataGridNode.prototype.select):
        (WebInspector.ProfileDataGridNode.prototype.deselect):
        (WebInspector.ProfileDataGridNode.prototype.expand):
        (WebInspector.ProfileDataGridNode.prototype.insertChild):
        (WebInspector.ProfileDataGridNode.prototype.removeChild):
        (WebInspector.ProfileDataGridNode.prototype.removeChildren):
        (WebInspector.ProfileDataGridNode.prototype.findChild):
        (WebInspector.ProfileDataGridNode.prototype.get averageTime):
        (WebInspector.ProfileDataGridNode.prototype.get averagePercent):
        (WebInspector.ProfileDataGridNode.prototype.get selfPercent):
        (WebInspector.ProfileDataGridNode.prototype.get totalPercent):
        (WebInspector.ProfileDataGridNode.prototype._save):
        (WebInspector.ProfileDataGridNode.prototype._restore):
        (WebInspector.ProfileDataGridNode.prototype._merge):
        (WebInspector.ProfileDataGridTree):
        (WebInspector.ProfileDataGridTree.prototype.get expanded):
        (WebInspector.ProfileDataGridTree.prototype.appendChild):
        (WebInspector.ProfileDataGridTree.prototype.insertChild):
        (WebInspector.ProfileDataGridTree.prototype.removeChildren):
        (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save):
        (WebInspector.ProfileDataGridTree.propertyComparator.comparator):
        (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator):
        (WebInspector.ProfileDataGridTree.propertyComparator):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype.set profile):
        (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree):
        (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree):
        (WebInspector.ProfileView.prototype.get currentTree):
        (WebInspector.ProfileView.prototype.set currentTree):
        (WebInspector.ProfileView.prototype.get topDownTree):
        (WebInspector.ProfileView.prototype.get bottomUpTree):
        (WebInspector.ProfileView.prototype.refresh):
        (WebInspector.ProfileView.prototype.refreshVisibleData):
        (WebInspector.ProfileView.prototype.refreshShowAsPercents):
        (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
        (WebInspector.ProfileView.prototype.performSearch):
        (WebInspector.ProfileView.prototype._changeView):
        (WebInspector.ProfileView.prototype._focusClicked):
        (WebInspector.ProfileView.prototype._excludeClicked):
        (WebInspector.ProfileView.prototype._resetClicked):
        (WebInspector.ProfileView.prototype._sortProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.showProfile):
        (WebInspector.ProfilesPanel.prototype.showView):
        (WebInspector.ProfilesPanel.prototype.searchMatchFound):
        * inspector/front-end/TopDownProfileDataGridTree.js: Added.
        (WebInspector.TopDownProfileDataGridNode):
        (WebInspector.TopDownProfileDataGridNode.prototype._populate):
        (WebInspector.TopDownProfileDataGridNode.prototype._exclude):
        (WebInspector.TopDownProfileDataGridTree):
        (WebInspector.TopDownProfileDataGridTree.prototype.focus):
        (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

LayoutTests:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        Changed profile.treeProfile to just profile, since these aren't generated in C++ anymore.
        Removed heavy-view test since heavy-view isn't an actual tree that is generated in C++ land anymore,
        but rather just a different display of the normal treeProfile in the JS data grid.

        * fast/profiler/heavy-view-expected.txt: Removed.
        * fast/profiler/heavy-view.html: Removed.
        * fast/profiler/resources/profiler-test-JS-resources.js: profiles[i].treeProfile -> profiles[i].treeProfile
        (printProfilesDataWithoutTime):

git-svn-id: svn://svn.chromium.org/blink/trunk@42808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Use static functions (and a couple templates)
        to further reduce the amount of copy/paste code in SVGRenderTreeAsText

        No test changes, only code cleanup.

        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeNameValuePair):
        (WebCore::writeNameAndQuotedValue):
        (WebCore::writeIfNotEmpty):
        (WebCore::writeIfNotDefault):
        (WebCore::writeStyle):
        (WebCore::writePositionAndStyle):
        (WebCore::operator<<):

git-svn-id: svn://svn.chromium.org/blink/trunk@42807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - Windows build fix.  Mac only tests go in platform/mac

        * editing/deleting/deletionUI-borders.html: Removed.
        * editing/deleting/deletionUI-differing-background.html: Removed.
        * editing/deleting/deletionUI-minimum-size.html: Removed.
        * platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
        * platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.



git-svn-id: svn://svn.chromium.org/blink/trunk@42806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not Reviewed.

        Speculative Windows build fix II.

        * yarr/RegexInterpreter.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@42805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not Reviewed.

        Speculative Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * runtime/RegExp.cpp:



git-svn-id: svn://svn.chromium.org/blink/trunk@42804 bbb929c8-8fbe-4397-9dbb-9b2b20218538