GitLab

Currently, when a Chrome app is uninstalled, the respective
ChromeAppItem is not removed from ChromeAppListModelUpdater.
If the app is reinstalled in the same session, it is recognized
as existing and no new item is added to the app list.

This CL fixes this problem.

Bug: 884921
Test: manual, steps in bug.
Change-Id: I20bed583b1b484544cdf29f8fc0be2b08ef5280b
Reviewed-on: https://chromium-review.googlesource.com/c/1461189
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630422}

This test asserts that 'button' and 'link' do not
receive a language attribute; only the contents
of these elements receive a language attribute.

Change-Id: I8a9a1d1da3256f2e963fe327a04a49872f9a9547
Bug: 923068
Reviewed-on: https://chromium-review.googlesource.com/c/1458936Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630421}

My last attempt (r630385) didn't work:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8922068251220090064/+/steps/presubmit/0/stdout

Rather, it appears that comments may only start at the beginning of a
line. Running:
  find -name OWNERS -type f -exec grep -H '^[^#].*#' '{}' ';'

…finds only two cases of trailing comments, and both are “per-file”
directives. So I'm guessing that trailing comments in general break the
parser.

Change-Id: If22a168898859a674624af1b26b0990a88c0ef47
Reviewed-on: https://chromium-review.googlesource.com/c/1461084
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#630420}

Bug: 929994
Change-Id: I5cc1a2379358afffca9b95df49f485aefff232f3
Reviewed-on: https://chromium-review.googlesource.com/c/1460414
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630419}

Also refactor into objects with defined purposes.

The theme of this is to not load the results output or the test output
or the logs output into memory. There are some small time savings from doing
this (see crbug.com/927507). However, the main reason to do this is
to simplify the code and to prevent us from hitting errors in JSON
formatting at this level. It is better to simply pass on what is given to us.
Failures at this level cause the benchmark shard map to not be written,
which makes it harder for us to debug issues.

Also fix crbug.com/923628. Now we can save gtest_perf_tests logs to a
file so they will be outputted in the isolate and people can find them
more easily from Milo.

This also cleans up the logic a bit and deletes dead code, which will help
us with crbug.com/920002 and crbug.com/894254

Also, since Telemetry benchmarks always return histograms,
(See crbug.com/744736), remove the append_output_format
function.

BUG=927507, 923628, 920002, 744736

Change-Id: I96c2c49efeb7fbc0f864b6b20a4fa3cdc702a608
Reviewed-on: https://chromium-review.googlesource.com/c/1449151
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630418}

Bug: 788757
Change-Id: I53c85bb082b0138c97e33d80bdabd80b0e87c971
Reviewed-on: https://chromium-review.googlesource.com/c/1459545
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630417}

Change-Id: I18fa394604b1b9c18182508c213f3e097970aa37
Reviewed-on: https://chromium-review.googlesource.com/c/1460492Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630416}

crrev.com/c/1460185 and crrev.com/c/1457478 should have fixed these
tests on ChromeOS.

Bug: 927293
Change-Id: I506f4f5023e431df942797c6820feb7997e514cf
Reviewed-on: https://chromium-review.googlesource.com/c/1460125Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630415}

The WebLayerTreeView is a shortcut past the WebWidgetClient that is
not needed now that we always composite. This works toward eliminating
this extra API layer

More importantly this helps us Close/Restart the WebWidget parts of
WebViewImpl by not requiring plumbing 2 pointers with slightly different
lifetimes (WebLayerTreeView is created inside the Init of the
WebWidgetClient). This will help avoid a bunch of complexity in
creating WebFrameWidgets and other WebWidgets.

TBR=dcheng@chromium.org

Bug: 912193
Change-Id: Id9b496255f7f8bb67405f779903b6ba1826c3716
Reviewed-on: https://chromium-review.googlesource.com/c/1456205Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630414}

See https://bugs.chromium.org/p/chromium/issues/detail?id=912131#c6 for an
itemized list of changes.

Bug: 912131
Change-Id: I562d33fc376ccda13397038a17a7d4d96fc9e285
Reviewed-on: https://chromium-review.googlesource.com/c/1455070
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630413}

Running it locally on an emulator consistantly passes. I can't dig into the flakes as they are so old the logs are gone.

I'd like to renable and see if it is still flaky. At that point we can re-investigate.

Bug: 842999
Change-Id: I4d2119897a992bfd198589666e8c719bb594eae9
Reviewed-on: https://chromium-review.googlesource.com/c/1446552Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630412}

This CL removes all remaining chromeos/network deps from
network_icon.cc besides NetworkState and NetworkTypePattern in
preparation for switching to using mojo types.

Bug: 923444
Change-Id: Ia4657cfb28223fd82bddcc2635ffb13187565357
Reviewed-on: https://chromium-review.googlesource.com/c/1448781Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630411}

https://skia.googlesource.com/skia.git/+log/a41c6858da8a..d6841487eb8e


git log a41c6858da8a..d6841487eb8e --date=short --no-merges --format='%ad %ae %s'
2019-02-08 robertphillips@google.com Move auditTrail and opMemoryPool from GrContext to GrRecordingContext
2019-02-08 brianosman@google.com Fix vertex indexing error when using ImGui skiaWidgets
2019-02-08 mtklein@google.com move some methods out of line
2019-02-08 herb@google.com Simplify typeface and effects handling


Created with:
  gclient setdep -r src/third_party/skia@d6841487eb8e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I4f5c41925667e5b01cee0b57fd45bd4319621cb2
Reviewed-on: https://chromium-review.googlesource.com/c/1461139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630410}

//fuchsia/service, //fuchsia/common, //fuchsia/browser and
//fuchsia/renderer all contain code related to the Fuchsia WebEngine
implementation. This consolidates all that code in a single directory
under //fuchsia/engine.

TBR=sky@chromium.org

Bug: 922635
Change-Id: I5c5fa0a096a83e5dc21601a59e5bb723dd097e86
Reviewed-on: https://chromium-review.googlesource.com/c/1443953
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630409}

On Chrome OS, opening print preview against a CUPS printer exposes
unlocalized media names to the user. To enhance the user experience,
we extend media name localization. In this CL, we

  * Add GRIT scaffolding to map PWG media names to common, localized,
    and user-friendly names (to be translated).
  * Move display name processing out of CUPS IPP code into the print
    component.
  * Update the unit tests in the print component and the CUPS IPP
    code to exercise the new localizations and code flows.

R=jochen@chromium.org, skau@chromium.org, thestig@chromium.org, valleau@chromium.org

Bug: 899857
Test: Open print preview on Chrome OS against a CUPS printer and
observe the newly localized media names; run the components_unittests;
run the printing_unittests.

Change-Id: I1d4928a6d0f276a887c0edb5e2f2e17ad7fe0e80
Reviewed-on: https://chromium-review.googlesource.com/c/1446698Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630408}

BUG=none

Change-Id: I36a7b46e3ce60c49b79ece14e7c3ee376c5d4c05
Reviewed-on: https://chromium-review.googlesource.com/c/1461096
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630407}

Include <math.h> to fix the libstdc++ build:

    ../../third_party/blink/renderer/core/streams/queue_with_sizes.cc: In function ‘bool blink::{anonymous}::IsFiniteNonNegativeNumber(double)’:
    ../../third_party/blink/renderer/core/streams/queue_with_sizes.cc:18:10: error: ‘isfinite’ was not declared in this scope
       return isfinite(v) && v >= 0;
              ^~~~~~~~

Bug: 819294
Change-Id: I04eaebb0f951829b1994cd92eb4ec71df791ff22
Reviewed-on: https://chromium-review.googlesource.com/c/1461116
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Adam Rice <ricea@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630406}

This cl uses approx_equals instead of waiting for the scrolltop to get
equal to the precise scroll delta to make the test stable.

Bug: 766357
Change-Id: Ib4d5712fda6dca28a81fce0fbccf4c64f568e8d4
Reviewed-on: https://chromium-review.googlesource.com/c/1459792Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630405}

This CL:
* Makes networkProperties private (-> networkProperties_).
* Audits the JS to ensure that all methods test for undefined
  networkProperties_ (two methods were fixed).
* Uses standard !networkProperties_ and !!networkProperties_ instead of
  a mix of those and explicit undefined tests.
* Fixes the test to set prefs_ initially so that methods will trigger
  with undefined networkProperties in Polymer2.

Bug: 929744
Change-Id: Iedce43900adde5b67b1a3d1c2e8ef1e489bc4efb
Reviewed-on: https://chromium-review.googlesource.com/c/1460401Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630404}

We move the iOS / Android AttachToMessagePump method internally and
change sequence_manager::CreateUnboundSequenceManager to create a
ThreadControllerWithMessagePumpImpl since the message loop variant is
unused.  It's still possible to create a SequenceManager on top of
the current MessageLoop via CreateSequenceManagerOnCurrentThread.

Bug: 872372, 863341
Change-Id: I7459c29b5cf80a47720ae9781347bf55c7c75ac0
Reviewed-on: https://chromium-review.googlesource.com/c/1458197
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Auto-Submit: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630403}

This test was meant for https://crrev.com/c/1453112. It does a
window.open() and then window.close() on the new window. The new window
has an unload handler that runs layout.

This path is special because when doing window.close() on a same-domain
window, the render process will not be fast-shutdown, and the unload
handlers run as part of WidgetMsg_Close instead of ViewMsg_ClosePage.
This means they run in the middle of tear down (as ViewMsg_ClosePage
would be a separate step before teardown). This test succeeds if the
test is able to perform unload without crashing.

Bug: 927694
Change-Id: Iebdbdf242680f00f3eb6856d577520e39fb7fae6
Reviewed-on: https://chromium-review.googlesource.com/c/1458701Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630402}

This relands commit 2362937c.

This CL removes blocking worker pools from the task scheduler.
Tasks with MayBlock trait are instead posted to the usual foreground/background pool,
giving us better control over scheduling.

Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 628816 as the culprit
for introducing flakiness in the tests as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjM2MjkzN2M2NDk0ZWJiOTIwZjc1MjYxZTlkMzRhOGE5M2U5NDJhOAw

Fix: double kMaxThreads in ScopedTaskEnvironment to maintain total worker count
constant.

TBR=avi@chromium.org,gab@chromium.org,garykac@chromium.org,fdoray@chromium.org,eugenebut@chromium.org,alexilin@chromium.org

Bug: 874080, 915769
Change-Id: Ida84fe368b65eab7fdb761869b40c39601e01418
Reviewed-on: https://chromium-review.googlesource.com/c/1456288
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630401}

Add a manifest attribute to enable multiple resumed activities on newer
versions of Android. Update multi-instance tab model merging to wait to
merge until there is only one resumed activity.

BUG=904555

Change-Id: I6efe103d129cad709b3bf9392e70e6e441d75243
Reviewed-on: https://chromium-review.googlesource.com/c/1460132
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630400}

Sets delay to minimum delay for tabs with a width less than the pinned width.

Bug: 910739
Change-Id: Ie9d588a60d30b1eaab5ee1c45da64ad832794b64
Reviewed-on: https://chromium-review.googlesource.com/c/1461182Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630399}

Before, we used the column header text when searching by boolean properties.
When we replaced the headers with 1 letter abbreviations, this broke searching
boolean properties. I.e., to search for results that could be the default match,
you'd have to type 'is:d', but 'is:default' would no longer work. This CL
changes searching to use the first line of the tooltip text instead of the
header text.

The current tooltip names are:
  - Can be Default
  - Starred
  - Has Tab Match
  - deletable
  - From Previous
  - Done

Bug: 891303
Change-Id: Ic275924ca3e7dfad6fba3c20514e87577bbbf807
Reviewed-on: https://chromium-review.googlesource.com/c/1459782Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630398}

This change adds const char* overloads for the immutable versions of the
as_{w,u16}cstr() conversion functions. Without these overloads the
StringPiece versions would be chosen, leading to an strlen() call, that
is both unnecessary and can lead to buffer overruns.

Bug: 930026
Change-Id: If3bc264bc941b8152c4095e91b5f2122d11b71da
Reviewed-on: https://chromium-review.googlesource.com/c/1460934Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630397}

Chromium has a variety of command states that are intended to get
initialized upon launch, one of which being the TabRestoreService. The
code to initialize the TabRestoreService simply doesn't work properly
and it isn't actually initialized. This results in a couple bugs:

- When you right-click on the title bar (or hit alt+space) to open the
  system context menu the Reopen closed tab option is never enabled the
  first time. It works on subsequent times because that menu has code to
  initialize the service.
- When you open the tab context menu the Reopen close tab option is
  never enabled, ever, if that's the only thing you do. That menu
  doesn't have any code to initialize the state.

In both cases, if you do something that causes the service to initialize
first, such as closing a tab, then the menu items work properly.

This change fixes the launch code to properly initialize the service.
As a result, the system menu's code can be simplified because it no
longer needs special code to initialize the service. This change also
adds a variety of new test cases to cover these scenarios.

Bug:567929,764729,781037,444816

Change-Id: I65fc343f408ace9a4a86fdbad0a097a99d65d38b
Reviewed-on: https://chromium-review.googlesource.com/c/1447116
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630396}

Before this patch, the WPT tests for PaymentRequest.show() failed (and
were expected to do so) because the tests run in a content shell, which
does not have the Payment Request components sufficient for showing a
browser payment sheet.

This patch converts the show() test into a manual one, which should be
run in a full browser. One test case remains automated, because its
intent is to invoke show() without a user gesture. That test case is
expected to fail because Chromium does not require a user gesture for
show() at this time (https://crbug.com/817807).

After this patch, the manual WPT tests for PaymentRequest.show() pass in
the full Chromium browser.

Bug: 929773 817807
Change-Id: I9cacb5447fb3ae43a8b50c53a74b7c58db8f4466
Reviewed-on: https://chromium-review.googlesource.com/c/1460104
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630395}

Before this patch, the WPT tests for PaymentRequest.abort() were
expected to fail due to including the vendor testdriver JavaScript file
before the generic testdriver file. The vendor file was attempting to
use the objects defined in the generic file, but the incorrect include
order caused a JS error.

This patch reorders the vendor JS file to be after the generic JS file
and splits out the manual tests that require a user gesture for
PaymentRequest.show().

After this patch, the PaymentRequest.abort() tests are passing.

Bug: 929773
Change-Id: Ic0f8ff84b478116821e98775d1cec31cfad32d9f
Reviewed-on: https://chromium-review.googlesource.com/c/1459588
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630394}

Downscaled video isn't promoted to hardware overlay so we prefer to blit
it to screen space size so that it can be promoted to an overlay.

Bug: 848093
Change-Id: I8467d1ebd8f551900d6dfb756d67f5cfc7e76d9e
Reviewed-on: https://chromium-review.googlesource.com/c/1460483Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630393}

Bug: none
Change-Id: I3f7d680490147ca74c20d65c9c8d926b467b8f64
Reviewed-on: https://chromium-review.googlesource.com/c/1460403Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630392}

This reverts commit 2e77a4e7.

Reason for revert: Causing compile failures - https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8922068790388783168/+/steps/compile/0/stdout

Original change's description:
> Roll src/third_party/perfetto 56445ec1e273..65ae74030114 (2 commits)
> 
> https://android.googlesource.com/platform/external/perfetto.git/+log/56445ec1e273..65ae74030114
> 
> 
> git log 56445ec1e273..65ae74030114 --date=short --no-merges --format='%ad %ae %s'
> 2019-02-08 lalitm@google.com Merge "perfetto: add string writer class for formatting strings"
> 2019-02-08 fmayer@google.com Merge "Pad fuzzer input to 2^n * kPageSize."
> 
> 
> Created with:
>   gclient setdep -r src/third_party/perfetto@65ae74030114
> 
> The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> TBR=perfetto-bugs@google.com
> 
> Change-Id: I0b937a9c68f5a53520346ebd55acde0deae0ce81
> Reviewed-on: https://chromium-review.googlesource.com/c/1461137
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#630372}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com

Change-Id: Ic4ba39ab4e64dd837f51406a25272e88e8c92a0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1461187Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630391}

- Detects errors where entry write data call fails. In that
  case, deletes the entry.
- Detects bad entries while reading and signals them with an
  invalid response time.

Bug: chromium:719172
Change-Id: I3c977f9d2e2869c4dee6c83d45bc9d98cb9c0e93
Reviewed-on: https://chromium-review.googlesource.com/c/1459523Reviewed-by: Mythri Alle <mythria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630390}

This is a reland of 9a0ad6e5

Original change's description:
> Adds AssistantNotificationView.
>
> This view provides the UI for in-Assistant notifications. Currently the
> labels/buttons for this view are stubbed in but a follow up CL will wire
> this view up to actual mojom::AssistantNotifications.
>
> Screenshot: http://shortn/_MYjBlqDoku
>
> Bug: b:118654460
> Change-Id: I1a436c33466aff9db0c92595a988170c99456e0f
> Reviewed-on: https://chromium-review.googlesource.com/c/1453547
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630144}

Bug: b:118654460
Change-Id: I5ae70eb608697c3a41b34efdc2acec2a21342bdc
Reviewed-on: https://chromium-review.googlesource.com/c/1460314
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630389}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b8e007d8..311f25ab

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9b7bb5d9869da03f100cf399be23293d249b7ce6
Reviewed-on: https://chromium-review.googlesource.com/c/1460857Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630388}

Files moved from chrome/ to content/, this copies previous OWNERS
to reduce load on content/ owners.

Change-Id: Iefeb682e8377e53c64100256e40947347a6cb97a
Reviewed-on: https://chromium-review.googlesource.com/c/1440345Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630387}

Using wpt-import in Chromium fd3240ae.
With Chromium commits locally applied on WPT:
c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html."
14c11107 "Implement `Sec-CH-Lang`"
c49d046d "Initial support for WorkletAnimation.playbackRate"
70938d55 "Fix remaining preload tests flaking on wpt.fyi"
af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads"
6ffd17ac "[Background Fetch] Fix flaky WP test that's timing out."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox
dcheng@chromium.org, palmer@chromium.org:
  external/wpt/domxpath
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
igrigorik@chromium.org, yoavweiss@chromium.org:
  external/wpt/preload
jfernandez@igalia.com:
  external/wpt/css/css-align
kojii@chromium.org:
  external/wpt/css/css-writing-modes
meade@chromium.org:
  external/wpt/web-animations
mkwst@chromium.org:
  external/wpt/mixed-content
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: Ic62fb479cb96769dde36ad727596aafa55e4c8e4
Reviewed-on: https://chromium-review.googlesource.com/c/1460862Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630386}

The parser for OWNERS files seems to get upset about '@' symbols in
comments. See
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8922070423035272912/+/steps/presubmit/0/stdout

Change-Id: I4d6c4782e9c077b42502c423832e84cea8583b4e
Reviewed-on: https://chromium-review.googlesource.com/c/1461219
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#630385}

Bug: 928772
Change-Id: I8d939e8b6803c4d67b4cc24f19e47b695f84400e
Reviewed-on: https://chromium-review.googlesource.com/c/1460073
Commit-Queue: Sky Malice <skym@chromium.org>
Auto-Submit: Sky Malice <skym@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630384}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1dbb0c6184f..78f6491898f6


Created with:
  gclient setdep -r src-internal@78f6491898f6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I06853fb1edd67eb548f3f49252ae69da809f9b49
Reviewed-on: https://chromium-review.googlesource.com/c/1461138Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630383}