- 07 Sep, 2018 40 commits
-
-
Maksim Sisov authored
This patch makes use of new minigbm APi names, which are aligned with Linux libgbm. Also, it defines certain definitions, which are different between libgbm and minigbm. What is more, it adds USING_MINIGBM for internal usage to be able to distinguish between system linux gbm and minigbm. Last but not least, drmPrimeHandleToFd is used in case of linux system libgbm in order to be able to get mappable fds per each plane, which is neede to add GpuMemoryBuffers support. Bug: 869206, 578890, 820047 Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585 Reviewed-on: https://chromium-review.googlesource.com/1158234 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#589475}
-
Uladzimir Miniailau authored
AddIE7PasswordInfo method and LoginsTable should also be deleted. I will do it in the following changes. Bug: 456119 Change-Id: I581fd88bc1fa9bf35d0484616be9d69e939e69ef Reviewed-on: https://chromium-review.googlesource.com/1174729Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#589474}
-
Daniel Bratell authored
Jumbo is the Chromium implementation of a Unity build system aimed at dramatically lowering the compilation times, especially for those without access to goma. In reference testing, this patch reduces the effort to compile content_shell+chrome+blink_tests by about 9 CPU minutes, 1-2% of the total effort. Earlier patches saved more so the total build effort reduction in //ui is about 41 CPU minutes. There is still some code in ui that doesn't use jumbo. Specifically most of the tests. Bug: 773275 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie59fec4b67fc1e3d6855d04a4b9a1088e0a08768 Reviewed-on: https://chromium-review.googlesource.com/834348Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589473}
-
Mihai Sardarescu authored
The feature kRemoveUsageOfDeprecatedGaiaSigninEndpoint was enabled by default in M62. This CL removes the feature flag and all the code that use it. In a subsequent CL we will also remove the GaiaUrls::deprecated_client_login_to_oauth2_url() (here https://cs.chromium.org/chromium/src/google_apis/gaia/gaia_urls.h?rcl=461cbc77709a44135a9c9fce4ac2e4d81a7cb1cb&l=44) as that should no longer be user either. Bug: None Change-Id: I0d5534472e56c7276a1ce57503e992e652068ebc Reviewed-on: https://chromium-review.googlesource.com/1210265 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#589472}
-
Fredrik Söderquist authored
Rather than converting an int argument to a float in the function (that return a FloatRect), pass a float argument and let the caller handle a conversion (if needed.) Bug: 881188 Change-Id: If3083fc19c866f003b0d60e10246b3088463dcdd Reviewed-on: https://chromium-review.googlesource.com/1209923Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589471}
-
Mike West authored
Bug: 787905 Change-Id: I2248173947ed87ff3e8f40dc86a8e9044ed2dd3b Reviewed-on: https://chromium-review.googlesource.com/966442 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589470}
-
Yuki Shiino authored
This reverts commit a11e3884. Reason for revert: Suspicious to have broken viz_browser_tests and webui_polymer2_browser_tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7689 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936081737798843840/+/steps/viz_browser_tests/0/logs/CrSettingsMultideviceFeatureToggleTest.All/0 Original change's description: > [CrOS MultiDevice] Settings UI A11y labels. > > > Bug: 876796 > Change-Id: Ie369384f218fde83ae03f21add99c0573ab97912 > Reviewed-on: https://chromium-review.googlesource.com/1211915 > Reviewed-by: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589397} TBR=hcarmona@chromium.org,jlklein@chromium.org,jordynass@chromium.org Change-Id: Ife1c75063e197a32142604f3f05c964910721079 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876796 Reviewed-on: https://chromium-review.googlesource.com/1212212Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589469}
-
Mark Cogan authored
This CL adds metrics to track: - Use of the new Close All and Undo Close All controls. - Use of interactive tab grid reordering. Bug: 880845 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I822044ea7bd1065a987d50dd03842662fa618a41 Reviewed-on: https://chromium-review.googlesource.com/1206433Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#589468}
-
Maksim Sisov authored
Instead of blindly using a fake presentation feedback result, use the wayland provided one if available. If not, pretend there is a feedback, but provide a faked one. In order to provide feedback, the callback, which comes from the GPU, is stored in the Buffer instance. Although, both frame and presentation feedback are setup, the frame callback always comes first. Thus, we store the result and once the feedback comes, we use the previous swap result and the presentation feedback to let the GPU know the status of the request. Bug: 859012 Change-Id: I4f4628be6101149daa30b6c74f3490254ace0fad Reviewed-on: https://chromium-review.googlesource.com/1193883 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589467}
-
Pin-chih Lin authored
Initial config has both profile and H264 level now, we then apply the configuration by passing to H264 encoder class for VAVEA, and setting up v4l2 controls for V4L2VEA, rather than using fixed profile and level in the past. According to H264 spec, there are limitations for framerate/bitrate/framesize combinations as the requested level, and we may want to fail initization for excessive configuration. For VAVEA, we add the check on H264Encoder::Initialize(). For V4L2VEA, we will let driver judge the legality on configuration. In video_encode_accelerator_unittest, a new property requested_h264_level is added to test_stream to specify requested level, and ForceH264Level test for checking output level meets expectation. BUG=863327 BUG=865302 TEST=build, deploy Chrome, and run video_encoder_accelerator_unittest on Eve TEST=build, deploy Chrome, and run video_encoder_accelerator_unittest on Elm Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I003a4f5c1c8ef149ace3dd2ad18aebd84f60dd0c Reviewed-on: https://chromium-review.googlesource.com/1209883 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589466}
-
Daniel Bratell authored
A commit just introduced a second g_id_map in ui/views/cocoa, which broke jumbo builds. This renames the g_id_map globals to the longer names g_id_to_impl_map and g_id_to_host_impl_map. Bug: 859152 TBR=ccameron@chromium.org,ellyjones@chromium.org Change-Id: Id30d71b67f4bfb7c3ddc3ec8d03c759b5b7df14f Reviewed-on: https://chromium-review.googlesource.com/1212862Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589465}
-
Matthew Cary authored
webkit_layout_tests will fail if there is a non-ascii character in the stack dump. This CL encodes the stack dump to avoid that. Very probably there is some other problem that is causing the stack to contain non-ascii characters, but at this point we can't even tell what's the problem due to the crash (see the bug for details). Bug: 880246 Change-Id: I34c5582cc2d4bd98fb17053336e9084624df52a5 Reviewed-on: https://chromium-review.googlesource.com/1204015Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#589464}
-
Fredrik Söderquist authored
This implements initial values for SVGAnimatedInteger properties (which includes SVGAnimatedIntegerOptionalInteger since it is a reverse proxy for the former.) Bug: 225807 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0563b6cfe4dc22b08ed04ab508faf4fb9491b5b4 Reviewed-on: https://chromium-review.googlesource.com/1209743 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589463}
-
Brandon Wylie authored
Change-Id: I7af13ac123280be7b4b89a3b05918e2b8ea96ce3 Reviewed-on: https://chromium-review.googlesource.com/1208819Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589462}
-
Anders Hartvoll Ruud authored
The most important use case for css-properties-values-api is having typed (and possibly interpolated) custom properties in paint worklets. So naturally, this is the *least* well tested use case in WPT. This CL improves that by adding tests for most of the syntax types. The test works as a kind of "ref" test, which compares the output of CSSStyleValue.parse /parseAll with the value observed inside the worklet. <transform-function> and <transform-list> are not supported yet, so they will come later. Interpolations should also be tested, but that belongs in a separate test. Bug: 641877 Change-Id: I4bd310ecd61a2a8989df9c4a5c818cdc7c179b3a Reviewed-on: https://chromium-review.googlesource.com/1209711 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#589461}
-
Yutaka Hirano authored
This is a reland of 0af66703 Original change's description: > Remove cors:: namespace specifier in the namespace > > Bug: None > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib487fee40beaac941b74c090d31133b12d61ea4a > Reviewed-on: https://chromium-review.googlesource.com/1203517 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589158} Bug: None Change-Id: Ibfeafc088e016153ff3c3b6278107f62f2bdb710 Cq-Include-Trybots: luci.chromium.try:linux_mojo Tbr: toyoshim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1212428Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589460}
-
Clemens Hammacher authored
If a worker terminates while a wasm finisher task is scheduled, we try to cancel that task even though the platform already deleted it. This results in UBSan failures, ASan failures or crashes. The bug itself is fixed on the v8 side in https://crrev.com/c/1209344, but the test needs to be a layout test, thus on the chromium side. R=ahaas@chromium.org Bug: chromium:875579 Change-Id: I98f19869044299801eb521d97f417b403ca356c0 Reviewed-on: https://chromium-review.googlesource.com/1209602Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589459}
-
Kenichi Ishibashi authored
ServiceWorkerNavigationLoader is responsible for setting up LoadTimingInfo which are used to create web-exposed PerformanceResourceTiming. Specifically, the field |send_start| in LoadTimingInfo is populated as `requestStart` in PerformanceResourceTiming. The resource timing spec[1] doesn't state explicitly but according to a spec discussion[2], following ordering would be reasonable: workerStart <= fetchStart <= requestStart Before this CL, ServiceWorkerNavigationLoader recorded `requestStart` before starting a service worker, at the same time `workerStart` is recorded. This doesn't seem a good timing because `requestStart` would be less than `fetchStart`, which is recorded after the service worker is started. This CL moves the timing to record |send_start| (and corresponding |send_end|) to the time the service worker is started. Note that web-exposed `fetchStart` still doesn't follow the above ordering even after this CL, as we have a special case code for `fetchStart` in navigation. A follow-up CL will address `fetchStart` case. The wpt service-workers/service-worker/navigation-timing.https.html should cover this change. [1] https://w3c.github.io/resource-timing/#sec-performanceresourcetiming [2] https://github.com/w3c/resource-timing/issues/119 Bug: 782958 Change-Id: I339d41d8c93a2cbcd053d4348d8e0f51b1134925 Reviewed-on: https://chromium-review.googlesource.com/1212423Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589458}
-
Maksim Sisov authored
Instead of just assuming buffer is committed, use wayland provided frame callbacks. Once the GbmSurfaclessWayland (resides on the GPU process side) requests to swap buffers from Wayland (the connection is established on the browser process side), it sends a ScheduleBufferSwap requests and provides a completion callback, which is then triggered once Wayland sends a frame callback (setup for each new buffer swap). This callback is then used to identify if the swap was successful or not. Bug: 859012 Change-Id: I3264db6bb4456ef610d11945199ecddffbc23024 Reviewed-on: https://chromium-review.googlesource.com/1193882 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589457}
-
Jinsuk Kim authored
This CL rewrites WebContentsUserData using org.chromium.base.UserData. There should be no functional change. WebContentsUserData is deleted. Bug: 877878 Change-Id: Ib8f5b2267bf9d21f84661d2e747d8a6c9c1d9d66 Reviewed-on: https://chromium-review.googlesource.com/1189584 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589456}
-
Alan Cutter authored
This CL fixes a bug where permission prompts and page info dialogs go off screen when hosted app windows are maximised. This only affects platforms that don't support bubble anchor adjustment (see calls to set_adjust_if_offscreen(false) in BubbleDialogDelegateView::CreateBubble()). These platforms are Linux, Mac and Windows 7 with Aero disabled. This patch fixes the issue by making permission and page info dialogs anchored off the app menu use TOP_RIGHT instead of TOP_LEFT for their arrow position leading the bubble to position itself within the main window's bounds by default. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355950&signed_aid=ziHkOFUJALIjs_7uaUaPtQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355951&signed_aid=9B2p0GLHiuHOMC-Ha-rXBQ==&inline=1 Bug: 877032 Change-Id: I98b1fe1e4fe8018886ae960c8601f5d518c9ea5e Reviewed-on: https://chromium-review.googlesource.com/1201507 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589455}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1220339..104cb056 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6e3006420aa1afdcb60de363d4d5029e7f16750 Reviewed-on: https://chromium-review.googlesource.com/1212745Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589454}
-
Joel Einbinder authored
Change-Id: Ib45039f33313e2fe950967d6ad2b9d2ee956bf81 Reviewed-on: https://chromium-review.googlesource.com/1199966Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#589453}
-
Kuo-Hsin Yang authored
Upload the keyboard property file for keyboard emulator to remove the dependency to /usr/local/autotest/cros/input_playback/keyboard.prop. Bug: chromium:881240 Change-Id: I65daf0326d9237ac5a904f2966be4e95c6f8e210 Reviewed-on: https://chromium-review.googlesource.com/1209135 Commit-Queue: Vovo Yang <vovoy@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#589452}
-
Adam Rice authored
The are no unencodable characters in UTF-8, however previously callers to blink::TextCoder::Encode had to pass a dummy UnencodableHandling argument. Add a kNoUnencodables value to the UnencodableHandling which is an explicit no-op. Also add DCHECKs that is is only used for UTF-8 or UTF-16. Convert callers to use kNoUnencodables where the encoding is statically known to be UTF-8. It's still valid to use other values for the UnencodableHandling argument with UTF-8 or UTF-16; kNoUnencodables simply documents that it makes no difference. Change-Id: I5eebe4c76ae4006ee91f3884f94ec3b5e410685b Reviewed-on: https://chromium-review.googlesource.com/1206055Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589451}
-
Findit authored
This reverts commit e7492cbb. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 589442 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U3NDkyY2JiM2M4N2MxNWE3YTE3YjlkMjI4YTcyNmE4ZTYxNTEzMWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/40795 Sample Failed Step: compile Original change's description: > CrOS FilesApp: refactor strings to allow reuse in tests > > Created static FileManagerPrivateStrings::GetStrings() which is called > by fileManagerPrivate.getStrings() extension function, and can now also > be called by utility executable to generate strings.js file for > testing rather than having strings duplicated. > > Bug: 813477 > Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2 > Reviewed-on: https://chromium-review.googlesource.com/1208993 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589442} Change-Id: I4b29ee18d2a663e08108aaf796bcae2aa0728d9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 813477 Reviewed-on: https://chromium-review.googlesource.com/1212486 Cr-Commit-Position: refs/heads/master@{#589450}
-
Josh Pratt authored
This allows CrostiniManager to handle states where a VM hasn't finished starting/stopping fully. BUG=880165 Change-Id: Ia94bf4059c4bfbf41c3fe920873fa7c8bc2aea18 Reviewed-on: https://chromium-review.googlesource.com/1212206Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#589449}
-
Stuart Langley authored
This is a speculative fix for crash in drive::FileSystem::OnTeamDrivesChanged, that appears to be caused by passing an invalid iterator to map.erase(). The change uses the key rather than in iterator, which will not crash if the key is not present. We have test coverage for this code path, but the fake_drive_service does not support us triggering this issue, which I think it a race between loading the initial list of team drives and processing the users first change list. Instead I added a unit test to ensure that removing a team drive id that is not in the map will not cause a crash. Bug: 881679 Change-Id: I16f71f7984b5d4f7fed4cb9e939824fac1c813e8 Reviewed-on: https://chromium-review.googlesource.com/1212371 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589448}
-
Kyoko Muto authored
Currently the Runtime flag is setted as test, change it experimental instead for the test in local. Change-Id: I633fc63720022214e4857395763843db9c1d578a Reviewed-on: https://chromium-review.googlesource.com/1212203Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kyoko Muto <kymuto@google.com> Cr-Commit-Position: refs/heads/master@{#589447}
-
Yutaka Hirano authored
This is a reland of bd27fde7 Original change's description: > FetchManager should not set "referer" HTTP header > > Instead it should use ResourceRequest::SetReferrerString and > ResourceRequest::SetReferrerPolicy. > > Bug: 863769 > Change-Id: I4de47bae9aa259ace5ffb5bbdd17d6cf423931d7 > Reviewed-on: https://chromium-review.googlesource.com/1203474 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Dominic Farolino <domfarolino@gmail.com> > Cr-Commit-Position: refs/heads/master@{#589159} Bug: 863769 Change-Id: Ie01801ef1ab7adec166832511539b19b707ab220 Tbr: domfarolino@gmail.com Reviewed-on: https://chromium-review.googlesource.com/1212208Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589446}
-
Artur Khachatryan authored
Adding searching for Chrome binaries in the system PATH as well. bug: chromedriver:2550 Change-Id: I42c3ad1618e324c964e9b420b2399ce5c8039dab Reviewed-on: https://chromium-review.googlesource.com/1211744 Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589445}
-
Shao-Chuan Lee authored
Enables other components to depend on this file instead of the entire ARC library for UMA recording. Required for upcoming change in //ash/system/message_center/arc:arc to record user interactions to UMA. Bug: 862001 Change-Id: I3100879344a95313963e9b2bf1861a8f8206a416 Reviewed-on: https://chromium-review.googlesource.com/1212429Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589444}
-
Xianzhu Wang authored
This reverts commit 91779560. Reason for revert: The layout object to paint text clip might not be LayoutBlock. Bug: 881644 Original change's description: > [PE] Support float, block, table descendants for background-clip:text > > In https://chromium-review.googlesource.com/c/chromium/src/+/1197462 > we changed box_model_.Paint() to LineBoxListPainter so we no longer > supported text clip for descendants other than inline contents. > > This CL calls ToLayoutBlock(box_model_).PaintObject() to support text > clip of other descendants, and still avoid the original double paint > offset issue of box_model_.Paint(). > > Bug: 880825 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I2c4b0e23df11bf300c01f9c804fb7e7d129f3aa0 > Reviewed-on: https://chromium-review.googlesource.com/1211244 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589314} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Id26f9f690884300fceb4bdaf3e4f3fb2aad4fc04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880825 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1212483Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589443}
-
Joel Hockey authored
Created static FileManagerPrivateStrings::GetStrings() which is called by fileManagerPrivate.getStrings() extension function, and can now also be called by utility executable to generate strings.js file for testing rather than having strings duplicated. Bug: 813477 Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2 Reviewed-on: https://chromium-review.googlesource.com/1208993 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#589442}
-
Nicholas Verne authored
It is possible for Crostini apps to be disallowed by policy. This can change at any time for a give machine, so we always need to check. While the pinning bug is still happening, we also need this as a failsafe. Bug: 881681 Change-Id: I2e2497ef9cdaee7f989d38931a88886d52535cf9 Reviewed-on: https://chromium-review.googlesource.com/1212373Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#589441}
-
Rakina Zata Amni authored
Adds a new level of "invisible" attribute: "static", which prohibits custom element upgrade inside invisible-static subtree unless authors explicitly call CustomElementRegistry.upgrade() See design doc at https://goo.gl/sEJt3e I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Icw_sU6PqVA/8hwXw0jTDwAJ Bug: 873057 Change-Id: I5c2a88446ca3a758b28917fcae349c5cdadd0132 Reviewed-on: https://chromium-review.googlesource.com/1204373Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589440}
-
Nicholas Verne authored
Tremplin now sends a signal indication percent downloaded for a container. This is bounced to the appropriate observers (in this case, the CrostiniInstallerView). The install progress bar now indicates install progress based on download percent and estimated time for each stage. Bug: 860094 Change-Id: Iaa4dfe3464e30931d8ae1fce15a46f2d5ffbe7b5 Reviewed-on: https://chromium-review.googlesource.com/1201647Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#589439}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea8b6f95c763..7cd2a9514837 git log ea8b6f95c763..7cd2a9514837 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 buildbot@webrtc.org Roll chromium_revision 450316ff..d03e9be2 (589248:589368) 2018-09-06 emircan@webrtc.org Multiplex codec cleanups 2018-09-06 peah@webrtc.org AEC3: Parametrize the delay estimator to leverage strong echo paths 2018-09-06 benwright@webrtc.org Updated FrameEncryptorInterface and FrameDecryptorInterface with status code. 2018-09-06 sukhanov@webrtc.org Interface for media transport 2018-09-06 buildbot@webrtc.org Roll chromium_revision fcd25fc0..450316ff (589073:589248) Created with: gclient setdep -r src/third_party/webrtc@7cd2a9514837 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium: 880686,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I056a13c149b75fb27ccef3358e6fdbac8f772e85 Reviewed-on: https://chromium-review.googlesource.com/1212563Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589438}
-
Trent Apted authored
The //ui/file_manager/common/js:util target has a dependency on the file_manager_private extern. Break out that extern to a separate target to bundle its hidden dependencies together, since multiple things depend on it. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icfa65dff5c692b6bd415f9f2d5c67b14a0db0ef6 Reviewed-on: https://chromium-review.googlesource.com/1212706Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589437}
-
Alan Cutter authored
Change-Id: I35304eb77e8e09d971b1854416c121bc5ec0935e Reviewed-on: https://chromium-review.googlesource.com/1212369Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#589436}
-