- 02 Sep, 2020 40 commits
-
-
Ryan Harrison authored
BUG=dawn:521 Change-Id: Ic2a3b500a5c9f752a871d3f25ad4b3cc4921b0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391609 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#803977}
-
Joe DeBlasio authored
Change-Id: Id6db3f20f6ff8914b4b840851323c2f6ad342bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388947 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#803976}
-
Sophey Dong authored
Bug: 1112281 Change-Id: I549d1cd20e78245c4df973b42bba3666c53881a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383451 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#803975}
-
Samuel Huang authored
This CL modifies lacros_resource_sizes.py to compute total files sizes and total compressed sizes. Compression relies on gzip as an external tool. Also add tracking for WidevineCdm/ directory. Bug: 1106626 Change-Id: I84ac09b4f66f8f55bb1869e2917cdaa60ef4bf03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390877 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803974}
-
evliu authored
The Speech team recently made a change to the Speech On-Device API to take in a path to the language pack directory rather than a path to the dictation.ascii_proto config file. The getdents() syscall is required for SODA to select the appropriate config file to use. Bug: 1124367 Change-Id: I9265d7f178d85bb9cb0fea8175878d4db6f26dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390879Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#803973}
-
Marijn Kruisselbrink authored
Rather than storing a GURL and resolving that to a FileSystemURL on read, this instead stores the resolved FileSystemURL. All callsites already resolve the GURL beforehand anyway. This also makes it possible to create blobs from FileSystemURLs that don't serialize properly as GURL. Bug: 1093653 Change-Id: I09a8836cab9e84f20fc4f4c16fa4b92730150398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363318 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#803972}
-
Michael Sun authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ded752ca0c0b..8152eec38dd1 $ git log ded752ca0..8152eec38 --date=short --no-merges --format='%ad %ae %s' 2020-07-10 pbond arc-data-snapshotd: initial commit 2020-07-18 kdgwill system_api: Add a new signal DBus service constants for CfM Broker 2020-08-25 charleszhao ml: add DlcClient in mlservice. 2020-08-13 fletcherw lorgnette: multi-page scanning support 2020-08-10 alanlxl federated: Skeleton daemon D-Bus handler and make a service 2020-08-19 dtor system_api: add command to send Parallels problem reports 2020-08-26 sonnysasaka system_api: Add powerd RefreshBluetoothBattery method constant 2020-08-25 fletcherw system_api: build lorgnette goprotos 2020-08-12 fletcherw system_api: add multi-page scan API to lorgnette Created with: roll-dep src/third_party/cros_system_api Bug=b:166530001 Change-Id: I453d185fe65b26cda8411f9a22184edda110b7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390949 Commit-Queue: Michael Sun <michaelfsun@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#803971}
-
Mike Dougherty authored
Bug: 1122059 Change-Id: Id9644b9dff7e9854f20218f09750fbf191d5a318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378274 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#803970}
-
Dana Fried authored
Bug was uncovered by fixing another bug that caused repeated, expensive browser layouts. Because the browser wasn't constantly laying out, the "Press %^F to exit fullscreen" prompt did not have its position immediately updated on being shown, and was using a stale position calculated before the browser moved to fullscreen. This was exacerbated on Mac by the fact that showing windows is asynchronous, so while on other platforms there was a layout pass as the browser was resized to fullscreen that repositioned the window, an explicit visibility check on Mac failed and that code was never run, plus the fact that the zoom-to-fullscreen animation on the Mac is fairly slow. This CL changes the logic (on Mac only) so that the position of the "toast" bubble is updated even if the widget is not yet visible, as long as the animation is playing or has played towards the "shown" state (i.e. the value of the SlideAnimation is greater than zero). Bug: 1122467 Change-Id: I0a962b52d7a7531dc7bc77748efc82877b62d05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389263Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#803969}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If75c5cccb317d7fe275265d0362b7283dfb36816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391267Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#803968}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/121d985642fd..6b2639b023f9 2020-09-02 jonahr@google.com Workaround to disable OES_get_program_binary 2020-09-02 syoussefi@chromium.org Gracefully fail end2end tests if no window support 2020-09-02 sugoi@chromium.org Revert "Make copyTexImage2D robust when source area is out of bounds" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1034840 Tbr: cwallez@google.com Change-Id: I9e81e85a97607e54f990511638fe9a7a2a3a9b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803967}
-
Anatoliy Potapchuk authored
As a part of simlification of AccessibilityControllerImpl, we should remove calls related to the feature dialogs being accepted, since they can be done via new Feature class logic. Bug: 1051892 Change-Id: Ifd4cdde356ec5b4caa195b7eb83a403e54dab7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390184Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#803966}
-
Chris Lu authored
Normally, when the active WebState is being changed with a presenting Overlay, the overlay's request will still be in the queue. However, When multiple tabs are being simultaneously opened, there will be a situation where the "last" active WebState has no requests, even though presented_ in OverlayPresenter is true because the original presenting overlay is still finishing its dismissal. There is an assumption in SetActiveWebState() that if presented_ is true,then there is an overlay in the queue to dismiss. In this situation, which occurs in Popup Infobars often, that is not true. Bug: 1121755 Change-Id: I45829c8abe81283cbc52a8c61acc5c9ecd17c8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382425 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#803965}
-
Anatoliy Potapchuk authored
There are some flaky test failures fixing of which that would benefit of having profile loading log line visible. Bug: 1015383 Change-Id: I4a9703411cdd19b89ca095f2625aa1ae05fba732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391060 Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#803964}
-
Christopher Cameron authored
Some WebGPU ImageBitmap helper functions use CanvasColorParams to determine the pixel format and color space of an ImageBitmap. But ImageBitmap already has a SkImageInfo, which specifies these things. So we're specifying the same thing twice, in two potentially incompatible ways. Remove one. Bug: 1119507 Change-Id: Iadeedb9bb09831d69e6012763eb5039cd8840a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373450Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#803963}
-
Patrick Noland authored
Bug: 836689 Change-Id: I0cf38c5048ea33260131690a2fd006a076da3dc6 TBR: qinmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391382 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#803962}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3ccd13ca. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I8335c11e3f59ea784517bf5234b14795d6dcbbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390543Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803961}
-
Sunny Sachanandani authored
This is a reland of b71115a3 Relanding after triaging Gold failures on gpu.fyi bots in previous attempt. Original change's description: > media: Use GL_UNPACK_ROW_LENGTH for software planes stride adaptation > > Avoid a CPU side copy to account for mismatched strides between the > decoded video frame and GPU texture created for uploading the frame. > GL_UNPACK_ROW_LENGTH allows specifying the stride for glTexSubImage2D, > and is part of the GL_EXT_unpack_subimage extension implemented by the > command buffer on the client side. > > Also includes a pixel test with a VP8 video with a GL incompatible > stride that doesn't match the video's coded size (992 vs 962). > > Bug: 1077211 > Change-Id: I62753234bde3b92e64089c92a59e65ae2bc1c84c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386671 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803696} TBR=dalecurtis@chromium.org,zmo@chromium.org Bug: 1077211, 1124215 Change-Id: I43a97e72cdd0ba633d4b374a2319fbc7dc7252f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390958Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#803960}
-
Mustaq Ahmed authored
Bug: 1122371 Change-Id: I494aaa813faa6138c40629d567ebc0332a1047de TBR: dtapuska@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382068Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#803959}
-
Marijn Kruisselbrink authored
This deletes a bunch of old code that is no longer needed. Bug: 1121673 Change-Id: Ie5fccd67aaa989d9011018a14315c5f18c8a452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376365Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#803958}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26be5f68f929..8584a9dfb946 2020-09-02 jleconte@google.com Make ReadValue quest process proto file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1123318 Tbr: nuskos@google.com Change-Id: I6f9ba2492f5583600ca6f038352980c796238e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391360Reviewed-by:
-
Ben Joyce authored
Bug: 1096591 Change-Id: I085c379c4189b3ed71943edeffa53aa4bf1cb10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385818Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#803956}
-
Shengfa Lin authored
Add parsing webSocketUrl for connection Bug: chromedriver:3588 Change-Id: I39fc933fcf8cfc2a7ff14c7fbf65fa3f1ba832b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389053 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803955}
-
yiyix authored
There is lots of magic number 4 in the image_data.cc. in fact, we are using 4 to represent that there are 4 color bit to describe each pixel, namely, red, green, blue and alpha. Add a class level comment to describe what 4 means in image_data.cc. Bug: 1122866 Change-Id: I728ea5fadba3bc7f7477dbbdd35aa180872beb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379656Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#803954}
-
Anastasia Helfinstein authored
This change renames NodeWrapper to BasicNode for increased clarity. This is a pure refactor. AX-Relnotes: n/a. Bug: None Change-Id: I86302cbfbaf76ee33c9f2672c4a92b4c424f081c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388772Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#803953}
-
Daniel Classon authored
Adds deep links to the Languages Page, as well as the old Language subpage, Language V2 subpage, Input subpage, and Smart Input subpage. Bug: 1084154 Change-Id: Ib00b78e0d5e1a7a7d832864894c6f76f364328e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386433 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803952}
-
W. James MacLean authored
More tests that are flaking on Win7 32. TBR=dschuff@chromium.org Bug: 1059468 Change-Id: Iae2f5d10b0e2e36ef6487d7e20d34e626111993e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391171 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#803951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/90b027a36b4c..4ef21edffb35 2020-09-02 robertphillips@google.com Split creation of integral table out of GrRectBlurEffect 2020-09-02 johnstiles@google.com Disallow inlining ternary true/false branches. 2020-09-02 johnstiles@google.com Add unit tests for the inliner. 2020-09-02 mtklein@google.com skvx spring cleaning 2020-09-02 robertphillips@google.com Split up find_or_create_rrect_blur_mask_fp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: michaelludwig@google.com Change-Id: I10e3e19996db88b57403f6fad6d0722e0f20dc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390985Reviewed-by:
-
Toni Barzic authored
This reverts commit crrev.com/c/2181825 in order to fix a tooltip bug on certain multi-mon setups on Windows. This is not an automatic revert because subsequent changes required a bit of editing to undo the change. Manual testing shows that this fixes the multi-mon variable-DPI tooltip issue, but regresses bug 1053938. Bug: 1108833, 1053938 Change-Id: I39b9a013ad82c79b2e3cb263e380ad9f3e65554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380252 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#803949}
-
Mike Dougherty authored
web::test::HttpServer has been deprecated in favor of using net::EmbeddedTestServer directly. A new::EmbeddedTestServer is already exposed in ChromeTestCase subclasses as |self.testServer|. It is important to stop using web::test::HttpServer in ChromeTestCase because many of these servers are being created and never stopped. Additionally, many tests don’t require the use of the server at all. In order to support tests which still require the use of this server, starting and stopping the server has been moved to a specialized subclass, WebHttpServerChromeTestCase. Bug: 891834, 1121576 Change-Id: I6722b1c75140dd5ac5baffb88489fa6f6af85a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380744 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#803948}
-
Ben Mason authored
TBR=agrieve@chromium.org Bug: 1123319 Change-Id: Ib60d02dd820e2f60a9ab6b7f9f0380b4af839d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390863 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
-
ckitagawa authored
This CL expires old captures after 72 hours in order to allow for previews to be reasonably current. Bug: TODO Change-Id: I0c86c928dc73564e3721d4d8f79b8b7693931619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386223Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803946}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b7642c19404f..3ffd1d826be3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I993c58e22e3b1e0f8732ce999494e751e651dcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390946Reviewed-by:
-
Ben Pastene authored
This reverts commit 5159cfc6. Reason for revert: spec revert for crbug.com/1124142 There are "MojoResult(3): INVALID_ARGUMENT" errors in a CrOS ARC test after this landed. Original change's description: > Remove unused methods in std::string StringTraits > > IsNull and SetToNull aren't needed as the STL string type doesn't use > nullable_is_same_type. > > Change-Id: I0770b42e275e3026749c5409015c4b79941ea56f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386744 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#803654} TBR=rockot@google.com,hferreiro@igalia.com Change-Id: I63114a22d365c1b4c8c8f79f4678e975d7f6c589 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391044Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#803944}
-
Weilun Shi authored
Add instructions for how to use shorthand to set variant's summary attribute. Change-Id: I5233dadd21c60f5c354e70d814f613e5f1f8c27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388911 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#803943}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, search chip properties might be set on IPH cards in the Grid tab switcher, and triggers an assertion error. To make debugging easier, the content dump of the offending model is added to the error message. Bug: 1076546 Change-Id: I8bf110050226a8462881fba069632a5e9380672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363773 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#803942}
-
Jeroen Dhollander authored
During shutdown this pointer might become dangling. Instead, we fetch the value through |AssistantInteractionController::Get()| whenever we need it (and check to ensure it is not nullptr). I also checked if we need to protect the |IdentityManager*|, but that should be safe as |BloomController| is created together with |Service| (*), which also contains a pointer to |IdentityManager|. (*) Here: http://shortn/_l71GCzVgX3 Bug: b/165356952 Tests: compiled Change-Id: I9e1e9ed83db9a42221e1c2f0e0f3dbe14a33e0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372591 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#803941}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /base/security_unittest.cc This CL was uploaded by git cl split. R=jln@chromium.org Bug: 1110266 Change-Id: I2e4b59b6cfb69c0638f7effb5e5d5e8f79e49f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371211Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803940}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a62890115c98..bef95c091b2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073476,chromium:1124242 Tbr: wjmaclean@google.com Change-Id: I9528ef12c1410b078dccf1b73d04513b2a8b1308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390983Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803939}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkConfigInputTest* Change-Id: I2cd588e70a0f7dbb92e4550ee7f0365368abbbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388988 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
