- 29 Jul, 2017 40 commits
-
-
Julien Brianceau authored
Get a unique implementation in base::test instead of having specific implementations in various places, as suggested by Scott Graham. Bug: none Change-Id: I1ac2186bd5ec0df38bb58189f42fafb7b75acfed Reviewed-on: https://chromium-review.googlesource.com/591428Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Julien Brianceau <jbriance@cisco.com> Cr-Commit-Position: refs/heads/master@{#490656}
-
Gabriel Charette authored
Leaving static MessageLoop::QuitWhenIdleClosure() behind as a mere redirect but flagging it in presubmits so its usage dwindles overtime. R=danakj@chromium.org Bug: 748715 Change-Id: I523c6e598f0de5c9d326ae2764cd6e2502be9cc4 Reviewed-on: https://chromium-review.googlesource.com/586889 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#490655}
-
Oystein Eftevaag authored
A few consequences of this: * To be able to easily tear down all the active CoordinationUnitImpls, the static CU map now owns the CoordinationUnitImpls as unique_ptrs, rather than just holding a raw pointer to them. * Because of the above, client code that creates CoordinationUnitImpls must now explicitly call Destruct() on these. This mainly impacts test code, so I've made a TestCoordinationUnitWrapper which RAII handles this. Bug: 749804 Change-Id: I251c17606c2b055a6a66409681c954cdd76b58d6 Reviewed-on: https://chromium-review.googlesource.com/590700 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#490654}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d30c218d..d4e622d7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I371c2977fd2f8829d2bcb19e1feb52725041bcc1 Reviewed-on: https://chromium-review.googlesource.com/592910Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#490653}
-
Kenneth Russell authored
The associated code has been removed for some time and its continued presence is confusing. BUG=237931 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4c2ed46f7e8882958b6e533633a60f9afe04ce36 Reviewed-on: https://chromium-review.googlesource.com/592713Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490652}
-
Fady Samuel authored
This is a mechanical CL that updates includes, namespaces and forward declarations accordingly. Bug: 722935 TBR: dalecurtis@chromium.org, reed@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0c3da1e0236100487f59b7b8c15f5a94452ac607 Reviewed-on: https://chromium-review.googlesource.com/591777 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490651}
-
Xiaocheng Hu authored
This is a quick fix to crbug.com/745501 that stops trying to extend selection when there is no selection. This may not fix the root cause as we are not sure why we reach there without a selection. This patch is made small to be merged to M61. Bug: 745501 Change-Id: Ib0ff45b71e8850ded6d292bf86859364cdaff299 Reviewed-on: https://chromium-review.googlesource.com/592056Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#490650}
-
Nico Weber authored
This is the only build configuration that still uses libstdc++4.8. Does not affect the simplechrome build (which is what we ship, and which uses a newer libstdc++). Bug: 554841 Change-Id: If8acb3c59445214ba78d6f076cd9698b52a37b59 Reviewed-on: https://chromium-review.googlesource.com/591775 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#490649}
-
Robert Hogan authored
This is a reland of 49ca5347 Original change's description: > Don't truncate inline atomic elements before an ellipsis > > A follow-up to https://chromium-review.googlesource.com/c/539460/, we > need to remember the linebox we added the ellipsis to and only hide > atomic inline elements associated with lineboxes that occur after it. > > Bug: 745867 > Change-Id: Iab6d82b7bdf67c05262f6b0b8eb30415f1cab338 > Reviewed-on: https://chromium-review.googlesource.com/579973 > Commit-Queue: Robert Hogan <robhogan@gmail.com> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490341} Bug: 745867 Change-Id: Iaae3f85525588d97a76946005138f8b85253a713 Reviewed-on: https://chromium-review.googlesource.com/592967 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490648}
-
David Reveman authored
These elements need to be centered to align with profile picture preview. BUG=730031 TBR=stevenjb@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2aeb8b7b7aed8903278a9d8b6cd24d0c8224d566 Reviewed-on: https://chromium-review.googlesource.com/592911 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490647}
-
Nico Weber authored
This reverts commit 517fd5f9. Reason for revert: Speculative; looks like it broke app_list_unittests on cros bots: https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/28588 https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/22655 Original change's description: > Remove hover on icons in launcher > > Changes: > Disable ImageShadowAnimator in fullscreen app list mode so that the icon > will not jump when hovered. > > BUG=748236 > > Change-Id: Iba8c0717f7cdb132a28c4c21eb9add81a652e93a > Reviewed-on: https://chromium-review.googlesource.com/592335 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490526} TBR=stevenjb@chromium.org,weidongg@chromium.org Change-Id: Ida566f754ff80b698c49a3c1ae6d82c0b098d983 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 748236 Reviewed-on: https://chromium-review.googlesource.com/593108Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490646}
-
Nico Weber authored
This reverts commit d7a2d953. Reason for revert: Looks like this broke at least the CFI bot: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20CFI/491 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_CFI%2F491%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPushMessagingBackgroundModeEnabledBrowserTest.BackgroundModeEnabledWithCommandLine%2F0 ./../third_party/boringssl/src/ssl/internal.h:184:10: runtime error: control flow integrity check for type 'bssl::(anonymous namespace)::X25519KeyShare' failed during cast to unrelated type (vtable address 0xffffc815a9ffce5e) 0xffffc815a9ffce5e: note: invalid vtable <memory cannot be printed> #0 0x9aefdf8 in bssl::(anonymous namespace)::X25519KeyShare* bssl::New<bssl::(anonymous namespace)::X25519KeyShare>() third_party/boringssl/src/ssl/internal.h:184:10 #1 0x9aefcb5 in bssl::SSLKeyShare::Create(unsigned short) third_party/boringssl/src/ssl/ssl_key_share.cc:199:37 #2 0x9b0bdbd in bssl::ext_key_share_add_clienthello(bssl::SSL_HANDSHAKE*, cbb_st*) third_party/boringssl/src/ssl/t1_lib.cc:2172:19 #3 0x9b07dc4 in bssl::ssl_add_clienthello_tlsext(bssl::SSL_HANDSHAKE*, cbb_st*, unsigned long) third_party/boringssl/src/ssl/t1_lib.cc:2679:10 Original change's description: > Roll src/third_party/boringssl/src 0e4a448ab..2507d9e70 > > https://boringssl.googlesource.com/boringssl/+log/0e4a448ab8aa66a38593f68d19fa0a2e340833e4..2507d9e7090fcd461f33f3b89bcd56c9a7476a04 > > BUG=none > > Change-Id: I34232babbf1adfdb663142b1f6970ed490b16399 > Reviewed-on: https://chromium-review.googlesource.com/586645 > Reviewed-by: Adam Langley <agl@chromium.org> > Commit-Queue: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490632} TBR=davidben@chromium.org,agl@chromium.org,svaldez@chromium.org Change-Id: I155a5550fa70429a33a85654845b9b87c3f11991 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/593107Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490645}
-
Christian Biesinger authored
This should now be sufficient to allow an initial version of Flexbox-in-LayoutNG! Change-Id: I0c9c5f330e90e85705cdbc3eb0cfb26b24d0fbf3 Reviewed-on: https://chromium-review.googlesource.com/592691 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490644}
-
Christopher Cameron authored
In some instances, rather than update the logic to use the base::Feature instead of the command line switch, simply delete the old logic (especially logic that checks for color correct rendering being enabled). R=holte,hubbe,jbauman TBR=avi (content/ stamp) Bug: 682416 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7dbc0c6151e353e94600ff83d975909b96af9fb4 Reviewed-on: https://chromium-review.googlesource.com/589348 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
ccameron chromium <ccameron@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490643}
-
Tom Anderson authored
This CL removes debian/expected_deps_ia32_jessie and rpm/expected_deps_i386. We no longer do official x86 builds, so the files are unnecessary and only serve as a source of confusion when updating the x86_64 deps files. R=thestig@chromium.org Change-Id: Ie14ba3c314aa82a172bfe20bed4498c1bdb3fdb8 Reviewed-on: https://chromium-review.googlesource.com/592312Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#490642}
-
Christian Biesinger authored
Especially all the ones needed by ComputeLineItemsPosition, in preparation for moving that function to FlexLine. This replaces MainAxisExtent() with LogicalWidth(), because it's simpler to compute and it's only used when !IsColumnFlow(), so they are equivalent. It also moves the available space recomputation into ComputeLinePosition because it doesn't rely on any additional data, and moves out the main_axis_offset computation because it does. Change-Id: Icd18329b113127b464497c0ed3e354ac3de3654a Reviewed-on: https://chromium-review.googlesource.com/592405 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#490641}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5f255298555b..88cac37a87f3 $ git log 5f2552985..88cac37a8 --date=short --no-merges --format='%ad %ae %s' 2017-07-28 dtu [pinpoint] Add --pageset-repeat. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I449a5e8ff4e141e268c8d3930c245733aefffa43 Reviewed-on: https://chromium-review.googlesource.com/592808 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490640}
-
Yuzhu Shen authored
BUG=699569 Change-Id: I98a9f7053742f29473f25ad97b70d519ce337b30 Reviewed-on: https://chromium-review.googlesource.com/592276Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490639}
-
Alexander Alekseev authored
This Cl adds Advanced options menu screen to ChromeOS OOBE. Bug: 709263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8c759981d525f15c8c9b90cb11f5c29d9b813c7d Reviewed-on: https://chromium-review.googlesource.com/591049 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#490638}
-
jdoerrie authored
This change fixes the display of origins with leading numbers by adding an appropriate bidirectional override tag. Bug: 740853 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I662c5505a2043e6ee03ddde2ca8a42c4b6729768 Reviewed-on: https://chromium-review.googlesource.com/585532 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#490637}
-
Marijn Kruisselbrink authored
Move it off the main/worker thread to prevent deadlock when the main or worker thread tries to synchronously read the blob (using XHR or FileReaderSync). Additionally BlobBytesProvider might do blocking file operations, which shouldn't be done on the main thread anyway, so this moves the code to always run on the File thread. In the future it might make sense to have part of BlobBytesProvider on the IO thread with only the file operations on the File thread (matching the old IPC based implementation), but for now doing all its work on the File thread should work just fine. This also required actually exposing a File task runner in blink::Platform. This file task runner is not shared with the file thread in content, but then the content one is only created on demand (for ppapi and MHTML saving) anyway, so in most cases this should not result in extra threads. Also add a virtual test suite to enable FileAPI (blob) layout and WPT tests with mojo blobs, now that creating blobs works. Bug: 740584, 744774 Change-Id: Icc1e22f662dea895e1d1b2f1a1cc79c885e6706e Reviewed-on: https://chromium-review.googlesource.com/565641Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#490636}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2f145bff0b2e..31981ecdcb37 $ git log 2f145bff0..31981ecdc --date=short --no-merges --format='%ad %ae %s' 2017-07-28 ethannicholas fixed a vec2 -> float2 that got missed 2017-07-28 bsalomon Two small fixes from recent changes prepping for std::unique_ptr<GrFragmentProcessor>. 2017-07-28 ethannicholas renamed SkSL types in preparation for killing precision modifiers 2017-07-28 caryclark fix output header in bookmaker 2017-07-28 caryclark bookmaker generated site docs 2017-07-28 egdaniel Add Metal build bot 2017-07-28 bsalomon Add clone methods to unit test GrFragmentProcessor classes 2017-07-28 egdaniel Add placeholder GrMtlTypes in include/gpu/mtl Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ieee54c9ff81cf2aebfc927ddade9efceb4af9690 Reviewed-on: https://chromium-review.googlesource.com/592787Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490635}
-
Leslie Watkins authored
This class listens for changes to default network and host scan cache, and removes Tether notifications when they are no longer relevant. Bug: 738108, 672263 Change-Id: Iba45108e65e82ea60711e6666e89a5faedcd2b57 Reviewed-on: https://chromium-review.googlesource.com/591877 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#490634}
-
Charles Harrison authored
Bug: 747022 Change-Id: I222594af09156a26921df0888c8ddf51afbce5d4 Reviewed-on: https://chromium-review.googlesource.com/577671Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#490633}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/0e4a448ab8aa66a38593f68d19fa0a2e340833e4..2507d9e7090fcd461f33f3b89bcd56c9a7476a04 BUG=none Change-Id: I34232babbf1adfdb663142b1f6970ed490b16399 Reviewed-on: https://chromium-review.googlesource.com/586645Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#490632}
-
Erik Luo authored
Bug: 749910 Change-Id: Iea25c4b2e102d773273523de10734efc1d688923 Reviewed-on: https://chromium-review.googlesource.com/590960Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#490631}
-
Doug Turner authored
In order to use the accessibility mode flags from the ui AXPlatformNode and friends, we need to move the flags from content/common into ui/accessibility. The majority of this change is mechincal renaming. Bug: 703369 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I683d1e0abcf5ce33b65ea206f07899a12a284bb5 Reviewed-on: https://chromium-review.googlesource.com/588383 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#490630}
-
Tommy Nyquist authored
Some features require additional state tracking to figure out whether in-product help should be triggered, and some of this state tracking is both costly and possibly unnecessary. A typical unnecessary state would be if the in-product help has already triggered, and it's OK to wait until next time the browser restarts to see if it should be triggered again. This CL adds support for exposing the triggering state for in-product help. After the Tracker has been initialized, it is now possible to inspect whether a particular feature has already had its in-product help triggered. This still respects the particular |event_trigger| FeatureConfig of the in-product help. Plumbing for Android, in addition to related tests and mocks have also been updated, and lastly the OnceConditionValidator is updated to now set the |result.trigger_ok| flag correctly. The documentation is also updated to describe this new API. BUG=746779 Change-Id: I81becdfadaee99ec6ee39cf5252d746ed7050e69 Reviewed-on: https://chromium-review.googlesource.com/590501 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#490629}
-
Marijn Kruisselbrink authored
In preparation for adding mojo Blob handles to the serialized message port messages, this changes the logic in content::MessagePort to serialize its messages using a mojom bindings generated struct. For now the struct still just contains the blink encoded message and a list of message port handles, but in the future blobs and other extra data can be added much easier. Bug: 351753, 740744 Change-Id: I411dd4398907eb7bbf21e630f5c82fb49798c440 Reviewed-on: https://chromium-review.googlesource.com/590082 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#490628}
-
Jay Civelli authored
ChildProcessLauncher created with a BoundConnectionProvider could end up with an null connection causing an NPE. This would happen if the initial connection failed to start (typically because it used by another process). The CPL would restart and the BoundConnectionProvider would have no connection at that point. To address this, ChildProcessLauncher is now always created with a ChildConnectionAllocator. BoundsConnectionProvider has been removed, the delegate is now used to retrieve a bound connection to use if any. If there is none, the ChildConnectionAllocator is used. Bug: 749326 Change-Id: I5e89d809f91bfa41cf9229513ea0589ae3f37deb Reviewed-on: https://chromium-review.googlesource.com/591073 Commit-Queue: Bo Liu <boliu@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#490627}
-
Mohsen Izadi authored
Pull-to-refresh should land behind a flag. There is an unused --scroll-end-effect flag that was supposed to be used for a related scroll-end effect feature which was never implemented. This change renames the flag to use with pull-to-refresh. BUG=702404 TEST=none Change-Id: If0d9b4e84ef6515137e1280154bf5dfc31eb4dd6 Reviewed-on: https://chromium-review.googlesource.com/582169 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#490626}
-
dpapad authored
Bug: 739532 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75215b4a8363cdfd403e54d584f63670d5a11b64 Reviewed-on: https://chromium-review.googlesource.com/590953Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#490625}
-
Paul Irish authored
Updated emulation state is applied in stopAndReattach, but that was racing against the state being reset within hideDialog. Bug: 747245 Change-Id: I1c1698525691f37d4c988349cd7bc84a23a3e7f6 Reviewed-on: https://chromium-review.googlesource.com/592464Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#490624}
-
David Reveman authored
This implements support for requesting a specific frame of an image when using chrome://theme URLs. Initial support is limited to frame 0, which is sufficient to conveniently provide stills of animated images to Web UI. Follow-up: Support for frame > 0 and scaling of animated images instead of returning a scaled frame 0. BUG=721647 TEST=Settings->People->"Change picture", only selected image is animating Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9c920a6943cd1f1a2654716db73e8cd88575359d Reviewed-on: https://chromium-review.googlesource.com/589709Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490623}
-
Tetsui Ohkubo authored
Improve the representation of download notification in MD style notification. * Add status attribute to RichNotificationData. * Add status_view_ in NotificationViewMD and show if status is available. Use message instead if they are not available. * Add GetSubStatusString in DownloadItemNotification. Add short_form argument in GetStatusString. BUG=740807 TEST=manual Change-Id: Iab9756e0f8eafc9bfce67aade64454e5f586a7ef Reviewed-on: https://chromium-review.googlesource.com/578540Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#490622}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/90555e06b0c0..f0e9c849a3fd $ git log 90555e06b..f0e9c849a --date=short --no-merges --format='%ad %ae %s' 2017-07-28 thestig Use FX_GetUnicodeProperties() in more places. 2017-07-28 rharrison Fix broken coverage_report.py 2017-07-28 thestig Remove unused param from CFX_TxtBreak::AppendChar_PageLoad(). 2017-07-28 npm LibTIFF: upstream patch to fix null dereference Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Idc6f64f540c589b89461f0bdd86115707df28285 Reviewed-on: https://chromium-review.googlesource.com/592646 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490621}
-
Toni Barzic authored
Adds SwipeDetector to MD TopHeaderBar, and hooks it up to observe touch events originating on new-note action launcher element and detect swipe gesture. If the SwipeDetector detects a swipe originating from the new-note action element, lock UI requests lock screen note taking flow. Bug:737067 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I560eef22365a37bfd3c5cbb8cb56f48eb44e62cf Reviewed-on: https://chromium-review.googlesource.com/582211Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#490620}
-
Lei Zhang authored
BUG=689520 Change-Id: Id3cd14282be33ae60ae071ffc5385c987a682727 Reviewed-on: https://chromium-review.googlesource.com/592393Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#490619}
-
John Bauman authored
This is similar to the logging from r483092 for regular DXVAVDA errors. Change-Id: Ia7a33d55e5bbdbebed8fbdc59703ed18f352042d CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia7a33d55e5bbdbebed8fbdc59703ed18f352042d Reviewed-on: https://chromium-review.googlesource.com/580251Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Bauman <jbauman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490618}
-
Alok Priyadarshi authored
Bug: 750311 Change-Id: I56480223e0d896660f4c98c477c6a245643e1d1b Reviewed-on: https://chromium-review.googlesource.com/591698Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alok Priyadarshi <alokp@chromium.org> Cr-Commit-Position: refs/heads/master@{#490617}
-