- 02 Apr, 2018 36 commits
-
-
Rohit Rao authored
Modifies the test to use the TabSwitcherMode enum instead of checking IsIPadIdiom(). Adds some EG matchers for various elements of the tab grid. BUG=825431 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29de41c895696627f37cc26b0c7853ab068f1834 Reviewed-on: https://chromium-review.googlesource.com/988273 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547435}
-
https://skia.googlesource.com/skia.git/+log/c6a19f1d044e..5ab52f6a3805 $ git log c6a19f1d0..5ab52f6a3 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 caryclark fix a couple of minor surface doc changes Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I5f8c2fcfcf216d331629779dc8ce4e086268d3b9 Reviewed-on: https://chromium-review.googlesource.com/989843 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547434}
-
Chandan Padhi authored
Currently, default resolution is set to 2880x1800. This CL now sets it to the actual screen size. Bug: 257097 Change-Id: I547262c563453e31cd8be30e79148d4b92d8c90a Reviewed-on: https://chromium-review.googlesource.com/989531 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#547433}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f11c0604. With Chromium commits locally applied on WPT: ad7d8f49 "[css-grid] Fix resolution of percentage paddings and margins of grid items" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15230 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=ajuma No-Export: true Change-Id: I41891be12620bcbf667e60d2906e56f3f8dfb949 Reviewed-on: https://chromium-review.googlesource.com/989247 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547432}
-
https://webrtc.googlesource.com/src.git/+log/0ffe03d2ef6f..23ffbe78f3b3 $ git log 0ffe03d2e..23ffbe78f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5eeef4598a152d8cd89c058390b67b036d4e2a2e Reviewed-on: https://chromium-review.googlesource.com/989842 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547431}
-
Koji Ishii authored
While working on supporting LayoutNG, it turns out that there are several cases where the selection range becomes start > end. e.g., fast/text/selection/emphasis.html Layout functions generally prefer proper checks are done in the callers, rather than input arguments automatically corrected in lower-level functions. This patch makes LayoutText::LocalSelectionRect match to it. Bug: 636993, 827925 Change-Id: I3068e70886f7cd425a2fd5f701ac0b7d77a8a978 Reviewed-on: https://chromium-review.googlesource.com/989474Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547430}
-
Findit authored
This reverts commit 3017d428. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 547425 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMwMTdkNDI4ZTI2NzNlYjdkM2E1MDhlYWI1MzIxMzliODc0ZTAzZmEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4999 Sample Failed Step: browser_tests Original change's description: > Reland "Enforce user gesture requirement on browser side for WebUI." > > This is a reland of f6953215 > > Original change's description: > > Enforce user gesture requirement on browser side for WebUI. > > > > Also, don't trust the renderer process to send the correct URL. > > > > Bug: 823864 > > Change-Id: I1f5c1c7908d8157240b5a7d5fc2df944267cf537 > > Reviewed-on: https://chromium-review.googlesource.com/979399 > > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#547114} > > Bug: 823864 > Tbr: sky@chromium.org > Change-Id: I9751f0f63524aa52bc5af326cd00e99a84dc1009 > Reviewed-on: https://chromium-review.googlesource.com/987694 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547425} Change-Id: I100d8b7bdcf95693a3ee8a7d70af76bfc0ea9654 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823864 Reviewed-on: https://chromium-review.googlesource.com/989992 Cr-Commit-Position: refs/heads/master@{#547429}
-
Tatsuhisa Yamaguchi authored
This will avoid exposing in-progress zip file to the destination folder. It will resolve the issues like: - the zip file is synced to Drive with incomplete state, having multiple revisions - when cancelling zip packing, the file appears in the trash of Drive Bug: 714579,785096,785093,785086,797873 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0b32515d5e896d87e1dee499f1eea40dd7a481f0 Reviewed-on: https://chromium-review.googlesource.com/844442 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547428}
-
Adam Rice authored
Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/YEHinDOBaBw Move TransformStream.js from v8_experimental_extra_library_files to v8_extra_library_files in //.gn. Also update the stable webexposed interface expectations. Bug: 780689 Change-Id: Ia16a9c2d7a45a00a0cdf72b1e53f72d60dd07e71 Reviewed-on: https://chromium-review.googlesource.com/985933 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547427}
-
Kent Tamura authored
The old names were confusing because they looked to handle any TextControlElement instances like other IsFoo/ToFoo but actually they don't handle non-text-field input types. This CL has no behavior changes. Change-Id: Ibd504e8bfb164550c33cb37d463acdbcda0b17ad Reviewed-on: https://chromium-review.googlesource.com/989524 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547426}
-
Daniel Cheng authored
This is a reland of f6953215 Original change's description: > Enforce user gesture requirement on browser side for WebUI. > > Also, don't trust the renderer process to send the correct URL. > > Bug: 823864 > Change-Id: I1f5c1c7908d8157240b5a7d5fc2df944267cf537 > Reviewed-on: https://chromium-review.googlesource.com/979399 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547114} Bug: 823864 Tbr: sky@chromium.org Change-Id: I9751f0f63524aa52bc5af326cd00e99a84dc1009 Reviewed-on: https://chromium-review.googlesource.com/987694 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#547425}
-
Kent Tamura authored
Bug: 821831 Change-Id: I5b3e1978e37ce34e6fb885ca1077ea90ab2f494c Reviewed-on: https://chromium-review.googlesource.com/987972Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547424}
-
Yoshifumi Inoue authored
This patch changes |Sample| class used in |assert_selection()| by reusing IFRAME for making |selection_test()| and |assert_selection()| faster. # Changes of tests ## assert_selection.html Because of |assert_selection| doesn't remove IFRAME used by |Sample|, this patch changes assertion to check IFRAME, which "id" is "sample", available. ## overtype.html This patch changes each test starts with overwrite mode is off, because of the overwrite mode state is state of |LocalFrame|, each test should reset it. ## spellcheck_test.js This patch changes |spellcheck_test()| not to reuse IFRAME used by |Sample|. Change-Id: I6513a2ffa01caeb0ad18360b543d0ebb4bad253a Reviewed-on: https://chromium-review.googlesource.com/987632 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#547423}
-
Yuta Kitamura authored
Blink scheduler code is transitioning to a new directory structure. This patch moves files for ChildScheduler and its children, and rewrites affected include paths. This patch only renames files; the class names are not changed yet. The file names reflect the new names of the classes, instead of the current names, to avoid renaming include paths twice. The class names will be updated in a follow-up patch. The renaming scheme of those classes is a bit complex. Look at the design doc linked from the bug for details. TBR=kinuko@chromium.org,dalecurtis@chromium.org Bug: 826203 Change-Id: I72c10ee15f3510c11e9d0520d7f6e7d4a5715b66 Reviewed-on: https://chromium-review.googlesource.com/986112 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#547422}
-
Yoshifumi Inoue authored
This patch changes test cases using out of bounds positions to use valid positions. It seems these tests passes offset in Text node rather than child index in container node. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/987655 Validate offset parameter of Position constructor with introducing Position::CreateWithoutValidation() Change-Id: Ia14788eb4f9d9a7123795f9ef3cd6abeca8e094a Reviewed-on: https://chromium-review.googlesource.com/989521Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547421}
-
Adam Rice authored
Add use counters to the constructors for ReadableStream, WritableStream and TransformStream. A new function, binding.countUse(), is added to the V8 Extras binding object and called from the constructors. See the V8 Extras Design Doc for more details on how this works: https://docs.google.com/document/d/1AT5-T0aHGp7Lt29vPWFr2-qG8r3l9CByyvKwEuA8Ec0/edit#heading=h.334ekprhracb binding.countUse() is registered by a new C++ function, AddUseCounterFunctionToV8ExtrasBindings() which is called when setting up the Javascript contexts for windows and workers. To help implement tests for the new function, some test functions have been factored out of core/streams/ReadableStreamOperationsTest.cpp into V8ExtrasTestUtils.{h,cpp}. There are also new layout tests to verify that the use counters are correctly set. Internal creation of a ReadableStream by creating a Response object does not set the counter. Currently constructing a TransformStream also set the ReadableStream constructor use counter. This will be fixed once ReadableStream has been updated to the latest standard version (http://crbug.com/710728). Bug: 769663 Change-Id: I484ef6843cbb800b345d56cf67d09e45b97ab3a3 Reviewed-on: https://chromium-review.googlesource.com/985345Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#547420}
-
Zhuoyu Qian authored
This CL introduce "StyleCommands.cpp" with moving |StyleCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Icb9a4f48ec4855d178e7b2932cc7f1bc7eef6666 Reviewed-on: https://chromium-review.googlesource.com/987652Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547419}
-
Kent Tamura authored
We have no reason to restrict links to specific WebKit sub-directories. Bug: 622551 Change-Id: If0ebcb1b1241cb99e80d4bfffac2a24300fd3a02 Reviewed-on: https://chromium-review.googlesource.com/989812Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#547418}
-
Manuel Rego Casasnovas authored
We were not resolving properly percentage paddings and margins for tracks that have something like minmax(auto, 100px). The reason was that while computing the minimum size of a grid item, the percentages were resolved against the inline size of the grid container. But for grid items we shouldn't never use the grid container size, but the grid area size, as that's their containing block. The patch modifies ContainingBlockLogicalWidthForContent() and ContainingBlockLogicalHeightForContent() in LayoutBox, so for grid items we return 0 if the area size hasn't been set yet. We never want to use the grid container's sizes in these cases. BUG=808758 TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-margins-* TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-paddings-* Change-Id: Ib142e51aee1fe623d38688469b179f01f82eb07b Reviewed-on: https://chromium-review.googlesource.com/980756Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#547417}
-
cathiechen authored
This patch supports image list marker in LayoutNG, including: 1. Display image list marker. 2. Switch between image and text. 3. Deal with image error. 4. Support svg image marker. This approach creates a LayoutNGListMarkerImageContent which is subclass of ListStyleImage as marker_'s child. Use ListStyleImage as its ImageResource. The reason to create a new class is that: When image error occurred, marker should display text instead which needs updating layout tree. LayoutNGListMarkerImageContent overrides ImageNotifyFinished to send NotifyOfSubtreeChange when ErrorOccurred. So that list item could update layout tree before layout. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I43d2ac80f823b603a0c52c872abb78785453450e Reviewed-on: https://chromium-review.googlesource.com/970131Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#547416}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: If828d17072875fddc12936f3f158fec380f2ea13 Reviewed-on: https://chromium-review.googlesource.com/989516 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547415}
-
tzik authored
This CL adds two rewriters to //tools/clang/base_bind_rewriters: - pass_by_value converts pass-by-cref base::Callback parameters to pass-by-value. - add_std_move inserts std::move() to pass-by-value base::Callback and local base::Callback variables where it looks relevant. add_std_move rewrites a occurrence of a reference to base::Callback if: - it's a pass-by-value parameter or non-const local variable. - the occurrence is the latest in its control flow. - no pointer is taken for the variable. - no capturing lambda exists for the variable. Change-Id: I83dfef7d8189ee43d052a203461bfb4ad1a25c1d Reviewed-on: https://chromium-review.googlesource.com/970143 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#547414}
-
Kenichi Ishibashi authored
r547407 fixed a deadlock which caused timeout in fetch-request-xhr.https.html when S13nSW is enabled. Update the expectation file as it is no longer timed out. Note that the test is failing currently (w/ or w/o S13nSW). Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If6aca08a4ee513a331772f73e3c7bc24da8114ba Reviewed-on: https://chromium-review.googlesource.com/989518 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#547413}
-
Yoshifumi Inoue authored
This patch changes "android-longtap-not-select-empty.html.html" to utilize |selection_test()| for ease of maintenance. Following patch will move "android-longtap-not-select-empty.html.html" to "mouse/" directory for test classification. Bug: 679977 Change-Id: Iebab8184db6d228320748cf0b8f3090889ba247f Reviewed-on: https://chromium-review.googlesource.com/987837 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#547412}
-
Satoshi Niwa authored
Bug: chromium:811679 Bug: chromium:816678 Bug: b:76128680 Test: Manually tested steps in b:76128680 Change-Id: Ia997588424e90af97aac2f89de1fe1e84266b6fc Reviewed-on: https://chromium-review.googlesource.com/987634Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#547411}
-
Koji Ishii authored
Following bot results are included. 4470 4474 4477 4484 4486 4487 4488 4489 4490 4491 4492 4493 4495 2 lines were removed and 4 lines were deflaked by consecutive results since 4426. ~150 image/image+text failures probably due to CL:986812, another incremental CL to change fonts on Linux in crbug.com/787020. Among them, 1 was changed from a ref test to test harness, and that text dump was removed. A few of them seem new failures and that they are not rebaselined. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I95a87e51f0fbcacbf58f0c89cce03334d0440d8d Reviewed-on: https://chromium-review.googlesource.com/988153 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547410}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 827065 Change-Id: I4a062ac1db4631215d1ec58bd5d79cc3acc5ba33 Reviewed-on: https://chromium-review.googlesource.com/987833Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547409}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: Id34d9b90a1e78b4cc72af1d0a0e1f6a6b009cd6b Reviewed-on: https://chromium-review.googlesource.com/989374 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547408}
-
Tsuyoshi Horo authored
Before 5e1b52dd, synchronous XHR on worker was handled by service workers. It is because the |is_sync_load| was false when the sync request is from worker thread. But after the CL, the |is_sync_load| flag for the sync request from worker became true, so the request will not go to the service worker. This CL will fix this by - Set the SkipServiceWorker flag for synchronous loads from the main thread in the renderer process. (FetchParameters.cpp) - Don't set skip_service_worker even if is_sync_load is true in the browser process. (resource_dispatcher_host_impl.cc) Bug: 706331,827473 Change-Id: I186bc97f3f8d298e0a04942d0ec4b708b3022cc1 Reviewed-on: https://chromium-review.googlesource.com/989376Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547407}
-
Satoshi Niwa authored
Background: * We are migrating callers of ConvertPathToArcUrl (sync) to using ConvertToContentUrl (async) instead. * exo_parts.cc (a caller of ConvertToContentUrl) needs to handle multiple URLs at a time, so it converts single-URL callbacks to multiple-URLs callback using BarrierClosure. * It turns out arc_file_tasks.cc (a caller of ConvertPathToArcUrl) also needs to handle multiple URLs at a time. * Moving the BarrierClosure logic from exo_parts to path_util, so we don't need to duplicate the same BarrierClosure logic in arc_file_tasks after migration. Bug: chromium:811679 Test: unit_test Change-Id: I461651bac3e5110afdd7b97d39576436cb3a92fd Reviewed-on: https://chromium-review.googlesource.com/983335Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#547406}
-
Takuto Ikuta authored
Change-Id: If199dc2b8fa924cc2299551e130925ee0eb63544 Reviewed-on: https://chromium-review.googlesource.com/987835 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547405}
-
Yoshifumi Inoue authored
Utilize selection_test() in "editing/selection/click-in-focusable-link-should-not-clear-selection.html" This patch changes "click-in-focusable-link-should-not-clear-selection.html" to utilize |selection_test()| for ease of maintenance. Following patch will move "click-in-focusable-link-should-not-clear-selection.html" to "mouse/" directory for test classification. Bug: 679977 Change-Id: I88cb017fd3fd8b983548693c1abd86f55fa672de Reviewed-on: https://chromium-review.googlesource.com/987420Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547404}
-
Gyuyoung Kim authored
This CL introduces new APIs to suspend/resume the active tasks on the page of blink. Android webview, devtools, or other projects which use the content module needs to be able to suspend current active tasks including active javascript, active timers, defer loadings, and so on. This CL supports to suspend/resume through the APIs when they want to pause current active tasks. This feature will help us to save CPU resources, and so on. Besides WebKit2 has been supporting this APIs for applications which uses WebKitWebView. TEST: WebContentsImplBrowserTest.PausePageScheduledTasks Bug: 822564 Change-Id: Icec0390c2dffd676a6079dd9e148feb8a3e859e1 Reviewed-on: https://chromium-review.googlesource.com/952642Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#547403}
-
Megumi Hattori authored
Before this CL, |password_view_| is always focused when HasAuthMethod(AUTH_PASSWORD) is true. This CL limits the timing of focusing |password_view_| to only when HasAuthMethod(AUTH_PASSWORD) is changed from false to true. This CL also fixes a bug that users cannot focus inline reply using virtual keyboard on the lock screen. BUG=825781 TEST=manual Change-Id: I7afa75af0b3c86bf0988d5cbd95edc192255785a Reviewed-on: https://chromium-review.googlesource.com/980272Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#547402}
-
Kristian H. Kristensen authored
On ChromeOS, CL:950007 changed the decoder output format to NV12 instead of RGB. This means that the color space conversion now happens when the test suite textures from the NV12 EGLImage, which accounts for small differences in the conversion. BUG=827032 TEST=video_VideoDecodeAccelerator Change-Id: Ic3f22736dae0632756a62e4b9226da30cc561e68 Reviewed-on: https://chromium-review.googlesource.com/989024Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#547401}
-
Kent Tamura authored
It's unnecessary since VS2015. Change-Id: Iba63fa152ea0fbc2f567903e21b3cba9065a746a Reviewed-on: https://chromium-review.googlesource.com/987637 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547400}
-
- 01 Apr, 2018 4 commits
-
-
https://skia.googlesource.com/skia.git/+log/5614ce189732..c6a19f1d044e $ git log 5614ce189..c6a19f1d0 --date=short --no-merges --format='%ad %ae %s' 2018-03-29 ethannicholas fix for frexp dataflow analysis Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ic360bc98b46471fab1cf748888d2bc8e820d9e14 Reviewed-on: https://chromium-review.googlesource.com/989403 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547399}
-
Klaus Weidner authored
The heuristic wasn't working right due to using the wrong frame as timing reference, resulting in overthrottling for fast applications and excessive latency for slow applications. When estimating the render time for a frame that was already complete at the time of check, it uses the time-until-copied as a lower bound, but accidentally used the copy time of the currently processing frame as opposed to the copy time of the previous rendering frame, resulting in overestimating the render time. Also, the heuristic to decide when to skip VSync also should have used the currently rendering frame (two frames back when sending a new animating frame), but was erroneously using the currently processing frame (one frame back). Fix this, and adjust the heuristic to more accurately reflect the intended scheduling. Bug: 827811 Change-Id: Ic4884ccaee6f2f6d3051ce2790132582dba6702a Reviewed-on: https://chromium-review.googlesource.com/989431 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547398}
-
https://skia.googlesource.com/skia.git/+log/0806b7ce3b59..5614ce189732 $ git log 0806b7ce3..5614ce189 --date=short --no-merges --format='%ad %ae %s' 2018-04-01 update-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1f7f381790b860f0b52540ea0cb293e498ff816f Reviewed-on: https://chromium-review.googlesource.com/989398Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547397}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0b3985c7b4ed93a0041caaba13308b5040020056 Reviewed-on: https://chromium-review.googlesource.com/989264Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547396}
-