GitLab

Test that front buffer has expected contents after present.

Bug: 939655
Change-Id: I5a3e89655e1ae20e04ab7463a6ad9d4040a57002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717653Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681040}

Intent to Ship: http://bit.ly/2YmJAYN

Bug: 581518
Change-Id: Ia8a0ded90e09470e019cf05e5aa2745863b2302c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719273Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681039}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d242ed7a0e0a..3a98df0bdd49


git log d242ed7a0e0a..3a98df0bdd49 --date=short --no-merges --format='%ad %ae %s'
2019-07-25 ehmaldonado@chromium.org depot_tools: Move six to depot_tools' .vpython


Created with:
  gclient setdep -r src/third_party/depot_tools@3a98df0bdd49

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=agable@chromium.org

Bug: chromium:984182
Change-Id: I9280580e23c7c517d10f306b682d5d4721694b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718841Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681038}

This CL removes the dynamic import of APIs which are always available on
all supported platforms. It also removes the old fallback path for pre-Vista
platforms as well as a general code cleanup.

Bug: 986625
Change-Id: I123942cdec976356bf5ba2c12e0f97cbbd65dde0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715536Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681037}

TabGrid uses UIToolbar for both compact layout (Regular(V)xCompact(H))
and non-compact layout. For non-compact layout, the new tab button is
wrapped in to a container UIView with insets, then inserted into a
transparent UIToolbar so that it looks like a floating button but still
has the built-in a11y modal panel for long-press under a11y font-size.

The non-compact layout is no longer working in iOS13 and the floating
new tab button is compressed probably because the calculation of
UIToolbar's height is changed in UIKit. After a discussion with UX, we
decided to remove the transparent UIToolbar for non-compact layout and
make the new tab button a real floating button.

Bug: 971786
Change-Id: I7efddd5e044ce19a469c01ca75535a22b1b5da6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715188
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681036}

Chrome migrates pinned icons in UserPinned/Taskbar dir, but not the
subdirectories of UserPinned/ImplicitAppShortcuts. It's unclear to me why
Windows puts some pinned icons in the ImplicitAppShortcuts subdirectories,
but we should handle them.

Bug: 980239
Change-Id: Ia41c3853b2a4bb78781a39733f388915f58c02eb
TBR: 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710722
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681035}

We tear down BrowserContext-bound Service Manager services when the
BrowserContext is being torn down, but the relevant state which receives
service requests from the Service Manager is on the IO thread. This
means we can end up hitting races where some client of a service
reconnects to the service and triggers the service-startup path
immediately after BrowserContext destruction, which in turn can violate
service's expectations about shutdown behavior.

This CL fixes that by explicitly posting to disable all service request
handling prior to initiating any service instance destruction.

Bug: 987473
Change-Id: I488d8fbed19bc50efc1b8ea4eee80b0cb36d9bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717914Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#681034}

Bug: 944317, 959414
Change-Id: Icd9d51ec1e44c9d483ef921f413f0b3bf9b0fc64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717685Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#681033}

This CL adds `delivery_key` to spec.src.json down to
the JSON objects supplied to JavaScript test runners,
to distinguish referrer-policy and mixed-content tests
explicitly by data fields.

Generated files will be updated after some more changes, not now.

Bug: 906850
Change-Id: Iedae7830cbc41eb87ab884a88aa9e667cc54f6e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717109
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681032}

This causes segfaults in client code.

Bug: 977603
Change-Id: Iee474224509c425f8747e9e4f42c253891ba16dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719328Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681031}

https://quiche.googlesource.com/quiche.git/+log/89b9af539b58..753002daef60

$ git log 89b9af539..753002dae --date=short --no-merges --format='%ad %ae %s'
2019-07-24 fayang gfe-relnote: Add NumRegisteredStreams interface to WriteScheduler and implements it in subclasses. No used in prod yet, not protected.
2019-07-24 bnc QuicSpdySession header size limit related cleanup.
2019-07-23 renjietang Simplify header lengths field.
2019-07-23 wub gfe-relnote: (n/a) In QUIC BBRv2, only update max bandwidth filter per ack event. Protected by existing flag --gfe2_reloadable_flag_quic_default_to_bbr_v2.
2019-07-23 quiche-dev gfe-relnote: Abandons HPACK decompression for overly large header blocks. Protected by default-true --gfe2_reloadable_flag_http2_reject_too_large_header_blocks.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=rch@chromium.org

Change-Id: I50464b9e661339650641a72291f65211ec6d2002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716061
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681030}

During the migration from Framework preferences to the preferences
Support Library, many methods and classes were duplicated so that the
two implementations could coexist during migration.

Now that the migration is complete, all of these duplicates can be
cleaned up.

Bug: 967022
Change-Id: I5947a92935cbdc0f200a14d9fe95f804a111f2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709880
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681029}

This will be used by the BinaryUploadService for uploading requests. It
also encapsulates the retry logic.

Bug: 980784
Change-Id: I1b0beee83548b38b678ef6d0ae6db3130f3db05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710853
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681028}

Previously, it took a `const std::vector<base::string16>&` as
argument. It then immediately copied it into its |items_|
member. However, all callers discard their vector immediately after
constructing SimpleComboboxModel so this copy is unnecessary. Taking
it by value allows the caller to either move or copy their vector.

Change-Id: Ice6bfeafb50ba23a2a63440eb1e7a67406481368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717648Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681027}

This patch ensures that we don't DCHECK when checking positioned object's
layout state, since those objects can also be locked.

R=chrishtr@chromium.org

Bug: 987727
Change-Id: If0d92d81f6b9f47bf12b56d11dd0428f87a5e939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719272Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681026}

TBR=treib@chromium.org

Bug: 987734
Change-Id: I27f1208b01fa73f2276093a7701f41401e8762d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718597
Commit-Queue: Vincent Boisselle <vincb@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681025}

Fixes a mistake in the bound of this histogram that was introduced in
https://crrev.com/c/1710839 .

Bug: 986540
Change-Id: Icbafa5fe648203274eb8f450a168c1421e81dcff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713592
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681024}

Set Cast specific |cors_exempt_headers| in CastNetworkContexts when
initializing NetworkContexts. Also, reuse the system NetworkContext in
CastExtensionBrowserClient so that the same settings can be applied to
extension network requests.

Bug: b/135124090
Merge-With: eureka-internal/283340
Merge-With: eureka-internal/295799
Test: On device
Change-Id: I409cd4873f68d68bc684510f609eb261d569dcd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714284
Commit-Queue: Junbo Ke <juke@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681023}

Use BrowserListObserver::OnBrowserAdded instead.

Bug: 268984
Change-Id: I00dd005962a2ab634e191379c9af21e6b6afe984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717190
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681022}

This allows the two sets of tests to run the same infrastructure, and
ensures that they will stay more closely in sync.  This also allows
for easier porting of the tests and more consistency in the tests.

Bug: 959476
Change-Id: I8eca0372a4091dd27702b099eb3836bfe9d6648d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717328
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681021}

Passing render frame/process ids to device runtimes is a potential
security threat. However, ArCoreDevice requires them to figure out
the ChromeActivity that the device's Tab is associated with. So, while
the ids cannot be removed from XRRuntimeSessionOptions mojo struct, this
change assigns those ids only for ArCoreDevice.

Bug: 854655
Change-Id: I61f53570d88feb988d2242c7f4b5c8ae17f977ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717539Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681020}

This accessor is no longer used.

R=asvitkine@chromium.org

Bug: 944227
Change-Id: I60e3ff0ba7790b35afcdb6ecdd5a7faf835d2044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719107
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681019}

This change erases reference to the OmniboxZeroSuggestionsOnNTP flag from
zero suggest provider since it will no longer be needed there.

The behavior is currently controlled with the OmniboxOnFocusSuggestions
feature, via ZeroSuggestVariant:X:Y parameter, where Y specifies type
of suggestions for context X, rendering the flag semi-redundant.

We will keep the flag for the time being however, since it allows us to
control the behavior of Chrome when flags are explicitly enabled or
disabled.

Bug: 963173
Change-Id: Ia786412aad25589a079115f6e89603bdee1b9de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718988
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681018}

If the bitmap for the app icon and media artwork is not RGBA_8888, the
images will not render on some screens. This CL converts the color of
the images if necessary.

Change-Id: I6df3ecdc228a88e8646a68a416020ee5c7e5a9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717995
Commit-Queue: Mia Bergeron <miaber@google.com>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681017}

It always takes me forever to find how to do this, so put a comment
in the first place I usually look.

Other places in this file also say "Can be set using custom_vars",
so it makes some sense to explain how to do this in this file.

Bug: none
Change-Id: I02ec45a4888ebc0439178e7b9cc9524356f9b47b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718594
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681016}

This also allows the Messages feature to be in the disabled
state when there is no pairing which was previously not allowed.

Bug: 956819
Change-Id: I995347df141b5577cf2f2f35d2a4b3bf9c5803f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709892Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681015}

After the initial fix in 67e8d392 the
crashes observed in raspberrypi3 were gone in stable and beta builds,
but not on dev (current master). Debugging pointed out that the
problem was still present because of the tcmalloc code out of
gperftools.

So this change just drops _all_ uses of initial-exec model for
ARM builds using GCC. This fixes the crashes even in current master.

Bug: 973767
Change-Id: Idaec9eb3af0cc688466777b63efc601b77c9e55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715266Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#681014}

Relevant Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DXSoS7dMmok

Bug: 879270, 942033
Change-Id: I399489e766f4eafdd3087f159320dc3211bf1c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715257Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681013}

This patch gives us the ability to download the most recent
orderfile (with name specified in a file) so that ChromeOS can
use it for linking Chrome in the future.

This patch generalizes the script used for downloading
newest AFDO profiles for Android/Linux to be able to download
any artifacts generated on Chrome OS. The script now takes
arguments that can describe any profiles/orderfiles.
Also move the script to a non Android-specific location.

Bug: chromium:950627
Test: The script is working locally for both android and chromeos

Change-Id: I9eedbd6f39664013c5f61c7e64cbe0652bb13b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704936
Commit-Queue: Tiancong Wang <tcwang@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Tiancong Wang <tcwang@google.com>
Cr-Commit-Position: refs/heads/master@{#681012}

The tests WebXrVrWmrBrowserTest.TestDeviceServiceDisconnect and
WebXrVrWmrBrowserTest.TestNonImmersiveStopsDuringImmersive were failing
locally but not on the bots. Applying Bill's fixes from CL 1676344
related to focus makes these tests pass.

Bug: 987405
Change-Id: If4532327e71342c2d3aeddd6273b911f80f05f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718774Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681011}

A clip that is not axis aligned or can become non-axis-aligned needs a
render surface. Previously, we would require a render surface if any
transform animation was present, but this was too large of a hammer.
This patch checks blink-side transform animations for axis alignment
instead of assuming all transform animations are axis-misaligned.

The implementation in blink follows a similar pattern as is used in cc.
blink::ElementAnimations::AnimationsPreserveAxisAlignment has been
added which is similar to
cc::ElementAnimations::AnimationsPreserveAxisAlignment. Similarly, the
newly-added blink::TransformOperations::PreservesAxisAlignment follows
the pattern of cc::TransformOperations::PreservesAxisAlignment.

Whether an Element's animations preserve axis alignment is cached on the
blink::TransformPaintPropertyNode. This is later consulted when making
render surface decisions in PropertyTreeManager.

Bug: 939589
Change-Id: Ia839497acae56f99f08213c95e67f9e45380e86a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715234
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681010}

For a short time window after resuming from suspension, BluetoothAdapter
returns incorrect presence and power values (crbug.com/986896). This CL
is a stopgap measure while we wait for this bug to be resolved. This CL
caches the correct values, and uses them within that time window instead
of directly requesting them from BluetoothAdapter.

This CL also partially addresses crbug.com/890047; it resolves one of
the flickering tooltips.

Bug: 969036, 890047
Change-Id: I26ba8c85d1c3e086ae598aec6abbdae7ee6c5164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715632Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681009}

This updates the WebIDL for the Shape Detection feature to match
https://github.com/WICG/shape-detection-api/pull/73.

Bug: 659138
Change-Id: I1b3acaeb1496b06a69100453c834e3f1f16d9c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717229
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681008}

The test had a crash which has since been fixed. This re-enables it.

TBR=ynovikov@chromium.org
TEST=Pixel_CanvasDisplayLinearRGBAccelerated2D

Bug: 984954
Change-Id: I889095f7466393b39dbba558547dde1e27c287bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717125Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681007}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a38facd37c4..519a25f2a6a9


git log 9a38facd37c4..519a25f2a6a9 --date=short --no-merges --format='%ad %ae %s'
2019-07-25 tcwang@google.com afdo: Add build config for afdo generate/verify builders.


Created with:
  gclient setdep -r src/third_party/chromite@519a25f2a6a9

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Id308a1e2e3dcd23c0fe9098af69f25896378e3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718610Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681006}

This component is for the implementation of adding Wi-Fi networks to
Chrome sync in ChromeOS.  WifiConfigurationBridge is responsible for
tracking changes to the network list locally and on the server and
reconciling differences between them.  This CL is only concerned with
tracking the remote network list.

Bug: 966270
Change-Id: I57e330d4a53e5db2472c6fc5c3c5f2adbd3d673b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703802
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681005}

Followup to
https://chromium-review.googlesource.com/c/chromium/src/+/1717228

This makes the contents view of each tab also have the role of tab (this
was left out of the original CL). The result is that when a screen
reader user uses arrow keys to switch between tabs in e.g. the cookies
dialog, they will hear "allowed tab" and "blocked tab" rather than just
"allowed" and "blocked". This should clarify the function of the
controls for low-vision users.

We have also added unit tests for this functionality.

Note that after the pane view is added, the caller of
TabbedPane::AddTab() can set the role and title of the pane to whatever
they want; however this default should produce expected accessibility
behavior in nearly 100% of cases.

Bug: 962966
Change-Id: I6a77ab29c0427e216e47557f8d40e556b0311304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717448
Auto-Submit: Dana Fried <dfried@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681004}

adaptive icons"

This is the first part of integrating adaptive icon with WebAPKs.
This CL plumbs through the is_primary_icon_maskable parameter
for crafting create/update requests to our WebAPK minting server.

This CL also removes the requirement for a web app manifest to
have an "any" purposed icon to be eligible for being added as a
WebAPK, if adaptive icons are supported.

For adaptive icon to be a fully functioning feature, change in
shell apk, and their corresponding change in chromium is needed.
These changes are left for further commits.

Also, fix a lint error in WebappSplashDelegate.java

Bug: 977173
Change-Id: I85c30c275212d6aefd4c3823fd128bb7c8ad9cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712515
Commit-Queue: Henry Jian <hzjian@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681003}

Currently adding tests for the expiration date fix flow.
Will add more tests for the normal upstream flow and the name fix flow
as followup.

Bug: 960612
Change-Id: I0988f0754aaaba953b384de9785f6f471980f92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600753Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681002}

Bounds geometry isn't available until a few seconds after an immersive
session starts for WMR. Blink xr code was only checking if the stage
parameters had changed, but didn't handle the case where the stage
parameters didn't become available until after the session started.

Also updated the E2E test page for bounded reference spaces to properly
call requestReferenceSpace and try creating a bounded reference space
once every second until one becomes available in an immersive session.

Bug: 986867, 986866
Change-Id: I6897269f20ee3814e7f1eeb036c183a85f38d9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717453
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681001}