- 14 May, 2019 40 commits
-
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/4d0fe85c1957..78c44e2dc26e $ git log 4d0fe85c1..78c44e2dc --date=short --no-merges --format='%ad %ae %s' 2019-05-13 jianj Reland "vp9: Enable ml based partition for speed>=8 low res." 2019-03-04 ravi.chaudhary Fix update of mb_smooth_pct and mb_av_energy Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I202ab58a304053d86a503bf1d29928c1f3b3613a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611649Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#659614}
-
Tetsui Ohkubo authored
This is a follow-up change of https://crrev.com/c/1602193 and https://crrev.com/c/1599758. After the first change landed, gamepad vendor ID and product ID are exposed to ARC. However, device version wasn't included because the field wasn't available in ui::InputDevice. After the second change, now the information is available. This is a part of the effort to improve ARC Gampad compatibility. Design doc: go/arc-improved-gamepad TEST=manual(--enable-features=ExoRawGamepadInfo to /etc/chrome_dev.conf) BUG=b:130597086 Change-Id: Ie2def04cafaa52295e8e0d2e75313b1bb5f8c314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610272Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#659613}
-
Steve Kobes authored
This tweaks the DVLOG output of JankTracker to be more useful, printing the URL of the document in which the layout shift occurred, indicating whether it's in a subframe, and suppressing output for devtools windows. Bug: 581518 Change-Id: I5515137219a6ff88fb46ca9181f500e5b23c191d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1459802Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#659612}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/701ac9a6e80f..88ad352aa1c6 git log 701ac9a6e80f..88ad352aa1c6 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 oysteine@google.com Devtools tracing handler: Propagate Tracing.end errors Created with: gclient setdep -r src/third_party/catapult@88ad352aa1c6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:956191 TBR=oysteine@google.com Change-Id: I3328578f00f9ee84e1700ce8b4b14a43316b4fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659611}
-
John Rummell authored
BUG=none Change-Id: I0c207a6cb2131ede179b5c03aed4cb58277363b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606594Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#659610}
-
Kevin Ellis authored
Spec: https://drafts.csswg.org/web-animations/#the-animation-interface Animation.updatePlaybackRate differs from the setter for playbackRate in a number of aspects. The updatePlaybackRate method provides a guarantee that the update will not trigger a visual jump in the animation by ensuring that current time remains continuous. Furthermore the update method does not alter the playback rate retrieved via the getter until after the next async update cycle if there is a pending run or pause task. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/lTYK1HT47Qk Bug: 827634 Change-Id: Ic7c9e520786a7bbf1894cb50a991185f2f400b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598210 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#659609}
-
Robert Ma authored
The tool is broken because our builders.json is out of date (lots of testers have been moved or renamed during the LUCI migration and the teardown of chromium.webkit). Although LUCI no longer has the concept of masters (only groups), the legacy test-results app that this tool relies on still requires the master param in the URL. Besides, with chromium.webkit gone, the builders that run webkit_layout_tests are now in different groups (masters), so we need to add a "master" field to builders.json. Bug: 840230 Change-Id: I3f9c17ea8c8e72506a5680f717b9b11163d14aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604332 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#659608}
-
Andrew Grieve authored
They were showing up as nodes with count of 0 because their size had changed but not their count. When in method count mode, it makes more sense to just hide these nodes. Bug: 947372 Change-Id: Ic90cf0a41e0cd601687199b7a938a90a786cdab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611763Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#659607}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bbe382ef. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I19d32f095c3bbbc67e582de5c6592f1aca9c1d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610204Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659606}
-
Koji Ishii authored
Following bot results are included. 19482 19483 19486 19495 19501 19507 19512 19532 19550 19570 19578 19585 19595 19607 19614 19638 2 lines were removed and 5 lines were deflaked by consecutive results since 19501. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: Ibdbc0a5f1ff7e53722ccb2d0356b094e500cdb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607709Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659605}
-
Sky Malice authored
Certain actions on the touchless builds that loaded the NTP would cause a DCHECK during cleanup of observer state. This change simply passes the modified tab through in NavigationRecorder#onDestroy(). It is unclear if passing null in onDestroy() initially was an oversight or on purpose. Bug: 959230 Change-Id: I23b9e9abe6ed03183af80e525ee6ec2f582cdee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611507Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#659604}
-
Mason Freed authored
Previous to this CL, an empty rect was used to signal that no clipping should be performed on the backdrop filtered image. However, in the corner case that the element with backdrop-filter was zero size, this would cause no clipping to be performed, which is incorrect. With this CL, backdrop_filter_bounds is base::Optional. There is also a test for this case. Change-Id: I8d3d1e383ccf807f1e4f569847bd828a8d04fd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604330Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#659603}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a82ea5d..8642c0be Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c840537335c32cf707e9723e17e0b5511619ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610207Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659602}
-
Bruce Dawson authored
pe_summarize.py had a "convenient" dependency on VS 2015 which now seems anachronistic, and hard to maintain. Run it from a VS command prompt with dumpbin in the path. Also use the /nopdb option to avoid querying symbol servers, and print an informative error message if dumpbin can't be found. Change-Id: I2dad597ae4fb397b46caed969c6b46eac091c2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610030 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659601}
-
Devlin Cronin authored
Karan's been the go-to person for webRequest issues for awhile. Add him to the ONWERS file. Also add an OWNERS file to extensions/browser/api/web_request (and have the //chrome one point to that). Bug: None Change-Id: Iaac56b50c305238e99c2e033ce710c05c0847860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612023Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659600}
-
Devlin Cronin authored
Opaque origins (such as about:blank and data: URLs) inherit the security and privileges of their creator origins, which are tracked in precursor tuples. ScriptContext::GetEffectiveDocumentURL() attempts to determine the precursor origin of an opaque URL today by traversing the creation chain and looking for the first non-about:blank opener or parent. However, this is not always strictly correct for all opaque origins; for instance, the precursor tuple of a data: frame may not be that of its immediate parent in the case of nested iframes. Update ScriptContext::GetEffectiveDocumentURL() to use Origin::GetTupleOrPrecursorTupleIfOpaque(), which correctly tracks this. Note that we still have to do the opener/parent traversal case because content script matching needs to have the full URL (including path), and not just the scheme, host, and port tuple. To balance these, we simply return the document URL (which is potentially opaque) in the case of a mismatch between opener/parent traversal and the precursor tuple. This should be an exceptionally rare case in practice. Updating this method to use the precursor tuple is a prerequisite for adding support for data:-URL content script injection. Bug: 55084 Change-Id: I8f7d17b999f909cc32091b8fff06bd53a2370db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601663 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#659599}
-
dpapad authored
No longer used anywhere and not needed. Bug: 961063 Change-Id: I699773db478aac13495a63166edbbe774f3115f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607128Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659598}
-
Avi Drissman authored
It is redundant to the one that Chromium provides. BUG=960209 Change-Id: I5d9133311f19196b3cbe4d59376300defe5451c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611910 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659597}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb19-26.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Iba1a2b628b7fb796788691693c4ca94cf9651af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611648Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659596}
-
Theresa authored
A previous refactor switched dismissal of the app menu from ChromeActivity#onConfigurationChanged to a ComponentCallback inside of AppMenuHandler. The ComponentCallback does not get notified when entering/existing multi-window causing the app menu to no longer get dismissed in that scenario. Introduce a new ConfigurationChangedObserver, registered through the ActivityLifecycleDispatcher, and use that to dismiss the app menu in AppMenuHandler instead. BUG=962416, 956260 Change-Id: I96e5c5b3a369ece2ad235b4dd4eeabba2050be61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610587 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#659595}
-
Matt Menke authored
The removed code CHECKed if NetLogWithSource or socket pool request objects had been deleted. While the issues were never resolved, they're also not under active investigation, and the CHECKs did not prove useful, and we don't seem to seeing them in crashes at the moment. Bug: 467797, 652868 Change-Id: I07ae2e12f5e940a5cb8f3b23440f23a12df6680e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612017 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659594}
-
Vladimir Levin authored
This patch makes it so size containment takes priority over display locked size. This makes it so that contain: size still treats the element as having no children, if even that child is indcued by a display lock size. R=ikilpatrick@chromium.org, cbiesinger@chromium.org Bug: 961297 Change-Id: Ia134c5522e0a1dde504d6866298c1543bb3bd47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611514 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#659593}
-
Tim Volodine authored
After [1] landed the |method| and |headers| parameters are not needed anymore in the HandleExternalProtocol implementation. Also update all relevant sub-classes and method invocations. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1318976 BUG=841556,963008 Change-Id: Id43fe55c8a613cf0648013102675babcabbfb18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609843 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#659592}
-
Tommy Steimel authored
This CL adds a |SetNeedsLayout()| call in PictureInPictureInterstitial to force the interstitial to layout after we receive a sizing change. This fixes an issue where the video size would change but the pip interstitial would be stuck at the previous video size. Bug: 960995 Change-Id: Ib4f18706b5f923a4f2c5bd34c70c95b02bcd2ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606246Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659591}
-
Xianzhu Wang authored
The original code caused a side-effect of local rebaselining that new baselines would be created under flag-specific/disable-blink-features=LayoutNG directory instead of the default baseline directory. Now move the LayoutNG disabling code into Port.additional_driver_flags() to avoid the side-effect. Bug: 961437 Change-Id: I18c6c429e492c0ced59cef2e0dda41597a4ef9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611105Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659590}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I871ad49a3e38a3a46f9b2462b56da3165032ffcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611887 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659589}
-
Nate Chapin authored
We now check a target name and select the correct frame before calling into FrameLoader, so there's no reason to store it on FrameLoadRequest. Change-Id: I4e48b15184d740b71fed242d0d1f8327f2325123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610570Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#659588}
-
Patrick Monette authored
This is a reland of 391dff3d Original change's description: > Create source sets for tests in chrome/browser/conflicts > > This solves a filename collision that happens when moving all the files > in chrome/browser/conflicts to chrome/browser/win/conflicts because > module_info_win_unittest.cc becomes module_info_unittest.cc, and this > file already exists at > chrome/browser/install_verification/win/module_info_unittest.cc > > Change-Id: Id269f582259ac8e53a8a5aa64a61f4232ad732ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593894 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659186} Change-Id: I5428f2a79b65b5dd25aed85f467b4772fbaec0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610593Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#659587}
-
Maksym Onufriienko authored
Use [ChromeEarlGrey setContentSettingsBlockPopups] instead of chrome_test_util::SetContentSettingsBlockPopups(..). This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Bug: 922813 Change-Id: Iba1f291af45c2676e0d04158542c4752716cf4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600635 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#659586}
-
Tanmoy Mollik authored
This cl is part of the effort to introduce strongly typed CoreAccountId instead of std::string in CoreAccountInfo to stop confusion among gaia_id, email and account_id. Bug: 959157 Change-Id: I78c1c77b9a5634d03154cfc4b8a95e517aa73620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602647 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659585}
-
Jun Mukai authored
Instead, this CL exposes the existing ShellTestApi as ash/public/cpp/test/shell_test_api.h. Bug: 958216 Test: trybot Change-Id: I12aaa0aeccc13dbf65dbf90cdd0671d8276eae20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610573 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659584}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I0795227dcd8c9c95a9ae99324b7f6782fa0cb63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611880 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659583}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I3d67bad8fd17130ffa750475a65a8cb25afdaa68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611884 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659582}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e935dac9ef8a..f815e6fe51af git log e935dac9ef8a..f815e6fe51af --date=short --no-merges --format='%ad %ae %s' 2019-05-14 stevenperron@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f815e6fe51af The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: Ic109c1f3bdc3a04244917a4f239cc4a7e7333b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659581}
-
Elly Fong-Jones authored
This flag doesn't do much on Mac right now, since the old content fullscreen implementation was lost with the Cocoa browser window. Bug: None Change-Id: I9e263cc4546765b60ab8edaa28cbea3b67b95292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611897 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659580}
-
Koji Ishii authored
It returned nullptr for any objects laid out by LayoutNG. `AXPosition::AtStartOfLine()` relies on this, and that it fails to return the correct value in LayoutNG. This patch fixes following content_browsertests with LayoutNG: AccessibilityAuraLinuxBrowserTest.TestParagraphTextAtOffsetWithBoundaryLine AccessibilityWinBrowserTest.TestParagraphTextAtOffsetWithBoundaryLine Change-Id: I409682232a29f84cda7e2d547ffd6a264357b3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608867Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659579}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13e06be378d8..9d5d210a420f git log 13e06be378d8..9d5d210a420f --date=short --no-merges --format='%ad %ae %s' 2019-05-14 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9d5d210a420f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id3d0d60b026959f757c9d6d7b369706be838b998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/491b47da442e..d56a905e68a2 Created with: gclient setdep -r src-internal@d56a905e68a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: Icb9d48ec0a0617c75f2a00b4ef36408004c84616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611642Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659577}
-
Tim Song authored
Currently, the message center closes apbruptly after the last notification slides out. It should instead gracefully animate being hidden. Video: https://screencast.googleplex.com/cast/NTQzNTM4NTg3MjEyMTg1Nnw2NmNlZThiNi1lZA TEST=manually verified, updated unit test BUG=958603 Change-Id: If1c9e6ced1670bc208af281d42f687af3084a488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610651Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659576}
-
Maksim Sisov authored
After https://crrev.com/c/1570014, Chromium started to crash immediately because of null accelerated widget provided to the WaylandBufferManager and hitting data validation error when --enable-native-gpu-memory-buffer with the --enable-gpu-rasterization passed. The problem was that the raster buffer provided can create a staging buffer for rasterization, which is not tight to any of the existing widgets. Thus, it seems like it just passes a null widget [1][2]. But, when the GbmPixmapWayland was created and the dmabuf handle was passed to the WaylandBufferManager to import a wl_buffer, it crashed on the data validation, because the widget was null. Thus, when a null widget is passed, just create a native pixmap and do not call the WaylandBufferManager with a request to import a wl_buffer as long as they can also be used as staging buffers and not meant for attaching to Wayland surfaces. [1] https://cs.chromium.org/chromium/src/cc/raster/one_copy_raster_buffer_provider.cc?type=cs&g=0&l=296 [2] https://cs.chromium.org/chromium/src/cc/raster/zero_copy_raster_buffer_provider.cc?type=cs&g=0&l=125 Bug: 962466 Change-Id: Ied6fd6d3e29fdd21939c8b159682537f9239ab84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609781Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#659575}
-