GitLab

Password manager does not use clients, while it includes
chrome_password_manager_client.h.

It caused flaky build failures on some trybots.
e.g. https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/82274
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/82281

BUG=None

Review-Url: https://codereview.chromium.org/2319763003
Cr-Commit-Position: refs/heads/master@{#417243}

Revert of Do a better job at faking simple challenge signatures. (patchset #7 id:120001 of https://codereview.chromium.org/2297193006/ )

Reason for revert:
crbug.com/645052

This is causing build_package failures on chromeos.

Original issue's description:
> Do a better job at faking simple challenge signatures.
>
> By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests.
>
> Note that the signature is purposedly not verifiable in the FakeCryptohomeClient.
>
> BUG=643245
> TEST=chromeos_unittests; unit_tests and components_unittests also pass
>
> Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
> Cr-Commit-Position: refs/heads/master@{#417118}

TBR=dkrahn@chromium.org,xiyuan@chromium.org,drcrash@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=643245

Review-Url: https://codereview.chromium.org/2326473002
Cr-Commit-Position: refs/heads/master@{#417242}

This CL changes the inline ScopedTempDir::path() to an out-of-line
GetPath() and enhances it with a DCHECK against the directory not
having been created yet.

FAQ

Q: Why GetPath?
A: Because of the added DCHECK in the path accessor, which needs
   #include "base/logging.h", there were two alternatives:
    (A) Keep the inline path() and #include "base/logging.h" in the header.
    (B) Change the inline path() to an out-of-line GetPath and implement it
        in the .cc file.

   (A) would affect compile-time, (B) affects run-time of the tests. I made no
   measuring, but obtaining the path is usually a one-off step in a test, so an
   unlikely hotspot. Therefore the trade-off seems much better for (B).

Q: Why deprecating path() instead of deleting it?
A: Due to the big amount of callsites (almost 600 files in the whole codebase),
   this change is rolled out in phases. This CL changes //base. After all of the
   codebase is converted, the deprecated path() will be deleted.

R=danakj@chromium.org
BUG=640599

Review-Url: https://codereview.chromium.org/2275553005
Cr-Commit-Position: refs/heads/master@{#417241}

This patch provides a basic skeleton implementation of the
CSS Properties and Values API. In particular, the pipeline from
registration to reading from computed styles is supported but with
many missing bits along the way.

Some of the missing bits:
- Only * and <length> syntax supported with trivial parsing logic.
- All properties assumed to be inherited.
- Computation logic is currently a no-op (needs to resolve ems, etc.)
- CSSOM on specified styles aren't yet affected by (un)registration

Spec: https://drafts.css-houdini.org/css-properties-values-api/
Design notes: https://docs.google.com/document/d/1IBT3qlZK-BznqcVANckj6kjMjpyFHc-KHdBLz1n4M4c

BUG=641877

Review-Url: https://codereview.chromium.org/2310823002
Cr-Commit-Position: refs/heads/master@{#417240}

This patch gets rid of unused parameter |caretRectChanged| from
|CaretBase::invalidateCaretRect()|, since it is always |false| as default
parameter, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2320933002
Cr-Commit-Position: refs/heads/master@{#417239}

Review-Url: https://codereview.chromium.org/2321713002
Cr-Commit-Position: refs/heads/master@{#417238}

After a bit of discussion in [1], the latest strict 'Secure' draft [2]
relaxes the equivalency checks for strict 'Secure' enforcement to allow
a non-secure cookie whose path does not overlap an existing secure
cookie's path to be set.

That is, given a secure cookie at '/path', a non-secure cookie can be
set at '/not-path', but not at '/path/subpath'.

This carveout allows us to harden 'Secure' without breaking folks who
host both secure and non-secure applications on a single domain. That
turned out to be the root cause of the breakage Blizzard experienced
in https://crbug.com/580770.

[1]: https://github.com/httpwg/http-extensions/issues/223
[2]: https://tools.ietf.org/html/draft-ietf-httpbis-cookie-alone-01

BUG=580770
R=jww@chromium.org

Review-Url: https://codereview.chromium.org/2306393002
Cr-Commit-Position: refs/heads/master@{#417237}

This includes changing the GetBudgetDetails on BudgetDatabase to use the mojo
types and plumbing the result through the BudgetManager. It pulls out all of
the old implementation in BudetManager that used the prefs to store data
(although cleanup of that isn't quite complete). It also replaces the old
GetBudget/StoreBudget calls in the push messaging system with the new Consume
call.

Tests were added in BudgetManager for the new reserve functionality, and any
tests of GetBudget that were still applicable were moved from BudgetManager
to BudgetDatabase.

BUG=617971

Review-Url: https://codereview.chromium.org/2281673002
Cr-Commit-Position: refs/heads/master@{#417236}

Review-Url: https://codereview.chromium.org/2320723002
Cr-Commit-Position: refs/heads/master@{#417235}

BUG=625808

Review-Url: https://codereview.chromium.org/2319033004
Cr-Commit-Position: refs/heads/master@{#417234}

Nobody is looking at them, and they're not even in histograms.xml

The only thing GpuMemoryManager is doing now is populating the task
manager values.

BUG=643522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2310623002
Cr-Commit-Position: refs/heads/master@{#417233}

See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pwyjF_jAf6I/5MeKCBG8BQAJ
for context. Also https://codereview.chromium.org/2312323002 for checklicenses.

BUG=none

Review-Url: https://codereview.chromium.org/2319093002
Cr-Commit-Position: refs/heads/master@{#417232}

AppendMirrorRequestHeaderHelper added the X-Chrome-Connected header when it was required, but did not remove it when it was not required and already exited from previous redirection. The funcion is now renamed to FixMirrorRequestHeaderHelper and removes already existing header if it is not required.

BUG=588492

Review-Url: https://codereview.chromium.org/2258483002
Cr-Commit-Position: refs/heads/master@{#417231}

The XHR spec describes progress events on XHR are queued on the networking
task source, where Networking task runner is the corresponding task runner.
https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send

BUG=624696

Review-Url: https://codereview.chromium.org/2269513002
Cr-Commit-Position: refs/heads/master@{#417230}

https://chromium.googlesource.com/external/github.com/googlei18n/sfntly/+log/b18b09b..1ef790a

1ef790a Add missing header from commit c9025ecc.
6917286 Merge pull request #58 from leizleiz/leizleiz-lotsofchecks
4f1aa49 Add ReadableFontData::kInvalidUnsigned.
c9025ec Add more bounds checks in WritableFontData.
dd23046 Return error values in ReadableFontData::Read*().
813efeb Add a size limit for font tables.
08652be Add a nullptr check to GlyphTable::Glyph().

BUG=641330,641446,641460,642300
TBR=behdad@chromium.org

Review-Url: https://codereview.chromium.org/2316303003
Cr-Commit-Position: refs/heads/master@{#417229}

Use automatic functionality instead of manually calling
UseCounter::count.

BUG=636288

Review-Url: https://codereview.chromium.org/2250613002
Cr-Commit-Position: refs/heads/master@{#417228}

The revert patch was committed twice, and broke build again.
This CL is a revert of the second committed revert.

Original CL:
https://codereview.chromium.org/2318933002/
https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55

Revert CL:
https://codereview.chromium.org/2325583002
https://chromium.googlesource.com/chromium/src/+/d7586a77bd18573597cc48bbd2e0e6fb0fbc0fb9
https://chromium.googlesource.com/chromium/src/+/0f82e43808017ab95d877be86eb63fe1e4057e97

TBR=bashi@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2323673002
Cr-Commit-Position: refs/heads/master@{#417227}

Revert of [Bindings] Remove aggregation of generated binding code (patchset #3 id:60001 of https://codereview.chromium.org/2318933002/ )

Reason for revert:
Build break
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10652

Original issue's description:
> Remove aggregation of generated binding code.
>
> After this change, we maybe able to skip needless compiles
> based on redundant dependencies. (issue 388172)
> Plus, it is expected to compile those files in parallel.
>
> BUG=634231, 388172
>
> Committed: https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55
> Cr-Commit-Position: refs/heads/master@{#417216}

TBR=bashi@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634231, 388172

Review-Url: https://codereview.chromium.org/2325583002
Cr-Commit-Position: refs/heads/master@{#417226}

Revert of [Bindings] Remove aggregation of generated binding code (patchset #3 id:60001 of https://codereview.chromium.org/2318933002/ )

Reason for revert:
Build break
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10652

Original issue's description:
> Remove aggregation of generated binding code.
>
> After this change, we maybe able to skip needless compiles
> based on redundant dependencies. (issue 388172)
> Plus, it is expected to compile those files in parallel.
>
> BUG=634231, 388172
>
> Committed: https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55
> Cr-Commit-Position: refs/heads/master@{#417216}

TBR=bashi@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634231, 388172

Review-Url: https://codereview.chromium.org/2325583002
Cr-Commit-Position: refs/heads/master@{#417225}

net::WebSocketFrameParser keeps state between calls as a WebSocket frame header
can span multiple reads from the underlying socket. Up until now, the fuzzer
only simulated one read. By passing the input in multiple chunks, the coverage
of the fuzzer is increased.

Also increase max_len to 256. As the per-iteration setup cost is quite high for
this fuzzer, a larger input length makes the coverage from each iteration higher
without significantly harming speed.

R=yhirano
BUG=

Review-Url: https://codereview.chromium.org/2309723002
Cr-Commit-Position: refs/heads/master@{#417224}

BUG=627517
TBR= changes to clients of the changed APIs.
NOTRY=true
(flaky try bot: https://codereview.chromium.org/2270333002).

Review-Url: https://codereview.chromium.org/2300703005
Cr-Commit-Position: refs/heads/master@{#417223}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fe5de9d3cfc2886d3f75b36ef774259abfdac250 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/e2d6fd987e17c0a099382419f76fdffffea7659a Prompt to delete pending edits before changing the Gerrit CL description. (dsansome@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=641838

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2316403003
Cr-Commit-Position: refs/heads/master@{#417222}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5cc438d6..36997250

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2322643003
Cr-Commit-Position: refs/heads/master@{#417221}

This refactors prerender_browsertests in preparation for adding nostate prefetch
tests. The idea is to make the nostate prefetch tests independent from the
current prerender tests in order to make deprecation & removal of prerender as
easy as possible. prerender_test_utils.* contain code extracted from
prerender_browsertest.cc with only syntatic changes.

See crrev.com/2304953002 for nostate prefetch browser tests.

This does not change any functionality.

BUG=643652

Review-Url: https://codereview.chromium.org/2309443002
Cr-Commit-Position: refs/heads/master@{#417220}

Replace dbus::FileDescriptor with base::ScopedFD.

BUG=621841

Review-Url: https://codereview.chromium.org/2310883003
Cr-Commit-Position: refs/heads/master@{#417219}

Set the top controls height as the top margin for BlimpView. This fixes
the contents from being clipped at the bottom of the page and makes
touch inputs work correctly.

BUG=644417

Review-Url: https://codereview.chromium.org/2319913002
Cr-Commit-Position: refs/heads/master@{#417218}

BUG=590369

Review-Url: https://codereview.chromium.org/2313613003
Cr-Commit-Position: refs/heads/master@{#417217}

After this change, we maybe able to skip needless compiles
based on redundant dependencies. (issue 388172)
Plus, it is expected to compile those files in parallel.

BUG=634231, 388172

Review-Url: https://codereview.chromium.org/2318933002
Cr-Commit-Position: refs/heads/master@{#417216}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e385b94f6be7..fa4f083913a8

$ git log e385b94f6..fa4f08391 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 benjhayden Enable unreachable code detection in eslint.
2016-09-07 benjhayden Add Breakdown Diagnostic.
2016-09-07 benjhayden Implement geometricMean in Statistics, RunningStatistics, and Histogram.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2322883002
Cr-Commit-Position: refs/heads/master@{#417215}

BUG=638716
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2299943002
Cr-Commit-Position: refs/heads/master@{#417214}

Cr-Commit-Position: refs/heads/master@{#417213}

The out-of-line constructor generates smaller binary after
http://crrev.com/2317563002, and the binary size growth along with
the member addition to BindStateBase is slower on the out-of-line
constructor.
This CL reduces the stripped binary size of chrome by 36kB on Linux.

Review-Url: https://codereview.chromium.org/2310093003
Cr-Commit-Position: refs/heads/master@{#417212}

CommandBufferService should not accept put == num_entries, the client must
wraparound to 0 (CommandBufferHelper does).
CommandParser wraps to 0 and never sets get_ == num_entries, so
CommandParser::IsEmpty would never become true.

A test should have caught that but unfortunately it confused buffer size and
number of entries. This fixes it.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2304813002
Cr-Commit-Position: refs/heads/master@{#417211}

This implements the Chrome side support for Service Discovery Protocol.
- Retrieve SDP records from a remote device
- Create/remove a SDP record for the local device
- Convert service record/attribute between Chrome and Mojo

BUG=b:29314637
TEST=None (The manual test is blocked on chromium:627907.)

Review-Url: https://codereview.chromium.org/2149713002
Cr-Commit-Position: refs/heads/master@{#417210}

Change the timing of event dispatching and <script> execution in Node::appendChild, insertBefore, and replaceChild.

When we insert a DocumentFragment including multiple children into another node,

* WebKit and Blink: DOMNodeInserted is dispatched just after each of
  DocumentFragment children was inserted.

* Firefox and Edge: DOMNodeInserted is dispatched after all of DocumentFragment
  children were inserted.

<script> execution and <iframe> load event have the same incompatibility.

This CL makes Blink same as Firefox and Edge in order to improve interoperability
and avoid additional hierarchy check for crbug.com/523157.

Implementation:
Fold updateTreeAfterInsertion() and notifyNodeInserted() into insertNodeVector(),
and move childrenChange(), didNotifySubtreeInsertionsToDocument(), and
dispatchChildInsertionEvents() out from the loop.

Test changes:
* fast/dom/MutationObserver/removed-out-of-order.html
  DOMNodeInserted timing change.  New result matches to Firefox and Edge.

BUG=523157

Review-Url: https://codereview.chromium.org/2306323002
Cr-Commit-Position: refs/heads/master@{#417209}

This patch converts "fast/dom/Range/deleteData-replaceData-count-overflow.html"
to use w3c test harness to simplify test case and make this test script
independent from selection behavior, since this test script verifies methods
of |Range| object, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2321863002
Cr-Commit-Position: refs/heads/master@{#417208}

While deserializing, make a note of all changed nodes via id before performing any tree changes/removals.

While removing (non-atomically), reference the changed list to ensure we notify delegates of nodes that will actually be deleted and not just deleted then re-created as part of bookkeeping to enforce the "non-reparenting" invariant inside of AXTree::CreateChildVector.

BUG=642799
TEST=for each of the reproductions in the bug, ensure the automation api (as a client) does not destroy then re-create js objects; rather, ensure it re-uses them for reparented trees.

Review-Url: https://codereview.chromium.org/2080573003
Cr-Commit-Position: refs/heads/master@{#417207}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cb19e3cfb00ef7f6732073bcf0c8ed1d8bd1d531 WebRTC: Promote Linux 32-bit bots to main waterfall again. (kjellander@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644167

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2319413002
Cr-Commit-Position: refs/heads/master@{#417206}

Replace dbus::FileDescriptor with base::ScopedFD.

BUG=621841

Review-Url: https://codereview.chromium.org/2317593002
Cr-Commit-Position: refs/heads/master@{#417205}

All tabs created by TabDelegate.createNewTab() are treated as from external
apps.
However, if the tab was created from Chrome's own UI, we shouldn't do
this.
Otherwise, clicking the back button will dismiss the Chrome app.
This change also passes the header String when creating a new tab.
This allows Chrome UI to create tabs with correct header Strings.

BUG=637239

Review-Url: https://codereview.chromium.org/2319143004
Cr-Commit-Position: refs/heads/master@{#417204}