GitLab

R=jcivelli@chromium.org
BUG=108171


Review URL: http://codereview.chromium.org/10027014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132223 0039d316-1c4b-4281-b951-d872f2087c98

Also retry if OAuth fetcher is cancelled during verification.

BUG=122972
TEST=Manual. Sign with SPDY proxy enabled. Sign out. Notice that OAuth token is valid i.e. you're not asked for OTP.

Review URL: http://codereview.chromium.org/10008079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132222 0039d316-1c4b-4281-b951-d872f2087c98

Properly process the ISOLATE_DEBUG environment variable value as an int.

R=nsylvain@chromium.org
BUG=98834
TEST=


Review URL: http://codereview.chromium.org/10073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119250
Review URL: https://chromiumcodereview.appspot.com/9958034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132218 0039d316-1c4b-4281-b951-d872f2087c98

Fix flakiness in unload browser test, take two. I was able to repro this on my Linux box (~10% of the time). The issue turned out to be that the beforeunload ack from the renderer would sometimes come after the second time that we try to close the tab. The browser wouldn't put up the beforeunload prompt because it was waiting for the previous ack. The old ui test had a 10 second sleep here which masked this.

BUG=123110
Review URL: https://chromiumcodereview.appspot.com/10065041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132217 0039d316-1c4b-4281-b951-d872f2087c98

These became unnecessary when we switched away from using factories to create DataSource objects in r118338.

TBR=acolwell

Review URL: https://chromiumcodereview.appspot.com/10091001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132215 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118641
Review URL: https://chromiumcodereview.appspot.com/10038040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132214 0039d316-1c4b-4281-b951-d872f2087c98

It's wrong to have OnDirectoryChanged in MockGDataSyncClient,
as GDataSyncClient is not interested in the event.

BUG=none
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/10073005

TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10084018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132213 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132211 0039d316-1c4b-4281-b951-d872f2087c98

(cloned http://codereview.chromium.org/9699069/#ps35007 since it was reverted)

This adds glue for JSEP PeerConnection. PeerConnectionHandler is split in two classes and a base class. The class name is kept for the old ROAP PeerConnection to be aligned with WebKit naming. ROAP is planned to be removed pretty soon, then the classes can be refactored.

See also main WebKit bug https://bugs.webkit.org/show_bug.cgi?id=80589
(In particular https://bugs.webkit.org/show_bug.cgi?id=82450)

TEST=content_unittests and manual webrtc test.

BUG=123130
TBR=darin

Review URL: http://codereview.chromium.org/10008077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132210 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132209 0039d316-1c4b-4281-b951-d872f2087c98

From experience of measuring the time to succeed on our bots, 1 in 10000 times
the start time came up as high as 25 seconds.  This bumps the theoretical
sleep time over that threshhold.

Also updated the title comment description, since this changes the numbers,
and the rest was not updated as the purpose expanded.

R=sadrul@chromium.org
BUG=103882
TEST=try jobs.

Review URL: http://codereview.chromium.org/10008101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132208 0039d316-1c4b-4281-b951-d872f2087c98

We should aquire num_pending_tasks_lock_ BEFORE we reset on_io_completed_ event.
We should do that to avoid following scenario:
* num_pending_tasks_ equals 1.

* We reset on_io_completed_ event in PostBlockingPoolSequencedTask and
ask for num_pending_tasks_lock_ to increase num_pending_tasks_

* At the same time RunTaskOnIOThreadPool finishes running its task and
asks for the same lock to decrease num_pending_tasks_

If RunTasksOnIOThreadPool gets the lock first, it will decrease
num_pending_tasks_ to 0, signal on_io_completed_ and thus undo reset
done in  PostBlockingPoolSequencedTask .

If we don't reset on_io_completed_ before GData file system begins its
destruction, we may leave task on blocking pool pending after the
gdata_file_system object is destroyed. This is dangerous since tasks on
blocking pool can alos access file system's data members.

BUG=122717
TEST=GData unit_tests

Review URL: https://chromiumcodereview.appspot.com/9960089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132207 0039d316-1c4b-4281-b951-d872f2087c98

For accelerated content, switch to a less scary method of fixing window shadows that works better.

BUG=53382,56154,120772
TEST=go to accelerated page, notice no square corners


Review URL: http://codereview.chromium.org/10037008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115275
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10089001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132205 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132204 0039d316-1c4b-4281-b951-d872f2087c98

preventDefault in handleDrop, as suggested by arv

BUG=122850
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10065034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132203 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: http://codereview.chromium.org/10083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132202 0039d316-1c4b-4281-b951-d872f2087c98

libcompositor (.so) gets linked against libwebkit_fileapi (.a) and libwebkit_quota (.a), each of which is built with googleurl, but does not include it as a dependency, causing libcompositor (.so) to not include all of the symbols it requires.

R=kinuko@chromium.org
BUG=112626
TEST=Compiled chromeos with shared library on a buildbot like setup.

Review URL: http://codereview.chromium.org/9980022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132201 0039d316-1c4b-4281-b951-d872f2087c98

DEPTH support will eventually be removed from isolate.py since this variable is
not used inside chromium's gyp anymore.

R=nsylvain@chromium.org
BUG=98834
TEST=


Review URL: http://codereview.chromium.org/10066035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132200 0039d316-1c4b-4281-b951-d872f2087c98

Special handling of CWS icon.
Also correctly handle URL rewrites in favicon requests.

BUG=chromium-os:28314,chromium:120471
TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon.
Review URL: https://chromiumcodereview.appspot.com/9979001

TBR=dgozman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121729
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10084012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132198 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/10069032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132197 0039d316-1c4b-4281-b951-d872f2087c98

Special handling of CWS icon.
Also correctly handle URL rewrites in favicon requests.

BUG=chromium-os:28314,chromium:120471
TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon.
Review URL: https://chromiumcodereview.appspot.com/9979001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15189
TEST=unit tests


Review URL: http://codereview.chromium.org/7233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132195 0039d316-1c4b-4281-b951-d872f2087c98

"Detab" content/browser/renderer_host.

BUG=105875
TEST=no change


Review URL: http://codereview.chromium.org/10073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132194 0039d316-1c4b-4281-b951-d872f2087c98

"Detab" content/browser/debugger.

BUG=105875
TEST=no change


Review URL: http://codereview.chromium.org/10065017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132193 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=121657
TEST=PluginFinderTest.*


Review URL: http://codereview.chromium.org/10066016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119242
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10084008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132190 0039d316-1c4b-4281-b951-d872f2087c98

This is part of removing more hard-coded file lists from the buildbot
scripts, specifically symsrc_binaries from site_config/config.py.

Review URL: https://chromiumcodereview.appspot.com/10069045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132189 0039d316-1c4b-4281-b951-d872f2087c98

This is needed, because views::Combobox does NOT own its model.

BUG=122092
TEST=play with this dialog, try the comboboxes, they should work as before, and
we shouldn't see any crashes.
R=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10050030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132188 0039d316-1c4b-4281-b951-d872f2087c98

and change "Set Wallpaper..." string to "Set wallpaper..."

BUG=120763, 122728
TEST=Loggin as guest, close all browser windows, right click on desktop background,
verify the "Set wallpaper..." option in the context menu is disabled.

Review URL: https://chromiumcodereview.appspot.com/10038020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132187 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132186 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org


Review URL: http://codereview.chromium.org/10079001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29235
TEST=

Review URL: https://chromiumcodereview.appspot.com/10065039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromeium-os:28681
TEST=Copy files from the issue to the Downloads folder.

Review URL: https://chromiumcodereview.appspot.com/10082006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132182 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132181 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib@chromium.org

Review URL: http://codereview.chromium.org/10086002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116954
TEST=none

Review URL: http://codereview.chromium.org/9835049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22836
TEST=Move through the list or grid using arrow keys, observe that the item under the mouse is not highlighted. Move the mouse, observe the hover highlighting.

Review URL: https://chromiumcodereview.appspot.com/10079002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132178 0039d316-1c4b-4281-b951-d872f2087c98