- 25 Feb, 2019 40 commits
-
-
Nico Weber authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/37a60998cade..30153b4eb581 $ git log 37a60998c..30153b4eb --date=short --no-merges --format='%ad %ae %s' 2019-02-22 thakis breakpad: Remove semicolons, mac edition. Created with: roll-dep src/third_party/breakpad/breakpad Bug: 926235 Change-Id: I675d9e89a94499be37e76719b687fb3709f52094 Reviewed-on: https://chromium-review.googlesource.com/c/1486715 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635151}
-
Morten Stenshorne authored
Remove NGInlineChildLayoutContext from NGBlockLayoutAlgorithm. This structure is quite big, and since we stack-allocate the alogorithms, this matters. Only stack-allocate NGInlineChildLayoutContext on demand (when children are inline). This saves 816 bytes [*] of stack space per in-flow layout recursion. [*] Linux 64bit release. Bug: 930637 Change-Id: I40c12cb6e7996e54c9bf3ebe7285350591c90fef Reviewed-on: https://chromium-review.googlesource.com/c/1485238Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#635150}
-
Aaron Krajeski authored
ImageBitmapRenderingContext.toDataURL() does not throw CORS errors when reading from a tainted canvas. It is not super urgent right now as the entire functionality is broken, it simply returns black pixels, so there is no security vulnerability RIGHT now. Regardless once https://bugs.chromium.org/p/chromium/issues/detail?id=838108 is fixed, it will expose a problem. Currently toDataURL() in dev builds fails https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/graphics/unaccelerated_static_bitmap_image.cc?q=unaccelerated_static_bitmap_image&sq=package:chromium&dr=C&l=28 and on https://cs.chromium.org/chromium/src/cc/paint/paint_image_builder.cc?dr=C&q=paint_image_builder&sq=package:chromium&g=0&l=47 not sure when this was introduced, but as of now we have no tests for toDataURL(). toDataURL() with LOCAL images also appears to be broken for ImageBitmapRenderingContext, as it just returns empty images. Will add tests and try to fix those problems in other CLs Bug: 930057 Change-Id: Id22d22310ae2130472f1a3cbc104cfe632a7129c Reviewed-on: https://chromium-review.googlesource.com/c/1474546Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635149}
-
Nico Weber authored
Bug: 926235 Change-Id: I9f9018856c94a6863ab04f7cb058abc0d9645840 Reviewed-on: https://chromium-review.googlesource.com/c/1486713 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635148}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/507158f88d4d..e3b205b1202f git log 507158f88d4d..e3b205b1202f --date=short --no-merges --format='%ad %ae %s' 2019-02-25 nigeltao@google.com Update Wuffs version Created with: gclient setdep -r src/third_party/skia@e3b205b1202f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: If10424bd21f79e15445f3e9210ecc6a9ae5b2f4a Reviewed-on: https://chromium-review.googlesource.com/c/1486511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635147}
-
Eugene But authored
Return non-zero rect from WKWebView.frame to avoid DCHECK. Additional changes: - rename mock_wk_list_ to fake_wk_list_ - create fake_wk_list_ in SetUp - consistently use OCMock3 API Bug: 935056 Change-Id: I1ce700ad1fd0db03230535fa72799699a26c0ccd Reviewed-on: https://chromium-review.googlesource.com/c/1484973 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635146}
-
Emily Hanley authored
This reverts commit 234e5b3a. Reason for revert: <INSERT REASONING HERE> Original change's description: > Batch Histogram uploads. > > Some benchmarks such as rendering.mobile produce more data than the chromeperf > dashboard can handle at once. > This CL passes the new --max_bytes flag to add_reserved_diagnostics to batch > histograms into multiple files, then uploads them one at a time. > > Bug: chromium:909961 > Change-Id: Ia3e16657c6bf0bfbf0e1da9671ebe0852f9e70d3 > Reviewed-on: https://chromium-review.googlesource.com/c/1478085 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Simon Hatch <simonhatch@chromium.org> > Commit-Queue: Ben Hayden <benjhayden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634220} TBR=benjhayden@chromium.org,simonhatch@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:909961 Change-Id: Ie3bd895037266bd88e31f1275b784a86f8ed23c3 Reviewed-on: https://chromium-review.googlesource.com/c/1486679Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635145}
-
Jérôme Lebel authored
Opens the sync encryption dialog when the user taps on the "Encryption" item. Bug: 914059 Change-Id: I5a750107f2594e64c4d81e468a47c8a7607e5286 Reviewed-on: https://chromium-review.googlesource.com/c/1477237 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#635144}
-
Yi Su authored
ios_web_shell_egtests.PDFTestCase can be removed now since it's covered by WebStateObserverTest.PdfFileUrlNavigation. Bug: 930859 Change-Id: I5bfc34f825908b1380e52a7eb1e0a20450033661 Reviewed-on: https://chromium-review.googlesource.com/c/1486533 Commit-Queue: Yi Su <mrsuyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635143}
-
Scott Haseley authored
There were some cases where if BeginMainFrameNotExpectedSoon was not sent when the scheduler initally stopped observing frames, it would not be sent when the client (blink scheduler) needed it. This led to requestIdleCallback getting stuck in a state where idle tasks would queue but not run since the blink scheduler was unaware the the CC was in a long idle state. This CL splits the NOTIFY_BEGIN_MAIN_FRAME_NOT_SENT -- which could have resulted in either BeginMainFrameNotExpected[Until|Soon] messages being sent -- into two separate actions. If the scheduler is in a long idle period and has not already send a BeginMainFrameNotExpectedSoon message in that frame, it will now send one when requested. This also adds several unit tests: - Test for not sending more than one BeginMainFrameNotExpected* message in the same frame. - Test that BeginMainFrameNotExpectedSoon is sent if it wasn't initially needed when entering a long idle period. - Test that BeginMainFrameNotExpectedSoon is sent when requested if it wasn't initally, even if BeginMainFrameNotExpectedUntil was sent in the frame (this previously failed). - Test that BeginMainFrameNotExpectedSoon is sent when requested if it wasn't initally, even if visibility changed to false while inside of BeginImplFrame (this previously failed). Bug: 893653 Change-Id: I242aa5aa247200993f837fc577e18d4e27c4a0bf Reviewed-on: https://chromium-review.googlesource.com/c/1474806 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#635142}
-
Roman Sorokin authored
s/QuitWhenIdle/Quit Bug: none Change-Id: Ideb2560ec8ba637e4b29644a73e9a32e68cba724 Reviewed-on: https://chromium-review.googlesource.com/c/1482980Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f408608..d7d9726d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I931698add5214f076f952028527fd589f0be13cf Reviewed-on: https://chromium-review.googlesource.com/c/1486116Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635140}
-
Michael Lippautz authored
Canonical fix: - Model liveness through PannerNode (AudioNode), i.e., keep alive listener from there. - Change off-thread handler to use a weak root This works as AudioNode disposes the handler in the pre-finalizer. Bug: 928781, 843903 Change-Id: I3b7454adcfbd2ab2c993974c3cda0415c1a20427 Reviewed-on: https://chromium-review.googlesource.com/c/1486092Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#635139}
-
Xiaocheng Hu authored
Bug: 935587 NoTry: True Tbr: xiaochengh@chromium.org Change-Id: Ic438a578728b6cfe4a5897dd22c37af5606fe3f4 Reviewed-on: https://chromium-review.googlesource.com/c/1486835Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635138}
-
Fredrik Söderquist authored
This enumeration value is only used during style resolution, and thus there should be no need to handle it elsewhere. This allows cleaning up the ShouldFullyInvalidateFillLayersOn*Change helpers as well, removing the only users of StyleImage: :UsesImageContainerSize() and in turn also Image: :UsesContainerSize(), so removing those as well. Change-Id: I6400ca9acf98359712891fc74e1a232a2cfbc208 Reviewed-on: https://chromium-review.googlesource.com/c/1486354Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#635137}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8deadd8d022c..b92fa105572a git log 8deadd8d022c..b92fa105572a --date=short --no-merges --format='%ad %ae %s' 2019-02-25 cwallez@chromium.org KnownObject: Make it an error to request ID 0 Created with: gclient setdep -r src/third_party/dawn@b92fa105572a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:934360 TBR=cwallez@chromium.org Change-Id: I07642d4fcad4e3339bf6becf4ce8a8ffad92fed5 Reviewed-on: https://chromium-review.googlesource.com/c/1486065Reviewed-by:
-
Guido Urdaneta authored
Bug: 921006 Change-Id: I7c10d5a7cde82d6fb921ce93bde7559ab15c5a5c Reviewed-on: https://chromium-review.googlesource.com/c/1486171Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#635135}
-
Josh Karlin authored
Change-Id: Ib927874446324cc5f6aabfc9c9824846a3831022 Reviewed-on: https://chromium-review.googlesource.com/c/1486678Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635134}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e2d8b1286ce3..5efe61188243 git log e2d8b1286ce3..5efe61188243 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 sugoi@google.com Assert there are no unmatched eglBindTexImage/eglReleaseTexImage Created with: gclient setdep -r src/third_party/swiftshader@5efe61188243 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: If7602f8693f0743b4dc02dfd83720f498779d0bb Reviewed-on: https://chromium-review.googlesource.com/c/1486831Reviewed-by:
-
Philip Rogers authored
PaintTouchActionRects has shipped [1] so we can remove the previous touch action rect code. [1] https://groups.google.com/a/chromium.org/d/msg/paint-dev/IVeEDDT0Tk8/SrroWsrVBAAJ Change-Id: I53d95388015c258c52347a33f26e1db0df83ab41 Reviewed-on: https://chromium-review.googlesource.com/c/1485235 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635132}
-
Robert Ogden authored
Also cleans up the web report test whitespace and line breaks Bug: 934865 Change-Id: I5cc7d9d9fc08e50408982047d060f90446dc420e Reviewed-on: https://chromium-review.googlesource.com/c/1483358Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#635131}
-
Maksim Sisov authored
WaylandScreen::GetDisplayForAcceleratedWidget might be called right after the browser closed the WaylandWindow (on shutting down, for example), which may result in segfault or DCHECK. R=rjkroege@chromium.org Bug: 578890 Change-Id: Ic2b6fc5b9853a1aec7e5e70a0e979dc6c9e87aea Reviewed-on: https://chromium-review.googlesource.com/c/1485933Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#635130}
-
kylechar authored
Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 714018 Change-Id: I6a5e8501e1bb824afc1e9ceb11232709b4eb47fd Reviewed-on: https://chromium-review.googlesource.com/c/1486631 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#635129}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/37b584a73669..fc3897b5f585 git log 37b584a73669..fc3897b5f585 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 9856269+sarahM0@users.noreply.github.com Validate: (data) Block can't appear within a Block (#2410) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fc3897b5f585 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb74ecc2017c17c66d7ee87ddc4b85cde2771e67 Reviewed-on: https://chromium-review.googlesource.com/c/1486651Reviewed-by:
-
Chris Lu authored
Bug: 919685 Change-Id: I29969e5029028e7af0c64a4f6089aabc4b884055 Reviewed-on: https://chromium-review.googlesource.com/c/1483260 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
This relands commit 90ffaeaa, which has been reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1484088 See fix in ps2, the issue is that DCHECK(foo) calls aren't optimized away in release builds (they're disabled but still compiled). (TBR'ing jwd@ as this is a reland and nothing has changed in the code he owns). TBR=jwd@chromium.org Bug: 771478 Change-Id: Ifbd9873a1db870b35a7ad6fafc7763b0f2f3c090 Reviewed-on: https://chromium-review.googlesource.com/c/1486451 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#635126}
-
Andrew Grieve authored
Change-Id: I989e2d26c4ce97c5cdcf2d54fa2d5bc024ba9087 Reviewed-on: https://chromium-review.googlesource.com/c/1477962 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#635125}
-
Lukasz Anforowicz authored
Now that |CommonNavigationParams::initiator_origin| is available (and trustworthy - see https://crbug.com/919144#c12 and #c7) RenderFrameHostImpl (and its helper function GetOriginForURLLoaderFactory) can calculate an exact origin lock (rather than falling back to a site-URL-based lock). Bug: 918967, 888079 Change-Id: I3b180a785d5171bb924761e44fafb482314c1132 Reviewed-on: https://chromium-review.googlesource.com/c/1450237 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635124}
-
Alexandre Frechette authored
We do not expect user location to change drastically in between Chrome sessions. Hence, caching the geolocated languages persistently in a pref should reduce the number of times we will need to inflate geo-language data. Bug: 929155 Change-Id: I894b8828d5411e652b44d10ff70adfb07a3a7f6e Reviewed-on: https://chromium-review.googlesource.com/c/1476987 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#635123}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/1019978, the fontconfig cache is independent of the name of the build directory. With this, the linux/release build is the first build configuration where all files mentioned in isolates (i.e. all executables covered by tests, including chrome, and all files needed to run chrome) are deterministic and independent of the name of the checkout directory and of the name of the build directory. If your local build dir is two levels deep (so that the path from build dir to checkout root is ../..) and you use the same gn args and the same revision as the det bots, you will get exactly the same bits in your local build as the bots. (Also add todo comments pointing out that the android and mac bots currently test a weaker form of build determinism than the linux and win bots.) Bug: 908463,314403,330263 Change-Id: Ic571b8ad63323f381f36539540545f19d295989d Reviewed-on: https://chromium-review.googlesource.com/c/1486071Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee9ff700224e..4b1953a0012f Created with: gclient setdep -r src-internal@4b1953a0012f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iabdf24ac587fb313de3e5125544587ecc55bd0aa Reviewed-on: https://chromium-review.googlesource.com/c/1486063Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635121}
-
Leonard Grey authored
Tracing categories are mostly guesswork; we'll need to refine these down the line. Bug: 934981 Change-Id: I96b86f67b01eafbb81ac12fc209bacba69fb0dfb Reviewed-on: https://chromium-review.googlesource.com/c/1483707 Commit-Queue: Leonard Grey <lgrey@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635120}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/601d898e6096..8747978ce6f5 git log 601d898e6096..8747978ce6f5 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 lalitm@google.com Merge "Fix PagedMemory, use -1 FD for mmap to fix WASM" 2019-02-25 lalitm@google.com Merge "trace_processor: fix printing of clock sync rate events" Created with: gclient setdep -r src/third_party/perfetto@8747978ce6f5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I10388e0ee58f5ba316f0e4ca6e3cd48fe2c8516d Reviewed-on: https://chromium-review.googlesource.com/c/1486068Reviewed-by:
-
Sylvain Defresne authored
Update the implementation of NotificationPromo to use JSONReader::Read instead of JSONReader::ReadDeprecated and fix calling code. Convert to use new base::Value API instead of using base::DictionaryValue too. Bug: 925165 Change-Id: I2077c0537fa416478b62a017b8617c842b32706c Reviewed-on: https://chromium-review.googlesource.com/c/1477229 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
dalyk authored
Cached results that are obtained insecurely are not a valid substitute for sending a DoH query. This cl takes the first step towards this goal by storing results in the cache with a key that indicates whether the results were obtained via DoH ("secure") or not. Some results that are stored with an "insecure" key may have actually been obtained securely (i.e. via DoT), but we store them with an insecure key because we don't know how they were obtained. CT log inclusion checks will be updated in a follow-up CL to use secure DNS if the associated hostname lookup was resolved securely. The behavior of the CT log inclusion checks is not altered by this CL. Bug: 878582 Change-Id: Ic88bb3c4a3af4e2695e8b382d598de042e26e580 Reviewed-on: https://chromium-review.googlesource.com/c/1450434 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#635117}
-
Eyor Alemayehu authored
Per feedback from: https://chromium-review.googlesource.com/c/chromium/src/+/1465070 updated documentation for preferences that can be overridden by administrator policies. Bug: b:124113875 Change-Id: I2b47ae6a031b3e65dcbc1348d4050600c63a8307 Reviewed-on: https://chromium-review.googlesource.com/c/1483258Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eyor Alemayehu <eyor@google.com> Cr-Commit-Position: refs/heads/master@{#635116}
-
Elly Fong-Jones authored
This change assigns: enable-gpu-appcontainer enable-appcontainer to forshaw@ and wfh@. Bug: 933708, 807249 Change-Id: I9cf2cb5561bcd7c9dfa2129a191e91e51d3e1bd2 Reviewed-on: https://chromium-review.googlesource.com/c/1486432 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#635115}
-
Denis Kuznetsov authored
Bug: 912704 Change-Id: Ie1804ce8a6f05721e28a6d2c703530d8e0c53841 Reviewed-on: https://chromium-review.googlesource.com/c/1481511 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#635114}
-
Stephane Zermatten authored
This change removes dead code from the controller, which would register itself as WebContentsObserver. This was never exercised in production, because there's already a WebContentsObserver and there can be only one (on Android, it's TabWebContentsDelegateAndroid.) Bug: 806868 Change-Id: I7920010cfe6df2ceb241fd393faf427adb46d83a Reviewed-on: https://chromium-review.googlesource.com/c/1486272Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635113}
-
Lowell Manners authored
Calling GetSafeWeakWrapper() is preferable to explictly constructing a WeakWrapperSharedURLLoaderFactory, because GetSafeWeakWrapper guarantees that Detach() will be called when the underlying TestURLLoaderFactory is destructed. Bug: 924960 Change-Id: I9e61c0b098a50972a189c1cdac56fc661f455e0d Reviewed-on: https://chromium-review.googlesource.com/c/1475448Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#635112}
-
