- 07 Aug, 2018 40 commits
-
-
Christopher Cameron authored
Query SupportsSeparateFramebufferBinds to determine if the framebuffer target should be GL_DRAW_FRAMEBUFFER_EXT or GL_FRAMEBUFFER_EXT. Update tests so that one test uses an ES2 context and tests target GL_FRAMEBUFFER_EXT, while the other test uses an ES3 context and tests target GL_DRAW_FRAMEBUFFER_EXT. Bug: 848952 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If9ff227498e10aef912f38e7bc26700c7513ed87 Reviewed-on: https://chromium-review.googlesource.com/1165597 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#581312}
-
Peng Huang authored
For OOPD, the display compositor is in the viz process. The LayerTreeFrameSinkLocal used by exo is for submitting frames to a local display compositor, so it will not work with OOPD. To make it work, we need use the AsyncLayerTreeFrameSink which can submit frames to the remote display compositor in viz process via mojo IPC. And the AsyncLayerTreeFrameSink also works with a local display compositor, so we will use it for non-OOPD case as well. Bug: 866898 Change-Id: I2003c8a6744547ee0c62c38667727c594ccb4537 Reviewed-on: https://chromium-review.googlesource.com/1153404Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581311}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1bd4bfb0c2d8..b983a4b28b83 git log 1bd4bfb0c2d8..b983a4b28b83 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 jmadill@chromium.org Pass Context to Framebuffer::invalidateCompletenessCache. 2018-08-07 jmadill@chromium.org Remove excess gl:: prefixing in validationES.cpp. Created with: gclient setdep -r src/third_party/angle@b983a4b28b83 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Id7a4cfa3b1403fde12b1fc946eb2a42643dd4d74 Reviewed-on: https://chromium-review.googlesource.com/1165523Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581310}
-
jonross authored
This relands the following change: Enable FlingSchedulerMac Enable tests that were disabled because of this functionality missing. Bug: 842325 Change-Id: I6f540460f4e5f81d7ff8dd36e4abf369f0bd4785 Reviewed-on: https://chromium-review.googlesource.com/1149612Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#577957} This was identified as a cause of flakiness in Mac webkit_layout_tests. But that test's flakiness also pre-dated this patch. The test in question has also been marked to expect fails on Mac. The source of that flakiness will be investigated separately. Change-Id: I22364cb8e18507b528c6c0c32f452fcf208caf7e Reviewed-on: https://chromium-review.googlesource.com/1162716 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#581309}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. We are using SERIAL_EXECUTOR in clearSharedImages and shareImage since they don't appear to be thread safe, and they could potentially be called multiple times. We are using the UI thread in getShareableIconAndName since we immediately call get() on it anyway. This negates any benefit for having an AsyncTask. Bug: 869907, 729737 Change-Id: I9ea44efba2155bb2b643f6d4d8f2b38c8365f418 Reviewed-on: https://chromium-review.googlesource.com/1161218 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581308}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite is stuck on the SERIAL_EXECUTOR. We make this requirement explicit. Bug: 869907 Change-Id: I651a27380b514600793a248babd41aa556983fb1 Reviewed-on: https://chromium-review.googlesource.com/1162714Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#581307}
-
Robert Ma authored
Prevent FindIt from auto-reverting import CLs. Bug: 871392 Change-Id: If4fb4abfcbf0e1e7bf95b8272701031ccb96ee38 Reviewed-on: https://chromium-review.googlesource.com/1164030Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#581306}
-
Elly Fong-Jones authored
This change causes all buttons to use focus rings on platforms that use them. Bug: 847121 Change-Id: Ida4fba2004d03d6482fd7c4da6dd3cbb8b13a72b Reviewed-on: https://chromium-review.googlesource.com/1163315Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581305}
-
erikchen authored
This CL uses ui::PlatformEventSource observer API to hook into pre and post native event dispatch on Linux. Timestamps for X11 events are in X11 server time. The implementation makes a round-trip to the X11 server to obtain a delta, and then uses that delta with base::TimeTicks::Now() to convert to a base::TimeTicks. The overhead from the rount-trip seems reasonable. 99th percentile X11 RTT is 3ms. 99.9th percentile is 16ms. 99.99th percentile is 40ms. These include the time for syscalls to base::TimeTicks::Now(). To further reduce overhead, this CL changes the UMA metric to only be computed with 1/1000 frequency, to avoid two calls to base::TimeTicks::Now(). Note: The implementation of native event observer will be turned on via Finch experiment to measure overhead. Change-Id: I786537f093e862a7a19630c9150606a2eb8267d9 Bug: 859155 Reviewed-on: https://chromium-review.googlesource.com/1162658Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581304}
-
Li Lin authored
Add STREAM_MP3 in GetSupportedStreamEncodings to unblock open media in browser before decoder is ready. Bug: b:112162166 Change-Id: I7cbc3a753742ac9626877b8b76acc052328c90a1 Reviewed-on: https://chromium-review.googlesource.com/1164164Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581303}
-
Fernando Serboncini authored
Replace current ThreadId check with a sequence checker. We also add a test that tests font fallback, so PpapiBlinkPlatformImpl::SandboxSupport::GetFallbackFontForCharacter actually gets tested somewhere. Bug: 866645 Change-Id: I743eb9cd6a1004c25074b907a50e9b4cf680f805 Reviewed-on: https://chromium-review.googlesource.com/1165312Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Maggie Chen authored
There are failurs in Win7 FYI Release (AMD) bot after removing it from the test suit exceptions. Now add it back to the list to keep the bot green. Bug: 868143 Change-Id: I5af929eba7db8f57b334ab759e0a194d8e29e5f9 Reviewed-on: https://chromium-review.googlesource.com/1165662Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581301}
-
Michael Thiessen authored
If we lose our GL context, which could potentially happen on pre-Daydream devices, we can just exit VR and expect the user to re-enter. On Daydream-ready devices context loss should only happen if we fail to turn on Async Reprojection, so we should just not enter VR if we fail to turn it on (the experience would suck anyways). Bug: 870743 Change-Id: Ic2052ff5ef4a7977cb8626df00aee57480e5d2f2 Reviewed-on: https://chromium-review.googlesource.com/1162277Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#581300}
-
Clark DuVall authored
This is a reland of 41b81861 The original change was reverted for an old build that didn't have the fix in the reland. Original change's description: > Reland "Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service" > > This is a reland of c9cbab07 > > request_completed_ was being set unnecessarily after RemoveRequest was called. > > Original change's description: > > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > > > The error event was not being sent when the client was reset. > > > > Bug: 721414 > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > > Reviewed-on: https://chromium-review.googlesource.com/1150403 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580911} > > TBR=jam@chromium.org > > Bug: 721414 > Change-Id: I48769a4b86d2a18acbe5fbcedb9de3ed478e4c54 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1164209 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581058} TBR=jam@chromium.org Bug: 721414, 871601 Change-Id: Ia42b661e48b61a6d1cffab453710160ac0f5b8d7 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1165503Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581299}
-
Esmael El-Moslimany authored
Bug: 869528 Change-Id: I07ed3e041a24612b063d9b85e05305811b903fb9 Reviewed-on: https://chromium-review.googlesource.com/1159324Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#581298}
-
Ben Pastene authored
This reverts commit e64c72b9. Reason for revert: This causes the https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests bot to turn red with webkit_layout_tests failures that are empty. Original change's description: > Stop running webkit_layout_tests on mac 10.12 and 10.13 w/ GPUs. > > And disable http/tests/media/video-load-metadata-decode-error.html, > which appears to have a dependency on GPUs. > > Bug: 854874, 871445 > Change-Id: I254ce21953ac428351203d6479e1936347ce5b4c > Reviewed-on: https://chromium-review.googlesource.com/1162963 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581074} TBR=dpranke@chromium.org,kbr@chromium.org,bpastene@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854874, 871445, 871830 Change-Id: Ia9963a9f3cb6dbaad0f7a8b78723bf0dc034d052 Reviewed-on: https://chromium-review.googlesource.com/1165846 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#581297}
-
Becca Hughes authored
Add a block autoplay pref that is available on all platforms except Android. BUG=865548 Change-Id: I4b09105da1ed901ac8a8ad8bb9ec984237b0662b Reviewed-on: https://chromium-review.googlesource.com/1165494Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#581296}
-
Geoff Lang authored
TBR=zmo@chromium.org BUG=angleproject:2761 BUG=angleproject:2760 BUG=795030 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I27b47f2ce8b8b66c9bb0577cf627b5998f043fe8 Reviewed-on: https://chromium-review.googlesource.com/1165587 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581295}
-
Miguel Casas authored
This CL does two things to support the correct SkSurface orientation for low latency canvas 2D contexts to get promoted to overlay: 1. CanvasRenderingContext::IsOriginTopLeft() is extended in 2D canvases to return false if IsAccelerated() (because those refer to the bottom left) -- but true if it IsSingleBuffered(). This is needed to support overlays on Intel, which can only be top left (and other platforms/archs like ARM RockChip are OK with it anyway). 2. CanvasResourceProvider::Create() gets a new parameter, namely |is_origin_top_left|, which is by default true (since that's how Canvases work by default). The callsites where true is not the right thing are corrected. Bug: 869161 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia798bd674b3f9e42063e5ae8b4017bfdd9e60d48 Reviewed-on: https://chromium-review.googlesource.com/1160774Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Robert Ma authored
Following https://crrev.com/c/1154107, the test results JSON no longer collapses multiple retries if they are all same, so some of the assumptions in the expectations updater no longer hold. This CL changes the updater to properly support multiple retries in the "actual" results. Besides, add a "--patchset" argument to the tool for easier debugging. Bug: 870528 Change-Id: Ia6045eac7781708046a7ab8f07eb40c23a9f5897 Reviewed-on: https://chromium-review.googlesource.com/1164027 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Directories "metrics" and "vr" have errors. All the other directories are enumerated because gn doesn't support negative list. Bug: 367595 Change-Id: If009fa36916dacd9d67aea95a6b22b13c9e37919 Reviewed-on: https://chromium-review.googlesource.com/1164579Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581292}
-
Jérôme Lebel authored
Settings data type is missing from the all the data type to sync. It should have been added from the beginning. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idb972d67856c324e9899762c05bfd7c84b07d6b0 Reviewed-on: https://chromium-review.googlesource.com/1158404Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581291}
-
Marina Ciocea authored
Temporary disable feature until fixing regression reported in linked bug. Bug: 870171 Change-Id: Ib66b1d5c820e257f2ade9cd6f492339639a241c6 Reviewed-on: https://chromium-review.googlesource.com/1164364Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#581290}
-
Ella Ge authored
font size property is set on CSS pixel, but it's calculated from video size, which is in physical pixel after use-zoom-for-dsf enabled on Android. This CL applys the page zoom factor to the video track font size. Bug: 870243 Change-Id: If597e115b8f77395bbd21ac90d0112c7a86ee62f Reviewed-on: https://chromium-review.googlesource.com/1160775Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#581289}
-
Calder Kitagawa authored
This CL adds a persistent variant of the Snackbar with the following properties: - Persistent snackbars do not time out (setting their duration has no effect). - Persistent snackbars appear last (they appear below notification or action snackbars). Bug: TODO Change-Id: I440373c8b54e90b0709b91b87748ce6eac01c3e1 Reviewed-on: https://chromium-review.googlesource.com/1159173 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Commit bf7722f9 ('Reland "Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service"') caused the GCC build to hit https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849, where having base::NoDestructor<T<U>> and passing an initializer list of Us does not work. Explicitly create an std::set<string> to pass to base::NoDestructor, just like we did in https://chromium-review.googlesource.com/944405 before. Bug: 819294 Change-Id: I8077b39959d8a53daef40bc33f8293f15c597ce0 Reviewed-on: https://chromium-review.googlesource.com/1165360Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#581287}
-
Theresa authored
Don't show the IPH bubble when on the NTP and post the request to show the bubble to allow time for a layout pass so the anchor view has a valid height when the bubble is shown. BUG=871537 Change-Id: I28b4a5621a332360141b553582ba4f182363d280 Reviewed-on: https://chromium-review.googlesource.com/1165599Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581286}
-
Chris Hamilton authored
BUG=846953 Change-Id: Ic354c61147f14f080341aba36220cb81324df81e Reviewed-on: https://chromium-review.googlesource.com/1165302 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#581285}
-
Penny MacNeil authored
Change-Id: I22e31b6dd6a5e2a6c809f0563a614b4d3150a969 Reviewed-on: https://chromium-review.googlesource.com/1164390Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#581284}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like these callsites are stuck with the SERIAL_EXECUTOR, since they both call updateAccountRenameData() which is not thread safe. Bug: 869907 Change-Id: I23ac4430cd10acb61842ee1b37c36d8c36f0f8af Reviewed-on: https://chromium-review.googlesource.com/1161092Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
This CHECK should be removed since it is being hit in rare cases. This first CL is to try to gather more information in clustefuzz reports about the state when the CHECK is hit, since we have been unable to reproduce it locally. The CHECK will be removed in a follow-up CL. Bug: 871714 Change-Id: Iefed096801002e8f4d022723c07c876ff10b0014 Reviewed-on: https://chromium-review.googlesource.com/1165542Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#581282}
-
Yue Li authored
- Assistant need to be destructed before voice interaction controller client in order to correctly remove the observer. Bug: b/112273549 Test: Manual Test Change-Id: I6360dcdca38dd8d50ac6bbf768841f34d375b31b Reviewed-on: https://chromium-review.googlesource.com/1164411 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7008287219b6..b3e2c8eb1b16 git log 7008287219b6..b3e2c8eb1b16 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 buildbot@webrtc.org Roll chromium_revision 39d45f08..474eca05 (580730:581204) 2018-08-07 srte@webrtc.org Makes units constexpr when possible. 2018-08-07 titovartem@webrtc.org Move spl_sqrt_floor dep to proper third_party directory Created with: gclient setdep -r src/third_party/webrtc@b3e2c8eb1b16 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id7e6656b8df57fe0f234221bd46e94f229afc40f Reviewed-on: https://chromium-review.googlesource.com/1165325Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581280}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I8bd55d5ff4eb7c3078d5d1b8bb075bcfff5a7345 Reviewed-on: https://chromium-review.googlesource.com/1165590Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581279}
-
Jacob Dufault authored
Tap to unlock still should work on an empty password, though. Bug: 839320 Change-Id: Id5fd17c9428ddc2b6823cd3c63a5f21aa486b860 Reviewed-on: https://chromium-review.googlesource.com/1164257 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#581278}
-
Fredrik Hubinette authored
This reverts commit 1638e067. Reason for revert: New tests are flaky and causing problems when submitting code. Original change's description: > [heap] Do not revive WeakMember during incremental marking > > Overwriting deleted values with cleared values potentially revives > buckets in collections. For atomic garbage collections this is not a > problem as those values are filered out in the visitors already. For > incremental garbage collections the deleted values may be introduced by > erasing a value from a container after it has been visited by the > incremental marker. > > Bug: chromium:870196, chromium:757440 > Change-Id: I1d628f00c2e2ea6e36e880d50a397dcbcc8566d1 > Reviewed-on: https://chromium-review.googlesource.com/1164950 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581238} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org Change-Id: I632b5594d137acd37b4639ebcd46f8d61638dbc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:870196, chromium:757440 Reviewed-on: https://chromium-review.googlesource.com/1165328Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#581277}
-
Charlie Andrews authored
BattOr is being removed from Chrome tracing. Before the code for it can be deleted, we need to do this. TBR=inferno@chromium.org Bug: 859514 Change-Id: I3f88e147570e05c4056052aebfc085648231a4f3 Reviewed-on: https://chromium-review.googlesource.com/1162631 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#581276}
-
Gauthier Ambard authored
When the UnifiedConsent view is presented by the ConsentBump, it shouldn't be interactable: it shouldn't be possible to change the selected account or to tap the settings link. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I343157986df387382539746e12cca87e0121b413 Reviewed-on: https://chromium-review.googlesource.com/1165148 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581275}
-
Avi Drissman authored
BUG=871740 TBR=tnijssen@google.com Change-Id: I6c19c03148cdd7f5499d2fba114690a4b258d8c8 Reviewed-on: https://chromium-review.googlesource.com/1165319Reviewed-by:
-
Jérôme Lebel authored
Reorganizing GoogleServicesSettingsCommandID enum and <GoogleServicesSettingsCommandHandler> to match the UI layout. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie60468e0d3f2f2ad3b9ad3d515675ab4deafaaa8 Reviewed-on: https://chromium-review.googlesource.com/1163663 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
