- 03 Dec, 2019 40 commits
-
-
Chris Mumford authored
Switched to base::RepeatingClosure as well as switching base::BindOnce to WTF::Bind as base::Bind* is banned in Blink. Bug: 1007835 Change-Id: I6b6b6d028671ea2e50dd60e8cfc8048803aafd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949114Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#721216}
-
Chris Mumford authored
Jumbo builds are deprecated, so simplifying code by renaming RunClosure4 to the more commonly used RunClosure. Additionally removed a base::Closure in the VideoTrackRecorderTest.ReleasesFrame test. Bug: 1007835 Change-Id: Ibab8fda2bc3c717774d1657d3752acab94d2601d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949067Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#721215}
-
Michael Ludwig authored
Bug: 973696 Change-Id: I3e0750a60890da45681d4a50c1ec383e429243df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947358 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#721214}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6b2bb4b5. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I50e421d9afd09d0b455a4371e0a0bb75d4e25671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947984Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721213}
-
Michael Spang authored
This is a reland of f93bc96d Original change's description: > views: Assert toolkit_views=true in BUILD.gn > > Now that Chromecast Linux enables this, all builds that link //ui/views > are enabling this in GN. Add an assert so that accidental dependencies > are diagnosed by "gn gen". > > Bug: 1021770 > > Change-Id: I681645e97f69c22ee0410c1dba95319fddef7038 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898622 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715524} Bug: 1021770 TBR: robliao@chromium.org Change-Id: I6ce35ae59265a1ccc866256d1730a8d07fb88496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934430Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#721212}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/98b58ad3de71..8a0f76d3749e git log 98b58ad3de71..8a0f76d3749e --date=short --first-parent --format='%ad %ae %s' 2019-12-03 tsepez@chromium.org Remove CFXJSE_Value::SetDate() and IsDate() 2019-12-03 tsepez@chromium.org Take vectors from partition in CFX_BmpDecompressor 2019-12-03 tsepez@chromium.org Take buffers from the partition in CPDF_Creator 2019-12-03 tsepez@chromium.org Avoid RetainPtr<Retainable>::As<CFX_TextUserData>() calls. 2019-12-03 tsepez@chromium.org Test FormCalc Encode() function. Created with: gclient setdep -r src/third_party/pdfium@8a0f76d3749e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifc1fcf545369440e3ff2590df084aa9323ce136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721211}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/be3109961d3d..240afdb1c43a git log be3109961d3d..240afdb1c43a --date=short --first-parent --format='%ad %ae %s' 2019-12-03 vadimsh@chromium.org [cipd] Update client 2.2.20 => 2.3.1. Created with: gclient setdep -r src/third_party/depot_tools@240afdb1c43a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I29b726976d6af24e63c7619334c202ac954e2e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949176Reviewed-by:
-
Hesen Zhang authored
- After several attempts of prototyping, we've figured out for this feature we need to build a keyedservice to keep some intermediate runnables, instead of directly hooking it up to ChromeActivity in Android side. - This CL setup UpdateNotificationService with empty implementation. Bug: 1013685 Change-Id: Iad1a973c6c8f10c4d4a08347e444f1a3221c6638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946462Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721209}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/969df2b3a21c..be5c13567227 git log 969df2b3a21c..be5c13567227 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 rharrison@chromium.org Refactor code to have rudimentary support for using SPVC Created with: gclient setdep -r src/third_party/dawn@be5c13567227 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iad7605495377cf51ab1fbacd2efd91813dc19726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949170Reviewed-by:
-
Collin Baker authored
Fixed: 1010247 Change-Id: Ic2efa71b563a339e5c9f23a76bbfbb8be5c9762a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948092 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#721207}
-
Joe Downing authored
With the Webapp gone, I am updating some build rules to be less webapp specific. Change-Id: I420aa95f9a87095008b5c39ef552db786b2301f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947985Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#721206}
-
Thomas Anderson authored
This is a reland of abf93b0b Reason for reland: Should be fixed for realz (hopefully) now that [1] has landed. [1] https://chromium.googlesource.com/chromium/src.git/+/5cc50bc375d289623ed0c290c3429c70e32a88d9 Original change's description: > Revert "Revert PowerSaveBlockerLinux [2/4]" > > This reverts commit bbfce899. > > Reason for revert: Issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1937507/ lands > > Original change's description: > > Revert PowerSaveBlockerLinux [2/4] > > > > and the subsequent PowerSaveBlockerLinux [3/4] and PowerSaveBlockerLinux [4/4] patches > > > > This reverts commit 2fdeba1b. ("Rewrite PowerSaveBlockerLinux [2/4]") > > This reverts commit 38fdf074. ("Rewrite PowerSaveBlockerLinux [3/4]") > > This reverts commit 3bc463b4. ("Rewrite PowerSaveBlockerLinux [4/4]") > > > > The patch caused timeouts in WakeLockTest.ChangeType() and other tests in the services_unittests on > > Linux Tests (dbg). More details in crbug/1027852. > > > > TBR=thomasanderson@chromium.org > > > > Bug: 1013812,1027852 > > Change-Id: I7688c72f9d9d6c12ff3731f3abde6a05508cfbeb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932357 > > Commit-Queue: Tim Schumann <tschumann@chromium.org> > > Reviewed-by: Tim Schumann <tschumann@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718447} > > TBR=thomasanderson@chromium.org,tschumann@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1013812, 1027852 > Change-Id: I84a6681cc8ec347587d38f0f5f38ed628e624274 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937509 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720760} TBR=tschumann@chromium.org Bug: 1013812, 1027852 Change-Id: I4e18be4df7824a93769b8a13cc5455b8640e48c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949232Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#721205}
-
Brian Sheedy authored
Rolls the goldctl version to pick up recent changes, including the ability for goldctl to provide diffs for local testing. Also updates the GPU Gold code in order to provide the now-required --crs and --cis arguments when running on trybots. TBR=ynovikov@chromium.org Bug: 1030349 Change-Id: I3a3bd880a8c754441ff2f343ebb49eb610b5c7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949082Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721204}
-
Stephen Nusko authored
protozero event. This is the first full protozero typed event (!!). As part of this we need to add some dependencies on tracing to access the macros as well as protozero writing. This improves the output trace size when enabled because we no longer need to write out the JSON dictionary including field names. And decreasing tracing CPU overhead when this category is enabled by 8% (6%-10% at 95% CI) [1] This should also improve memory usage while tracing since we will not be emitting large dynamically allocated JSON dictionaries. [1] https://docs.google.com/spreadsheets/d/1dxtQ72hl_aRA4lWp45u0SsGysZ1YR155oE83pUd5Iso/edit?usp=sharing TBR=nuskos@google.com Change-Id: I0ac53b850cbce78d893ff26a204280bc8d627c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944357 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
enne <enne@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721203}
-
Connie Wan authored
Created TabGroupViews, which manages most of the tab group's visual calculations and updates. TabStrip still paints the views, but it no longer keeps low-level maps to each individual view. TabGroupUnderline can now use TabGroupViews for the bulk of its visual calculations. In the future, TabGroupHighlight will take a similar approach. Change-Id: I894dc03375cb29b42b80bd1273587a41131f1b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925336 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#721202}
-
Yann Dago authored
Bug: 1012920 Change-Id: Ifccd4d4eab21ba21d0e7984add2b26757e5cbec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929450Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#721201}
-
Takumi Fujimoto authored
This reverts commit 53550932. Reason for revert: This CL seems to have broken compile on the android_arm64-builder-perf bot: https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/135203 Original change's description: > [Payments] remove stubs for Clank dependencies > > This cl removes stubs from PaymentApp and PaymentInstrument classes as > well as payment_handler_host.mojom > > This should get landed after the dependnet Clank cl gets merged: > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2255260 > > Bug: 984694 > Change-Id: I03972ab75d7c4f33b644ebf77a9ef2618ef07921 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946457 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721089} TBR=kenrb@chromium.org,rouslan@chromium.org,sahel@chromium.org Change-Id: Iff10dbae61e31d32312bf8a4ca947b00ed003fae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948919Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721200}
-
Devlin Cronin authored
Add a DCHECK that the Browser object the ExtensionViewHost is creating the view for is associated with the same profile as the ExtensionViewHost itself. Bug: None Change-Id: I2be3c2bcc5a3faaa309dd3250d5ecaac76b5ab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940588Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721199}
-
kdillon authored
Bug: 966177, 1027606 Change-Id: I335d1df534ff7a7baafac89f6e0c8d034fc061d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947399Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721198}
-
James Hawkins authored
This case is no longer possible in the multidevice world. R=hansberry@chromium.org Bug: none Test: none Change-Id: I070b46562d28517b373fa67a8267d5504ac2da7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936968 Commit-Queue: James Hawkins <jhawkins@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721197}
-
Henrique Ferreiro authored
Bug: None Change-Id: I515c7508c09a857e9023fb1a93d080de97115f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948442Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#721196}
-
Maks Orlovich authored
Just because requested range start is < kMaxOffset doesn't mean the final result will be; consider for example this sequence: WriteSparseData("Key0", offset = 331530, size = 61184) = 61184 GetAvailableRange("Key0", 131076, 262143) = net::ERR_IO_PENDING (async) [Async IO (GetAvailableRange) = 60938] [1203/162431.032212:FATAL:disk_cache_fuzzer.cc(1000)] Check failed: *start_tmp <= kMaxEntrySize (331776 vs. 262144) this asks for the available interval in [131076, 393219), and returns [331776, 392714), which is reasonable given the earlier write of [331530, 392714), since the backend doesn't have to guarantee complete exactness on sparse writes. Bug: 1029779, 1026689, 1020882, 1028111 Change-Id: I23ea47a48c13828d343d6830974583a4bc355617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948047 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#721195}
-
Luke Zielinski authored
Logged bugs where issues were found, or there were discrepancies between local and/or wpt.fyi runs. If the test was failing everywhere, it just goes on the backlog. Bug: 937369 Change-Id: Ie5412f80b2e13006b77d666d6c59e6ba07007331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949060 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#721194}
-
Joe Mason authored
R=proberge Bug: 1030333 Change-Id: I66b9b3dc73980e8ed03ee37d89eb172b5330c913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948235 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#721193}
-
Xiaoqian Dai authored
Bug: 1027353, 997885 Change-Id: Ia72d214f3a96f55e15128bb4b4155df5ddfe250e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931544 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721192}
-
Peng Huang authored
This CL refactor DClayers related code, so it can be shared with other platforms. Bug: 1012401 Change-Id: I6550823081d538b6b1a4702fae941534af897508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940347 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721191}
-
Nigel Tao authored
This undoes crrev.com/c/1898151 "Flip enable_skia_wuffs_gif gn arg default to true", as there have been reports (crbug.com/1023129, crbug.com/1023191) of ARM performance regressions, and fixing those is ongoing work. We might try flipping the default back to true after the upcoming M80 branch point. Also fix build of skia when enable_skia_wuffs_gif=false. The libgifcodec dependency isn't really new. It was spun out of the existing Skia git repository a couple of weeks ago: https://review.skia.org/255780 Fix to: https://crrev.com/c/1942595 Bug: 1014044 Bug: 1023129 Bug: 1023191 Change-Id: Icfd7e9b703cb1c7d25f891937d54a01f97711389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944286 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by:Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721190}
-
Brian Ho authored
This CL introduces a NativePixmap-based SharedImageBacking for use by ChromeOS to support WebGPU. This only creates a skeleton for SharedImageBackingOzone in an effort to split up code reviews; the SharedImageBacking methods are neither implemented nor called. Bug: 1023997,996470 Change-Id: Id4e8ba3079df8af609f883b61ffe6e54975e075b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913081 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721189}
-
Fei Ling authored
"about:blank" should not be a translatable URL. Bug: 960369 Change-Id: Ife979fd641a793d8e4442309c436c6c0dd07c876 Fixed: 960369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946870Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Fei Ling <feiling@chromium.org> Cr-Commit-Position: refs/heads/master@{#721188}
-
Jesse Schettler authored
This reverts commit 0ec01b13. Reason for revert: Causing browser to crash. Original change's description: > printing: Check all color modes in IsColorModelSelected() > > Update IsColorModelSelected() to check for all color modes. > > Change-Id: I61b4922e1ddb6b9a3f906b9122b1ca4f29c8272e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901835 > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718884} TBR=thestig@chromium.org,skau@chromium.org,jschettler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id739f17f6a3e8c1bc232eb85d10c165b8a515a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948501Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#721187}
-
Mia Glaese authored
Bug: 1029691 Change-Id: I06d704ff991d5ee19ab733b50c893568309a5bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944283Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#721186}
-
Vi Nguyen authored
This CL allows for spatialRendering to be queried with MediaCapabilities.decodingInfo() for clear and EME. Changes required to blink and media were relatively small so they were combined into this CL. This CL does not add the ability to render spatial audio. This functionality is behind blink feature flag MediaCapabilitiesSpatialAudio. Note that if the flag is disabled, querying for spatialRendering will return supported because decodingInfo ignores extraneous parameters by design. For the media implementation, AudioType was because spatialRendering is strictly tied to the codec. Bug: 1020943 Change-Id: I01c9853b88f72ae8cb6291f9ca49e1d82cb220d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928077Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Vi Nguyen <ving@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721185}
-
Joe Mason authored
Update comments to clarify how the child process log interacts with ScopedLogging. Use the new class to capture logs in cleaner_test.cc, secure_dll_loading_test.cc and proto_chrome_prompt_ipc_unittest.cc. R=proberge Bug: 1030333 Change-Id: I88f538ff360bb8ed9da6743dc5d6c4b263af992c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947986 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Collin Baker authored
Bug: 989131 Change-Id: Ie6816df088e9a3dcbc6a8dba884e9b7c72f02c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938194 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721183}
-
Etienne Pierre-doray authored
The comparison was too strict. In practise, there's only one PT_NOTE segment, so early exit doesn't affect behavior. For correctness, we should keep looking for other segment. Change-Id: I49fb7ab3c7361d4ed6ea1d6f3a0c56db24dc13cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948497 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#721182}
-
Jeremy Roman authored
Previously the shell redirection only redirected stdout, but the message was being printed to stderr. While here, use trap to ensure that the output file is removed even when bash exits abnormally. Change-Id: Icf9f9de24bf115713b61e860616a6457be8fa593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945925 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This callback can be called multiple times, so make it a RepeatingCallback. Also pass it by value for functions that take ownership per guidelines in //docs/callback.md. Bug: 1007763 Change-Id: Ib15dd0a20357ac58dbe691b3dea263ebf24b0163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948364Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721180}
-
Saman Sami authored
Since each cache miss can result in one frame with no overlays, we would like to make sure it doesn't regress as we work towards fixing https://crbug.com/756454 Bug: 756454 Change-Id: Iae7cbaddf5974ece8e0078d9ea265752fa016fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941047 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#721179}
-
Yuke Liao authored
This reverts commit 5b3adc3c. Reason for revert: This turns out to be NOT helpful to debugging the issue. Original change's description: > [code coverage] Change log warning to info > > Will ssh to bot if still nothing printed. > > Bug: 1027818 > Change-Id: I98147da43689d2b4ea9db0ee8643312eac6fc72b > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935860 > Auto-Submit: Yun Liu <yliuyliu@google.com> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719180} TBR=liaoyuke@chromium.org,yliuyliu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027818 Change-Id: Ibc49a3f10e3847a1b269e2f501ba321ef943b9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948489Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721178}
-
Mike Reed authored
TBR= Change-Id: I4607f91a8efb87202d68311894f67bc69a8f8e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948487 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#721177}
-
