- 16 Nov, 2018 40 commits
-
-
Matthew Wang authored
This is a reland of 20b9700c Original change's description: > Add Fast Transition as enterprise policy > > Add support for an enterprise policy that lets the admin > turn Fast Transition on or off. > > BUG=791202 > CQ-DEPEND=1291930 > TEST=(1) unit-tests (2) Added network policy to YAPS > server, enabled Fast Transition and checked that the > values propagate to client > > Change-Id: I4092ffb33169219515d235a25b1153e197a5af2d > Reviewed-on: https://chromium-review.googlesource.com/c/1297644 > Commit-Queue: Matthew Wang <matthewmwang@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607824} Bug: 791202 Change-Id: Id89eec841667ceb821e52eb53a37f2f9641bcbaa Reviewed-on: https://chromium-review.googlesource.com/c/1334839Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608897}
-
Jonathan Metzman authored
Bug: 906126 Change-Id: I4a6cce3f2b535fe24e44dd4569cb005c6edc2bc8 Reviewed-on: https://chromium-review.googlesource.com/c/1340481Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608896}
-
Shakti Sahu authored
This crash was introduced due to the changes for URL backstack introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1309428 Bug: 903716 Change-Id: Idfb7c09fde27ed546628b875f6fa2ac68b6f1cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1338484 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#608895}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5bf5a64fe7a9..07ee63d076e5 git log 5bf5a64fe7a9..07ee63d076e5 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 csmartdalton@google.com sksl: Add builtinFMASupport to StandaloneShaderCaps 2018-11-16 brianosman@google.com Add SkPMColor4fFitsInBytes 2018-11-16 mtklein@google.com remove _DXDY_ sample procs 2018-11-16 jvanverth@google.com Remove use of integers for atlas indexing 2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 000df8b42041..b16f9897a868 (4 commits) 2018-11-16 halcanary@google.com SkShaper: better error info. 2018-11-16 mtklein@google.com I think the _DXDY_ code may all be dead. 2018-11-16 michaelludwig@google.com Update threshold for degenerate gradients 2018-11-16 brianosman@google.com Use GrVertexWriter for GrRegionOp, add writeQuad() 2018-11-16 brianosman@google.com Do CCPR hairline coverage scaling in floats, rather than bytes 2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 44994a88c9cc..000df8b42041 (1 commits) 2018-11-16 herb@google.com Fun with flags 2018-11-16 csmartdalton@google.com sksl: Polyfill fma() when not present in GLSL 2018-11-16 scroggo@google.com Add safety net logging for issue 118143775 Created with: gclient setdep -r src/third_party/skia@07ee63d076e5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:905607,chromium:b/118143775 TBR=rmistry@chromium.org Change-Id: I8f2c6d04a79abcc003ca4c5c9c02fb4e71c05441 Reviewed-on: https://chromium-review.googlesource.com/c/1340386Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608894}
-
Austin Eng authored
Bug: 894200, 891059 Change-Id: Ic3ad1be6bf9ce21cd672266d42ef4259fd47cd9d Reviewed-on: https://chromium-review.googlesource.com/c/1340568Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608893}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=timvolodine@chromium.org Bug: 903957 Change-Id: Icaf8fe70611a4e937b69bca1c2a670a9a45ae5ac Reviewed-on: https://chromium-review.googlesource.com/c/1338129Reviewed-by:Tim Volodine <timvolodine@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608892}
-
Lily Chen authored
Original CL description: This change makes it possible to reprioritize socket pool ConnectJobs to match their corresponding Requests. For TransportConnectJobs that are reprioritized while undergoing host resolution, the corresponding host resolver request is also reprioritized to match the connect job. Reland fixes a bug in the original CL causing a failing DCHECK due to trying to reprioritize jobs with RespectLimits::DISABLED, which should not be reprioritized as they should always be MAXIMUM_PRIORITY. Bug: 166689 Change-Id: If845c941b02a9a1c01c267ee463fda7205bd928c Reviewed-on: https://chromium-review.googlesource.com/c/1333135 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#608891}
-
Lei Zhang authored
Aside from adding the sanity check, this also hooks up loadTimeData in pdf_viewer.js, and demonstrates how to plumb a feature flag from the browser into pdf_viewer.js. BUG=61248 Change-Id: I48850afaac17854af785d04a8ca93078ebd8532f Reviewed-on: https://chromium-review.googlesource.com/c/1339244Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608890}
-
Justin Cohen authored
Change-Id: I9da271f43547686c9e141b2875e0b796d7adabae Reviewed-on: https://chromium-review.googlesource.com/c/1340643Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608889}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe9b104421c3..5a3d34a0f7ad Created with: gclient setdep -r src-internal@5a3d34a0f7ad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0d49bb78f50faa15cb23309f8af17b08bb9c92f7 Reviewed-on: https://chromium-review.googlesource.com/c/1340387Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608888}
-
Changwan Ryu authored
Check window.origin value for HTTPS-schemed base Uri vs custom-schemed base Uri. Bug: 896059 Change-Id: Ic310c584e0826d14683734f8e6190875dddcc28f Reviewed-on: https://chromium-review.googlesource.com/c/1340821Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608887}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4d4ac41560ad..acedb7bc166f git log 4d4ac41560ad..acedb7bc166f --date=short --no-merges --format='%ad %ae %s' 2018-11-16 treehugger-gerrit@google.com Merge "ftrace: Add oom_score_adj_update" 2018-11-16 treehugger-gerrit@google.com Merge "profiling: Remove unused dump path." Created with: gclient setdep -r src/third_party/perfetto@acedb7bc166f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ida96dbcae9b91951260596b7f47b8a1043445c19 Reviewed-on: https://chromium-review.googlesource.com/c/1340383Reviewed-by:
-
Shimi Zhang authored
SELECTION_HANDLES_MOVED and INSERTION_HANDLE_MOVED are triggered for scrolling, but we don't want to perform haptic feedback in this case. Bug: 900778 Change-Id: I1ab97f3630ae0b0cca5ee1a1bf988699ac710bbb Reviewed-on: https://chromium-review.googlesource.com/c/1315990Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608885}
-
Colin Howes authored
Add a network disconnected connection type to the Update Engine connection type histogram. BUG=chromium:660283 Change-Id: Icc93ec2f49073566dcb49d6abcd70bc535aca176 Reviewed-on: https://chromium-review.googlesource.com/c/1235282Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Colin Howes <chowes@google.com> Cr-Commit-Position: refs/heads/master@{#608884}
-
Yaron Friedman authored
This is accessed by native and must not be renamed by proguard. BUG=905960 Change-Id: I99f74affe95c2e9356f66303eb921fa8a5eb1125 Reviewed-on: https://chromium-review.googlesource.com/c/1340366Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608883}
-
Jamie Madill authored
Currently when the script reads multiple results it outputs the last value read as well as a zero placehold for standard deviation. According to benjhayden@ we can return all results in an array. This change does just that and adds a test. It also updates the expected unit test output. Bug: 900677 Change-Id: Icc38808ea83caddbdf6b8582e2ddc34db4f8cdf0 Reviewed-on: https://chromium-review.googlesource.com/c/1338468Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#608882}
-
Theresa authored
The "ablation" variant of the Simplifid NTP was launched, so the shortcuts are no longer needed. We can also remove the feature flag and clean up some test code. Future CLs will do more clean-ups to remove support for bookmarks/downloads sections on the Chrome for Android NTP. BUG=865216 Change-Id: Ia0bd851c300f5a16d0a9d417eebb3cc37652e79e Reviewed-on: https://chromium-review.googlesource.com/c/1333107 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608881}
-
David Bokan authored
In https://crrev.com/f9cbcfa426bdf0cb830cd7d1ce7cc80845184d3e I landed a fix to https://crbug.com/898757. This fix was needed ASAP since it needed to be merged. I landed a fix without a test at the time. This CL adds a test. Bug: 901083,898757 Change-Id: I0b3dc44a7e94e33f5897f7d9f19159523807dc56 Reviewed-on: https://chromium-review.googlesource.com/c/1336786Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608880}
-
Mohamed Amir Yosef authored
This CL uses CachedMetric to record the histogram for number of queued messages instead of using RecordHistogram directly. RecordHistogram call native directly and hence falsifies the whole purpose of queuing FCM messages (to avoid calling the native code) In order to test the behavior, ShadowRecordHistogram had to implement the method recordCustomCountHistogram() of RecordHistogram. The reason is CachedMetric is internally using this method directly instead of the proxy methods such as recordCount100Histogram(). Bug: 882887 Change-Id: I15e9e77ab96cf65084242443a1a134c5df00f7fd Reviewed-on: https://chromium-review.googlesource.com/c/1340000Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#608879}
-
Steve Anton authored
Bug: 874296 Tbr: hbos@chromium.org Change-Id: Id2905574237fe9221d49a1e772c9ba0f3e7957e1 Reviewed-on: https://chromium-review.googlesource.com/c/1289436 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#608878}
-
Philip Rogers authored
Zoom animations [1] use LayerTreeImpl::ScrollableSize. ScrollableSize was incorrect if there was not an outer container layer, which is the case for Blink Gen Property Trees (BGPT) where we use property tree nodes for the outer container data. This patch makes LayerTreeImpl::ScrollableSize work using property tree nodes. To do this, ScrollTree::scroll_bounds has been introduced which is used by both ScrollTree::MaxScrollOffset and LayerTreeImpl::ScrollableSize. A common function for setting up browser controls and virtual viewport layers has been added: LayerTestCommon::SetupBrowserControlsAndScrollLayerWithVirtualViewport [1] Zoom animations are triggered on android via two codepaths: * Double tapping _anywhere_ on a non-mobile (i.e. desktop) page * Focusing (single tapping) on any editable These can also be triggered on desktop in some configurations, such as two-finger tapping a touchpad on MacOS. Bug: 899702 Change-Id: I022974df18c410f5a513aad1bce3dfcd30a902da Reviewed-on: https://chromium-review.googlesource.com/c/1338109 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608877}
-
Etienne Pierre-Doray authored
[TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /chrome/browser/ui/webui/chromeos/login base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=jdufault@chromium.org Bug: 903957 Change-Id: I884ec06bef124aef5b587bff4027e9014962c163 Reviewed-on: https://chromium-review.googlesource.com/c/1338487Reviewed-by:Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#608876}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6a7b164f0c0e..d7cd1203a42b git log 6a7b164f0c0e..d7cd1203a42b --date=short --no-merges --format='%ad %ae %s' 2018-11-16 zoddicus@users.noreply.github.com Ensure for OpVariable that result type and storage class operand agree (#2052) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d7cd1203a42b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icb13cda81738459913597a2274ff0667099d5816 Reviewed-on: https://chromium-review.googlesource.com/c/1340385Reviewed-by:
-
Scott Violet authored
This reverts commit 6aac2af3. Reason for revert: Caused breakage of mash test. See https://crbug.com/902870. Original change's description: > MojoVideoDecoder: Add histogram to track initialization and error. > > The autotest video_ChromeHWDecodeUsed verifies Chrome used the HW > decoding when playing a video stream by checking the histogram value, > which is reported from GpuVideoDecoder. > In order to keep the test pass during switching from GpuVideoDecoder > to MojoVideoDecoder, we have to report the same histogram value > temporarily from MojoVideoDecoder. > > With this CL, we can enable MojoVideoDecoder at ChromeOS platform. > > BUG=chromium:902968 > TEST=Pass video_ChromeHWDecodeUsed autotest on Eve > TEST=Play video at Youtube on Eve and confirm the successfull option > of Media.GpuVideoDecoderInitializeStatus are increased. > > Change-Id: I26fc53704843e9b153bbee304e8f60ab3a7b0417 > Reviewed-on: https://chromium-review.googlesource.com/c/1328634 > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607890} TBR=posciak@chromium.org,sandersd@chromium.org,akahuang@chromium.org,hiroh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:902968 Change-Id: I3b74c752b6cc34dcbcba203eeb39707f4921d405 Reviewed-on: https://chromium-review.googlesource.com/c/1340378Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608874}
-
Ella Ge authored
TBR=dimich@chromium.org Bug: 906093 Change-Id: Ica264f2a26dc52b1e44c12520b627a3032cbccf2 Reviewed-on: https://chromium-review.googlesource.com/c/1340779Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608873}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b2c3373106d2..8b33404f0931 git log b2c3373106d2..8b33404f0931 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 stevenjb@chromium.org Support full version in Simple Chrome Created with: gclient setdep -r src/third_party/chromite@8b33404f0931 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4daa8d937381a9159abb855f924e883ae9e6f3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1340384Reviewed-by:
-
Ben Pastene authored
Looks like it's failing due to expecting a zip file that's not present in the earlier package but is in the later: https://chromium-swarm.appspot.com/task?id=4126fb1a456d4710 Bug: 880623 Change-Id: I586160da125e2743cfaf65d81bd556c1c6d88300 Reviewed-on: https://chromium-review.googlesource.com/c/1334336 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Jered Gray authored
crbug.com/783246 is the fixed bug tracking it. Change-Id: I873b1eda8d3e43abd191779e6e503df5e31157d6 Reviewed-on: https://chromium-review.googlesource.com/c/1338729Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608870}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=torne@chromium.org Bug: 903957 Change-Id: Iaf80012bf6f5c5f7852031c21f68c75e11957ca1 Reviewed-on: https://chromium-review.googlesource.com/c/1338481Reviewed-by:Richard Coles <torne@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608869}
-
Min Chen authored
Unified system tray has been launched and web notification has been moved to the top of the system tray. The old system tray logic has been removed. This cl removes the logic that swiping up on the status area tray to open the corresponding bubble and swiping down on the tray bubble to close it. cl that landed the feature: https://codereview.chromium.org/2961313003/ cl that disabled the feature: https://chromium-review.googlesource.com/c/chromium/src/+/674527/ Bug: 767679 Change-Id: Id81091360ee47c9763d2f716f246146b940ac1e2 Reviewed-on: https://chromium-review.googlesource.com/c/1334932Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#608868}
-
Tim Volodine authored
Currently unsupported url schemes like "foo://some/resource" hit a NOTREACHED() and crash in the NS code path. Also, the current code path does not invoke any webview specific callbacks. This patch ensures that the unsupported url scheme cases are handled correctly and the appropriate error callback is invoked when we hit an unsupported scheme case (aka ERR_UNKNOWN_URL_SCHEME). This patch also adds some additional parameters (i.e. method and headers) to the ContentBrowserClient:: HandleExternalProtocol() method, in order to provide all the data required to execute the callback. The HandleExternalProtocol() method is invoked in two places: 1. navigation_url_loader_impl.cc 2. resource_dispatcher_host_impl For case 1 the additional data is obtained from the network::ResourceRequest and for case 2 from net::URLRequest. Tests fixed by this patch: - ClientOnReceivedError2Test.testOnInvalidScheme - ClientOnReceivedErrorTest.testOnReceivedErrorOnInvalidScheme - AwContentsClientShouldOverrideUrlLoadingTest.testCalledForIframeUnsupportedSchemeNavigations - AwContentsClientShouldOverrideUrlLoadingTest.testWindowOpenCustomSchemeUrlInPopup BUG=896223,893567,893573,893574,841556 Change-Id: I7053b66a489c0f49eaa1428a8ee2466380710b26 Reviewed-on: https://chromium-review.googlesource.com/c/1318976 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608867}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=henrika@chromium.org Bug: 903957 Change-Id: Id9a9bb29d5d9beb2f680472602badc3a1ac1f6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1338126Reviewed-by:Max Morin <maxmorin@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608866}
-
Orin Jaworski authored
The omnibox was accepting raw text from drag data when such text was left empty by stripping Javascript schemas and whitespace. This allowed invalid omnibox edit text content, containing e.g. newline characters which would then render with confusing glyphs. This CL fixes the issue by using the sanitized text even if empty. Bug: 904380 Change-Id: Ia43a9429d200261a929e858681cb771e6b8bc91c Reviewed-on: https://chromium-review.googlesource.com/c/1334558Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#608865}
-
Xiaohui Chen authored
* Add a feature to control this, default off * Move audio_input_impl to its own file since it grows big * Introduce hotword_state_manager that controls DSP input device state. For DSP device, it works as follows: - Open input device with HOTWORD effect - Input device won't forward audio data until OKG is detected - Once OKG is detected, input device behaves like a regular input device and constantly streams audio data, note that the preamble of OKG itself is included in the initial audio data - When a conversation is finished, we need to destroy and recreated the audio input to arm DSP again. Bug: b/77916222 Test: locally build and run on eve Change-Id: I4ce17fba21fbc584cde9178c2aca53a6ed410fe9 Reviewed-on: https://chromium-review.googlesource.com/c/1334566Reviewed-by:Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#608864}
-
Xing Liu authored
This CL adds security check for redirect in network service code path for download system. Bug: 883387 Change-Id: Icd5f9eac09a1197bffc72fbf3196b96a8c88ac4c Reviewed-on: https://chromium-review.googlesource.com/c/1330063Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
Joe Mason authored
R=csharp@chromium.org Bug: 830892 Change-Id: I6c3a17c2761545f58e18d9058bf2dedc31acf39e Reviewed-on: https://chromium-review.googlesource.com/c/1338566Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#608862}
-
Mathieu Perreault authored
Bug: 906135 Change-Id: Ibdf7195d93a8dc340e6ce9cdd3ab11b4917bdd1e Reviewed-on: https://chromium-review.googlesource.com/c/1340659Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608861}
-
dpapad authored
- Several "rm" commands are unnecessary because of rsync_exclude.txt. - Audited code that was replacing NBSP in polymer-mini.html (added in r332329). Seems to have no effect (no diff exists after running the command). Removed related TODO for Polymer 2. - Remove unused files from third_party/web-animations-js/. These files are not included in the build anyway. Bug: 738611 Change-Id: I372143a9bc1fd3f18d5aa6fb7fe735fdbdb82015 Reviewed-on: https://chromium-review.googlesource.com/c/1338334 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608860}
-
Lukasz Anforowicz authored
After r606352, default URLLoaderFactory does not make any CORB exceptions for extensions and/or apps. Separate URLLoaderFactories (relaxing CORB) need to be created for content scripts. One scenario, where separate URLLoaderFactories should be created, is content scripts injected into <webview> tag. Such scripts execute fetches with |request_initiator| set to the origin of the <webview> embedder and so permissions of the embedder need to be taken into account (e.g. a Chrome App might be able to make cross-origin requests). This CL adds a regression test for this scenario (without product code changes the new test fails with --enable-features=NetworkService flag) and fixes the product code to trigger creation of separate URLLoaderFactory when needed. For an overview of separate URLLoaderFactories for extensions, see https://docs.google.com/document/d/1fuBUmLZj1H319jMkK8waUbf5WdQS0N95J_mWXVzbP7A Bug: 846346 Change-Id: I6ac0f42df7562a01c14cbe6740417b6d94b51810 Reviewed-on: https://chromium-review.googlesource.com/c/1337822 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608859}
-
Adrienne Walker authored
Fix fuzzer crash by deleting fuzzer. ;) This fuzzer attempts to do a convoluted series of deserializing and reserializing to try to make sure that serializing an op ends up in the same op that is deserialized. However, over time, a number of changes to serialization have been added that modify what is being serialized, e.g. scaling paint records, adding clips and scales to serialized PaintRecords, scaling paint records, etc. I think this fuzzer was useful in early oopr releasing to build confidence about the number of serialization bugs, but it never caught any issues that the paint_op_buffer_fuzzer wouldn't have caught. However, it's no longer that useful. Bug: 904211 Change-Id: Ie62e296c9a5246ab74478755d738820e02bf7cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1337817 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608858}
-
