GitLab

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ib1c2d571dffddf742276c28875275abe790724f1
Reviewed-on: https://chromium-review.googlesource.com/c/1321149
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606551}

base::DictionaryValue is deprecated, and we are transitioning some
internal code to use base::Value instead of base::DictionaryValue, and
it calls GetOverridenFeaturesForStorage. So here we make
GetOverridenFeaturesForStorage accept a base::Value. We do not change
the return value so that we do not break any existing usages.

Bug: Internal 119219865
Test: None
Change-Id: I61a794456b586f0a0b99dc258d13f02d10ae7646
Reviewed-on: https://chromium-review.googlesource.com/c/1321672Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Matt Swartwout <mwswartwout@google.com>
Cr-Commit-Position: refs/heads/master@{#606550}

This CL removes three similar sections of code that generate histogram
names with a SecurityLevel suffix and replaces them with
a shared implementation in the security_state namespace. This is to
facilitate future growth of that histogram naming pattern.

Bug: 852479
Change-Id: Ic27bc65539108e672e64168c34dd80fa27a34b02
Reviewed-on: https://chromium-review.googlesource.com/c/1318695Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606549}

This is a reland of 14754da5 with some
fixes (see the ps #1..#2 diff).

The problem in the previous CL was that the LocalDB WCObserver was
sometime created despite not having a PageSignalReceiver, this caused
some access violation because this WCO relies on some signal sent by the
PSR. I've added a check to prevent creating this WCO when the PSR isn't
available (and fixed some tests to make them create one).

// Confirmed with sky@ that he's ok with me relanding this without his
// +1 as none of the files he owns have changed.
TBR=sky@chromium.org

Original change's description:
> RC: Encapsulate most of the singletons into ResourceCoordinatorParts
>
> There's several singletons / global instances in c/b/rc that are leaked
> at shutdown, this is causing some issues in runs of unit_tests because
> we end up re-using them between different test runs that should be
> independent. This is currently preventing some feature to be enabled.
>
> This CL add a new ResourceCoordinatorParts class that encapsulate all
> these objects that should be created only once, an instance of this
> class is owned by the browser process.
>
> Change-Id: Ia64618b6f47052815d861ff6820d994f8a65cc64
> Reviewed-on: https://chromium-review.googlesource.com/c/1290775
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606061}

Change-Id: I71feb4ea233d02cb5cc001c12e3cdd7f6ddd795b
Reviewed-on: https://chromium-review.googlesource.com/c/1324134
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606548}

This reverts commit b3a685fd.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 606525 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IzYTY4NWZkYTlkYzc0MjU1ZTVjNDRiNDY0NzJlYjg5ZTA1Zjc4NzMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/25051

Sample Failed Step: webkit_unit_tests

Original change's description:
> Reland "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow"
> 
> This is a reland of b43c6fca
> 
> Cannot reproduce the failures locally, nor in CQ.
> 
> Try to reland the same CL to see if it was a flake.
> 
> Original change's description:
> > Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow
> >
> > This patch allows computing NGOffsetMapping for legacy inline
> > formatting context.
> >
> > For an experimental project "Invisible DOM"[1][2] to support
> > the find-in-page feature, it is needed to compute the text
> > content with whitespace collapsing applied, along with the
> > mapping to the DOM offset. This patch adds an API to compute
> > NGOffsetMapping even when the LayoutBlockFlow is not laid out
> > by LayoutNG for that purpose.
> >
> > Note that the project is still in the early phase. We may
> > revisit the design as it moves forward.
> >
> > [1] https://github.com/rakina/searchable-invisible-dom
> > [2] https://www.chromestatus.com/feature/5105291213406208
> >
> > Bug: 636993, 873057
> > Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882
> > Reviewed-on: https://chromium-review.googlesource.com/c/1322184
> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> > Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> > Commit-Queue: Koji Ishii <kojii@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#606292}
> 
> TBR=yoshin@chromium.org, eae@chromium.org
> 
> Bug: 636993, 873057
> Change-Id: I241c6e9163add4000fa078c5d70a62b89acea9ac
> Reviewed-on: https://chromium-review.googlesource.com/c/1326343
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606525}

Change-Id: If3d6c17f4cf7ba241380ab3906da0a8029720a0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 636993, 873057
Reviewed-on: https://chromium-review.googlesource.com/c/1327401
Cr-Commit-Position: refs/heads/master@{#606547}

NOTRY=True
TBR=charliea@chromium.org

Bug: 903417
Change-Id: I8712e992b8abe19f05a1eb1f71c4908e6ac4369b
Reviewed-on: https://chromium-review.googlesource.com/c/1327160Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606546}

Remove 2 in the name

BUG=765327

Change-Id: Ie2bd854f45bd3e01c83cf94d026483d399380069
Reviewed-on: https://chromium-review.googlesource.com/c/1324392Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606545}

CL splitting Plan

1) Current CL - End to end flow and functional demo. Fix flow UI is quite basic and need to make small changes and I will chat with you tomorrow on UX layout here. Today at save card, it is crashing in JNI code. Matthew, will swing by your desk tomorrow. It is again at some Context OOO or some thing. This time I want to learn how to debug that stuff.

This is major part of CL where I have to get ack from multiple reviewers. I tried to make flow as basic as possible.

2) Pretty up the UI and fix all UI nits to match production one - This is mostly mdjones@ review and UX Ok with spacing and etc.

3) Metrics, tests and preferences - Today there is not much testing on Android side. So need to see what I can add - This jsaul@ can review.

What to implement - https://docs.google.com/presentation/d/1hfCDQJle0SB5AX2vdhERC7JuduR9jvOTiszSy4BON2Q/edit#slide=id.g433d7fc08d_1_8
Demo - https://drive.google.com/file/d/0Bw9uo2EXAqJ_NmtQbGtVdlpHWF9PQ1Y2QVR1SGtuRjBQeFI4/view?usp=sharing

Bug: 848955
Change-Id: I080684d8a864cba760b5be6fef96b1aa52478eb8
Reviewed-on: https://chromium-review.googlesource.com/c/1180438Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#606544}

This CL makes sure video context menu items show for MediaStream video.
Only "Picture-in-Picture" and "Show Controls" are enabled for now.

This also disables the "Loop" menu if video is a MediaStream or has
an infinite duration (Live).

Screenshot: https://i.imgur.com/P1t9urA.png

Bug: 899466
Change-Id: I309d7cf5918e8c17a84c3adfec4a8d7542336554
Reviewed-on: https://chromium-review.googlesource.com/c/1306997Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#606543}

The new methods will let us support MessageLoopCurrent and
ScopedTaskEnvironment.

Bug: 863341, 891670
Change-Id: I1358330e890e0f669de2869c3d9ee2255318e422
Reviewed-on: https://chromium-review.googlesource.com/c/1326012
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606542}

Bug: 902218
Change-Id: Ic81f9e83fa3bf21a549a9a8b90e7eeef769ae7ff
Reviewed-on: https://chromium-review.googlesource.com/c/1320203Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606541}

Change-Id: I92fd371e61ae951bf4609ac99824b61fb0b9f5e6
Reviewed-on: https://chromium-review.googlesource.com/c/1325211Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606540}

https://android.googlesource.com/platform/external/perfetto.git/+log/0bbca7f95d2f..85be49ec0bc2


git log 0bbca7f95d2f..85be49ec0bc2 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 rsavitski@google.com Merge "profiling: Fix BoundedQueueTest."
2018-11-08 treehugger-gerrit@google.com Merge "traced_probes: add bounds on /proc/p/stats and sys stats polling intervals"
2018-11-08 fmayer@google.com Merge "profiling: Add heapprofd producer."


Created with:
  gclient setdep -r src/third_party/perfetto@85be49ec0bc2

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ifce466d9288603cbe2c499878cc75ee897b53ea1
Reviewed-on: https://chromium-review.googlesource.com/c/1326741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606539}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowSyncPrimitives in non-test files
 * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=alemate@chromium.org

Bug: 766678
Change-Id: I24ef60f737d37fd901d8e765983d45742b530c7a
Reviewed-on: https://chromium-review.googlesource.com/c/1324396Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606538}

This patch changes tests in the following directories to use
Element.innerText for text dump:

fast/g* - fast/r*

Most of this patch is mechanical rebaseline, except that
- Some LayoutNG-specific baselines become redundant and are removed
- 4 LayoutNG multicol tests are turned to fail, due to failures in
  getting NGPaintFragment from different columns (crbug.com/873957).

Bug: 887148
Change-Id: Ia083fc59d7ff5d3e4576eaa497a7de08e9b9302b
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1318149
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606537}

Due to a new clang, a couple of shadowing warnings
appeared in existing code, related to enum values INVALID,
UNINITIALIZED and RUNNING. This patch moves both clashing
enums into enum classes.

Full errors below:

In file included from ./../../content/browser/renderer_host/input/synthetic_gesture.cc:10:
../../content/browser/renderer_host/input/synthetic_pointer_action.h:30:23: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow]
  enum GestureState { UNINITIALIZED, RUNNING, INVALID, DONE };
                      ^
./../../content/browser/browser_thread_impl.cc:36:3: note: previous declaration is here
  UNINITIALIZED = 0,
  ^
In file included from gen/content/browser/browser_jumbo_1.cc:505:
In file included from ./../../content/browser/renderer_host/input/synthetic_gesture.cc:10:
../../content/browser/renderer_host/input/synthetic_pointer_action.h:30:38: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow]
  enum GestureState { UNINITIALIZED, RUNNING, INVALID, DONE };
                                     ^
./../../content/browser/browser_thread_impl.cc:38:3: note: previous declaration is here
  RUNNING,
  ^
In file included from gen/content/browser/browser_jumbo_1.cc:505:
In file included from ./../../content/browser/renderer_host/input/synthetic_gesture.cc:10:
../../content/browser/renderer_host/input/synthetic_pointer_action.h:30:47: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow]
  enum GestureState { UNINITIALIZED, RUNNING, INVALID, DONE };
                                              ^
./../../content/browser/frame_host/ancestor_throttle.cc:52:3: note: previous declaration is here
  INVALID = 6,
  ^

TBR=avi@chromium.org

Change-Id: I2877006171e318dc43fe66ed4c2bcd558f6233a8
Reviewed-on: https://chromium-review.googlesource.com/c/1326498Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#606536}

gperf can generate symbols directly into the global namespace
(in this case wrapped in "blink") or into more tight scopes.
Most of the code generates into a tight scope but not
css_property_names.cc. In a new clang a shadowing warning appeared
in jumbo builds because of it. There seems to be no downside
to using a reduced scope.

In file included from gen/third_party/blink/renderer/core/core_generated_jumbo_1.cc:152:
./gen/third_party/blink/renderer/core/css_value_keywords.cc:3612:7: error: declaration shadows a variable in namespace 'blink' [-Werror,-Wshadow]
      TOTAL_KEYWORDS = 842,
      ^
./gen/third_party/blink/renderer/core/css_property_names.cc:55:5: note: previous declaration is here
    TOTAL_KEYWORDS = 554,
    ^
In file included from gen/third_party/blink/renderer/core/core_generated_jumbo_1.cc:152:
./gen/third_party/blink/renderer/core/css_value_keywords.cc:3613:7: error: declaration shadows a variable in namespace 'blink' [-Werror,-Wshadow]
      MIN_WORD_LENGTH = 1,
      ^
./gen/third_party/blink/renderer/core/css_property_names.cc:56:5: note: previous declaration is here
    MIN_WORD_LENGTH = 1,
    ^
In file included from gen/third_party/blink/renderer/core/core_generated_jumbo_1.cc:152:
./gen/third_party/blink/renderer/core/css_value_keywords.cc:3614:7: error: declaration shadows a variable in namespace 'blink' [-Werror,-Wshadow]
      MAX_WORD_LENGTH = 42,
      ^
./gen/third_party/blink/renderer/core/css_property_names.cc:57:5: note: previous declaration is here
    MAX_WORD_LENGTH = 34,
    ^
In file included from gen/third_party/blink/renderer/core/core_generated_jumbo_1.cc:152:
./gen/third_party/blink/renderer/core/css_value_keywords.cc:3615:7: error: declaration shadows a variable in namespace 'blink' [-Werror,-Wshadow]
      MIN_HASH_VALUE = 18,
      ^
./gen/third_party/blink/renderer/core/css_property_names.cc:58:5: note: previous declaration is here
    MIN_HASH_VALUE = 9,
    ^
In file included from gen/third_party/blink/renderer/core/core_generated_jumbo_1.cc:152:
./gen/third_party/blink/renderer/core/css_value_keywords.cc:3616:7: error: declaration shadows a variable in namespace 'blink' [-Werror,-Wshadow]
      MAX_HASH_VALUE = 6641
      ^
./gen/third_party/blink/renderer/core/css_property_names.cc:59:5: note: previous declaration is here
    MAX_HASH_VALUE = 3587
    ^
5 errors generated.

Change-Id: I03ffd31e0b6731b2e8bacb1e7222be5defce3ea4
Reviewed-on: https://chromium-review.googlesource.com/c/1326500Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#606535}

This CL adds the getAriaLabel() and getAriaDescription() helper
functions to the __GCrWeb.fill "namespace". These functions return
the ARIA label and description strings associated with an element.

The ARIA Label is the text referenced by one or more containing element
ids in the labelled elements aria-labelledby attribute, or the value
of the element's aria-label attribute, with preference given to the
aria-labelledby attribute. For example:

    <div id='foo-label'>Label for Foo</div>
    <input name='foo' aria-labelledby='foo-label'>
    <input name='bar' aria-label='Label for Bar'>

The aria-description is similar to aria-labelledby. For example:

    <div id='foo-description'>Long descriptive text for Foo</div>
    <input name='foo' aria-describedby='foo-descrition'>

Bug: 896719
Change-Id: I300b84298fc20e1b86474f60d08cdd1c9569036b
Reviewed-on: https://chromium-review.googlesource.com/c/1325032Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606534}

Bug: 845472
Change-Id: I6ba687245c8493d21bc305c1f530146ef97e59aa
Reviewed-on: https://chromium-review.googlesource.com/c/1318972
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606533}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowBaseSyncPrimitives in non-test files
 * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=kolos@chromium.org

Bug: 766678
Change-Id: I3fd284aae2f351224ceb21852bbf6737c031fc56
Reviewed-on: https://chromium-review.googlesource.com/c/1325204Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606532}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7491c965b291..b628aaf43bd1


Created with:
  gclient setdep -r src-internal@b628aaf43bd1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I53eb6e965983951077133fb96ac168a7cbf43b33
Reviewed-on: https://chromium-review.googlesource.com/c/1326742Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606531}

In TouchActionFilterTest, there is a function named ScrollingTouchAction,
and this CL changes the name to ActiveTouchAction. It is called
ScrollingTouchAction because the corresponding variable in the
TouchActionFilter was named |scrolling_touch_action_|. Now that this
variable is renamed to |active_touch_action_|, we should change the
function name to ActiveTouchAction.

Bug: None
Change-Id: I34d51bba4b5604dbeab743f3ce6f6a27d315c7e9
Reviewed-on: https://chromium-review.googlesource.com/c/1323622Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606530}

- Properly suffixes BigInt constants with 'n'
- Fixes stringification of constants into valid .js syntax
- Improve default values handling in structs which was only partially
  implemented previously

Bug: 883496
Change-Id: Id270d2f34dd40fa970d58448c1002c691db35a87
Reviewed-on: https://chromium-review.googlesource.com/c/1321577
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606529}

SVGTextLayoutEngineSpacing checking if the current and last characters
were non-nuls before attempting to apply word-spacing. This would mean
that we'd never add word-spacing at the beginning of a text box.
Remove the checks for non-nuls.

Bug: 902839
Change-Id: I751e1bd1317f7411960d137b7e55a3b83e8cb0df
Reviewed-on: https://chromium-review.googlesource.com/c/1326156Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#606528}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ib2089db12d37b7da709909dd797a695a2f1e8a8d
Reviewed-on: https://chromium-review.googlesource.com/c/1324872Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606527}

Bug: 714231
Change-Id: I441067d621effc11fbd8d497716d6693e7bb5971
Reviewed-on: https://chromium-review.googlesource.com/c/1320200
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#606526}

This is a reland of b43c6fca

Cannot reproduce the failures locally, nor in CQ.

Try to reland the same CL to see if it was a flake.

Original change's description:
> Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow
>
> This patch allows computing NGOffsetMapping for legacy inline
> formatting context.
>
> For an experimental project "Invisible DOM"[1][2] to support
> the find-in-page feature, it is needed to compute the text
> content with whitespace collapsing applied, along with the
> mapping to the DOM offset. This patch adds an API to compute
> NGOffsetMapping even when the LayoutBlockFlow is not laid out
> by LayoutNG for that purpose.
>
> Note that the project is still in the early phase. We may
> revisit the design as it moves forward.
>
> [1] https://github.com/rakina/searchable-invisible-dom
> [2] https://www.chromestatus.com/feature/5105291213406208
>
> Bug: 636993, 873057
> Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882
> Reviewed-on: https://chromium-review.googlesource.com/c/1322184
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606292}

TBR=yoshin@chromium.org, eae@chromium.org

Bug: 636993, 873057
Change-Id: I241c6e9163add4000fa078c5d70a62b89acea9ac
Reviewed-on: https://chromium-review.googlesource.com/c/1326343Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606525}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowBaseSyncPrimitives in non-test files
 * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=morlovich@chromium.org

Bug: 766678
Change-Id: Ibbaf0d854d2c8fb08b515e3fe8a3c7614630ab62
Reviewed-on: https://chromium-review.googlesource.com/c/1325203Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606524}

https://skia.googlesource.com/skia.git/+log/6d1df6d9c128..1379508a3a57


git log 6d1df6d9c128..1379508a3a57 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 caryclark@skia.org some pathops fuzz fixes
2018-11-08 caryclark@skia.org Check every word in docs


Created with:
  gclient setdep -r src/third_party/skia@1379508a3a57

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@chromium.org

Change-Id: I499f2e5b16e8a6f58c10e4b1f1964324aed6f8c1
Reviewed-on: https://chromium-review.googlesource.com/c/1326328Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606523}

The 'dlog' SSH channel appears to trigger a bug that causes the package-
upload step to fail on ARM64 under QEMU.

Bug: 900790
Change-Id: Ie5871cef98e94deb936ae591c87a5c90a960b092
Reviewed-on: https://chromium-review.googlesource.com/c/1325529Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606522}

This was causing extensions_unittests to fail under UBSan, see bug.

Bug: 903339
Change-Id: Ie7d80297d85668e3ba72d0c92467bcf6975fce19
Reviewed-on: https://chromium-review.googlesource.com/c/1326508
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606521}

A bluetooth enum was putting some common names like "SUCCESS",
"UNKNOWN" and "FAILED" in the content namespace. A recent
clang (I think) added new warnings when these got
got shadowed by other uses of the names. See full error below.

This enum was always intended to be in an enum class judging from
how it's used, so just use enum class to avoid further clashes.

This primarily affected jumbo builds but could happen to any build
which happened to include two conflicting headers in the same file.

../../content/browser/histogram_synchronizer.h:54:5: error: declaration shadows a variable in namespace 'content' [-Werror,-Wshadow]
    UNKNOWN,
    ^
../../content/browser/bluetooth/bluetooth_metrics.h:228:3: note: previous declaration is here
  UNKNOWN = 5,
  ^
In file included from gen/content/browser/browser_jumbo_1.cc:170:
In file included from ./../../content/browser/devtools/devtools_instrumentation.cc:16:
../../content/browser/frame_host/navigation_request.h:68:5: error: declaration shadows a variable in namespace 'content' [-Werror,-Wshadow]
    FAILED,
    ^
../../content/browser/bluetooth/bluetooth_metrics.h:229:3: note: previous declaration is here
  FAILED = 6,
  ^
In file included from gen/content/browser/browser_jumbo_1.cc:247:
In file included from ./../../content/browser/download/drag_download_file.cc:5:
../../content/browser/download/drag_download_file.h:53:37: error: declaration shadows a variable in namespace 'content' [-Werror,-Wshadow]
  enum State {INITIALIZED, STARTED, SUCCESS, FAILURE};
                                    ^
../../content/browser/bluetooth/bluetooth_metrics.h:223:3: note: previous declaration is here
  SUCCESS = 0,
  ^

TBR=jyasskin@chromium.org

Change-Id: I2f35c1c11262e4f071cf1d64348c9bc30c76351b
Reviewed-on: https://chromium-review.googlesource.com/c/1326507Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#606520}

This enables VaapiVEA to encode DMABuf-backed video frame. Because the
va surface format is NV12, NV12 format is only acceptable.
This change is tested by crrev.com/c/1295636

BUG=chromium:895230
TEST=VEA unittest --native_input

Change-Id: Ib3c09363936cdf3099bb9ed9fc14eb24bd0e70fe
Reviewed-on: https://chromium-review.googlesource.com/c/1306944
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606519}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I0738957fbcdb63da03152d852cf20e02603f7924
Reviewed-on: https://chromium-review.googlesource.com/c/1325429
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606518}

aura::client::kResizeHandleInset was added in 779ce514
but until now, never actually applied. This should fix the linked bug
(for Mash at least) as well as standard browser windows and frameful
app windows.

Bug: 891068
Change-Id: Iedd512bafd9f0ef7f0ecce05afcf942defba8249
Reviewed-on: https://chromium-review.googlesource.com/c/1325289Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606517}

This is now unused.

R=tbarzic@chromium.org
TBR=droger@chromium.org

TBRing David for the removal of EnsureAPIBrowserContextKeyedServiceFactoriesBuilt() from chrome_browser_main_extra_parts_profiles.cc.

Bug: 899324
Test: none
Change-Id: Ife19019fd8b05dfcd627e92167f485e96401662b
Reviewed-on: https://chromium-review.googlesource.com/c/1319340Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606516}

Change-Id: Ib28560cfbb9c550770da138236a9af8fa9152f9a
Reviewed-on: https://chromium-review.googlesource.com/c/1325560
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606515}

This change removes //chrome/installer/mac/app. This directory contained a
cancelled project from 2016 to build a standalone installer and has never been
shipped. Since its tests are broken on 10.14, we can just delete it rather than
fixing those.

Bug: 892172
Change-Id: Ib3d9e9c072a12e66cb7863a3e40eed8a13e948d6
Reviewed-on: https://chromium-review.googlesource.com/c/1315954Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606514}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowSyncPrimitives in non-test files
 * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=sergeyu@chromium.org

Bug: 766678
Change-Id: I769a4567e23b45976732ec447889eeb683faf68b
Reviewed-on: https://chromium-review.googlesource.com/c/1324917Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606513}

Right now the lifetime of AwGLFunctor (and that of associated objects)
roughly matches the lifetime of AwContents. This is not necessary, and
we only need to ensure it's alive when functor is in use. This better
matches the APIthat the vulkan functor will have. It also has the up
side of converting CleanupReference usage to explicit destroy, which
is always nice.

Bug: 901554
Change-Id: Ib1126d1ddfeacc7b8c689aeb51bb897cf839b41c
Reviewed-on: https://chromium-review.googlesource.com/c/1320749Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606512}