- 16 Sep, 2019 40 commits
-
-
Victor Costan authored
IDBTransactionCommit has been "stable" since M76. At this point, it is a permanent part of the Web platform. Bug: 898257 Change-Id: I8fbb5574c01a5f36dc1d785451f5f4cf7b21510c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806163 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#696735}
-
Ioana Pandele authored
This reverts commit 588d7e15. Reason for revert: This is likely causing TabletModeWindowmanagerWithClamshellSplitViewTest.ClamshellTabletTransitionTest to consistently fail on multiple ChromeOS bots. Bug:1004195 Original change's description: > split view: Remove window activation in SplitViewController's snap logic > > SplitViewController::OnWindowSnapped shall no longer activate the newly > snapped window. In many workflows, such window activation is redundant > or inappropriate (see the referenced issues on Monorail). Window > activation shall be done separately by code for workflows where the > snapped window actually does need to be activated. > > Bug: 982954, 983227, 991611, 995946 > Change-Id: Ie111d90786764f0612aea73ba9cfa4ce640fe1f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738338 > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Mitsuru Oshima (slow - perfing & gardening) <oshima@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Avery Musbach <amusbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696599} TBR=sky@chromium.org,oshima@chromium.org,xdai@chromium.org,amusbach@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982954, 983227, 991611, 995946 Change-Id: Ie6760645dd3ded55bf1190341155da63176d6f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803926Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#696734}
-
Maksim Sisov authored
This CL removes the setup of WindowEventFilter in the DWTHX11 and uses the one already implemented in the DWTHPlatform. However, to make move/resize work with non-Ozone X11, the WMResizeHandler is subclassed by the X11Window instead of X11WindowOzone now. Bug: 990756 Change-Id: I9e95bf56adcf21267246c45264d8a801ee9f45cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776027 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#696733}
-
Tanisha Mandre authored
- MobileAddCreditCard.AddPaymentMethodButton - Entry point from settings. - Modify ManualFallback_CreditCard_OpenAddPaymentMethod - Entry point from manual fallback. - MobileAddCreditCard.AddButton - Save a new card using the 'Add' button. Bug:1002512 Change-Id: I20ab8faf3b40345b21e00a37d801d6ae666b557b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796357Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#696732}
-
Jan Scheffler authored
This patch adds a min width to the debug panel in the sources panel to keep it from overflowing. Bug: chrome:841745 Change-Id: Id33fb70555a1d12a732c803fdf398a165a507ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786442 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#696731}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ecd10922eec5..914862e8ec8a git log ecd10922eec5..914862e8ec8a --date=short --no-merges --format='%ad %ae %s' 2019-09-16 dberris@chromium.org PinpointScheduler: Port of find_isolate to Tasks Created with: gclient setdep -r src/third_party/catapult@914862e8ec8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:988912 Change-Id: I3521c035e1e2327ef09d8cd8134ad4e584191322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806326Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696730}
-
Giovanni Ortuño Urquidi authored
Tests are failing on linux: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83157 TBR=pfeldman@chromium.org Bug: 1004150 Change-Id: I4bf6d6a10d60c7659a23b6aba1884a5995957531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804709Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#696729}
-
Tanisha Mandre authored
- Test that if a card with an invalid expiry date is added, an alert is shown. - Test that the 'Cancel' button dismisses the screen. Bug:1000669 Change-Id: Ie5f22fbcb4e8aecb9955c21d35a0bffbb55522e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786646 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
-
Benedikt Meurer authored
The color selection for code coverage (red+green) is not ideal for developers that are impacted by color blindness. This changes the colors to a brighter red and some blueish green that, a combination that is known to work well enough for people impacted by different kinds of color blindness. https://pbs.twimg.com/media/EEU9fCzUUAItz4n?format=jpg shows an example of how these two colors look like now. Bug: chromium:1003671 Change-Id: I9c3e08fb350a6086624d63f44e069813c618588e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801762 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/561b90bd1d76..86c48abc94f3 git log 561b90bd1d76..86c48abc94f3 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b1580a276713..d32dae1bb37c (5 commits) 2019-09-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader adb0d51ca672..30847688f059 (2 commits) Created with: gclient setdep -r src/third_party/skia@86c48abc94f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None,chromium:None Change-Id: I55ce7cc4f987c7ac46f7d1bdd8ff821a9b523a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805719Reviewed-by:
-
Jason Lin authored
* Remove extra inset for a few crostini dialogs * Do not show the close button for CrostiniUpgradeContainerView so that it is consistent with other crostini dialogs. Bug: 965185 Change-Id: Idf3934116ea73ef9153e05b8370cd67f4d64a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803943Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#696725}
-
Koji Ishii authored
When `word-break: break-all` or `keep-all` is specified, this patch fixes `overflow-/word-wrap: break-word` to be effective. Before this patch, it was forced to be `normal`. Bug: 1001378 Change-Id: I73f5956a6856f2cbd0944461a0aa7a2929e722cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806162 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#696724}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdf64c9f6d8e..f02b13925471 Created with: gclient setdep -r src-internal@f02b13925471 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3efd12057c6ef0b6c30a0fba2a63014eff4e95d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805904Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696723}
-
Renato Silva authored
ChromeOS update logo was chopped of on the tip of the arrow. This commit replaces the image with a proper one. Bug: 936616 Change-Id: I5943f187fb421b3ab70728344dc48590dda3e324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803284Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#696722}
-
Matt Giuca authored
Bug: 1001405 Change-Id: I918c57d6922915e624b731432b393311d8ab1a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802780 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#696721}
-
David Vallet authored
Bug: 937152 Change-Id: Ibf516ba18d596dd82f15cdcb060c7bd3e0345863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803946Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: David Vallet <dvallet@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#696720}
-
Keishi Hattori authored
This reverts commit 0d7047f8. Reason for revert: Caused regression in memory usage Bug: 1003130 Original change's description: > [Resolve Leak Error]Make ScriptValue Traceable > > We made ScriptValue Traceable to replace SharedPersistent > with TraceWrapperV8Reference in a follow-up CL. > > In this CL, most of the changes are just: > - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because > ScriptValue has a Trace method. > - Add a trace method for ScriptValue and ScriptPromise since > they have objects to Trace. > > We recommend you to mainly check > - script_value.h where I add VectorTraits. > - script_promise.h where I add VectorTraits. > - v8_callback_function.py where I add a code to generate HeapVector. > - v8_types.py > * Add ScriptValue and ScriptPromise to "is_traceable==True" > which is used to generate Trace method & HeapVector. > > + I removed code to detect leak around ScriptPromise because > ScriptPromise no longer has persistent which may cause memory leak. > > Bug: 998994 > Change-Id: I63fcbf01de099577fe14045785b3072c615d78c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792583 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Rika Fujimaki <rikaf@google.com> > Cr-Commit-Position: refs/heads/master@{#695505} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,keishi@chromium.org,kouhei@chromium.org,rikaf@google.com Change-Id: I35a1c06c1e9079950e03023f7577b28ca0811bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803942Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Andrew Moylan authored
Bug: chromium:1000119 Change-Id: I2da457de5901a8771b249bb19c2f6edb6895e3b1 Tested: No Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782020 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#696718}
-
Giovanni Ortuño Urquidi authored
TBR=afakhry@chromium.org Bug: 1003339 Change-Id: I49bdda14651699c562dbfc25be3ce434d570ab54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803945Reviewed-by:
-
Jinsuk Kim authored
This CL makes half/full state height of BottomSheet dynamic so that the sheet can have both half/full state and keep the content wrapped. Gesture navigation shows how it can be used as an example. By overriding BottomSheetContent.getCustomized{Half,Full}Ratio: - The sheet expands to the half state with content wrapped. The height is maxed out at the half the container height. - If slided up, the content moves to the full state, the content still wrapped. The height is maxed out at the full container height, and the content becomes scrollable if necessary. Bug: 993051 Change-Id: I7e000716ee6b544b541d385e34cae026d64798d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781123 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#696716}
-
Maksim Sisov authored
To make ozone/linux really use the DesktopWindowTreeHostLinux, it is also needed to share the BrowserDesktopWindowTreeHost* impl between X11/linux and ozone/linux. This CL renames the BrowserDesktopWindowTreeHostX11 to BrowserDesktopWindowTreeHostLinux and adds some USE_X11 guards, which will be removed in the future. Bug: 990756 Change-Id: Id99d63a627257fbaca7e5de65ec4973d8396d4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796547 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I82d3c60b12de9f9a0e5ceaf9fb1e960678c12e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805482Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb52badca04a..561b90bd1d76 git log cb52badca04a..561b90bd1d76 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 46548997..48c8f915 (416 commits) Created with: gclient setdep -r src/third_party/skia@561b90bd1d76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None Change-Id: Ifc855099d1236306a8a286dba2e706340bc10950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805481Reviewed-by:
-
Fergal Daly authored
This bug was introduced https://crrev.com/c/1772850. Set.add does not take multiple arguments, so most revealed elements were not added to the observed set. Bug: 1004102 Change-Id: If57b3125a54a52e1d0fd242c29b059b1cf69b2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804096 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#696712}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6fe107e0feca..b8a20f9d9f71 git log 6fe107e0feca..b8a20f9d9f71 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 sidereal@google.com Update GUEST_IMAGES_PINS_PATH Created with: gclient setdep -r src/third_party/chromite@b8a20f9d9f71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I93e870fa735a44d73d031a5aa8dde2a93d43b9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805479Reviewed-by:
-
Jeevan Shikaram authored
This CL adds a no-search tag to the os-settings/app-management subpage. This prevents the search provider from loading the App Management subpages as this can lead to long search times and recursive behaviors. Bug: 1003277 Change-Id: Ie72a574bf0e040961fa6f79b6281af8fbedf6457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804697 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#696710}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fcbe4071ce46..7af1bb3f90b3 git log fcbe4071ce46..7af1bb3f90b3 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9f151687..1d12ff69 (696593:696696) Created with: gclient setdep -r src/third_party/webrtc@7af1bb3f90b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I97cb84522a0b5b125039d68c447f6680642a16a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805478Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit cfc19ddd. Reason for revert: Initial revert didn't fix failures. Original change's description: > Revert "DevTools: Add ARIAUtils.setCheckboxAsIndeterminate" > > This reverts commit 2cf002af. > > Reason for revert: Breaks http/tests/devtools/a11y-axe-core/basic-a11y-test.js and 5 other(s), see issue 1004150 - locally identified > tests as fixed when reverting this CL (on Linux) > > Original change's description: > > DevTools: Add ARIAUtils.setCheckboxAsIndeterminate > > > > This adds a new API to UI.ARIAUtils to set an element's aria-checked > > attribute to 'mixed', which is the equivalent of setting > > intedeterminate=true on an actual checkbox element. > > This is needed to support keyboard accessibility in the javascript and > > event listener breakpoints views. > > > > Equivalent to the Animation checkbox in this screenshot: > > https://gyazo.com/99f2067f6810af3366943176393d8b2f > > > > Bug: 963183 > > Change-Id: Ie09f8e993d1776774c410f6099356f3a1d912048 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715815 > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > Auto-Submit: Jack Lynch <jalyn@microsoft.com> > > Commit-Queue: Jack Lynch <jalyn@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#696551} > > TBR=pfeldman@chromium.org,einbinder@chromium.org,jalyn@microsoft.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 963183, 1004150 > Tbr: ortuno@ > Change-Id: I3ef2a4a5b74be00de669db215f27c2586acba40f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803937 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696700} TBR=pfeldman@chromium.org,drott@chromium.org,ortuno@chromium.org,einbinder@chromium.org,jalyn@microsoft.com Change-Id: I433a1549e7f1ef909fe2b3b0fc2cea584bceafcd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963183, 1004150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804703Reviewed-by:
-
Alan Cutter authored
This CL moves kSaveCard and kLocalCardMigration PageActionIcons into the OmniboxPageActionIconContainerView so they can be reused by PWA windows. This removes them from the LocationBarView and makes them conform to the interface used by the majority of the PageActionIcons. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=411699&signed_aid=oN3fSiCBdesl2B-kWaptBQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=411700&signed_aid=PouzN_Ing1hmoMWdLqXZVA==&inline=1 Bug: 788051 Change-Id: Iebc963bdf24eeb5e16257065f79caefdc9158dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803018 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#696707}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3de1b8d0b098..cc17f852d575 git log 3de1b8d0b098..cc17f852d575 --date=short --no-merges --format='%ad %ae %s' 2019-09-15 :avih [cmake] Don't fail if brotli is missing (#56894). Created with: gclient setdep -r src/third_party/freetype/src@cc17f852d575 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I23f67d997c39dbae01bbee0e7f577d946c5e718f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805917Reviewed-by:
-
Eric Willigers authored
In preparation for testing with WebAppBrowserController, change BookmarkAppTest to use WebAppControllerBrowserTest. Similar to reverted CL https://chromium-review.googlesource.com/c/chromium/src/+/1787758 which experienced win-asan failures with observer lists on shutdown. Observer list issues on shutdown have been addressed by https://chromium-review.googlesource.com/c/chromium/src/+/1800884 Bug: 966290 Change-Id: I1180a12ad4a2f23255f9c711a40da21e71a5d205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801401Reviewed-by:
-
Emil A Eklund authored
Remove a DCHECK in ng_absolute_utils liable to trigger incorrectly when any combination of the component values are near the saturation limits. Bug: 1002317 Change-Id: I1bc22823dd72a23c162eecb2f3c676e059617817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804937 Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696704}
-
Eric Willigers authored
InstallableManager::CheckServiceWorker() now quits immediately if called after the service worker context has been destroyed. Bug: 993666 Change-Id: Idcb336f5532d52e9181c85f71a255579ae0f0cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806159 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#696703}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a5cce89fe5f6..bdf64c9f6d8e Created with: gclient setdep -r src-internal@bdf64c9f6d8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3e4d0deb9ab6e25a56a0bb920e0213731a0a9c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805477Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iec9a010782222ae75eff8aaf74a3a0e4eca6f86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804325Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696701}
-
Dominik Röttsches authored
This reverts commit 2cf002af. Reason for revert: Breaks http/tests/devtools/a11y-axe-core/basic-a11y-test.js and 5 other(s), see issue 1004150 - locally identified tests as fixed when reverting this CL (on Linux) Original change's description: > DevTools: Add ARIAUtils.setCheckboxAsIndeterminate > > This adds a new API to UI.ARIAUtils to set an element's aria-checked > attribute to 'mixed', which is the equivalent of setting > intedeterminate=true on an actual checkbox element. > This is needed to support keyboard accessibility in the javascript and > event listener breakpoints views. > > Equivalent to the Animation checkbox in this screenshot: > https://gyazo.com/99f2067f6810af3366943176393d8b2f > > Bug: 963183 > Change-Id: Ie09f8e993d1776774c410f6099356f3a1d912048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715815 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Auto-Submit: Jack Lynch <jalyn@microsoft.com> > Commit-Queue: Jack Lynch <jalyn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#696551} TBR=pfeldman@chromium.org,einbinder@chromium.org,jalyn@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963183, 1004150 Tbr: ortuno@ Change-Id: I3ef2a4a5b74be00de669db215f27c2586acba40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803937 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#696700}
-
Stephen McGruer authored
https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dxDGBFKvO3A Bug: 868224 Change-Id: I68b33822badc36c3cebcdca7bf6f47d834160270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797226Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696699}
-
Leon Han authored
nfc_constants.{cc,h} just defines some const texts like error messages etc. that we can just use directly in code. BUG=520391 Change-Id: Ied00da5594f22d07d9328d75874e9a2d54f8feff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797368 Commit-Queue: Leon Han <leon.han@intel.com> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696698}
-
Alan Cutter authored
This CL replaces BrowserWindow::GetOmniboxPageActionIconContainer() BrowserWindow::GetToolbarPageActionIconContainer() with BrowserWindow::UpdatePageActionIcon(type) BrowserWindow::ExecutePageActionIconForTesting(type) in order to hide the implementation detail of which container any given icon resides in. This is in preparation for adding more page-action-icons to PWA windows which only have one container. This is a pure refactor with no behavioural changes. Bug: 788051 Change-Id: I71a4e117db7595ac2bccdafc454f76e6b27c3bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792521 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch changes positions in |ShapingLineBreaker| from |LayoutUnit| to |float|. This change turns a few operations from |LayoutUnit| to |float|, but because |CachedPositionForOffset| uses |float|, it avoids a few casts between |LayoutUnit| and |float|, and avoids complexities caused by casting twice (|float| -> |LayoutUnit| -> |float|.) This patch can fix issue 1002442 without the previous one by eliminating snapping, because the issue occurs by the errors in snapping to |LayoutUnit|. There seems to be slight difference in the behavior, such as when extreme letter-spacing is used and positions become inifite numbers. The new behavior seems to be more correct, though an experiment to use the overflow state of |ShapingLineBreaker| more (crrev.com/c/1803994) in |NGLineBreaker| breaks slightly differently. Bug: 1002442, 1003742 Change-Id: I5ece8478b99fe76e7aa798b98cab64f24a95d5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801394Reviewed-by:
-
