GitLab

TrayPopupHeaderButton is a deprecated class that isn't used anymore.

BUG=none

Change-Id: I0065e012372f5a9ab3a2e97cc20add51afdf5b09
Reviewed-on: https://chromium-review.googlesource.com/918144
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536921}

Currently the set of fonts used for layout tests on Android and Fuchsia
doesn't include any Chinese, Japanese or Korean fonts, so they render tofu
on the pixel tests that contain text in these languages. Adding NotoSansCJK
so these tests can render properly.

Bug: 778467, 787020
Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4
Reviewed-on: https://chromium-review.googlesource.com/910122
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536920}

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7f3649304443c82c7604d4ba4c9e2ef0b966c5f1
Reviewed-on: https://chromium-review.googlesource.com/919643Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536919}

Full test name is
SSLClientCertificateSelectorCocoaTest.WorkaroundCrashySierra

Test only runs (and flakes) on mac.

Bug: 810909
Change-Id: I2dc0c8d347a8292d89df3e5590cfff1db481829a
TBR: sdy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/920685Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536918}

Bug: 805013
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0b9ed58466af7b0c7ea092d8210683ba510502d4
Reviewed-on: https://chromium-review.googlesource.com/916808
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536917}

This patch changes |TextIteratorTextNodeHandler::HandleTextBox()| to handle
range ends at end of leading collapsed whitespace of first-letter part, e.g.
"<p>^ |(1) foo</p>" where P has ::first-letter.

Bug: 810623
Change-Id: I6888bf0cba305d33c193b6cd4c3f191c8dcf36bd
Reviewed-on: https://chromium-review.googlesource.com/910543
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536916}

This reverts commit b36af4e1.

Reason for revert: There seem to be some rounding issues during continuous repositioning of the parent window.

Original change's description:
> Add Child Move and Resize Support to the BubbleAnchorHelper
> 
> The ExtensionPopup resizes its view dynamically after it can be
> anchored and shown.
> 
> This change adds child resize support to BubbleAnchorHelper to
> accommodate that scenario. Move is brought along for free.
> 
> BUG=728174
> 
> Change-Id: I7ca12b92da339263ca5558254d2bbb0595a57b4c
> Reviewed-on: https://chromium-review.googlesource.com/915010
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536753}

TBR=ellyjones@chromium.org,robliao@chromium.org

Change-Id: Ic8c3c6766f10a779b467605f808c883869def07e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 728174
Reviewed-on: https://chromium-review.googlesource.com/920604Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536915}

RefCountedMemory is an arbitrary wrapper around memory. It is used
extensively in code which passes encoded PNG files around, such as the
history system and the screenshotting code.

Bug: 706246
Change-Id: I9788aaba9dcfe38bd05418c4cc3a9e2737a5985c
Reviewed-on: https://chromium-review.googlesource.com/917198Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536914}

- Creates a RecentTabsTableViewController constants file.
- Creates a file for RecentTabsTableViewControllerDelegate protocol.
- Creates Protocol RecentTabsTableViewControllerInterface, this includes all the public
RecentTabsTableViewController methods.
- Renames RecentTabsTableViewController to LegacyRecentTabsTableViewController.
- Small cleanup of unused imports.


Bug: 805013
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie682653c2154e22776b0e991db56d52f6d5aab20
Reviewed-on: https://chromium-review.googlesource.com/896923
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536913}

Currently |recordStateInHistory| can clobber page display state of the
incoming page on back/forward navigation. This change works around it
by disabling page display state recording for new navigation manager.
WKWebView restores page scroll on back/forward navigation already, so
this only impacts the user when restoring pages from history, which
will be fixed in crbug.com/786511.

With this fix, FullscreenTestCase and ContentSuggestionsTestCase pass.

Bug: 807428,811770
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5205f5c18853078e9053f2b57708f3192fc64099
Reviewed-on: https://chromium-review.googlesource.com/916830Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536912}

Covers widget dialog title sentence case for app_modal_strings.grdp.

This reverts the dialog titles to pre-titlecase "www.google.com says"
since this no longer looks wonky when there's no titlecase version of
it.

Bug: chromium:810111
Change-Id: I5f72d704629dfc1da1522c4a34707c5864a44947
Reviewed-on: https://chromium-review.googlesource.com/917467
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536911}

Currently it isn't cleared. On 10.13, evidence suggests that AppKit has changed
to allow the runtime to clear it by a __weak annotation. But we shouldn't rely
on that.

Bug: 788271
Change-Id: I7d7d35dc9273fc113ce6fe8e460e238b712f9d41
Reviewed-on: https://chromium-review.googlesource.com/915406
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536910}

Dispatch events for all event types for impl only animations. Previously this was
only done for start|finish but we are doing it for abort|takeover too. There is
no good reason not to do so and doing so is simple and consistent.


Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I50ccd1fda663dd3e922f5ac97b0a3b6705fb352f
Reviewed-on: https://chromium-review.googlesource.com/911612Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536909}

Depth camera video capture is working with DirectShow but
not with MediaFoundation. This comes from the fact that
IMFCaptureEngine is unable to perform encoding/decoding on non standard
MediaFoundation formats Y16, Z16 and INVZ.

To fix it, formats Y16, Z16 and INZV are set equally in the source and
the preview sink.

Bug: 730068
Change-Id: I66bd25f9b8796e4ed564df1e3a9867dcbd9f9522
Reviewed-on: https://chromium-review.googlesource.com/918001Reviewed-by: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536908}

This reverts commit 46931c64.

Reason for revert: This is not the right approach based on the chat
with Oshima.

Original change's description:
> cros: ensure minimum window visibility for setting arc window bounds
> 
> changes:
> Applying minimum window visibility (25DIPs) when setting arc window
> bounds.
> 
> Bug: 806094
> Test: tested on device
> Change-Id: Ia89080bfc4a984395dea327e2ed3ab6229c43467
> Reviewed-on: https://chromium-review.googlesource.com/899961
> Reviewed-by: David Reveman <reveman@chromium.org>
> Commit-Queue: Qiang Xu <warx@google.com>
> Cr-Commit-Position: refs/heads/master@{#536879}

TBR=reveman@chromium.org,oshima@chromium.org,warx@google.com

Change-Id: I034bb4d7b92a6e1b425d95fb1f47ada7412b4a68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 806094
Reviewed-on: https://chromium-review.googlesource.com/920621Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#536907}

Since this unit test requires WinRT which only exists on Windows 8 or above,
we don't run it on Windows 7 bots.

Bug: 734095
Change-Id: I6889efb1e9425fe3cc4ae37ae6b0f0d54e7c4f5a
Reviewed-on: https://chromium-review.googlesource.com/915016
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536906}

This patch moves clang's AFDO into the "afdo" config, and pushes the
-fprofile-sample-accurate flag into an "afdo_accurate" config.

As discussed in the bug, the regressions we're seeing are heavily because
we're applying 'accurate' AFDO to both Skia and Blink. Marking profiles
inaccurate for all of Skia costs >400KB binary size, which is
undesirable. If we instead split a few particularly hot bits out, we can
see most of the benefit for ~half the binary size increase.

While the split of clang's AFDO into the afdo config isn't strictly
necessary, it probably doesn't hurt, and will help experimentation
with issues like this in the future, if they arise.

Bug: 799629
Test: Ran benchmarks; scores are better (as noted in the bug)
Change-Id: I4f1f8767cfb70fcc733ab468fb53347857d2fd98
Reviewed-on: https://chromium-review.googlesource.com/917201
Commit-Queue: George Burgess <gbiv@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536905}

This is needed for the "Build From Tarball" bot which unbundles
libraries.  Some of the libraries we bundle are very close to ToT,
and the build would fail if we were using an out-of-date version
without the latest features.

Sid allows us to have everything we need, and it doesn't matter
that the libraries are unstable since we don't actually run
anything against them.

R=thestig,dpranke

Change-Id: I0c42113b2e1bdc910230742cd22ad0681699291a
Reviewed-on: https://chromium-review.googlesource.com/823563Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536904}

Bug: 812304
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib729933d425af0630201e11092e406089b7084ff
Reviewed-on: https://chromium-review.googlesource.com/919543
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536903}

r536296 updated the LocationBarView decoration ink drops to be circular.
However, BubbleIconView's ink drop highlight is still the default
implementation, which uses a default ink drop size. To prepare for making the
LocationBarView taller, make sure the BubbleIconView's highlight is the same
size as the BubbleIconView itself. This avoids the highlight being smaller than
the ripple.

Bug: 801583
Change-Id: I94b42cd4d7fde23a8e0b07f84b0c31d80dda2a85
Reviewed-on: https://chromium-review.googlesource.com/917781Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536902}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/758f7df8..62d82cfd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7b60e89f987d5970701532c690d09e927a130543
Reviewed-on: https://chromium-review.googlesource.com/919970Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536901}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5ed4b3d3c6ee..13139639690b

$ git log 5ed4b3d3c..131396396 --date=short --no-merges --format='%ad %ae %s'
2018-02-09 rsorokin authpolicy: Add dm_token into JoinDomainRequest
2018-02-06 ejcaruso cryptohome: remove constant for AsyncAddKey
2018-02-12 baileyberro smbprovider: Add MoveEntry protobuf

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I9ddd04d8c4f8b7a00e666b253141c3ece5f2610f
Reviewed-on: https://chromium-review.googlesource.com/919663Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536900}

Failure codes such as STATUS_ACCESS_VIOLATION are easily recognizable
and easily differentiated when printed in hex (0xC0000005) but are
cryptic and conflated when printed as decimal (-1073741819). This change
teaches two of our wrapper scripts to print large negative numbers as
hex so that those skilled in the Windows arts can automatically say
"access violation" or "not access violation."

I also removed an inelegant trailing period, for consistency.

In testing with artificially inserted error codes the output is:
  Protoc has returned non-zero status: -99
  Protoc has returned non-zero status: 0xC0000005
  genperf.exe failed with exit code -99
  re2c.exe failed with exit code 0xC0000005

Bug: 803617,644525
Change-Id: I627754976ff04e334010d36e5734d73421523e47
Reviewed-on: https://chromium-review.googlesource.com/917101
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536899}

This CL changes all use of UIViewController<ViewControllerSwapping> to
simply be id<ViewControllerSwapping>.

A -viewController property is added to ViewControllerSwapping so that
calling code can access the view controller doing the swapping (there is one
call site for this at the moment).

Since MainController's MainViewController property is no longer necessarily
a view controller, it's also renamed to 'viewControllerSwapper'. (As a side
effect, this further reduces the coupling of MainController to the UI layer).

This will allow the tab grid to move the view controller swapping logic into
its coordinator, where it logically belongs, instead of coupling this to its
view controller.

Bug: 804533
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9821aa84aa17d61f1eef34376039714510fd3e1d
Reviewed-on: https://chromium-review.googlesource.com/920081Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536898}

khushalsagar@ wrote/updated a lot of the underlying CC/Viz Android
integration in Chrome and has a lot of experience in this area. As part
of identifying good OWNERS for Chrome, I feel that khushalsagar@ would
be a good steward of this area of the code.

Change-Id: I37ae00cee81b37eea8cc06b10b704693dd8e88f3
Reviewed-on: https://chromium-review.googlesource.com/917323Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536897}

Change:
Use the maximum of folder name's width and grid view's width as the
width of the folder.

Bug: 811699
Change-Id: Iaa456ea4a2d19585918e4184d625793862463ea2
Reviewed-on: https://chromium-review.googlesource.com/919431Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536896}

This reverts commit 4c50e3e1.

Reason for revert: Build failure on Android builder:
https://ci.chromium.org/buildbot/chromium/Android/81706

Original change's description:
> Adjust location and size of TapDisambiguator
> 
> As shown in crbug.com/737777#c72, the location and size of Android tab
> disambiguator is not correct when --use-zoom-for-dsf is enabled. It is because
> RenderViewImpl::DidTapMultipleTargets() assumes |touch_rect| is in DIPs while it
> is in physical pixels when --use-zoom-for-dsf is enabled. This CL solves this
> problem.
> 
> TEST=Android Chrome with production code on NEXUS 5X,
> content_browsertests RenderViewTapDisambiguationTest.CanvasSizeUseZoomForDSF
> on NEXUS 5X, NEXUS 4, NEXUS 9 (w/ and w/o this change).
> 
> Bug: 737777
> Change-Id: I64ca0b9b76fcfc3798036a80c9213973de8f3f77
> Reviewed-on: https://chromium-review.googlesource.com/898824
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536868}

TBR=dgozman@chromium.org,jaebaek@chromium.org

Change-Id: I18a8a045b179eac287aad7b4fae8f71cadbff84d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 737777
Reviewed-on: https://chromium-review.googlesource.com/919045Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536895}

base/i18n/rtl.h was never actually used in ManualTextFramer.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4477a659bc619e45e8c36aa6f7acaf0e8d7ce0f2
Reviewed-on: https://chromium-review.googlesource.com/919428Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536894}

The existing condition doesn't enable device linux builds as they can
never have use_dbus=true. Now that fixes for the build have landed this
can be changed

Bug: None
Test: local builds
Change-Id: I315512a3a0dfe538545eec64135d48c272499711
Reviewed-on: https://chromium-review.googlesource.com/907372
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536893}

Bug: 417782
Change-Id: I6308eb4e93e31e83a1ffa9249b3acf6d7bb1534a
Reviewed-on: https://chromium-review.googlesource.com/919644Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536892}

Discardable[Shared]Memory is only implemented on Android. Add a warning to
indicate this.

Change-Id: I87060eaa8a83148e3a52a246b7a7b82b04d04f43
Reviewed-on: https://chromium-review.googlesource.com/909689Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536891}

Merely accessing 'window.speechSynthesis' creates SpeechSynthesis object,
which fetches list of TTS voices. On Android process of fetching voices
involves creating and binding TTS service. TTS service is quite big and
causes memory pressure on low-end Android devices, which can result in
bad UI experience and even cause Chrome to be OOM-killed.

Since voices are fetched asynchronously, SpeechSynthesis.getVoices() can
sometimes return an empty list. Client code is supposed to be prepared for
that and needs to listen to 'voiceschanged' event to know when voices are
available.

This CL changes behavior on low-end Android devices, and defers fetching
TTS voices until any SpeechSynthesis method (including getVoices()) is
called. The change should be transparent to client code, which should be
listening to 'voiceschanged' event anyway.

Bug: 811929
Change-Id: Ib26d78aaf9e847fa0bda86c9bc800a7054b2487b
Reviewed-on: https://chromium-review.googlesource.com/917230Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536890}

Bug: 801583, 725599
Change-Id: I502172cfaa8292a80f1ce239491a089b77281a83
Reviewed-on: https://chromium-review.googlesource.com/915641
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536889}

At commit time, checks the NoScript optimization guide whitelist on the
committed URL (since it may have changed from original URL domain due to
redirects). Actually, the PreviewsDecider::ShouldAllowPreviewAtECT() api is
used which also includes other checks as well (so alternatively we could
add another api that is more specific/restricted instead).

Bug: 787191
Change-Id: I6fac145eb661a1dcfd285030799ac29799cfacfe
Reviewed-on: https://chromium-review.googlesource.com/909868
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536888}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idc78df3dd2ea82632d31f299fca2735edf92f846
Reviewed-on: https://chromium-review.googlesource.com/919173
Commit-Queue: Victor Costan <pwnall@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536887}

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug: 695189
Change-Id: Icebfcf14b4f57041b93268116748405b7628e685
Reviewed-on: https://chromium-review.googlesource.com/912203Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536886}

Bug: None
Change-Id: I8fa12c0525613a80de12cba0687ad31f5b5d872c
Reviewed-on: https://chromium-review.googlesource.com/920104Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536885}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/58a80d15568f..9ed334093692

$ git log 58a80d155..9ed334093 --date=short --no-merges --format='%ad %ae %s'
2018-02-13 sandersd Prevent NULL dereference in mov_seek_fragment()
2018-02-13 xhwang ffmpeg: Fix integer overflow in decode_cabac_residual_internal()
2018-02-13 xhwang ffmpeg: Fix stts_data memory allocation
2018-02-13 sandersd Prevent NULL dereference in mov_read_sidx()

Created with:
  roll-dep src/third_party/ffmpeg

BUG=804070,806580,801821,802335

Change-Id: Iae66a2c0ac4443b8ef04fffa630a925308dfdd04
Reviewed-on: https://chromium-review.googlesource.com/919863Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536884}

https://skia.googlesource.com/skia.git/+log/cb25659eb152..d23db1257af7

$ git log cb25659eb..d23db1257 --date=short --no-merges --format='%ad %ae %s'
2018-02-14 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 44b334f05..0e69310d6 (3 commits)
2018-02-14 halcanary BUILD(win): find 'Build Tools for VS 2017', doc update
2018-02-14 egdaniel Revert "Revert "Revert "When creating emptyp MipMap proxies, don't instantiate them immediately."""

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I96368f01012382ffd198f61646ebdaf38bc67ff4
Reviewed-on: https://chromium-review.googlesource.com/919868
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#536883}

InlineTextBox contains indices into layoutText. These indices are
documented as being in characters, but in reality they are in UTF-16
(OR latin1) code-units. In other words unicode code-points that are
represented with surrogate pairs in utf-16 are considered to have
length 2.

Even more confusingly, layoutText may be converted to UTF-8 depending on
where it is read from. In UTF-8 there is no such thing as surrogate
pairs.

This makes it very easy to use InlineTextBox wrong and end up with too
many characters when re-constructing text runs.

Change-Id: I243e4e5b729ebc678c87438f7bc5dde2e060fd25
Reviewed-on: https://chromium-review.googlesource.com/917643
Commit-Queue: Zoe Clifford <zoeclifford@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536882}