GitLab

Remove --[en|dis]able-new-dialog-style command-line flags.
Remove the corresponding strings and about:flags entry.
The new dialog style has been on-by-default since M-29.

Retain DialogDelegate::UseNewStyle() for Views/Win Textfield.
(new dialogs can't host the off-by-default Win Textfields)
(this will go away once I remove the Views Textfield flags)

Retain split DialogDelegate::UseNewStyleForThisDialog() codepaths.
(we explicitly want the old style for some dialogs see Issue 246777)
(task manager, about:ipc dialog, extension (cros save/open) dialog)
(this could go away if we made those windows not use dialog code)

BUG=166075,282698
TEST=New dialog style is used on Windows/CrOS everywhere except for the Task Manager, about:ipc dialog (Win only), and Extension (CrOS save/open) dialogs. The old dialog style is used with --disable-views-textfields for technical reasons.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23530019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221292 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23532042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221291 0039d316-1c4b-4281-b951-d872f2087c98

Somehow this slipped through the cracks.

BUG=none
TBR=jar@chromium.org, sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23950005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221290 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221289 0039d316-1c4b-4281-b951-d872f2087c98

1712: ninja: Stop lower-casing outputs on case-insensitive file systems.
1713: Convert setup.py to use setuptools
1714: ninja/mac: Support rules running on mac_bundle_resources.

BUG=280718
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/23630005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221288 0039d316-1c4b-4281-b951-d872f2087c98

This configuration has been broken for long time, and fixing it is a non-trivial
work without much benefit. For now, let's simplify the GYPI file so we don't have
to touch the broken part.

BUG=273386
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23942002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221286 0039d316-1c4b-4281-b951-d872f2087c98

This reduces the latency of CreateTextures (8 textures) from around
1000ms to 1ms for HW decode WebRTC on Chromebook Daisy.

GLES2Implementation doesn't currently have the right hook to make
mailbox generation fast, though WebGraphicsContext3DCommandBufferImpl
does. The fast path for mailbox generation only exists in content,
that GLES2Implementation, in gpu, can't directly access. So
GLES2Implementation has to go through command buffers, which is bad
for round-trips.

BUG=170345
TEST=Run http://apprtc.appspot.com/?debug=loopback on Chromebook Daisy.
     Play local hardware-accelerated videos on Daisy.

Review URL: https://chromiumcodereview.appspot.com/23567012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221285 0039d316-1c4b-4281-b951-d872f2087c98

This change moves the FileRef implementation from the previous one in the "old"
resource model (ppb_file_ref_impl.cc) to the "new" resource model
(pepper_file_ref_host.cc), and from the renderer to the browser.

As many as possible of the supporting changes were split off to other changes
to minimize the size of this change. Unfortunately, a lot of changes for
URLLoader had to be rolled into this change.

The data structures for CreateInfo have changed, and all users of FileRef have
to be moved over, which is what causes this change to be so large.

TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
BUG=225441

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216744

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218305

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219911

Review URL: https://codereview.chromium.org/21966004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/23514038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221283 0039d316-1c4b-4281-b951-d872f2087c98

NOTE: this is just porting to ReST, I haven't updated anything to PNaCl yet.

BUG=none
R=eliben@chromium.org

Review URL: https://codereview.chromium.org/23902007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221282 0039d316-1c4b-4281-b951-d872f2087c98

> Handle cache-control:no-store header in PNaCl translation cache
> 
> Pexe files with the cache-control:no-store header should not be cached.
> Add a field to the PnaclCacheInfo struct, plumb the value all the way
> from the plugin to the browser, and treat it basically the same way we
> currently treat incognito translations (since we currently don't have an
> off-the-record cache for those).
> R=jvoung@chromium.org
> BUG=none, noticed this was missing when doing cleanup
> 
> Review URL: https://chromiumcodereview.appspot.com/23458015

TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/23684032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221281 0039d316-1c4b-4281-b951-d872f2087c98

The above file was excluded in
https://chromiumcodereview.appspot.com/23030005/, but is necessary for
successful compilation when order_profiling flag is enabled.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23882006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221280 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that popup windows created by the content layer in desktop AURA don't grab activation when the user clicks on them.

This basically translates to setting the can_activate property in the widget init params to false.

Fixes bug https://code.google.com/p/chromium/issues/detail?id=282628

BUG=282628
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23691040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221279 0039d316-1c4b-4281-b951-d872f2087c98

After crrev.com/208163, dmprof can segregate areas that are shared with
chrome processes and others.
Use this feature in the android policies.

BUG=

Review URL: https://chromiumcodereview.appspot.com/18710003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221278 0039d316-1c4b-4281-b951-d872f2087c98

Somewhat reproducible via load google, clear cookies, load about:blank repeatedly.

Before, when we attempted to get the URL of the page after a successful
Page.navigate, we could end up setting the state = kLoading even though we
received the frame stopped loading event during the evaluate command.

Now, set the state to uknown first, and only force the state = kLoading if
not set already.
BUG=none

Review URL: https://chromiumcodereview.appspot.com/23944005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221277 0039d316-1c4b-4281-b951-d872f2087c98

This is in contrast to drawing overhang region with the LTH's background
color.

Specify the texture to use through WebLayerTreeView.

Use the UI resource framework to manage the upload of the linen texture.

BUG=133097

Review URL: https://chromiumcodereview.appspot.com/23805002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221276 0039d316-1c4b-4281-b951-d872f2087c98

Pexe files with the cache-control:no-store header should not be cached.
Add a field to the PnaclCacheInfo struct, plumb the value all the way
from the plugin to the browser, and treat it basically the same way we
currently treat incognito translations (since we currently don't have an
off-the-record cache for those).
R=jvoung@chromium.org
BUG=none, noticed this was missing when doing cleanup

Review URL: https://chromiumcodereview.appspot.com/23458015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221275 0039d316-1c4b-4281-b951-d872f2087c98

SIGSYS is a reserved signal for sandboxing on Linux. When we receive
a spurious SIGSYS, we typically crash.
This patch changes this behavior to only log an error.

BUG=178166
R=markus@chromium.org

Review URL: https://codereview.chromium.org/23686010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221274 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221273 0039d316-1c4b-4281-b951-d872f2087c98

e3b631da8034f7c6ecc6d809cd9e46d306215c32 does not exists.

> Roll freetype (Android-only) to e3b631da8034f7c6ecc6d809cd9e46d306215c32.
> 
> Includes the following commit:
> 
>   commit e3b631da8034f7c6ecc6d809cd9e46d306215c32
>   (https://codereview.chromium.org/23555005/)
> 
>   Update freetype to the latest version of Android external/freetype
> 
>   This upgrades freetype to 2.4.9.
>   Copied from public andorid source (https://android.googlesource.com/platform/external/freetype/).
> 
> BUG=274031
> NOTRY=true
> 
> Review URL: https://chromiumcodereview.appspot.com/23483034

TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/23627007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276002

Review URL: https://chromiumcodereview.appspot.com/23537014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221271 0039d316-1c4b-4281-b951-d872f2087c98

The NOTREACHED it hit a year ago was removed from the code in r205020. But the
test in the meantime has broken because TaskManagerModel now caches values.
Explicitly call TaskManagerModel::Refresh before querying values.

This makes TaskManagerModel::Refresh public.

BUG=131836
TEST=PrerenderBrowserTest.PrerenderTaskManager

Review URL: https://chromiumcodereview.appspot.com/23523024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221270 0039d316-1c4b-4281-b951-d872f2087c98

Move the WebPluginResourceClient interface to its own header. Also fix up method order in webplugin_proxy.h and change WebKit::WebCanvas usage to SkCanvas.

R=tburkard@chromium.org

Review URL: https://codereview.chromium.org/23684023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221269 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221268 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157170:157224&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23960002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221267 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221264 0039d316-1c4b-4281-b951-d872f2087c98

Includes the following commit:

  commit e3b631da8034f7c6ecc6d809cd9e46d306215c32
  (https://codereview.chromium.org/23555005/)

  Update freetype to the latest version of Android external/freetype

  This upgrades freetype to 2.4.9.
  Copied from public andorid source (https://android.googlesource.com/platform/external/freetype/).

BUG=274031
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23483034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178559

Review URL: https://chromiumcodereview.appspot.com/23717020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221262 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/22982011 will fix chromium's form resubmission defenses. Currently, we silently re-post on back/forward navigation, which is bad. This test sets Cache-Control: no-store, which prevents the page from being in our caches. On form resubmission, we should force cache usage and only go to the network with explicit permission from the user.

BUG=263508

Review URL: https://chromiumcodereview.appspot.com/23464023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221261 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves some functions to handle Shill properties to shill_property_util.*

This cleans up some dependencies (e.g. network_connection_handler.cc doesn't include managed_network_configuration_handler.h anymore) and allows to share some more code.

GetUIData was adapted slightly to make use of GetUIDataFromValue.

CopyIdentifyingProperties deviates from the original implementation in network_connection_handler (e.g. it didn't copy the SSID). This function will be used in ManagedNetConfHandler for the new "AllowAutoconnect" policy.

BUG=280146

Review URL: https://chromiumcodereview.appspot.com/23551004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221260 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 285279

Review URL: https://chromiumcodereview.appspot.com/23637005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221259 0039d316-1c4b-4281-b951-d872f2087c98

LayerAnimationController::TickAnimations ignores the time_offset for
animations that are Starting and for animations waiting for a synchronized
start time. This CL makes Animation::TrimTimeToCurrentIteration handle
computing the trimmed time for such animations, removing the need for
TickAnimations to have special cases for computing trimmed time.

BUG=284590

Review URL: https://chromiumcodereview.appspot.com/23926003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282679

Review URL: https://chromiumcodereview.appspot.com/23893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221256 0039d316-1c4b-4281-b951-d872f2087c98

Along with https://codereview.chromium.org/23455031/, this 
adds and makes use of Renderer.CompositedScrolling UMA histogram.

This records the total number of RenderLayers that are scrollable
areas, need to become stacking containers, and will use composited
scrolling.

Each of the buckets are intended to be recorded at most once per 
RenderLayer. The ratio between these stats should give 
us an idea of how effective stacking containers are at 
allowing scrollable divs to become composited.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23874003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/23627005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221254 0039d316-1c4b-4281-b951-d872f2087c98

This is so experience reviewers can make sure changes to policy
semantics don't cause compatibility problems.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23725004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23717031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221252 0039d316-1c4b-4281-b951-d872f2087c98

The WebRTC audio quality test has been relying on a particular
configuration for the input device name, but it has turned out to be
painful to maintain. Specifically, it used to require that the default
input source was named "render.monitor" to figure out which device
to force the volume to 100% on, but now it will just force the volume
on all input devices it can find on the system.

The volume is forced to 100% since PESQ will be confused if the
recording is too low in volume (or even refuse to run if the recording
is done at 0% volume, which obviously will make for a bad comparison).

BUG=

Review URL: https://chromiumcodereview.appspot.com/23562002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221251 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221249 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/23531029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221248 0039d316-1c4b-4281-b951-d872f2087c98