Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Jan, 2015 30 commits
  3. 27 Jan, 2015 10 commits
    • isherman's avatar
      [Smart Lock] Add a private API to show an error bubble anchored to the Smart Lock app window. · f69037c6
      isherman authored 
      BUG=406439
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/843023002

Cr-Commit-Position: refs/heads/master@{#313408}
      f69037c6
    • william.xie's avatar
      Minor Refactor: · d5c76bdc
      william.xie authored 
      Define kInvalidMediaPlayerID to replace "-1"
for BrowserMediaPlayerManager

BUG=

Review URL: https://codereview.chromium.org/883653002

Cr-Commit-Position: refs/heads/master@{#313407}
      d5c76bdc
    • naiem.shaik's avatar
      Remove NOTIFICATION_HISTORY_URLS_DELETED · 5017fc69
      naiem.shaik authored 
      Add the method OnURLsDeleted() to History{Backend,Service}Observer and
change History{Backend,Service} to call this method instead of sending
the notification.

Port client code to implement the History{Backend,Service}Observer
interface instead of using chrome::NOTIFICATION_HISTORY_URLS_DELETED.

Remove obsolete code for broadcasting notification from history code and
HistoryDetails type.

BUG=373326

Review URL: https://codereview.chromium.org/773103004

Cr-Commit-Position: refs/heads/master@{#313406}
      5017fc69
    • leviw's avatar
      Disable failing PushMessaging browser tests. · df3f06a5
      leviw authored 
      Failing on chromium.webkit/ChromiumOS

BUG=452666
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/881073003

Cr-Commit-Position: refs/heads/master@{#313405}
      df3f06a5
    • asargent's avatar
      Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/ · 275faaaa
      asargent authored 
      This is a mostly mechanical change to move these files over, and
make corresponding changes to strings, build files, and include paths.

BUG=447014

Review URL: https://codereview.chromium.org/864093002

Cr-Commit-Position: refs/heads/master@{#313404}
      275faaaa
    • kmarshall's avatar
      Add mojoPrivate.requireAsync method to chrome IDL. · 151e70d6
      kmarshall authored 
      Add unit tests for requireAsync.

R=mfoltz@chromium.org,sammc@chromium.org
CC=wez@chromium.org,haibinlu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/862793003

Cr-Commit-Position: refs/heads/master@{#313403}
      151e70d6
    • hanxi's avatar
      Introduce HostID and de-couple Extensions from "script injection System" [browser side] · b88fe3dc
      hanxi authored 
      The major refactor includes:
- Introduce HostID (a pair of |id, type|) to replace extension_id in browser
  side.
- Abstract UserScriptLoader to be a base class, and introduces
  a derived class ExtensionUserScriptLoader which is
  responsible for loading user scripts for extensions.
- In DeclarativeUserScriptManager, a master is created per
  extension/webUI.
- DeclarativeUserScriptManager becomes an
  ExtensionRegistryObserver and is responsible for clearing scripts
  for master objects when receive OnExensionUnloaded event.

BUG=437566

Review URL: https://codereview.chromium.org/822453002

Cr-Commit-Position: refs/heads/master@{#313402}
      b88fe3dc
    • erikchen's avatar
      Revert of Reland "mac: Layer back the root view of the browser window on OSX... · 86b7486d
      erikchen authored 
      Revert of Reland "mac: Layer back the root view of the browser window on OSX 10.9+." (patchset #1 id:1 of https://codereview.chromium.org/878673006/)

Reason for revert:
Chrome Mac lost its rounded bottom corners
https://code.google.com/p/chromium/issues/detail?id=452707

Original issue's description:
> Reland "mac: Layer back the root view of the browser window on OSX 10.9+."
>
> The original CL was reverted because it caused non-deterministic failures in
> browser tests that used the file tab-restore-visibility.html. The test file had
> an edge case that caused thrashing and prevented the page from loading. This
> has since been fixed.
>
> > BrowserWindowController always layer-backs the contentView of the window. If
> > Chrome were linked against OSX 10.9, this would also cause the root view to be
> > layer backed. Since Chrome is linked against OSX 10.6, the root view by default
> > is not layer backed.
> >
> > BrowserWindowController is going to have a custom AppKit fullscreen animation,
> > which requires that the root view is layer backed. While it is possible to
> > implement a custom AppKit fullscreen animation as early as OSX 10.7, the
> > effects of layer backing the root view on OSX 10.7 are murky. It seems much
> > safer to just layer back the root view on OSX 10.9+, and only enable the custom
> > AppKit fullscreen animation on OSX 10.9+.
> >
> > As far as I know, this change has no detrimental side effects. There is no
> > spike in memory usage
> > (https://code.google.com/p/chromium/issues/detail?id=396264#c11), presumably
> > because NSThemeFrame implements -wantsUpdateLayer on OSX 10.9+.
> >
> > BUG=413009, 414527
> > Committed: https://crrev.com/8dec34f8f3504352e4eef95b2aaa36c561aea930
> > Cr-Commit-Position: refs/heads/master@{#311191}
>
> BUG=413009, 414527
> TBR=rsesek@chromium.org
>
> Committed: https://crrev.com/4713180802457f8c6854c10db4689ab4fab98155
> Cr-Commit-Position: refs/heads/master@{#313207}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=413009, 414527

Review URL: https://codereview.chromium.org/881133002

Cr-Commit-Position: refs/heads/master@{#313401}
      86b7486d
    • danakj's avatar
      cc: Attempt to deflake the LayerTreeHostPictureTestTwinLayer test. · c949ffe0
      danakj authored 
      This test has been flaky (see bug), but I am not able to recreate the
flake locally. However, this test does PostSetNeedsCommit() from the
impl thread while also causing commits from the main thread in DidCommit
which could cause an extra commit to happen in theory.

This changes the test to stop using PostSetNeedsCommit() and always
cause commits from DidCommit on the main thread, to help make the test
more deterministic.

R=ajuma, enne@chromium.org, vmpstr
BUG=451988

Review URL: https://codereview.chromium.org/877213002

Cr-Commit-Position: refs/heads/master@{#313400}
      c949ffe0
    • scottmg's avatar
      Fix missing .Pass() on returning scoped_ptr<SdchManager::DictionarySet> · d9afd548
      scottmg authored 
      Warns on VS2015. I'm not sure why this is new, I guess something
become move-able (or not-move-able).

d:\src\cr3\src\net\base\sdch_manager.cc(459): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private
member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>'
        with
        [
            T=net::SdchManager::DictionarySet
        ]
d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr'
        with
        [
            T=net::SdchManager::DictionarySet
        ]
d:\src\cr3\src\net\base\sdch_manager.cc(463): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private
member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>'
        with
        [
            T=net::SdchManager::DictionarySet
        ]
d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr'
        with
        [
            T=net::SdchManager::DictionarySet
        ]
d:\src\cr3\src\net\base\sdch_manager.cc(467): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private
member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>'
        with
        [
            T=net::SdchManager::DictionarySet
        ]
d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr'
        with
        [
            T=net::SdchManager::DictionarySet
        ]

R=rsleevi@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/883753004

Cr-Commit-Position: refs/heads/master@{#313399}
      d9afd548