- 10 Jul, 2019 40 commits
-
-
Anthony Vallee-Dubois authored
Running with the geo language model enabled caused a DCHECK on startup because of a pref update happening on the wrong sequence. This moves the offending call to the correct sequence. Bug: 982428 Change-Id: Ib4e1bd641cceb9c035473e37a7ed0636096fc7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693563Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676001}
-
Stephen McGruer authored
This CL adds support for asynchronously painting PaintWorklets for the pending tree in LayerTreeHostImpl. Dirty PaintWorklets are gathered during UpdateSyncTreeAfterCommitOrImplSideInvalidation and dispatched to the worklet thread. When the results are available, the pending tree is marked as painted and life goes on. Note that this CL does not yet use the results for PaintWorklet content; the existing raster-thread path is still in use. That will be switched over in the next patch. Bug: 907897 Change-Id: I9f2921931631144ad8f2ef95e42a9ce1fb888a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649720Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#676000}
-
Rohit Rao authored
The previous implementation was inadvertently calling +setUpForTestCase once per test module, rather than once per XCTestCase. BUG=922813,977161 Change-Id: I49d0f5bc442c4bd793b85f932149699d24f5e665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692527Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675999}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c/1692661 that replaced std::unordered_map with WTF::HashMap in layout_shift_region.cc. This CL uses int64_t which is larger than real |int| since the empty value of the key is |max| and deleted value of the key is |max - 1| in HashMap and updates the comment. Bug: 952716 Change-Id: I3c756982f86f148f9d730d8c375a4e6625a4b738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692727Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#675998}
-
Dave Tapuska authored
A few presumbits were failing to be detected that didn't have the prefix. BUG=945971 Change-Id: Ib741b4f10bfcdd6efc12a223444081dec5c4f7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693398Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#675997}
-
Jérôme Lebel authored
Clearing the browsing data before each tests in SigninInteractionControllerTestCase. Browsing data is an issue in the recent tabs UI. The sign-in promo view can be off screen or behind a half transparent view. Bug: 976828, 976832 Change-Id: I4df033d5c60fb1226750ab51cbd0ea3fff981204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667662 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#675996}
-
Yi Gu authored
This patch adds more info into the crash report, i.e. the report now includes url, event type, global and local coordinates. Bug: 976284 Change-Id: I70568ade1c94e018d5a42ef023b0eb65d9c40c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689960Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#675995}
-
Nicolas Ouellet-payeur authored
linux-annotator-rel and win-annotator-rel will now test traffic annotations with extractor.py, as well as the clang tool. Also updates a traffic annotation in management_ui_handler.cc, since extractor.py doesn't understand #ifdefs. As a workaround, this CrOS-specific annotation is moved to a CrOS-only file. TESTED= Ran traffic_annotation_auditor_tests.py locally, excluding the --no-filtering configs. Bug: 966883 Change-Id: I7848877f67635b50d8ce2a841019e49136a33b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692970Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#675994}
-
Florin Malita authored
virtual/gpu-rasterization/images/color-profile-image.html TBR=michaelludwig@google.com Notry: true Bug: 982289 Change-Id: Ifd5e04c4eab718ad6da9345b2fbe30d4d13c0ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695742Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#675993}
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I0eed6b0436f32a3f1f4fc698b3ca712c11e217d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695348 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#675992}
-
Guido Urdaneta authored
The VID:PID for the camera is 04f2:b3ca Bug: 978852 Change-Id: I1117f00ef2e301c5b8a14e1ad138b61e6245cb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690583Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#675991}
-
Rohit Rao authored
zh-CN displays as "Chinese, Simplified" on iOS 13, but displays as "Chinese (Simplified)" on all other platforms. Updates the unittest to be more permissive and match any string that contains "Chinese" and "Simplified". Makes a similar change for zh-TW ("Chinese, Traditional"). BUG=967769 Change-Id: I5d516819f61fb1775c2d6747c8985eee954b445a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693953Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675990}
-
Yi Su authored
When WKWebView of CRWWebController is destroyed, KVO and WK*Delegate of WKWebView should be cleaned up before [WKWebView stopLoading] and [WKWebView removeFromSuperView] is called to avoid unnecessary callbacks. This will help greatly reduce the metric Renderer.WKWebViewCallbackAfterDestroy. Bug: 956511 Change-Id: I5f5e1acf502f890dc8d30587a78feeeb9c5040f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688956 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL populates the password primary key in the change list returned by PasswordStoreDefault::DisableAutoSignInForOriginsImpl(). This was overlooked when first adding the support for primary keys. Bug: 902349 Change-Id: I5dfe962861e0b7669722e02d13d07c9584556237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693005Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#675988}
-
Guido Urdaneta authored
Change-Id: I99e43f37610033d59a9d40e34352a09c39e9bed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692563Reviewed-by:
-
Yi Su authored
Many classes in //ios/web use delegate method to get "IsBeingDestroyed" state from CRWWebController. It can be either simplified by |close| method or just removed because unnecessary. Bug: 956511 Change-Id: I0850bb55c2de57087593a3685700c134761c75a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688950 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL replaces the use of std::array of std containers with WTF::Vector and introduces LCSArray struct in html_slot_element.h. Bug: 952716 Change-Id: I45d0dcbb63aed5198440bd7b94c5c693a05bd6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694801Reviewed-by:
-
Robbie Gibson authored
Bug: 974255 Change-Id: I06cb71fc016ef975b82992a2e01adc05940857fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692752Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#675984}
-
Wei-Yin Chen (陳威尹) authored
Fetching thumbnails when the Grid Tab Switcher (GTS) is hidden waste computation and memory. When GTS is hidden but warm, fetching thumbnail leads to user visible glitches. Bug: 982505 Change-Id: I1789cea1e72c3efb3e0678c9e349722eb3b90d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688027 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#675983}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ifcb65cb0eb42f107f38038f6a59c077d9cdba7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675982}
-
Alex Clarke authored
Previously the tasks posted by RespondAndDisconnectMockWriter could outlive it resulting in UAFs. Note we can't use weak pointers here because its used on multiple threads. Change-Id: I68d2f893f1ac4e2e9e00a151c0aaaaa709bd4798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691918 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#675981}
-
sczs authored
Bug: 981881 Change-Id: I73e1dce476e5188e2a6503ff47deec72ca601e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693001 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#675980}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I713e5f48fe77c86d47b6efacf429f8ab4d760f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695141 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#675979}
-
Javier Ernesto Flores Robles authored
Change-Id: Ia68e80fc463308d7389f2ba759f6bf862cd3c279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692937 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#675978}
-
Friedrich Horschig authored
With this CL, we allow every UserInfo section to have an own title. This is useful for PSL labels of password credentials. Bug: 976761 Change-Id: Ia87ec1e8778217ecc3e44d9a1a3497535e78b4a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692409Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#675977}
-
Javier Ernesto Flores Robles authored
The setUp of these tests already adds an entry. Bug: 981922 Change-Id: I44856e336291c82be23bb2f35705aebe5a45acf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692418 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#675976}
-
Dominik Röttsches authored
Migrate watchlists information from [1] and a note about how it's not possible to add a watchlist for autoroller commits. [1] https://www.chromium.org/developers/contributing-code/watchlists Change-Id: I30649e5c50e846d708e63e03dd7e7b1ccd04794f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692983 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#675975}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, thumbnail fetching happens during tab restoration. This should be avoided since it's a waste of computation and memory, leading to slower start up and memory leak. Bug: 982491 Change-Id: I7bb0aa57fb01b688ab070e1f058281d18cf20aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694149 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
Ali Juma authored
The WebDriver protocol specifies that error responses must include a "stacktrace" field that contains an implementation-defined string. The Web Platform Test runner expects this field to be present in error responses (but doesn't depend on its contents, just on its presence). This CL adds a "stacktrace" field to error responses, and uses base::debug::StackTrace() as its contents, matching ChromeDriver on non-iOS platforms. Bug: 673423 Change-Id: I8c5249753b896162f9128022b91a2f8fc5e14e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687359 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675973}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0fef8f7a8181a7b7dbe627df0782bf9868b323da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695241Reviewed-by:
-
Staphany Park authored
This CL is largely a revert of https://crrev.com/c/1583343. Tbr: kinuko Bug: 971492 Change-Id: Ia78b9ada4a1e1151301e2cab14560ae249e9b687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693948 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#675971}
-
Oleg Davydov authored
Every usage of ContentVerifyJob is like create it via ContentVerifier::CreateJobFor and immediately calling job->Start. That means that we can always start job in CreateJobFor. Change-Id: I517f185f08d5dff7dc3f2f193d97b96aec131ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687521 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#675970}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/3f194acb57e0..156cd8939c5f $ git log 3f194acb5..156cd8939 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 cmumford Removed reference to deprecated autotools. 2019-05-25 costan Use GCC 9 on Travis CI 2019-05-16 cmumford The snappy landing page at http://google.github.io/snappy/ is served by [GitHub Pages](https://pages.github.com/) and lives in the gh-pages branch. This changes moves the page contents to a more easily accessed Markdown file. 2019-05-14 cmumford Minor typo fix in README. 2019-05-13 cmumford Sync TODO and comment processing with external repo. 2019-05-09 cmumford Changed CMake version from 3.4 to that in CMakeLists.txt in README. 2019-04-29 costan Update Travis CI configuration. 2019-04-22 cmumford Fixed formatted (bash/c++) sections of README.md. 2019-04-04 atdt Remove MSan exemption for _bzhi_u32, since LLVM now handles it correctly. 2019-04-25 5627721+abyss7 Fix compilation 2019-02-15 costan Remove MSBuild section from AppVeyor configuration. 2019-01-22 nafi Optimize snappy compression by about 2.2%. 2018-12-14 maikuolan Update README to use HTTPS instead of HTTP. Created with: roll-dep src/third_party/snappy/src Change-Id: I3cc138dfb47116892c8baf9718d47e1b7f4798e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694245Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#675969}
-
David Staessens authored
This CL adds logic to the video player test environment to dynamically detect whether import mode is supported. This fixes one of several issues making the new video decoder tests fail on devices that only support allocate mode. TEST=./video_decode_accelerator_tests on nyan_big BUG=957808 Change-Id: Ibf1e28ae3baab63f53b6483d5d60cc7928065424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688769 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#675968}
-
Victor Hugo Vianna Silva authored
Change-Id: Ic1289db5bdcfbc65b615206809ad2e72625aa326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692935Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#675967}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I4afba134597cf9ec4080ae18310570c4fd7173c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695122Reviewed-by:
-
Hitoshi Yoshida authored
Responsibility of the pickle files that are expected to consist of Collection objects should be in Collection. This CL makes it clearer. Bug: 839389 Change-Id: I1ee645af60b3befd3a0923790a0170c91a331243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694405Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#675965}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I964de858a26c64a1e3a89217e704acbf5fb908a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692112Reviewed-by:
-
Anders Hartvoll Ruud authored
Change-Id: I789406de0c9ec7f1f03df9b845ee777f5ae406c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692163 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#675963}
-
Joel Hockey authored
Change-Id: I9da153a15bec4771fd8f7d3f6f71f60007d2a8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695081 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#675962}
-
