- 22 Jun, 2020 40 commits
-
-
Stephen Nusko authored
nexus 5x webview This test flakes 10% of the time due to a timeout. See bug for details. Bug: 1097719 Change-Id: Idfccd2c1839e302781b35d7bcf0c23dcb1ceb532 No-Try: True TBR: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255474Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#780725}
-
Marc Treib authored
Typically, PasswordAutofillAgent (unsurprisingly) shows its popup only if it has password suggestions. However, if the feature EnablePasswordsAccountStorage is enabled, then sometimes the popup needs to be shown even without password suggestions, because it might contain other entries. However, PasswordAutofillAgent didn't know if such other entries actually exist, and so would show the popup "speculatively". If it later turned out that there actually aren't any entries to show, the popup would get suppressed later (in PasswordAutofillManager). That's all well and good, but it produces a bad interaction with (non-Password) AutofillAgent: If PAA says it wants to show a popup, then AA suppresses its own popup. Together, this led to some cases where neither of the two popups showed up. This CL fixes the issue by explicitly informing PAA whether it should show its popup even without suggestions. This bit is passed as a new parameter in the existing InformNoSavedCredentials() IPC. (If there *are* saved credentials, then PAA will always show its popup, so no need to change anything about the FillPasswordForm() IPC.) Bug: 1096521 Change-Id: Id4cafc3e0190dd1d20ad266bc1d7e39f32f83b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252241Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780724}
-
Tim van der Lippe authored
In DevTools, we want to write Node scripts as part of our Ninja action scripts. That's because we are more familiar with Node than with Python. However, since Ninja only allows Python scripts to be a script of an `action`, we were previously forced to write Python. This change allows the `third_party/node/node.py` script to be used as if it was a regular `node <script args>` invocation. As a result, we can use this script as part of a Ninja action as follows: ``` action(target_name) { script = "//third_party/node/node.py" args = [ "path/to/my/node/script.js", "--any-arg", anyValueForArg, ] } ``` We were previously already using this in DevTools itself, but that requires a Node checkout in `third_party/devtools-frontend/src/third_party/node`. To make sure that a build in Chromium is possible as well, we need to reference the absolute path to `//third_party/node/node.py` and thus requires the same file to exist in Chromium itself. Additionally, the script would now fail with the exitcode as defined by the invoked Node script. Lastly, this CL reformats the script according to the Python formatting standard. Bug: 1096473 R=jacktfranklin@chromium.org,dpapad@chromium.org CC=devtools-reviews+blink@chromium.org Change-Id: Ie11150475d4d32c9dc9e8ec18228d490239ff7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248568Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#780723}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I053fb6f7fc1cb03ba43abceba93274f12f2c395f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254124 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#780722}
-
Olivier Robin authored
We report URLs for the latest 3 WebStateLists that had activity. Preload WebState count as a separate WebStateList. Bug: 1060658 Change-Id: I035a192de232ce9e9ce6ae864dbf57c8bdc051f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238933 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780721}
-
Anastasiia Nikolaienko authored
HandleNavigationButtonClicked was used only on Chrome OS and was triggered when user clicked "back" button. Remove this method from handler and navigate back when "back" button is clicked, instead of calling the handler. Bug: 1096007 Change-Id: If4992670fd03b23439be95650fd3a2a1551e5853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247889Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#780720}
-
Anatoliy Potapchuk authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12878 Change-Id: I024fe697bce0a6e4cfad7953b76958fdfd6dc3ce No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256180Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#780719}
-
Victor Hugo Vianna Silva authored
This is a reland of a89d80c4 Reason for reland: One of the upstream CLs had missing .js extensions in some imports, this caused failures later and then all CLs in the chain were reverted. TBR=aee@chromium.org Original changes's description: > This CL addresses a few design issues with PasswordListItem that predate > the introduction of PasswordsListHandler. > > - PasswordListItem would refer to a "menu" even though it knows nothing > about such menu, which is actually provided by the embedder. This CL > replaces mentions to passwordMenu in the component with what it actually > represents: the "more actions" button. > - The event fired by clicking the button was not documented in the file > overview. Moreover, the typedef for the event lived in the embedder. Now > the file exports the typedef. > - Tests that simulated clicks on the button would use the $$('#id') > syntax instead of the $.id one. This is now fixed. > > Bug: None > Change-Id: Ie815237134236468c639e73831bdb3eb7db36f98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248561 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779777} Bug: None Change-Id: I1a1db35efab745c7b5cb2893d153f6c643e3bbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254321Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b772a955e70c..0cc3a37881a2 2020-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 545d158a2ff9 to d4b9f576ebb4 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ib29c51559917802a5db1bfc481fbc082b49d7750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780717}
-
Mahmoud Gawad authored
Made untrusted.html create a Dedicated Web Worker. BUG=b:158119679 TEST=added browsertest to test WebWorker is working (PASS) Change-Id: I52a84135215b1cae028d3865af762d3ddb2cf44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232401Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#780716}
-
arthursonzogni authored
Patch [1] switched from RFH::is_active() toward RFH::IsCurrent(). We re-learnt this is possible for a RenderFrameHost to be pending deletion while being the "current" RenderFrameHost. This can happen when its frame is detached. [Bug] is caused by receiving DidFocusFrame() on a RenderFrameHost pending deletion (is_active() == false), but current (IsCurrent() == true). This caused a crash later. Patch [2] showed 100% of the crashes in [Bug] were explained by [1]. This patch revert all the is_active() -> IsCurrent() changes from [1]. It also revert the instrumentation [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2186641 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2252803 [Bug]: https://crbug.com/1093943 Bug: chromimum:1093943 Change-Id: If5cd5774a0f6fd7d0c77de96286f88649627a0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255603Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780715}
-
Joel Hockey authored
Bug: 1097596 Change-Id: I5bc30e9964f811041cc98bdbcba1d39bc2a2af85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256939 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780714}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592798309-f2bcf0f33aab857d8bcffdd4e0dd372aeeedf408.profdata to chrome-win32-master-1592808845-5ecd6c23d23a299e7b02af052540dc3d30072113.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9801ad9b38fcaa16c8e1cbec5430700f4d701258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257043Reviewed-by:
-
lijunsong authored
This changeset restores tests for UsernameDetector. The tests were removed in 1814832 along with the old parser. Bug: 1090694 Test: run the added tests Change-Id: I1de631de9943e975dfabaf4e9bc995de3cd7a252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239105Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53beceea..be2b0d66 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e63e61bf9b38efb8d32f9fc298d4242a1977b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256063Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780711}
-
Ulan Degenbaev authored
The test needs to wait until the redirected iframes load their documents. Additionally, the 'same-origin-8' iframe is allowed to appear in the result. Bug: 1097332 Change-Id: I44e0b2bc7adff7cdba68c9b8ba6b240aa380a08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255599 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#780710}
-
Anatoliy Potapchuk authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19576 TBR=apotapchuk@chromium.org Bug: 1097708 Change-Id: I7c926cdffc37ff418b23ed0a5654fb92129260b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257199Reviewed-by:
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I06bc0c29ef1369ac3d104c404a032e2937d500c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254325 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#780708}
-
Fredrik Söderqvist authored
Like in SVG LayoutObjects deriving from LayoutSVGModelObject, we need to handle implicit transform changes caused by changes to the viewport. Add the equivalent CheckForImplicitTransformChange() method that LayoutSVGModelObject has and hook it up in UpdateTransformAfterLayout(). Bug: 1094020 Change-Id: Iedd05bb7e2de2bde25a6ce9f01cf1903dc1d6a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250000 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780707}
-
Maksim Moskvitin authored
Bug: 1016702 Change-Id: I75da209fc1cbe8a93eb3f9cd229097161064bf29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253766 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#780706}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2cb6faf0664d0411d489583eb1576f9f4c1285b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257044Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Id64ee411246fe966b9964c3f72e5a80c1dabcb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257040Reviewed-by:
-
Friedrich Horschig authored
This CL adds two metrics that should help us figure out whether the unlock of the account store is used and yielded useful suggestions. The PasswordManager.* Metrics are: - CredentialsFromAccountStoreAfterUnlock which records the number of account suggestions a user has available right after the unlock. - Three new entries in PasswordDropdownItemSelected to check the usage of generation, unlock, and re-signin promo Metrics to see whether they dropped out during the reauth were split out into https://crrev.com/c/2252809. Bug: 1063852 Change-Id: I737e6dc73e4dd294d2b2b91a77a3dbdd2ae1fd61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252338 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Christoph Schwering authored
The AutofillCapturedSitesInteractiveTest test crashes on Linux because the process is not allowed to be blocking. This CL remedies this by adding a ScopedAllowBlocking RAII variable with minimal necessary scope. Bug: 1097526, 1090042 Change-Id: I6475d67be1cf308d4d2086076a7a0b2e7eb82ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255360Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#780702}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e20ac35adbfd..b97d7669bc7b 2020-06-22 johnkslang@users.noreply.github.com Merge pull request #2278 from ShabbyX/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ib294326b017e5e57935aa1ab81f604aae8c1c9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256697Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/545d158a2ff9..d4b9f576ebb4 2020-06-19 jaebaek@google.com [spirv-opt] debug info preservation in ssa-rewrite (#3356) 2020-06-19 ehsannas@gmail.com Updated desc_sroa to support flattening structures (#3448) 2020-06-19 vasniktel@gmail.com spirv-fuzz: Refactor variable creation (#3414) 2020-06-19 vasniktel@gmail.com spirv-fuzz: Swap operands in OpBranchConditional (#3423) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I5b25081679cd69cd5a52054088d35e1296bddcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257041Reviewed-by:
-
Jan Krcal authored
This is a reland of ec355e1b Original change's description: > [Profile menu] Streamline ProfileMenuClickTests > > This CL removes behavior of profile menu in tests that is not checked by > the click tests (i.e. the various actions that happen after clicking the > menu items). > > This CL is a speculative fix for high flakiness of > ProfileMenuClickTests. The flakiness has multiple root causes, none of > which seems specific to profile menu / the test code. The hope is based > on the fact that many of the actions in the user menu are expensive > (loading guest mode and opening another browser) and thus increase the > risk of flakiness. > > Bug: 1021930 > Change-Id: I0f24a1f18ce8d3029daef44e2bc96b95eef81ac9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247642 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780296} Bug: 1021930 Change-Id: I861463cf7e54be7456ff8e59fa46392a1f2893d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255463 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/47e76886f0ca..b85a296d6a61 2020-06-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6673f0192ef6c34131079fd494617c2d4d8489a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257038Reviewed-by:
-
Felipe Erias authored
The scrollbar-gutter CSS property provides control over the presence of scrollbar gutters (the space which may be reserved by the UA to display a scrollbar). The value of scrollbar-gutter is defined by a combination of one or more keywords ("auto", "stable", "always", "both" and "force"). This property is internally stored as an unsigned int with binary flags for each one of those keywords. For convenience, ScrollbarGutterIs* methods have been added to ComputedStyle. Parsing WPT tests are included. Feature status: test. Bug: 710214 Change-Id: Ia5928ab4c379097065e28604d8431aab3e8f22c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245426 Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#780697}
-
chrome://media-appDavid authored
This cl changes the way we load files such that 1. we load a single file, after this users can interact with the app. 2. we asynchronously load every other related file in that directory, will update the app when it is done. Notably: * adds a way to register observers to AbstractFileList * adds a way to add files and notify observers to ReceivedFileList * adds IPC to 'load-extra-files' * adds `processOtherFilesInDirectory` & `globalLaunchNumber` which keeps loads in sync Existing tests provide a lot of coverage for the new codepaths, however there are edge cases such as loading the first file then doing one of the following 1. invoking launchable IPC i.e. rename 2. invoking non launchable IPC i.e. delete / save 3. start an edit (or another action) changing the UI This cl adds tests for 1 & 2. in the case of 1, we have a token `globalLaunchNumber` to make sure only the most recent load is fulfilled. in the case of 2, we load files as normal as the previous focus file is now removed from the file system. 3. is handled internally in cl/317047655 Bug: b/158043802, 996088 Change-Id: I23e05efa1ffb9c720a116f63e06ca8565dcc7539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249266 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#780696}
-
Marc Treib authored
This CL parameterizes PasswordManagerTest.* so that they're run both with EnablePasswordsAccountStorage enabled and disabled. Bug: 1093310 Change-Id: I45d912ead2dd1e0e0e4fc9842872e9b87f4654cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255466 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
[Sheriff] Revert "Reland "When Serializing the CopyOutputRequest use the threadpool for expensive copies."" This reverts commit 41ad04ab. Reason for revert: This cl causes DesktopMediaListAshTest.WindowOnly to fail consistently on LSAN. Failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37920 Original change's description: > Reland "When Serializing the CopyOutputRequest use the threadpool for expensive copies." > > This reverts commit efddc7e5. > > Reason for revert: task runner needs to be set in slow_window_capturer_chromeos.cc > > Original change's description: > > Revert "When Serializing the CopyOutputRequest use the threadpool for expensive copies." > > > > This reverts commit f248d2a2. > > > > Reason for revert: Suspected of causing failures for AuraWindowVideoCaptureDeviceBrowserTest.* > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19215 > > > > Original change's description: > > > When Serializing the CopyOutputRequest use the threadpool for expensive copies. > > > > > > Currently when Chrome requests a screenshot we send a CopyOutputRequest > > > from the browser. However while taking this screenshot we need to > > > transfer it over a mojo pipe. This serialization takes 100-200 ms an > > > example traces in the linked bug on the VizCompositor thread and then > > > another 100-200 ms to deserialize it on the CrBrowserMain. This can > > > block high priority tasks which delay input handling causing visible > > > jank to users. > > > > > > We fix this by doing the expensive copies on the ThreadPool, most other > > > copy tasks only take a couple ms so this removes most of the pain > > > relatively easily. > > > > > > Tests had to be updated to know to wait for > > > CopyOutputResult::SendResult to complete async. > > > > > > > > > Bug: internal b/152858656 > > > Change-Id: I114d65894c80742309bc2a02fdd2a0a7ad56dae7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201762 > > > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > > Reviewed-by: Mitsuru Oshima (slow:gardening) <oshima@chromium.org> > > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#779930} > > > > TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > > > Change-Id: I7c3a2011728b442580dd2c2da4816c0426649a4b > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: internal b/152858656 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253678 > > Reviewed-by: calamity <calamity@chromium.org> > > Commit-Queue: calamity <calamity@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780185} > > TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,calamity@chromium.org,eseckler@chromium.org,nuskos@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: internal b/152858656 > Change-Id: I9fa3e36dd6e874ada1fe336157eee73011b16b99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252802 > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780267} TBR=palmer@chromium.org,oshima@chromium.org,vmpstr@chromium.org,calamity@chromium.org,eseckler@chromium.org,nuskos@chromium.org Bug: internal b/152858656 Change-Id: I81047125f697e3ffcf5ade55901c800a65ccc9c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256200Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Currently, IdentityServicesProvider gives |Profile#getLastUsedRegularProfile| param to the native. By this CL, feed classes pass |Profile#getLastUsedRegularProfile| to the IdentityServicesProvider to be used by native. Hence, this CL is only clean-up and does not change code behaviour. Bug: 1041781, 1075562 Change-Id: Ia4859f565da27638dd7b87e500a70cdabe51aa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253750 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#780693}
-
Rushan Suleymanov authored
Bug: 1096094 Change-Id: If3c3e8621fc4c503d276dd94adb261107c0982c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252186 Auto-Submit: Rushan Suleymanov <rushans@google.com> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
This test has been flakily failing. Example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel TBR=ulan@chromium.org Change-Id: Ib822a468b0eb9ff4799034b527e69bb9f3d0a97e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257198Reviewed-by:
-
Clemens Arbesser authored
I added GetUserModel() a while ago, which supercedes this method. Bug: b/145043394 Change-Id: I5d22394e8282906d61c40ce3958b4dcf33f38a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252343Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#780690}
-
Alex Rudenko authored
DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2253898 Bug: 946975 Change-Id: I6080f0b0c912b825024e710f68a0ac4f80de43fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256199Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#780689}
-
Bugs Nash authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hHNzH9agD69T1E_LZpIZVzqyspiBI3MkAir2tP-KXtIC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202006210800_RC00.html Bug: b/154069736, b/158702282, b/156201188, b/158703476, b/158263742, b/144966889, b/158263707, b/158794019, b/155448625, b/156556242 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I3e14df1923ac71dc4c1718fcc47369f8411ef347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255948Reviewed-by:
-
Takashi Sakamoto authored
Bug: 1086388, 1096952 Change-Id: Id8307aa3b21b46a237766ae1dd75664a8c804da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256920Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#780687}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592794775-3ca8972fd43e2dafcf6b1d386a5259b1a453c9cc.profdata to chrome-win32-master-1592798309-f2bcf0f33aab857d8bcffdd4e0dd372aeeedf408.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7bca20aa5b6cb0937f914824c9531addd3377a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256690Reviewed-by:
-
