- 06 Mar, 2019 40 commits
-
-
Adrienne Walker authored
Now that shared images have a color space in them, we don't need to explicitly pass a color space. Color space transfer cache entries can be removed in a followup. Bug: 933901 Change-Id: I2c95aa14ee79da70a907ff3ce90d38550397ea8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495574 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638253}
-
Daniel Murphy authored
This reverts commit 6fc31bcf. Reason for revert: The crashes have stopped, so these debugging CLs are being reverted. Original change's description: > [SessionStorage] Resolve OpenSessionStorage at bind site > > R=mek@chromium.org > > Bug: 927534 > Change-Id: Ic50cb227f34127ed69cbd9e8edf13ca5824238d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1479274 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633881} TBR=dmurph@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927534 Change-Id: I0a02e62a4b5b6a3a6f6a5ff35ef43326c106a8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506460Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638252}
-
Javier Ernesto Flores Robles authored
The space was modifidied in order to match Apple's next and previous arrows below them. Bug: 912551 Change-Id: I41955034a9b9af396ef710dbb494d5a97bbc799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505946 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638251}
-
Ken Rockot authored
Amends an existing IO-thread-bound interface in child processes to obey a new Crash() message when received. This is to help debug child process hangs on platforms where we don't get hang crash reports yet. The message is used by the renderer hang monitor if it detects a hung renderer and the user agrees to kill it. Crashes resulting from this change should provide some insight into why renderers are hanging on Chrome OS. Bug: 938647 Change-Id: Ifb5dc8c2f755c4a25f3f712145e4ddb9e32a584a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505832 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#638250}
-
Dan Beam authored
Screenshot: https://imgur.com/a/Zo7p0MI R=dpapad@chromium.org BUG=926658 Change-Id: I0631c213ad3ef7e5808af1ab9922f00791c60a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505116 Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638249}
-
manuk authored
This button compliments the previously named 'Import clipboard' button. With this CL, we have 4 buttons to export to or import from the clipboard or a file. Additionally, this CL renames the buttons and modifies accesskeys for clarity: - Copy (alt+c) - Paste (alt+v) - Download (alt+n) - Upload (alt+m) The 'Lock cursor position to end of input' checkbox also has its accesskey changed from alt+c to alt+x. Bug: 937321 Change-Id: Ieada086afd7e2d35e7b164679e1087245050ef91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497117Reviewed-by:
-
Ian Kilpatrick authored
As above. This iterates over all the scrollable areas, and marks their respective layout objects as requiring layout. This is required as LayoutNG has caches more items than in the existing LayoutNG, and nothing marks the layout_box with the scrollbar as needing layout. This is similar to the kPaintChange, which invalidates paint all of paint when something like high-contrast mode is enabled. Bug: 922456 Change-Id: Ie65b14872a832b73b197247c06ce77727d8e6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476811 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#638247}
-
Nick Harper authored
Bug: 700280 Change-Id: Icf24e2f8c1b4c96c198039561fbf8c2d97cd2b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500138Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#638246}
-
Piotr Bialecki authored
Bug: 935025 Change-Id: Iab1b70463d9d6fe5a5104520160b392f5f17e9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504000Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#638245}
-
Tommy Steimel authored
This CL adds a check to make sure there is a RemoteCommandCenterDelegate before we attempt to create a RemoteCommandMediaKeysListenerMac. Bug: 938070 Change-Id: Ie216a85e5c579b7d654888d00c24b67ddaa7351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506108Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638244}
-
Brandon Jones authored
Bug: 933411 Change-Id: I7e698846e7c733c15a82bd9079855df1e2d5abf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504223Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638243}
-
rbpotter authored
Bug: 936787 Change-Id: I7eeb1f3f9da68e6a4274afab2804ea3f2df21366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504309Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638242}
-
Mustafa Emre Acer authored
This test sanity checks that we display a lookalike interstitial for a relevant domain name. The test is adapted from chrome/browser/ssl/CaptivePortalTest.java. Bug: 936565 Change-Id: Ic92be9630c15ec4d88043411a79edf0a07ed78ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497767Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638241}
-
Christian Fremerey authored
This CL is in the context of enabling capturers to tell consumers, e.g. video encoders, what part of the video has changed (possibly none) since the last frame. Design Doc: https://docs.google.com/document/d/1YNYaP22fepgP_MXrFXytbo0LOyx29mdCKAsQ2TZAckg/edit?usp=sharing Functional changes in WebRTCVideoTrackSource: * Keep track of CAPTURE_COUNTER and and CAPTURE_UPDATE_RECT to determine when valid |update_rect| information is available. * Accumulate |update_rect| information when dropping frames before delivery to WebRTC * Mark whole frame as changed if cropping or scaling has changed since the last frame delivery. * Translate |update_rect| from being relative to the entire coded frame data (as delivered) to being relative to the visible_rect of the frame (as expected by WebRTC) * When hard-applying cropping and scaling into a new buffer, transform the |update_rect| information accordingly. Bug: 930186 Change-Id: Ic81e9d3bbe4a3f0c403dd709a338f0a699cbfeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464932Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638240}
-
Robert Liao authored
With the current Equals() semantics (BindStateBase pointer comparison), this should always return false as OnceCallback is a move only type. BUG=937566 Change-Id: I5477a51721f9c8bf1fa95636263b2095b9588452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497636 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#638239}
-
Sammie Quon authored
The backdrop is created after the shield button and it's the same size so it was eating all the events. Set the backdrop to not be able to handle events. Test: ash_unittests OverviewSessionTest.SelectingWindowWithBackdrop Bug: 938645 Change-Id: I18d53cf9ba385ab24a7e3dcce1ceaf16fcde48d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504307Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#638238}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6195cd0e66d0..767948b07604 git log 6195cd0e66d0..767948b07604 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 dgarrett@google.com workspace_stages: Only warn on unittest failures. Created with: gclient setdep -r src/third_party/chromite@767948b07604 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib342f2fcb94897acb58d3c276df488ab9e8eb263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638237}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id382889ba134a3fba888d19d4fe4372e6774f8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506472Reviewed-by:
-
Karolina Soltys authored
Part of an ongoing effort of ThreadUtils --> PostTask migration. Bug: 863341 Change-Id: I2feb4d7dc6280da16d25e91f75f8b10266bb3fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1448219Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638235}
-
Chase Phillips authored
Similar to the IDBCursor.Advance() commit 9a58b89a, IDBCursor.CursorContinue() previously took a separate IDBCallbacks interface that had its own lifecycle and could have a number of methods called on it. This CL updates CursorContinue() to use Mojo's native callback mechanism. Bug: 717812 Change-Id: Icc7d8b0be70a078f31d658ac9c35d83d8af12b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480810 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
bsheedy authored
Significantly improves the speed at which Android RenderTest comparisons take place if Bitmap.sameAs returns false. This is done by reducing the number of times we call methods that have to hop through JNI and by bulk editing images instead of going through pixel-by-pixel. Rough benchmarking shows this to result in a ~3x speedup. Bug: 904012 Change-Id: I51dc259df9124c6023572a8510fa87dd435bf2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500413Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638233}
-
Carlos IL authored
SSLCertificateErrorPageController is no longer only used on SSL errors, renamed it to SecurityInterstitialErrorPageController, and removed the net::Error code passed to EnablePageHelperFunctions since it's no longer used. Bug: 910794 Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Christian Fremerey authored
Add support for having some clients require buffers of type kSharedMemoryViaRawFileDescriptor while others are using kSharedMemory while sharing the same device. This is done by having class BroadcastingReceiver convert the buffer type as needed when distributing buffer handles to the clients. Design Doc: https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing Test: content_browsertests --gtest_filter=WebRtcVideoCaptureSharedDeviceBrowserTest.* Bug: 783442 Change-Id: Ia636157dfddba3eec09476c4b2be7750ff931fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1413022 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#638231}
-
Aga Wronska authored
Bug: 938655 Test: manually Change-Id: I77a713e84a9fbd8b73470234e39f9a416c1cad4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504952Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#638230}
-
David Bertoni authored
This data member is not used. Change-Id: I4542a818349e17863ec30faab2625ee0ab1c8322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504953Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638229}
-
Edin Kadric authored
This worked seamlessly; I only had to update unit tests: On Linux, Alt+left/right shouldn't do anything to be consistent with the behavior of Textfield. Also, on Mac Alt+left/right really moves between words, not to the beginning/end of the text. On Linux that's achieved with Ctrl+left/right. Bug: 923660 Change-Id: I891e7164e6dd2b88070915715d9e735321fd9b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503617Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ed5dc24c07a3..9ba187ae4751 git log ed5dc24c07a3..9ba187ae4751 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 thestig@chromium.org Fix FPDF_FILEACCESS lifetime issue with FPDF_LoadCustomDocument(). Created with: gclient setdep -r src/third_party/pdfium@9ba187ae4751 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I966a47b3dd1fa33080b6baf21c94cc179daf0ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505858Reviewed-by:
-
Owen Min authored
Disable the test on Android, Linux and Fuchsia due to flaky. Tbr: petewil@chromium.org Bug: 938812 Change-Id: I96504518c8556d5e8cdfb60a9e74c5dc8e1040ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506380Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638226}
-
Christopher Cameron authored
The root cause of this bug is that the call to LSCopyApplicationURLsForBundleIdentifier that is made in WebAppShortcutCreator::GetAppBundlesByIdUnsorted will not necessarily find app shims that were created just moments ago (likely there is an asynchronous indexing that is going on). To fix this, make WebAppShortcutCreator::GetAppBundlesByIdUnsorted read through all of the app shims in the path under ~/Applications where app shims are created, and see if it finds an application that matches the one we are looking for, based on its Info.plist. Rather than add another place where Info.plists are manually parsed, merge all code that reads Info.plists from app bundles, and put all of the accessors for this data in a single BundleInfoPlist class. Note that some of the moved code is not well understood by this author (in particular, IsForCurrentUserDataDir and GetFullProfilePath). This BundleInfoPlist will be used more extensively in the updated code to delete zombie bundles and to provide more robust renaming. Bug: 937703 Change-Id: Ia292840debd9c74024d707f784dceab78443a536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500851 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#638225}
-
Owen Min authored
Disable the test due to Timeout Bug: 938883 Change-Id: Id2b1f3bed6f8044bd8426dc42ac021ac2ec440ab Bug: 938883 Tbr: petewil@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506117Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0563888d3868..a2179093ac06 Created with: gclient setdep -r src-internal@a2179093ac06 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I047a9b75faa3ba9f27b2e542ccd59f13f40aecd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505982Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638223}
-
Austin Eng authored
WebGPUDecoderImpl will later need to link against symbols in libdawn_native. This patch directly copies the contents to separate files which later can be conditionally compiled when building with use_dawn. Bug: 877147 Change-Id: Iab7abfa2dd636bb4d5d3f3b0a416f2c1f69de990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504495Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#638222}
-
Gayane Petrosyan authored
This relands crrev.com/c/1472450 which was reverted because of a crash crbug.com/936830. The cause of the crash was fixed separately at crrev.com/c/1501493. Bug: 931806 Change-Id: Id659440b7798fe6f0a3c233c3b29a584565cdba3 TBR=ramyan@chromium.org, engedy@chromium.org Change-Id: Id659440b7798fe6f0a3c233c3b29a584565cdba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506107Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#638221}
-
Alex Newcomer authored
HomeLauncherGestureHandler used to send the work area's y position as the max y position of the AppListView in an attempt to modify the work area. AppListView already accounts for work area changes. This bug went unnoticed until HomeLauncherGestureHandler had to deal with the workspace being shrunk from the top via the DockedMagnifier. Now, send 0 instead of the work area y position to AppListView and let AppListView handle the work area change. Also translate based on the keyboard being shown/hidden to prevent search results from being pushed off screen with docked magnifier enabled. TEST=manually tested with multiple display configurations Bug: 936381 Change-Id: I4de62a0f239a72ba69256f5561c7bfb10035a870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504434 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#638220}
-
Arthur Hemery authored
This function is unused since the NavigationHandle and NavigationRequest are kept together now. Change-Id: I0ca24dc4dd37712c298084f7c2d2088df9a24e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495547Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#638219}
-
Jonathan Backer authored
Bug: 938076 Change-Id: I39087f0882c9296975c4a02742898e76175e17a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503342 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Owen Min authored
Disable the test on ChromeOS due to flaky. Tbr: petewil@chromium.org Bug: 938755 Change-Id: I99eb58c46f53ae6cac8c2925171b7c3e838e15b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506119Reviewed-by:
-
Peng Huang authored
Bug: None Change-Id: I9675e5f6515131e24fab8d4e39b9b3420387bf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506096Reviewed-by:
-
Wez authored
Previously CastRunner would look for Agent-provided services (e.g. CastChannel) in the service namespace supplied on component launch. If a ComponentContext is found in the service namespace passed to StartComponent() then the CastRunner will now use that to connect to the CastAgent to find Cast-specific services. This requires temporary work-arounds e.g. to fall-back to looking at the "additional services" provided in the component's StartupInfo, until we migrate to the new component-manager APIs. Bug: 920920, 893229 Change-Id: I43aec5c47bc24a0d2a537de621b20fad3342a5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472333 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#638215}
-
Jarryd authored
This change adds two new histograms that will be used in monitoring the quota expansion experiment. The experiment is ready to be launched on beta for M74, but if the data from that channel/milestone is insufficient, we will have these metrics in for M75. The first metric added is Quota.UsageByOrigin which records the usage by each origin (absolute value, in MB). Right now, we only have the value as a percentage of the quota granted to each origin, so this could be a little more useful for this particular experiment given that we've increased the quota granted for each origin. The second metric added is Quota.PercentUsedByTemporaryStorage2, which is the same as the first of it's name (global usage in MB of the temporary pool / total disk space), except this will be logged regularly. The first of it's name is logged during eviction, and since our experimental groups have less evictions, we have significantly less data for the experimental groups than the control; thus the original histogram is unreliable for this experiment. This metric will be logged regularly using QuotaManager's histogram timer. Change-Id: I4339f7d4f512cd31405dadd24a515719baa75c9f Bug: 897276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501218 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#638214}
-
