GitLab

This reverts commit 172df5f3.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Move SeparatorView into its own file
> 
> SeparatorView paints a separator for IconLabelBubbleView in certain
> cases. This moves it into its own file and loosens the coupling
> between the two, while trying not to change any behavior (yet).
> 
> This is in preparation for moving the separator out of
> IconLabelBubbleView entirely.
> 
> Bug: 946293
> Change-Id: Ia3b7c9c51c781dc75a7bcb33064d8cf0dc8c44ea
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540682
> Commit-Queue: Collin Baker <collinbaker@chromium.org>
> Auto-Submit: Collin Baker <collinbaker@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#645150}

TBR=bsep@chromium.org,collinbaker@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 946293
Change-Id: I874381204cd63d11b63c740a84556b3656d9f3b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553934Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648301}

Small modernization to clarify semantics and avoid base::WrapUnique()
calls downstream.

Change-Id: I12ce3c1f08531c7fcf357a4d723f1cdeff64d036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553871
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648300}

Ports are the two-way relocatable messaging endpoints used as a backing
for Mojo message pipe handles. Each port is essentially a message-
receiving queue, and the mutual independence of each port's queue is
fundamental to a port's ability to be relocated efficiently and thus be
suitable to support message pipes.

This CL introduces the concept of "slots" on an individual port,
effectively allowing for messages in the port's queue to be routed to
different consumers referencing the port. Messages are now sent on a
specific slot by the sender, and received on a corresponding peer slot
on the peer port. If multiple messages are received for different slots
on a port, they still must be read (and are still only exposed) in
sequential order.

This is a precursor to supporting shared message ordering across
multiple independent message pipes in Mojo, a feature which will
ultimately replace the bindings concept of "associated interfaces".

See bug for design doc link.

Bug: 941809
Change-Id: I84e6f35831d918178e9eb2cc32c8701d1808e4e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538778Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#648299}

I won't be on the Chrome team anymore, removing myself from OWNERS so
I don't accidentally delay people's CLs :)

Bug: None
Change-Id: If2ad520a75b0bc385f4b20b81bf8cbef66b9c0fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553651
Auto-Submit: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648298}

Check for showing powerwash and enable debugging dialogs on boot
were only handled in response to signin screen loads from web UI login
implementation (on gaia screen load, and account picker load).

This replaces check during account picker show with a check in login
display host mojo, just before the login display view is initialized.
(The account picker web UI is not generally expected to show on
startup).

BUG=944345

Change-Id: I1fa41fb64a3ba8c900e29695f47277c679581471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554830
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648297}

This patch fixes |LayoutObject::ForceLayout()| not to mark
|NeedsCollectInlines|.

This fix not only prevents crashes, but also reduces the
number of |CollectInlines| from 5 to 3, for the test case in
issue 948587.

Bug: 948587
Change-Id: If218978790af4ba0492e0d0b8fc5b8d011da63b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554469Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648296}

This CL is a preparation for moving blink::VideoTrackAdapter out of
the Blink exposed API.

VideoTrackAdapter class is not used by out of blink apart from
VideoTrackAdapter::CalculateDesiredSize, a static/public method only used
by tests in [1].

On the other hand, blink::VideoTrackAdapterSettings also defined
in the same public file
(public/web/modules/mediastream/video_track_adapter.h) is used by
//content.

This CL a preparation CL that factor out blink::VideoTrackAdapterSettings
out of video_track_adapter.h|cc, as a preparation to stop exposing
VideoTrackAdapter as part of Blink's public API altogether.

Next, both [1] and video_track_adapter.h will be moved down to
third_party/blink/renderer/modules/mediastream/.

[1] //content/renderer/media/stream/video_track_adapter_unittest.cc

R=haraken@chromium.org
CC=blink-reviews-vendor@chromium.org

BUG=949956,919392

Change-Id: I420d1be033ca1acf30cf407518578f5569c08fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554900Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#648295}

This CL separates callback being passed to StartReceivingMessages() into
an on_ready callback that is called whenever the stream is ready, and
an on_closed callback whenever the stream fails to start or is closed.
Previously there is no way to get notified when the stream is first
started then get closed. This allows FtlSignalStrategy to handle stream
failure after the stream is started.

Bug: 947337
Change-Id: I65220ad98cd188a5e9cedf918b8a38beb90e8438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553385Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648294}

This is a reland of 4e001d88

crbug.com/950008 disables the failing tests, and this CL is not
the culprit.

Original change's description:
> Fix quic webdriver test
>
> Net.QuicAlternativeProxy.* histogram is not recorded with servicification.
> So that check is removed in the test. The DataReductionProxy.Quic.ProxyStatus
> histogram used in the test should be sufficient.
>
> Bug: 934875
> Change-Id: I1cdb16e347bd4cf852cc30481887a94dabceef8b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551710
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Robert Ogden <robertogden@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647481}

TBR=robertogden@chromium.org

Bug: 934875
Change-Id: I85227992bdb5ac9d1abcf24e080f9d0a40af3e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554294Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648293}

This CL does two things:
1. Keep track of updates to all progress items in two new members.
   This eliminates the need to iterate through all the items in
   MaybeSendProgress.

2. Stop allocating ProgressItems on the heap with unique_ptr. This should
   make all map operations much faster. The Progress item is just two int64s.

Bug: 673189
Change-Id: I926d84ef5fb25713a85f184ab76d322fc0ab91d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554059
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648292}

https://android.googlesource.com/platform/external/perfetto.git/+log/3c836b671503..cc57bf714a30


git log 3c836b671503..cc57bf714a30 --date=short --no-merges --format='%ad %ae %s'
2019-04-05 rsavitski@google.com no_destructor_unittest: skip death tests under chromium build
2019-04-05 lalitm@google.com Merge "trace_processor: fix UI query for thread time by p-state"
2019-04-05 lalitm@google.com trace_processor: print non-zero error stats and stop counter events from log spam
2019-04-05 lalitm@google.com trace_processor: improve trace processor's iterator API
2019-04-04 rsavitski@google.com Introduce base::NoDestructor<T> to simplify static objects


Created with:
  gclient setdep -r src/third_party/perfetto@cc57bf714a30

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:129749217,chromium:126443808,chromium:118867986
TBR=perfetto-bugs@google.com

Change-Id: I34eb143effcb687253586ed6ccbe9197ffbc0e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554413Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648291}

Changes the majority of EXPECT_* macros in the XR browser tests to
ASSERT_*. This is because expectation failures are non-fatal, while
assertion failures are. In most cases, it doesn't make sense for us to
continue the test once a check fails, as many assumptions afterwards
will be wrong.

Some EXPECT_* uses that make sense to be ASSERT_* are left as-is due
to the restriction that fatal failure-generating macros can only be
used in void-returning functions.

Bug: 949772
Change-Id: I8258ebaaeae4b02d148f254a47635cbcc98e9a8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554832Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648290}

Add step to generate a supersize HTML report from the first to last
build revisions.

Sample output: http://gpaste/5150957543358464

Change-Id: I35ed0f3a05389e7ccb5eb93405df2197358bf9b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554828Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648289}

LocationBarModel was originally designed to provide data on the current
navigation entry's state, as described by the class comment.

Eventually, it grew to track input_in_progress() state as well,
duplicating this state canonically tracked by OmniboxEditModel.

This CL removes this method. All of the callsites (other than a few)
have already been migrated to calling the View to determine if
user input is in progress.

This is part of the overall UI architecture effort.

Bug: 912722
Change-Id: I609f98b53e1013be0db20a684d357dd71f7f055e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546623Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648288}

EG1 and EG2 do not share a common set of headers,
so any file that directly includes EarlGrey.h cannot be compiled under EG2.
Scrubbing the headers will enable us (in a future CL)
to share these helpers between EG1 and EG2.

Added #import <EarlGrey/EarlGrey.h> to each file
in which there is #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"

Files that need to change was found by:
git grep --files-with-matches ios/chrome/test/earl_grey/chrome_earl_grey.h . | grep .m | xargs grep -L '<EarlGrey/EarlGrey.h>'

Added #include "ios/web/public/test/element_selector.h" for files below
to fix issue `forward declaration of class here @class ElementSelector`:
- ios/chrome/browser/ui/download/download_manager_egtest.mm
- ios/chrome/browser/web/tab_order_egtest.mm

Bug:922813

Change-Id: I52527ceb805afea38ba0c6b9aa08ba85820257dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554188
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648287}

When we receive a device disconnect while presenting, we weren't closing
the overlay binding, which was causing a DCHECK in mojo because it was
being default closed/destructed on the wrong thread.

Bug: 950040
Change-Id: If3729b277f69883bb2e81a9308fe6dafc94f3ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553173
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648286}

This was causing renderer kills before, but we suspect the repro steps
might have been fixed.

BUG=948246

Change-Id: I3379dd128048a26655877704197c27cd19424ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553078
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648285}

This category is no longer in use. Mark the category as deprecated and
cleanup code references.

Bug: 947080, 947082
Change-Id: I26c7e52b87ef2775e468f10d25d93140ab029989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547932
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648284}

This CL:
(1) Creates the //c/b/ui/webui/chromeos/cellular_setup directory and
    moves the existing MobileSetupDialog and related classes to this
    directory. This was completed via the following command:
    ./tools/git/move_source_file.py chrome/browser/ui/webui/chromeos/mobile_setup_* chrome/browser/ui/webui/chromeos/cellular_setup/
(2) Adds a OpenCellularSetupDialog() function which opens the existing
    MobileSetupDialog. A follow-up CL will update this function to
    open the updated dialog when the kUpdatedCellularActivationUi flag
    is enabled.
(3) Updates existing comments on the old dialog to make it clear that
    this UI is being deprecated.

Bug: 948942
Change-Id: Ib8e67908de6b0ab7ad4314856cc29c81d69f4e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552252
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648283}

Major changes:
 - Consolidate stateful global scope and stateless global scope. i.e.
 only select one global scope randomly upon mutation.
 - No longer create animator instances on both global scopes. Instead,
 create one instance on the selected global scope and upon switching
 global scopes create a new one on the new global scope with all the
 properties transferred. For stateful animators, the state gets
 transferred as well.

Bug: 914918
Change-Id: I13837eb787dcc671492e8c5fbba6176a3bf34cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488312Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648282}

Problem: MediaSessionCompat is making calls when mMediaNotificationInfo
is no longer available, causing NPE crash in onStop() and
onMediaSessionAction().

Solution: Add null check for mMediaNotificationInfo into onStop() and
onMediaSessionAction() callbacks to prevent NPE crashes.
This solution mirrors previous NPE fix for onPause() and onPlay()
callbacks. See:
  https://chromium-review.googlesource.com/c/chromium/src/+/955694/

Bug: NONE
Change-Id: Ie5775f0d9098cb9693fe7f2d2422404d5612feb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549757Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Simon La Macchia <smacchia@amazon.com>
Cr-Commit-Position: refs/heads/master@{#648281}

This is a reland of 399f00ea.

Addresses test failures of crbug.com/948875 by ensuring that the
PerfettoTracingSession waits until startup tracing is fully enabled
before attempting to disable it again.

Original change's description:
> devtools/tracing: Support perfetto backend + proto output.
>
> Adds the ability for TracingHandler to use the new Perfetto Consumer
> interface to control a tracing session. For now, we still support the
> old TracingController backend via a new TracingSession virtual class.
>
> Also adds a proto output format option to the protocol.
> Further adds necessary missing methods to the perfetto ConsumerHost
> interface.
>
> To support startup tracing with perfetto + retrieving of the trace via
> DevTools, TracingHandler needs to become the consumer that initiates
> and controls the startup session, instead of TracingController.
> Otherwise, the trace data can't be read via DevTools. For this, we add a
> new command line flag.
>
> Background: We're replacing the old tracing backend (TracingController +
> TraceLog) with Perfetto! In this process, former clients of
> TracingController become consumers of the Perfetto service instead.
>
> Bug: 925142, 938879
> Change-Id: I2ac389e4b9a6d258b784acaf76043417be4f4f3b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505934
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#646895}

Bug: 925142, 938879, 948875
TBR: dgozman@chromium.org,dcheng@chromium.org,perezju@chromium.org
Change-Id: Ie80d261b9940b2de1917729736f6bb116290302d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553594
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648280}

https://swiftshader.googlesource.com/SwiftShader.git/+log/bd3af855ae74..484e08e0fae6


git log bd3af855ae74..484e08e0fae6 --date=short --no-merges --format='%ad %ae %s'
2019-04-05 bclayton@google.com SpirvShader: Rework pointer types


Created with:
  gclient setdep -r src/third_party/swiftshader@484e08e0fae6

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/126330097
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: Id2b780a876d01e7f6bed3c73b0a1002c2b861f0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554432Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648279}

BUG=950049
TBR=nektar@chromium.org,avi@chromium.org

Change-Id: I07d3e741c02eeae93be6d9c2647aedad4a735ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555000Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648278}

For ServiceWorkerGlobalScope, TrustedTypePolicyFactory interface attributes
are defined in "service_worker_global_scope_core_constructors.idl" which
was not visible to the origin trials code generator.
The issue is fixed by passing all the generated dependency idl files
to the build.
* Due to bug 358074, it is not possible to add the new dependency to
  the modules build only.

Bug: 937945
Change-Id: I999cde5830730f4366c5abbe9adbc478f84a0e05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553665
Commit-Queue: Yashar Dabiran <yashard@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648277}

BUG=949923
NOTRY=true
TBR=lfg@chromium.org

Change-Id: I35423dcb50326c9654329560be2edf542973a6b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553178Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648276}

This CL cleans up the DisplayConfigurator API for content protection,
specifically removing INVALID_CLIENT_ID in favor of an optional type,
as well as renaming functions and callbacks for consistency with
QueryContentProtectionTask and ApplyContentProtectionTask.

Bug: 929449
Test: display_unittests
Change-Id: I8081c964041e37682ce3555394ecf6fc4987eae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553581Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648275}

This reverts commit 81eedac1.

Reason for revert: possibly causing rendering.desktop to not be able to upload data. probably the dashboard is not intaking the data since the chunks are too big again.

Original change's description:
> Chunk perf data into 30 MB chunks instead of 1 MB.
> 
> Locally, I timed the process_perf_results() call in
> ProcessPerfResultsIntegrationTest.testIntegration before and after this change.
> 
> Before:
> Test #1: 40.6 seconds
> Test #2: 38.8 seconds
> 
> After:
> Test #1: 24.4 seconds
> Test #2: 24.7 seconds
> 
> I expect the difference on the waterfall to be more dramatic than this since
> the waterfall test results have a much more unequal distribution of perf data
> sizes, so we tend to get stuck chunking up some huge benchmark.
> 
> Bug: 947035
> Change-Id: Ib2a5075dc2504d0bec37750cd73eba57dbc19d11
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548356
> Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
> Commit-Queue: Ben Hayden <benjhayden@chromium.org>
> Reviewed-by: Ben Hayden <benjhayden@chromium.org>
> Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#646552}

TBR=benjhayden@chromium.org,crouleau@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 947035
Change-Id: I90493939c018cce504491dd99c5d0a8dd22fb94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554885Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648274}

The commit https://crrev.com/c/1492489 introduces a regression on
GCC build, as GCC will not enable the aarch64 feature modifiers
crc and crypto anymore.

This change keeps clang implementation using the target feature
extensions, but keeps the old implementation for GCC.

Bug: 819294

Change-Id: I343ba9587e0356ecdab2ed95513d6d58feb5e75e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553319
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648273}

When ControllerImpl is initialized, it adds itself as an observer of
NavigationMonitor. This CL makes ControllerImpl unregister itself in
its destructor, ensuring no events are sent from NavigationMonitorImpl
to a dangling pointer.

Bug: 943724
Change-Id: I0e6b122bf3a0efccaf867a4bcd71e2c9e13d09a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553648Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648272}

Right now in the PaintWorkletImageCache, we did do null check on the
|painter_| member to ensure that there is no crash when it is null.
This CL adds unit testing to ensure that it is functioning as it should
be.

Also, in order to fix a potential crash in GetPaintRecordAndRef, the
ScopedResult now takes a sk_sp<PaintRecord> instead of a const PaintRecord*.

Bug: 939192
Change-Id: I6282618566d931a6aea2e4d5674ed835d85c91d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518292
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648271}

GCC visibility evaluation is different from Clang. In this case build
breaks because the lambda function declared in .h does not have
access to ForAllChildLocalFrameViews yet. Moving the implementation
of DisallowLayoutInvalidationScope constructor and destructor to .cc
fixes the problem.

BUG=chromium:819294

Change-Id: I82e8b135aa911c878413998a24cacce03d2662c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550373
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648270}

Don't launch startup chrome browser window when a KioskNext login happens.

Bug: 938532
Change-Id: I61c0a13b298bc45e4945425c14874e9231952233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529889
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648269}

Bug: None
Change-Id: I8ebd9d26de723b78ca5aa971632def596d6a2c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536038
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648268}

This reverts commit fab66bae.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add new ANGLE Linux and Mac tester configs.
> 
> These configs will replace linux_angle_rel_ng and mac_angle_rel_ng.
> They initially mirror the configuration but will soon be updated to
> run only the subsets of tests that are most relevant to ANGLE. This
> should reduce flakiness in ANGLE and reduce load for Chrome.
> 
> Also updates related configuration files to include linux-angle-rel
> and mac-angle-rel.
> 
> Bug: 822310
> Change-Id: I2b40ed45f5d9e105c088ab166bd2207c96280151
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551463
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647854}

TBR=kbr@chromium.org,jbudorick@chromium.org,jmadill@chromium.org

Change-Id: I8ec1017835d224282688c4bd089c05d41fe9f3c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 822310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553176Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648267}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c5403d69e17c..c6dfce981f13


git log c5403d69e17c..c6dfce981f13 --date=short --no-merges --format='%ad %ae %s'
2019-04-05 pprabhu@chromium.org config: Migrate eve,grunt,samus,veyron_minnie PFQs to Skylab


Created with:
  gclient setdep -r src/third_party/chromite@c6dfce981f13

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I9c87453962754875e705a7ae28726567a8a52808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648266}

Bug: 927809
Change-Id: Ia2380f18ef87e7c93a40858d62777810d1e86d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553207Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Lucas Tenório <ltenorio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648265}

leveldb_proto databases will soon be migrated from unique LevelDB
instances to a single shared underlying database. Because of this,
we need to migrate to the new API to construct and initialize the
database.

Bug: 941795
Change-Id: I8a13c590361c812303304428252bb6fdc905dc68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548533Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648264}

Backface visibility does not depend on having a PaintLayer but the
invalidation logic did. This patch extracts out the invalidation of
paint properties into LayoutBoxModelObject::StyleDidChange. This patch
also removes outdated code that caused repaints for backface visibility
changes.

Bug: 946541
Change-Id: Ib6790b9c7d442d8e8971185c2eda2a99f10e8506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553168Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648263}

The data saver proxy will start returning a new header
(Access-Control-Expose-Headers) to all proxy responses soon. This change
adds tests to various proxy test cases to ensure that the ACEH header is
present and contains the expected values.

It is expected that the ACEH header will now contain "Chrome-Proxy",
"Chrome-Proxy-Content-Transform" and "Via" (the values set by the proxy),
but it may also contain other values that are provided by the origin.

Bug: 949301
Change-Id: Ibe00cf4027202d95435a6e266d925767c51327c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551494Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Marcin Bojanczyk <marcinjb@google.com>
Cr-Commit-Position: refs/heads/master@{#648262}