GitLab

Reverting previous revert as it did not cause the problem.

BUG=chromium-os:22840
TEST=Manual: see bug description
TBR=ivankr@chromium.org
TBR=dgozman@chromium.org
Review URL: http://codereview.chromium.org/8895001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113799 0039d316-1c4b-4281-b951-d872f2087c98

Fix UserActionsMetrics calls for content settings UMA, so that they get picked up by the the chrome/tools/extract_actions.py tool.

Remove wrong and unused user action metrics hash and add the correct hashes.


BUG=105865
TEST=none

Review URL: http://codereview.chromium.org/8873056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113798 0039d316-1c4b-4281-b951-d872f2087c98

This may potentially cause failure of ExtensionApiTest.ProcessesVsTaskManager.

BUG=chromium-os:22840
TEST=Manual: see bug description

Review URL: http://codereview.chromium.org/8872015

TBR=ivankr@chromium.org
Review URL: http://codereview.chromium.org/8890069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113797 0039d316-1c4b-4281-b951-d872f2087c98

Revert for potential cause of ExtensionApiTest.ProcessesVsTaskManager failure.

This enables a fix for bug 79520 that was previously committed but not enabled http://src.chromium.org/viewvc/chrome?view=rev&revision=112847.

BUG=79520
TEST=no
TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/8889007

TBR=battre@chromium.org
Review URL: http://codereview.chromium.org/8879051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113794 0039d316-1c4b-4281-b951-d872f2087c98

text checking.

It will enable us to use asynchronous spelling text checking
feature which will be implemeneted in WebKit. 

BUG=106968
TEST=manual


Review URL: http://codereview.chromium.org/8554002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22035
TEST=


Review URL: http://codereview.chromium.org/8702009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106969
TBR=miket@chromium.org

Review URL: http://codereview.chromium.org/8883045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113790 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22840
TEST=Manual: see bug description

Review URL: http://codereview.chromium.org/8872015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113789 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113786 0039d316-1c4b-4281-b951-d872f2087c98

This enables a fix for bug 79520 that was previously committed but not enabled http://src.chromium.org/viewvc/chrome?view=rev&revision=112847.

BUG=79520
TEST=no
TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/8889007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Trybots
TBR=tony@chromium.org

Review URL: http://codereview.chromium.org/8883044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113784 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113783 0039d316-1c4b-4281-b951-d872f2087c98

R=sail@chromium.org
BUG=106466
TEST=Modify Web Data file to trigger Protector bubble, launch Chrome, open Incognito window, wait for 10 minutes or dismiss the bubble with any button, verify that wrench menu button doesn't have Protector badge anymore.

Review URL: http://codereview.chromium.org/8844003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113780 0039d316-1c4b-4281-b951-d872f2087c98

Enable WebUI task manager for all platforms in r18, reverting r112133 ("WebUI TaskManager: Turn it off-by-default on Win/Mac/Linux").

BUG=97429
TEST=manual on linux
TBR=yoshiki@chromium.org

Review URL: http://codereview.chromium.org/8890065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113779 0039d316-1c4b-4281-b951-d872f2087c98

Recent large increase was r102341.

BUG=106966
TEST=None
TBR=cmp@chromium.org,tony@chromium.org

Review URL: http://codereview.chromium.org/8890066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113778 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104136
TEST=manual on linux


Review URL: http://codereview.chromium.org/8713016

TBR=yoshiki@chromium.org
Review URL: http://codereview.chromium.org/8873054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113776 0039d316-1c4b-4281-b951-d872f2087c98

This patch also enables partial refreshing on WebUI Task Manager.

BUG=104136
TEST=manual on TaskManager, CookieManager and FileManager


Review URL: http://codereview.chromium.org/8608007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106590
TEST=no


Review URL: http://codereview.chromium.org/8879011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113774 0039d316-1c4b-4281-b951-d872f2087c98

Regression:
linux-release-lowmem/bloat-http/times/t: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/bloat-http/report.html?history=150&rev=113768

BUG=106888
TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/8890064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113773 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104136
TEST=manual on linux


Review URL: http://codereview.chromium.org/8713016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: http://codereview.chromium.org/8889040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104361
TEST=Manual

Review URL: http://codereview.chromium.org/8821004

This reverts commit 4e7b5881.

TBR=mazda@chromium.org
BUG=104361
TEST=none

Review URL: http://codereview.chromium.org/8889043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105915
TEST=Enable bookmark bar (Ctrl+Shift+B) and enter fullscreen mode. Bookmark bar should not be visible


Review URL: http://codereview.chromium.org/8883038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=this is the test

Review URL: http://codereview.chromium.org/8883035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113768 0039d316-1c4b-4281-b951-d872f2087c98

Goes with r112647, where we added CHECKs for invalid file descriptors.

Regarding the GPU process, we already have a crash in GpuChannelManager::OnEstablishChannel() function due to invalid renderer fd.  But it's not clear whether this is due to channel reuse or failure in creating channel in server mode.  Talked to apatrick@ and the reuse one should never happen in normal case.  Adding check on that case so we can hopefully rule out that case.

Regarding the NPAPI process, we already have a lot of crashes due to invalid file descriptors in the rederer.  In NPAPI process, add a CHECK right after the channel is created in server mode to see where this invalid fd originates from.

BUG=none
TEST=passed unit tests


Review URL: http://codereview.chromium.org/8877001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106957
TEST=none
R=dmazzoni@chromium.org
TBR=dmazzoni@chromium.org

Review URL: http://codereview.chromium.org/8890063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113766 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113765 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=113760&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=113760&graph=chrome-si

BUG=94925
TBR=cmp
Review URL: http://codereview.chromium.org/8890062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113764 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=bashi


Review URL: http://codereview.chromium.org/8889033

TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/8873051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113763 0039d316-1c4b-4281-b951-d872f2087c98

Remove aura::RootWindow instance from LayerAnimator::observers_ and LayerAnimationSequence::observers_ when the window is deleted.

This would prevent Chrome from crashing (see the example stack trace below) when someone (e.g. ui/aura_shell/shell_accelerator_controller.cc) adds aura::RootWindow as an observer of a LayerAnimationSequence object, and the window is deleted before the animation finishes.

pure virtual method called
terminate called without an active exception
[24029:24029:1206/172212:111412790729:ERROR:process_util_posix.cc(139)] Received signal 6
        base::debug::StackTrace::StackTrace() [0x809fbf4]
        base::(anonymous namespace)::StackDumpSignalHandler() [0x830b615]
...
        ui::LayerAnimationSequence::NotifyAborted() [0x826fcce]
        ui::LayerAnimationSequence::Abort() [0x826f95b]
        ui::LayerAnimator::ClearAnimations() [0x8274f84]
        ui::LayerAnimator::~LayerAnimator() [0x8273a74]
        scoped_ptr<>::~scoped_ptr() [0x826c7e3]
        ui::Layer::~Layer() [0x8269873]
        scoped_ptr<>::~scoped_ptr() [0x81b7891]
        aura::Window::~Window() [0x81b4745]
        aura::RootWindow::~RootWindow() [0x81ae824]
        aura::RootWindow::DeleteInstance() [0x81ace70]

With the aura::RootWindow fix, we can reenable one test in shell_accelerator_controller_unittests.cc which checks the Control+Home accelerator.

BUG=None
TEST=ran aura_shell_unittests



Review URL: http://codereview.chromium.org/8816008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113762 0039d316-1c4b-4281-b951-d872f2087c98

Also implemented PbufferImageTransportSurface::SetVisible by making the underlying surface 1x1 when it is not visible.

Review URL: http://codereview.chromium.org/8884001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113761 0039d316-1c4b-4281-b951-d872f2087c98

Given protocols argument is not allowed to have any duplicated protocol
name in Connect().

This CL contains constant number replacement in test_websocket.cc like
s/0/0U/g, and detailed comments on protocols argument check.

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_Protocols'

Review URL: http://codereview.chromium.org/8839003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113760 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113759 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94125
TEST=none

Review URL: http://codereview.chromium.org/8872056
Patch from Arthur Hsu <arthurhsu@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113758 0039d316-1c4b-4281-b951-d872f2087c98

gcc 4.4.3 isn't very bright.

BUG=94925
TEST=none

Review URL: http://codereview.chromium.org/8890055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113757 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=bashi


Review URL: http://codereview.chromium.org/8889033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113755 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8890041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106777

Review URL: http://codereview.chromium.org/8890016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113753 0039d316-1c4b-4281-b951-d872f2087c98

base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8889024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113752 0039d316-1c4b-4281-b951-d872f2087c98