GitLab

This reverts commit 11079a47.

Revert "Fix build after code changed from underneath."

This reverts commit 93b43a2c.

Revert "Moar build fix."

This reverts commit bf84b576.

Revert "Fix the fix."

This reverts commit 4aecf275.

R=csilv@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8937011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114276 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106932
TEST=Manual

Review URL: http://codereview.chromium.org/8885030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105773
TEST=no fuzzy favicons, bug 107269 does not occur

Review URL: http://codereview.chromium.org/8921035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114273 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8938009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8933015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114271 0039d316-1c4b-4281-b951-d872f2087c98

Add an EncryptIfDifferent method that only encrypts something if the underlying
unencrypted data is either different or encrypted with an old key. Modify sync
encryption code to use this method instead of their own difference checks.

Because of this change, we also now always ensure the nigori has the full set of
encryption keys during any SetPassphrase call

BUG=107297
TEST=sync_unit_tests, cryptographer's unit_tests

Review URL: http://codereview.chromium.org/8759019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8907022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114268 0039d316-1c4b-4281-b951-d872f2087c98

Options2 is a copy of the resources for and implementation of chrome://settings that will be pared down significantly for UberPage (see bug).

BUG=100885
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8895023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114267 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=

Review URL: http://codereview.chromium.org/8822017

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8898028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114265 0039d316-1c4b-4281-b951-d872f2087c98

Making profile avatars and names sync. This is done by moving these two properties into profile preferences and making them syncable. The profile observes changes to these prefs and pushes them to the profile info cache.

The initialization of these prefs and of the info cache is done in two steps. First, the profile prefs are setup with values generated by the profile info cache. This causes the profile to try to push the changed values to the info cache, but since the profile isn't in the cache, it fails 


BUG=87658
TEST=ProfileManagerTest.InitProfileUserPrefs, Have two machines with chrome, both with multiple profiles and each with one profile signed in to the same account. Change avatar/name on one, and it will change on the other.

Review URL: http://codereview.chromium.org/8883030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114263 0039d316-1c4b-4281-b951-d872f2087c98

never allowed to use these ports anyways, this wasn't a
security issue, but just doesn't seem like a good idea.

BUG=93326

Review URL: http://codereview.chromium.org/8898008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://bugs.webkit.org/show_bug.cgi?id=74290
TEST=chrome --enable-threaded-compositing


Review URL: http://codereview.chromium.org/8912002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114260 0039d316-1c4b-4281-b951-d872f2087c98

This application icon index values are being changed from ints to StringOrdinals to decrease the potential number of syncs required when icons are moved, by only needing to change 1 StringOrdinal instead of all the integers.


BUG=61447
TEST=Open up an instance of chromium with multiple application icons and ensure
that icons can still have their page and order changed. There should be no
behaviour change.


Review URL: http://codereview.chromium.org/8198003

TBR=csharp@chromium.org
Review URL: http://codereview.chromium.org/8898027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114257 0039d316-1c4b-4281-b951-d872f2087c98

... Convert copy-and-pasted unit tests into TYPED_TESTs."

This reverts commit 20543ba5.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114255 0039d316-1c4b-4281-b951-d872f2087c98

We are suspecting this has side effects on official builds.

If so, this is a configuration error. Trying out to be sure.

TBR=timurrrr@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8898023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114251 0039d316-1c4b-4281-b951-d872f2087c98

Exclude extension unpacking since it accesses the FS.

BUG=93109
TEST=Install an extension from the Web Store.


Review URL: http://codereview.chromium.org/8921023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114248 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r113922.

Win Canary has been failing to link due to OOM since the weekend.  While this was not the original cause, it might be making things worse.  Speculatively remove for now.

Also changes render_widge_host_view to use Owned() instead of Passed().

BUG=none
TEST=existing.

Review URL: http://codereview.chromium.org/8931008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114247 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit bae6675d.

TBR=piman@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8931009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114245 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114244 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erik.corry

Review URL: http://codereview.chromium.org/8935003

TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/8907020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114243 0039d316-1c4b-4281-b951-d872f2087c98

Extract common code from StringPiece and StringPiece16 into a templated base class. Convert copy-and-pasted unit tests into TYPED_TESTs.

The motivation is that I wish to add constructors for string::iterator ranges and I don't want to do it twice.

The motivation for adding the string::iterator range constructors is to reduce the number of overloads in string_number_conversions.h .

BUG=87634
TEST=

Review URL: http://codereview.chromium.org/8659047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114242 0039d316-1c4b-4281-b951-d872f2087c98

edit link steals focus from menu item which hides edit link button in focus-out-event handler, so, it misses the click event.

BUG=107348
TEST=As described in the bug.

Review URL: http://codereview.chromium.org/8933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114241 0039d316-1c4b-4281-b951-d872f2087c98

Removing plugin data is different to removing only LSO data. Moreover, we call
out to content::PluginDataRemover to do the work: we should have an external
name here that's consistent.

This CL's tests depend on http://codereview.chromium.org/8907015/ 
landing. It shouldn't be landed until that patch is approved. 

BUG=107355
TEST=

Review URL: http://codereview.chromium.org/8907018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8895023

TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8930012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114239 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the problem of the Me2Me process being stopped when running as a
shell background job.

BUG=106935
TEST=Follow repro steps

Review URL: http://codereview.chromium.org/8899011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8895023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114236 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
TBR=ben@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8938005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105900
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8934007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114232 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r114228.

BUG=none
TEST=none
TBR=acolwell

Review URL: http://codereview.chromium.org/8929008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114230 0039d316-1c4b-4281-b951-d872f2087c98

[Karen Grunberg requested a speculative revert, because
we are currently unable to complete a link of the canary.
This change is working fine on the Dev branch, and did
not impact the link over the weekend, but for lack of
other items, this change is being reverted]


This code should only have much of an impact on the XP
platform, where thread teardown notification are not
currently made.

Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.

This fallback is ONLY used if there are no notifications
coming via the linker list. This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.

It is a minimal change, suitable for pushing to other
channels (beta? stable?).

r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8836003

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8934006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114229 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Redo r113722 - Add Pass(), which implements move semantics, to scoped_ptr, scoped_array...."

This reverts commit r113922.

Win Canary has been failing to link due to OOM since the weekend.  While this was not the original cause, it might be making things worse.  Speculatively remove for now.

BUG=none
TEST=none
TBR=kareng

Review URL: http://codereview.chromium.org/8932006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114228 0039d316-1c4b-4281-b951-d872f2087c98

Not the final UI yet.
Additional improvements:
- file name is selected in save-as dialog at start;
- new folder moved to context menu, button deleted.

BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113804

Review URL: http://codereview.chromium.org/8554003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114227 0039d316-1c4b-4281-b951-d872f2087c98

After BrowsingDataRemover removes browsing data, it now triggers a
chrome::NOTIFICATION_BROWSING_DATA_REMOVED, which uses the profile
in which data was removed as it's |source|, and a struct containing the
beginning of the removal's timeframe, and the removal mask
(BrowsingDataRemover::NotificationDetail) as it's |details|.

BUG=107202
TEST=BrowsingDataRemover unit tests.


Review URL: http://codereview.chromium.org/8907015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96010
TEST=Ran Release unit_tests BrowserAboutHandlerTest.WillHandleBrowserAboutURL and confirmed suppression is used and no errors reported; confirmed in Debug by hand with build that disables the DCHECK that kills child before this error is hit

Review URL: http://codereview.chromium.org/8935005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114224 0039d316-1c4b-4281-b951-d872f2087c98

We should wait for signal connection, for each signal.
Otherwise, 2nd call to OnConnected() may quit the message
loop instead of OnTestSignal().

FWIW, the flakiness was introduced in crrev.com/111423

BUG=106796,107301
TEST=confirm the test no longer fails by: while true; do out/Release/dbus_unittests --gtest_filter=EndToEndAsyncTest.TestSignal || break ; done


Review URL: http://codereview.chromium.org/8907010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=compile


Review URL: http://codereview.chromium.org/8912008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107172
TEST=none
R=ben@chromium.org,avi@chromium.org

Review URL: http://codereview.chromium.org/8921032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114221 0039d316-1c4b-4281-b951-d872f2087c98

[ Re-land of 114076 http://codereview.chromium.org/8899015 ]

This code was platform independent so could just be copied over into the
platform independent file with no changes.
Review URL: http://codereview.chromium.org/8927001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114220 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=cbentzel@chromium.org


Review URL: http://codereview.chromium.org/8929002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114219 0039d316-1c4b-4281-b951-d872f2087c98

JavaBridgeDispatcherHost must be ref-counted because it is used with
base::Bind. http://codereview.chromium.org/8834013 changed
JavaBridgeDispatcherHost to also inherit from RenderViewHostObserver. The base
implementation of RenderViewHostObserver::RenderViewHostDestroyed() deletes the
object. This is unwanted in this class, so we provide an empy implementation of
the method.


Review URL: http://codereview.chromium.org/8929005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114218 0039d316-1c4b-4281-b951-d872f2087c98