- 31 Aug, 2018 11 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eabc276ceacd..01bd09d56fbd git log eabc276ceacd..01bd09d56fbd --date=short --no-merges --format='%ad %ae %s' 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-30 nodir@google.com [bot_update] Fix initialization from buildbucket 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@01bd09d56fbd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161 TBR=agable@chromium.org Change-Id: I6abb911ab1aa454dcd6d86d4fd60990c9333caad Reviewed-on: https://chromium-review.googlesource.com/1198123Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587873}
-
Giovanni Ortuño Urquidi authored
UninstallApps adds uninstallation tasks to the queue of tasks and uninstalls the corresponding extension for the provided URL. Bug: 876174 Change-Id: Id79adb12a0999332aaec830acb48eadbf62b2abb Reviewed-on: https://chromium-review.googlesource.com/1196782 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#587872}
-
Istiaque Ahmed authored
The param was always passed with nullptr value, so remove it entirely. Bug: None Test: None, test cleanup. Change-Id: If8cd3c4c7e0bd77fabbc545dcbd5fda69a9c0703 Reviewed-on: https://chromium-review.googlesource.com/1196143Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587871}
-
Aaron Leventhal authored
Invalidate the object when aria-haspopup changes. Explanation: The cached native_role_ value, which is computed from NativeAccessibilityRoleIgnoringAria(), must not return a different result depending on whether aria-haspopup changes before/after the caching. This affects CanHaveChildren() for a button that changes its aria-haspopup value. This in turn affects many other things for the button, such such as aria-activedescendant computation. Bug: 879032 Change-Id: I2b929623f7dfbc0ba926088add4d747af1f77ef7 Reviewed-on: https://chromium-review.googlesource.com/1196864 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#587870}
-
Miguel Casas authored
This CL moves V4L2SliceVDA to use DecodeSurfaceHandler interface. This needs moving the inner V4L2DecodeSurface out of V4L2VDA, which causes a ripple of mechanic substitutions in the .cc file. Note that the inner classes still have the * to V4L2VDA because other methods are needed in addition to the interface. Partial diagram before: https://goo.gl/LBxH3h, after: https://goo.gl/E6sDrc. Bug: 875005 Test: v_d_a_unittests and simplechrome on kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibed94b8763e02ffbfef3b5137684306761e5d748 Reviewed-on: https://chromium-review.googlesource.com/1178667Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#587869}
-
Anne Lim authored
Removing implementation for "Send first six digits of PAN when determining whether to offer to save". The original plan to avoid offering to save credit cards when Payments cannot support the given card type by sending first six digits of PAN has been abandoned in favor of somehow doing it entirely client-side in the future. Change-Id: I3e95293626d11a07dedb80bd6b5013149cb2dfbc Reviewed-on: https://chromium-review.googlesource.com/1188587 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#587868}
-
Raymond Toy authored
Implements AudioContextManager mojo interface that can be obtained from a frame so that audible playback from WebAudio can be recorded by the browser. Whenever audible playback starts or stops, a message is sent to the browser indicating such. Bug: 855069 Change-Id: Ib236a9506a2a6d9b53e95948eb5519145805a2cb Reviewed-on: https://chromium-review.googlesource.com/1114147Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587867}
-
Yao Xiao authored
Change-Id: I0deb1e45f2e76ac887e9a03d6e48d151211b1c97 Reviewed-on: https://chromium-review.googlesource.com/1191726 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#587866}
-
Matt Falkenhagen authored
It can be used for both network service enabled and disabled. The factory also can't be sent to the renderer. Change-Id: I443179fbb5dcb9e1325614e5bc04bf8fe20db2d9 Reviewed-on: https://chromium-review.googlesource.com/1195296Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#587865}
-
Stephen McGruer authored
The bot currently times out on webkit_layout_tests. I noticed that most other bots use 'chromium_webkit_isolated_scripts' rather than 'webkit_layout_tests_isolated_scripts'. The former has a swarming size argument of 12, whilst the latter has none (and thus seems to use a swarm of size 1). Hopefully switching to 'chromium_webkit_isolated_scripts' will enable the bot to finish the tests. Bug: 876029 Change-Id: I35c77992b28e5a108bee65c1ea91bb39d66c9bd2 Reviewed-on: https://chromium-review.googlesource.com/1197267Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587864}
-
Jeffrey Kardatzke authored
This receives MIME type information from Crostini and uses that as a secondary lookup technique for file associations. This information is only referenced when a file has been detected to have one of the default MIME types of either text/plain or application/octet-stream. This is stored in a new preferences location as well with a unit test for that. Bug: 869747 Test: Verified Open With associations on eve, unit tests pass Change-Id: Ie631ae609b04c72e37c205e6d5c214816ba47563 Reviewed-on: https://chromium-review.googlesource.com/1195045 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#587863}
-
- 30 Aug, 2018 29 commits
-
-
Scott Chen authored
A bug occured when searching through settings page, because one of the controls associated with the "edit person" subpage does not exist if DICE is enabled. This CL points it to a different control when DICE is enabled. Bug: 876280 Change-Id: I24049100f2b2357ada85b07a44c893a39fd1b66b Reviewed-on: https://chromium-review.googlesource.com/1198006 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#587862}
-
Sam McNally authored
Bug: 844298 Change-Id: I318dbeab7f0badd6d2cf06d22ddf197d590662af Reviewed-on: https://chromium-review.googlesource.com/1196286Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#587861}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7a770735549a..cd6bcbe53ba7 git log 7a770735549a..cd6bcbe53ba7 --date=short --no-merges --format='%ad %ae %s' 2018-08-30 benjhayden@chromium.org Make SparseDiagnostic.GetMostRecentDataByNamesAsync more tolerant. Created with: gclient setdep -r src/third_party/catapult@cd6bcbe53ba7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877809 TBR=sullivan@chromium.org Change-Id: Iaeb976d7508515e648353c3b77fdc6c078098bee Reviewed-on: https://chromium-review.googlesource.com/1198122Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587860}
-
Bailey Berro authored
- Updates the CrSearchableDropDown element to support the autofocus property. Bug: chromium:757625 Change-Id: I2df07bd7dde0a22a7b724c2bd9132c7df321a5fb Reviewed-on: https://chromium-review.googlesource.com/1196017Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#587859}
-
Will Harris authored
The old name for this was 'no_size_t_to_int_warning' which was specific to MSVC. clang does not have a specific warning for just 64-bit size_t -> 32-bit value, but instead it has a warning for any conversion from 64-bit to 32-bit (-Wshorten-64-to-32). As part of re-enabling this warning, fixes will be landed to get Chromium warning-clean with -Wshorten-64-to-32 on 64-bit builds only (as tackling for 32-bit builds too, which was never covered by any previous MSVC warning would be too big a first step). For those projects that are e.g. third party or can be tackled at a later date, they can include this new config. The name is different from 'no_size_t_to_int_warning' because that name is confusing (as the new warning enables more than just this). New exceptions will be added with 'no_shorten_64_warnings' and old 'no_size_t_to_int_warning' will be slowly removed or migrated over time. Then the old config will be removed. BUG=588506 Change-Id: I3a6ce9b19e52c7bdc724c7fd326f6afe7b509219 Reviewed-on: https://chromium-review.googlesource.com/1197404 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587858}
-
Anand K. Mistry authored
Within MTPDeviceDelegateImplLinux::ReadDirectoryInternal, the call to PendingRequestDone at the end of the function allowed for another task to run and potentially delete the file_id from the cache prior to the directory listing being done. This would then cause a nullptr dereference in OnDidReadDirectory which expects the cache entry to exist. Since ReadDirectoryInternal is only run from a task, just continue the task instead of posting it to the request queue. BUG=817523 Change-Id: I9df651864ba1ef3c26365832b149871b027f99d5 Reviewed-on: https://chromium-review.googlesource.com/1195202Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#587857}
-
Justin Cohen authored
Bug: 856516 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I52bee9bcd13d835eab5592bee12c48b95c25c233 Reviewed-on: https://chromium-review.googlesource.com/1197923Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587856}
-
David Quiroz Marin authored
Our current implementation of canvas textBaseline alignment for top middle and bottom doesn't do what the spec says it should, i.e. align with the EM square. https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-textbaseline This has been a bug on FF side for quite some years: https://bugzilla.mozilla.org/show_bug.cgi?id=737852 This change fixes this misalignment by using the EM square ascent and descent from SimpleFontData instead of the font's max ascent/descent. Also fixing the EM related metrics in canvas TextMetrics. Bug:607053,277215 Change-Id: Id6374e6fcd4e46fa989a7e23a80dc1f5bf961b94 Reviewed-on: https://chromium-review.googlesource.com/1194494 Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587855}
-
Fabio Tirelo authored
Bug: 879342 Change-Id: Ic2451cdbaa221f0dcd844c29ed8b732d68dc7d76 Reviewed-on: https://chromium-review.googlesource.com/1197360 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587854}
-
Philip Rogers authored
This patch cleans up the expectations file for blink-gen-property-trees and starts running more tests. Bug: 836886 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a6252bfa6a1fa5fb3ca8f5c4cc6d01ad7eec8e5 Reviewed-on: https://chromium-review.googlesource.com/1196906Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587853}
-
Mohsen Izadi authored
Now that viz::mojom::GpuHost implementation has moved out of content, viz::GpuClient can directly call on that to establish a gpu channel and we can remove the functionality from GpuClientDelegate. BUG=709332 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ied5a8ead810973068190e3ce485609f68f5826d5 Reviewed-on: https://chromium-review.googlesource.com/1188883 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#587852}
-
khmel@google.com authored
This fix crash when App Launcher is opened next time and having results for Answer Cards from the previous opening. This cleans search result on App Launcher close and adds extra protection to prevent handling views in Answer Cards not attached to the app list view. TEST=Manually, no crash, no error reported BUG=878987 Change-Id: I06fb0d8898161228b95a9001d2dc9b79690fe0c5 Reviewed-on: https://chromium-review.googlesource.com/1197328 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#587851}
-
khmel@google.com authored
This is required for cheets_AuthPerf test that waits until Play Store window is shown. Before we used implicit check that some property file was created. That was bit flaky due background nature of creating this file and did not work on all platforms. This CL introduces explicit way by checking if app is actually shown on Chrome. BUG=b:110060284 TEST=cheets_AuthPerf passes for Scarlet (where was failing before) + few other boards. Change-Id: Ia372b4939853a1c99fdd70a68079e080e14111c3 Reviewed-on: https://chromium-review.googlesource.com/1194735 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#587850}
-
Manu Cornet authored
See what it looks like in comment #15 of the linked bug. Bug: 874161 Change-Id: I42a81c93742fb68720e237e34e2b66b68b3e9de5 Reviewed-on: https://chromium-review.googlesource.com/1197730 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#587849}
-
Ryan Hamilton authored
Change-Id: I307c05133fc9188997cd010ce8dd1dcf0657835c Reviewed-on: https://chromium-review.googlesource.com/1197784 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#587848}
-
Istiaque Ahmed authored
Bug: None Test: None, internal only cleanup. Change-Id: I5e29e662450c6b7a5ee14d332caa1d76ea14b7b1 Reviewed-on: https://chromium-review.googlesource.com/1144538Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587847}
-
Kurt Horimoto authored
This CL increases kLongDownloadTimeout from 25 to 35 seconds in order to reduce flake caued by long download times on iOS 11. Bug: 879344 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic26dbb5ca96129e0696db4e9343fedf2a7a81b59 Reviewed-on: https://chromium-review.googlesource.com/1197762Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#587846}
-
James Wallace-Lee authored
This is a reland of a6f6697e The test, GetAccessibleTabModalDialogTitle, failed on OSX because tab-modal dialogs are treated as native windows in Voiceover. This fix is unnecessary on OSX so the test is now disabled there. Original change's description: > Tab modal dialog title should be accessible window title > > Tab modal dialogs (ui::MODAL_TYPE_CHILD) should report their title > to AT (insert+T on JAWS and NVDA) when active. To accomplish this, > BrowserView::GetAccessibleWindowTitle should report the title of > the dialog when one is active. > > Bug: 775680 > Test: browser_tests.exe --gtest_filter=BrowserViewTest.GetAccessibleTabModalDialogTitle > Change-Id: Ie693e1627c87e4d97eede64381d80dab31635642 > Reviewed-on: https://chromium-review.googlesource.com/1184039 > Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587371} Bug: 775680, 879074, 879253 Change-Id: I4351a6487a4cb582383fe18b97e825a986464f59 Reviewed-on: https://chromium-review.googlesource.com/1197333Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#587845}
-
Evan Stade authored
Test: browser_tests Bug: none Change-Id: I2f4841af05d1ca2b0ea3ad686e8e1b322549b3d2 Reviewed-on: https://chromium-review.googlesource.com/1197903Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#587844}
-
Tom Anderson authored
BUG=874341 R=sky Change-Id: I996a9f57e569acb62eec7e27f8ae0015b92d0ceb Reviewed-on: https://chromium-review.googlesource.com/1196932Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#587843}
-
Matt Menke authored
Previously, there was no way for a consumer to distinguish a graceful socket close from the data pipe being closed for something other than a network error (Network Service crash, NetworkContext shutdown, etc). Bug: 878136 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibf0f1bbe0603a5db2d40945b12d59f243e7e34e9 Reviewed-on: https://chromium-review.googlesource.com/1196964Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587842}
-
Weilun Shi authored
After experiment, the hover state on dark/image of the gear icon should be lighter instead of darker to make it visible. Also change the active state setting for gear icon on dark/image Bug: 867768 Change-Id: I1b993297788ed6145ac7a32acfd85b766bd67999 Reviewed-on: https://chromium-review.googlesource.com/1197410Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#587841}
-
Bailey Berro authored
- Use more descriptive error message than the generic failure message when failing to mount an SMB share because it is SMB1, which is unsupported. Bug: chromium:757625 Change-Id: I8293ce065293172cd3faacab7fac304908069f09 Reviewed-on: https://chromium-review.googlesource.com/1196009 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#587840}
-
Joshua Bell authored
The Storage API [1] defines the "persistent-storage" string to allow querying the state of the permission. Plug this into the Permission API [2] implementation and add a web platform test. [1] https://storage.spec.whatwg.org/ [2] https://w3c.github.io/permissions Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/FRAmGlAoDTY/discussion ChromeStatus: https://www.chromestatus.com/feature/4770049554382848 Bug: 878525 Change-Id: Ia12fb43676e04e7e60ad58b5ffbd7ee22f78ffc4 Reviewed-on: https://chromium-review.googlesource.com/1194106 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#587839}
-
Matthew Jones authored
This patch delegates the task of reporting context to GSA to Contextual Search. This is being done in preparation to make the ContextualSearchObserver package protected since its use is extremely feature specific. Bug: 878006 Change-Id: I340a6196210a4709cebef03e477e241be1633bb4 Reviewed-on: https://chromium-review.googlesource.com/1198003Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#587838}
-
Max Moroz authored
TBR=inferno@chromium.org,liaoyuke@chromium.org Bug: 879389 Change-Id: I74ab663e1b7e69457d6f81cfa6890422610f4c9a Reviewed-on: https://chromium-review.googlesource.com/1197829 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#587837}
-
Farah Charab authored
Records the number of resource loading tasks split by priority. Recorded each time a task is executed. Bug: 870349 Change-Id: Ic643cf1c5a578017c5cc8a78471c3ea7ebfc617d Reviewed-on: https://chromium-review.googlesource.com/1185199 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587836}
-
kristipark authored
The property is used to determine if we need to show the "Restore default shortcuts" option. Previously this was calculated by checking the tile source of the most visited items, but this did not account for the case where there are no available items. As such, if there were no custom links, the restore default option was disabled. Bug: 879082 Change-Id: Ia15f4fc863642b520234c061ee5ecf6f7a54c50e Reviewed-on: https://chromium-review.googlesource.com/1197465 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#587835}
-
Weilun Shi authored
Clicking on the same custom background image tile should be considered as unselecting the tile. Therefore, the done button should not be clickable after that. Bug: 879002 Change-Id: I2396660dec1a10d2a4acd05e8d80672db8072a3c Reviewed-on: https://chromium-review.googlesource.com/1197463 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#587834}
-