GitLab

The HTTP header parser in Blink forbids empty header values which should
be allowed. This CL fix the issue.

BUG=380075
R=tyoshino@chromium.org

Review URL: https://codereview.chromium.org/318613002

git-svn-id: svn://svn.chromium.org/blink/trunk@175532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/313053008

git-svn-id: svn://svn.chromium.org/blink/trunk@175531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With (for instance) a to-animation, the frozen element will for instance
provide the 'underlying value' to any following element.

BUG=374793

Review URL: https://codereview.chromium.org/316013003

git-svn-id: svn://svn.chromium.org/blink/trunk@175530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/311193007

git-svn-id: svn://svn.chromium.org/blink/trunk@175529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The 'HitTestChildBlockBackground' hit test action needs to be considered
as well when detecting hits on the SVG root container itself.

BUG=379299

Review URL: https://codereview.chromium.org/318663002

git-svn-id: svn://svn.chromium.org/blink/trunk@175528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

updateRequestForAccessControl() updates ResourceRequest for access
control, but ResourceLoaderOptions passed to FetchRequest also contains
configuration items that must be updated for access control.

This CL removes cookie handling code and iframe from the following
layout tests since they're testing user:pass but not cookie.
- access-control-preflight-credential-async.html
- access-control-preflight-credential-sync.html

A new test is added to check that no cookie is set in a preflight
request. This new test uses third-party-cookie-relaxing-iframe.html
which was loaded by the two tests but was not actually used.

Missing testRunner.setAlwaysAcceptCookies() calls are added to
third-party-cookie-relaxing-iframe.html.

BUG=377541
R=japhet

Review URL: https://codereview.chromium.org/312653002

git-svn-id: svn://svn.chromium.org/blink/trunk@175527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current UI was racy and would output the last roll
and current roll in random order. This change fixes this
and puts the roll information to a new line, so that it
stands out from the bot information.

Review URL: https://codereview.chromium.org/314913002

git-svn-id: svn://svn.chromium.org/blink/trunk@175525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid calling slower Node::firstChild() / Node::lastChild() when possible by
using tighter typing. This way, we end up using ContainerNode::firstChild() /
ContainerNode::lastChild(), bypassing a useless isContainerNode() check.

R=eseidel@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/307243004

git-svn-id: svn://svn.chromium.org/blink/trunk@175524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make sure calling moveParagaph() with proper parameters in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary()

This patch changes CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary()
to calculate start and end positions of paragraph to move before calling
moveParagraph(), because inserting paragraph element at |upstream| can change
start and end positions represented by |VisiblePosition|.

This patch is similar to http://crrev.com/311593003, for
InsertListCommand::listifyParagraph().

BUG=325222, 351291
TEST=LayoutTests/editing/execCommand/apply-style-empty-paragraph-start-crash.html

Review URL: https://codereview.chromium.org/315513003

git-svn-id: svn://svn.chromium.org/blink/trunk@175523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- We need to update RefPtrs not in core/dom/ too because argument types of
  insertBefore/replaceChid/appendChild are changed.

- Member<T> should support implicit conversion to
  RawPtr<SuperClassOfT>.  This is necessary for code like:

    Member<HTMLFooElement> m_foo;
    ....
    parent->appendChild(m_foo);


BUG=357163

Review URL: https://codereview.chromium.org/313813002

git-svn-id: svn://svn.chromium.org/blink/trunk@175522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The value of this property will be null because it is not being set by
the embedder yet.

BUG=379012

Review URL: https://codereview.chromium.org/313553002

git-svn-id: svn://svn.chromium.org/blink/trunk@175520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The previous CL (r172433) was reverted because it caused regression.
This is second attempt to set referrer for css resource fetching.

- Add WebCore::Referrer (not String) object to CSSParserContext
- Pass the referrer to CSSImageValue, CSSImageSetValue, and CSSFontFaceSrcValue
- Set the referrer when fetching

BUG=380457,377864

Review URL: https://codereview.chromium.org/314893003

git-svn-id: svn://svn.chromium.org/blink/trunk@175519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Return early in SelectorChecker::checkOne() if selector.isAttributeSelector()
is true and the selector matched. Previously, we were only returning early if
the selector did not match and we were falling through if it did. This means
that we ended up doing the 2 if() checks below in the method unnecessarily:
- selector.m_match == CSSSelector::PseudoClass
- selector.m_match == CSSSelector::PseudoElement

Review URL: https://codereview.chromium.org/319513005

git-svn-id: svn://svn.chromium.org/blink/trunk@175518 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a regression that was accidentally introduced in r169669.
If autoplay is set, then loading should not be delayed even if preload
was set to "none".

BUG=372770, 378682
TEST=LayoutTests/media/autoplay-with-preload-none.html

Review URL: https://codereview.chromium.org/313963004

git-svn-id: svn://svn.chromium.org/blink/trunk@175517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

StyleImage::image can be used to get a cached image just like it can be
used to get a generated image. So we can just have one RefPtr and remove
the raw pointer, simplifiying the code immensely.

Review URL: https://codereview.chromium.org/316983003

git-svn-id: svn://svn.chromium.org/blink/trunk@175516 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL makes use of the new ReloadBypassingCache policy and removes the
setting of cache HTTP headers in blink.

BUG=376025

Review URL: https://codereview.chromium.org/318673002

git-svn-id: svn://svn.chromium.org/blink/trunk@175515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We want to be able to recognize tap events that the page has not handled and provide some useful default behavior for those events.  Currently taps are considered handled in many cases when they really have not been handled by the page or default behavior.  This CL is a beginning at correcting this.  We plan to also check if the tap interacted with an element with an ARIA role that indicates it was interactive.

BUG=355154

Review URL: https://codereview.chromium.org/267313008

git-svn-id: svn://svn.chromium.org/blink/trunk@175514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380054

Review URL: https://codereview.chromium.org/314783004

git-svn-id: svn://svn.chromium.org/blink/trunk@175513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
This change breaks:
org.chromium.android_webview.test.AwSettingsTest#testBlockNetworkImagesDoesNotBlockDataUrlImage

Probably because it pre-loads images when "automatically load images" is disabled on Android.

See
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/159696/steps/androidwebview_instrumentation_tests/logs/stdio

Original issue's description:
> Always preload all tokens before parsing
> 
> This change is in preparation for re-writing the path
> through which tokens are handled on the main thread
> to allow them to be batched and deferred until more
> important work is done:
> https://codereview.chromium.org/258013009/
> 
> Currently the threaded parser uses the main thread's
> MessageQueue as its work-queue and we'll commonly
> queue 10 chunks of work in the main thread MessageQueue
> even if the first chunk takes a long time we'll still have to
> process the next 9 before we can do more important things
> like put up a frame because we don't have a separate
> queue for parser work.  258013009 will fix that.
> 
> http/tests/security/script-crossorigin-loads-correctly-credentials-2.html
> originally started failing with this change and it
> turns out that always-preloading found a real bug
> in CORS handling with preloads. The ResourceFetcher
> was incorrectly always reusing an in-flight preload
> request, even if the CORS state didn't match. Nate
> helped me re-order the calls in requestResource to fix it.
> 
> This change also discovered 2 other bugs in the preloader.
> 1. a preload request != LinkPrefect request
> and one will cancel the other. crbug.com/379893
> 2. The preloader has no concept of script type and will
> blindly issue preloads for all <script href> regardless
> of <script type>.  I decided this didn't matter in practice.
> Making the <script type> handling threadsafe isn't
> worth the trouble.
> 
> I would anticipate that this change might make some
> speed-index scores better (we'll now be preloading
> all tokens slightly sooner, especially those
> which are in the same chunk as a long inline
> script block for instance), but may make non-network
> PLT scores lower (due to extra mallocs required
> to process every chunk since more loads will
> be preloaded just before their actually loaded).
> 
> BUG=356292
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175427

TBR=tonyg@chromium.org,japhet@chromium.org,eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356292

Review URL: https://codereview.chromium.org/317703005

git-svn-id: svn://svn.chromium.org/blink/trunk@175512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380588
TBR=ojan

Review URL: https://codereview.chromium.org/319503004

git-svn-id: svn://svn.chromium.org/blink/trunk@175510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change fast/text/decorations-transformed.html to use the Ahem font
instead of ahem as test-only side-loaded fonts are case sensetive on
Windows. Also fix similar issue in line-break-after-question-mark
test.

BUG=378610
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/316933003

git-svn-id: svn://svn.chromium.org/blink/trunk@175509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350571

Review URL: https://codereview.chromium.org/298093004

git-svn-id: svn://svn.chromium.org/blink/trunk@175508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following flakiness resulting from race conditions, I'm splitting the image-currentsrc
test into 3 separate layout tests.

BUG=380664

Review URL: https://codereview.chromium.org/317723003

git-svn-id: svn://svn.chromium.org/blink/trunk@175507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

patch 3 of 4 to specify the deviceSource of a desired fling animation
request via enum throughout Blink and Chromium.

BUG=343327

Review URL: https://codereview.chromium.org/304823002

git-svn-id: svn://svn.chromium.org/blink/trunk@175506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that frames always have a layer and get their self-painting
bit updated whenever m_compositing changes, we don't need to
do a layer update when they get composited. Instead we just
need to mark the frame in the owner page as needing a compositing
update.

This removes one of the needs for applyUpdateLayerCompositingStateChickenEggHacks.

BUG=379097

Review URL: https://codereview.chromium.org/302093002

git-svn-id: svn://svn.chromium.org/blink/trunk@175505 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now function ensureTextFinder is used to create TextFinder object if it doesn't exists.

BUG=359983

Review URL: https://codereview.chromium.org/229043004

git-svn-id: svn://svn.chromium.org/blink/trunk@175504 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should duplicate the devtools resources, with the exception of the "debug" build of devtools.

R=apavlov@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/302093008

git-svn-id: svn://svn.chromium.org/blink/trunk@175501 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The change to no longer pixel snap for ellipsis (r175434) fixed two ref
tests failures on Win7 with DirectWrite. Remove the failing expectation
for those tests accordingly.

TBR=leviw@chromium.org
BUG=378489

Review URL: https://codereview.chromium.org/311153002

git-svn-id: svn://svn.chromium.org/blink/trunk@175500 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This matches Firefox's behavior.

Review URL: https://codereview.chromium.org/302283002

git-svn-id: svn://svn.chromium.org/blink/trunk@175498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/319453002

git-svn-id: svn://svn.chromium.org/blink/trunk@175497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The "root" translation layer was previously below the overlap controls
host layer. This meant it was actually below the pinch viewport's scale
layer. We really want the root translation layer to be at the root so that
DevTools' screen emulation feature can scale and offset the entire tree.

BUG=370035

Review URL: https://codereview.chromium.org/308183002

git-svn-id: svn://svn.chromium.org/blink/trunk@175496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dglazkov@chromium.org
BUG=378610

Review URL: https://codereview.chromium.org/313903002

git-svn-id: svn://svn.chromium.org/blink/trunk@175494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test crashes because the createFlingAnimationCurve call hits the int version in Platform.h which is no longer matching the signature in content/test/test_webkit_platform_support.h (and content/child/blink_platform_impl.h). Instead it hits the default one in Platform.h which just returns 0.
Subsequently the WebActiveGestureAnimation calls through the null pointer in WebActiveGestureAnimation::animate.

TBR=rjkroege@chromium.org, jam@chromium.org, ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/310413002

git-svn-id: svn://svn.chromium.org/blink/trunk@175493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL refactors the FrameView methods to be paintInvalidation instead
of repaint.

I have left the repaint rect output to be 'repaint' for now as that
seems like a large and scary rebaseline when it lands.

I also did not change the slowRepaints methods as they were previously
mentioned as not having to do with paint invalidation.

BUG=338691

Review URL: https://codereview.chromium.org/306413002

git-svn-id: svn://svn.chromium.org/blink/trunk@175492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It helps to troubleshoot messages traffic between DevTools and the inspected page.

BUG=

Review URL: https://codereview.chromium.org/316813003

git-svn-id: svn://svn.chromium.org/blink/trunk@175491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/313023002

git-svn-id: svn://svn.chromium.org/blink/trunk@175490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we run sanitizers like ASAN and LSAN, we typically don't care about whether the tests run exactly like they do normally; we are just looking for errors that the sanitizers have detected.

This flag changes run-webkit-tests to ignore text and image failures and just look for crashes and timeouts (most crashes will be sanitizer-triggered).

In theory most of the time the tests *should* run the same way, but in practice we see a lot of noise that no one has the time to deal with, so this change should reduce a lot of the redness we see on the bots.

BUG=336971, 374043

Review URL: https://codereview.chromium.org/294973008

git-svn-id: svn://svn.chromium.org/blink/trunk@175488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit r174963.
Reason for revert: the patch regressed ::content selectors for distributed
nodes in shadow DOM.

BUG=380414,356999
TBR=vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/311123002

git-svn-id: svn://svn.chromium.org/blink/trunk@175487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The specification for ready is here:
https://github.com/slightlyoff/ServiceWorker/issues/223

ready is a convenience that lets the page talk to an installed
ServiceWorker, without having to track the details of whether that
Service Worker is controlling the page, or merely installed but
waiting for the page to reload.

This implements the trivial ready case, where the page is
controlled by a Service Worker and ready can produce that one
immediately.

BUG=363967

Review URL: https://codereview.chromium.org/309233002

git-svn-id: svn://svn.chromium.org/blink/trunk@175486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the specialized code for tracking wheel events in favor of the
generic EventHandlerRegistry. Covered by existing tests.

See https://codereview.chromium.org/206603002/ for full review history.

BUG=359566,332793
TEST=fast/events/wheelevent-handler-count.html

Review URL: https://codereview.chromium.org/225823007

git-svn-id: svn://svn.chromium.org/blink/trunk@175485 bbb929c8-8fbe-4397-9dbb-9b2b20218538