GitLab

Don't run StatusTrayWinTest.ClickOnIcon on bots since it fails on them. It does pass locally though.

BUG=156370
Review URL: https://codereview.chromium.org/11198033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162428 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162424 0039d316-1c4b-4281-b951-d872f2087c98

Try bots: https://codereview.chromium.org/11191023

TBR=danakj

Review URL: https://codereview.chromium.org/11196010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162423 0039d316-1c4b-4281-b951-d872f2087c98

Show number of uknown instrumented objects on a single graph for all test sites. No need to show each graph separately as our final goal is to make all of them flat zeros.


BUG=None
TBR=dennisjeffrey

Review URL: https://chromiumcodereview.appspot.com/11188036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org,nkostylev@chromium.org
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/11201002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162420 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately, the prerender histograms mechanism for determining origin was basically a global variable; when multiple prerenders can be in flight at the same time, this doesn't work so well.

To fix this, track the origin of prerenders in the PrerenderData and in the structure keeping track of prerendered web_contents, and pass explicit origins in for histogram recording.

The "wash" determination still uses the window, which is the same as the TTL, and so it's passed in at initialization rather than being another constant in prerender_histograms.cc.


BUG=None


Review URL: https://chromiumcodereview.appspot.com/11028037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155501
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11149009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162416 0039d316-1c4b-4281-b951-d872f2087c98

According to comment to HttpStream::ReadResponseBody() 0 means end of response
while HttpResponseBodyDrainer treated it as error.

BUG=154712
TEST=net_unittests


Review URL: https://chromiumcodereview.appspot.com/11112021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162415 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11198019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162414 0039d316-1c4b-4281-b951-d872f2087c98

We should use DCHECK_EQ whenever possible.

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/11148007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162413 0039d316-1c4b-4281-b951-d872f2087c98

When app windows are maximized the normal window frame is replaced with a
special AppNonClientFrameViewAura. This adds a test for frame replacement
on maximize, restore and minimize.

BUG=156093
TEST=added test to browser_test AppNonClientFrameViewAuraTest


Review URL: https://chromiumcodereview.appspot.com/11192004

TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/11191028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162412 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/10912173/ constructs the DownloadFile, and
thus the BaseFile, on the UI thread and then passes it to the FILE thread.
DownloadFile / BaseFile may be constructed with a FileStream to which to 
write the download.  The FileStream cannot be passed by linked_ptr<> in this
case, as that is not thread safe. 

BUG=123998
R=benjhayden@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11028131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162411 0039d316-1c4b-4281-b951-d872f2087c98

The android gyp backend has been updated to introduce an
"android_unmangled_name" target option, which allows the backend to skip
mangling the name of designated targets. Turn this on for libwebview in
order that it's generated as libwebview.so instead of
lib_android_webview_libwebview_gyp.so which was rather confusing.

BUG=

Review URL: https://codereview.chromium.org/11198030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162410 0039d316-1c4b-4281-b951-d872f2087c98

BUG=145875


Review URL: https://chromiumcodereview.appspot.com/11147009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=no visible change


Review URL: https://chromiumcodereview.appspot.com/11189026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162408 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a 'CreateNaClPluginModule' method to the content/renderer API, and
to PepperPluginDelegateImpl, which implements it.
BUG=116317
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11140046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162407 0039d316-1c4b-4281-b951-d872f2087c98

###
Reason:
52>system\chromeos\tray_display.cc(56): error C2039: 'output_configurator' : is not a member of 'ash::Shell'
52>          ..\ash/shell.h(116) : see declaration of 'ash::Shell'
52>system\chromeos\tray_display.cc(56): error C2227: left of '->output_state' must point to class/struct/union/generic type
52>system\chromeos\tray_display.cc(122): error C2039: 'output_configurator' : is not a member of 'ash::Shell'
52>          ..\ash/shell.h(116) : see declaration of 'ash::Shell'
52>system\chromeos\tray_display.cc(122): error C2227: left of '->AddObserver' must point to class/struct/union/generic type
52>system\chromeos\tray_display.cc(127): error C2039: 'output_configurator' : is not a member of 'ash::Shell'
52>          ..\ash/shell.h(116) : see declaration of 'ash::Shell'
52>system\chromeos\tray_display.cc(127): error C2227: left of '->RemoveObserver' must point to class/struct/union/generic type
###

Also adds DEPS to keep chromeos dependencies out of ash/system

This is part of an effort to move chromeos network management code from src/chrome/ to src/chromeos.

BUG=154856

Review URL: https://chromiumcodereview.appspot.com/11039034

TBR=stevenjb@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162406 0039d316-1c4b-4281-b951-d872f2087c98

The WebView needs a bunch of Java code from the Chromium tree
(contentview and its dependencies) in order to build. Introduce an
Android build system makefile into android_webview which builds a
suitable static java library.

R=benm@chromium.org
BUG=

Review URL: https://codereview.chromium.org/11185025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162404 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=no visible change


Review URL: https://chromiumcodereview.appspot.com/11193017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156165
TEST=Open the media galleries config dialog with a test extension and close the window with the config dialog open.  The browser should not crash.


Review URL: https://chromiumcodereview.appspot.com/11196007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162402 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162401 0039d316-1c4b-4281-b951-d872f2087c98

GVD should release its references to textures when it Destroy()s VDA or
when it is deleted. It's safe to do so, as the VDAs should keep their own
references to those textures if they are still using them (normally
achieved via binding them to XPixmaps or EGLImages).

BUG=156251
TEST=manual playbacks, refreshes, tab closes, etc.


Review URL: https://chromiumcodereview.appspot.com/11189027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11193012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162399 0039d316-1c4b-4281-b951-d872f2087c98

This updates NSS to 3.14 pre-release snapshot 2012-09-25, along with
https://bugzilla.mozilla.org/show_bug.cgi?id=795213 to fix a warning.

R=wtc
BUG=153281, 151692, 151927
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11040061

Review URL: https://chromiumcodereview.appspot.com/11143026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162398 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/11140040 adds the event's
-description as a breakpad key.  Unfortunately, event type 28, which
is undocumented, is sent by Mountain Lion when you do a control-scroll
zoom.  Work around it manually.

BUG=154483,156103


Review URL: https://chromiumcodereview.appspot.com/11198008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162397 0039d316-1c4b-4281-b951-d872f2087c98

ShouldOverrideLoading and ShouldIgnoreNavigation was upstreamed for
Chrome on Android to implement the URL overriding feature, however,
we are planning to implement this in a different way (by means
of network request throttle).

BUG=156044


Review URL: https://chromiumcodereview.appspot.com/11194004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162396 0039d316-1c4b-4281-b951-d872f2087c98

Suppress the Startup.BrowserWindowDisplay metric when the Windows 8 first-run default browser dialog is shown.

BUG=156121
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11189006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162395 0039d316-1c4b-4281-b951-d872f2087c98

A null ExtensionGalleriesHost was left in the map, prevent it from being inserted.

BUG=155845
TEST=See comment 5 of bug.


Review URL: https://chromiumcodereview.appspot.com/11188015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162394 0039d316-1c4b-4281-b951-d872f2087c98

R=jamesr@chromium.org
BUG=154451


Review URL: https://chromiumcodereview.appspot.com/11183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162393 0039d316-1c4b-4281-b951-d872f2087c98

Plumb RunFileChooser to the embedder's WebContentsDelegate so if the embedder is allowed to show
a file chooser, then so is the guest.

BUG=143801
TEST=<input type="file"> in guest

Review URL: https://chromiumcodereview.appspot.com/11098056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162392 0039d316-1c4b-4281-b951-d872f2087c98

###
Reason:
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc: In function 'int ui::CoalescePendingMotionEvents(const XEvent*, XEvent*)':
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1449:14: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1450:15: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1483:18: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: ui/base/x/x11_util.cc:1484:19: error: 'ui::ValuatorTracker' has not been declared
chromeos-chrome-24.0.1300.0_alpha-r1: make: *** [c/Release/obj.target/ui/ui/base/x/x11_util.o] Error 1
###

This shares the movement event coalescing from RootWindowHostLinux, which
was disabled to make initial bringup easier.

BUG=146077


Review URL: https://chromiumcodereview.appspot.com/11192009

TBR=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11185026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151255
TEST=unit test & visual


Review URL: https://chromiumcodereview.appspot.com/11087037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=145783


Review URL: https://chromiumcodereview.appspot.com/11193014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162389 0039d316-1c4b-4281-b951-d872f2087c98

The fix for 153077 (10977088) was reverted because the ash_unittests failed for non ChromeOS. The only change is that I moved "#if defined(OS_CHROMEOS)" to encompass the whole newly added test:
AcceleratorControllerTest.DisallowedAtModalWindow
in file:
ash/accelerators/accelerator_controller_unittest.cc

see also: 
http://code.google.com/p/chromium/issues/detail?id=156227
https://codereview.chromium.org/11189021

http://code.google.com/p/chromium/issues/detail?id=153077
https://chromiumcodereview.appspot.com/10977088/

http://code.google.com/p/chromium/issues/detail?id=134093
https://chromiumcodereview.appspot.com/10993067/

BUG=156227
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11189021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162388 0039d316-1c4b-4281-b951-d872f2087c98

Some code checked the resizability of the window and used it to key a change in
window style. For app windows, we always want a very particular window style,
so we check for the remove_standard_frame Widget::InitParams option and ignore
the resize flag.

Also, change the shell window NonClientHitTest code to not return HTTOPLEFT and
friends when the window is non-resizable.

R=ben@chromium.org
BUG=155219


Review URL: https://chromiumcodereview.appspot.com/11154007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152181


Review URL: https://chromiumcodereview.appspot.com/10987039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162386 0039d316-1c4b-4281-b951-d872f2087c98

R=dgrogan@chromium.org
BUG=113118


Review URL: https://chromiumcodereview.appspot.com/11193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162385 0039d316-1c4b-4281-b951-d872f2087c98

There was a bug in the Flash code that caused a render crash. To reproduce the crash you had to do the following:
  - run on a Retina device
  - disable accelerated compositing
  - enable click to play
In this case playing a flash video would crash the renderer.

The problem was that we were incorrectly calculating the scaled rect of a bitmap.

For example, when the pixel size of the bitmap is 1x1 the scaled size should be 0x0. Instead we were rounding up and returning a scaled valeu of 1x1.

Fix was to use ToEnclosedRect instead of ToEnclosingRect.

BUG=155309
TBR=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11146009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162384 0039d316-1c4b-4281-b951-d872f2087c98

PPB_Font_Dev.GetFontFamilies() is a sync operation that waits for GetFontListAsync() to finish on the FILE thread in the browser process.
If the thread is busy, it could hang for quite a while.
Some Pepper Flash hangs are caused by this.

BUG=155931
TEST=None


Review URL: https://chromiumcodereview.appspot.com/11143028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162383 0039d316-1c4b-4281-b951-d872f2087c98

When app windows are maximized the normal window frame is replaced with a
special AppNonClientFrameViewAura. This adds a test for frame replacement
on maximize, restore and minimize.

BUG=156093
TEST=added test to browser_test AppNonClientFrameViewAuraTest


Review URL: https://chromiumcodereview.appspot.com/11192004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162382 0039d316-1c4b-4281-b951-d872f2087c98