- 26 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a5bb612e624..731ce5cd88f2 git log 9a5bb612e624..731ce5cd88f2 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@731ce5cd88f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I3d7cfe7cde747b3d53bbea9b8a2e0a11435b54f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700149}
-
Austin Tankiang authored
This dialog was only relevant to the legacy drive sync client, so remove it. Bug: 1003238 Change-Id: I0df8b043f585916684f019af62bfd0c9ca238a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819287Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#700148}
-
Guido Urdaneta authored
Bug: 1008005 Change-Id: I8b4361012430447010ec98bf19cddf79638378fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824107Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#700147}
-
Roman Sorokin authored
I believe it causes flakes of kiosk browsertest which use this helper Bug: 1008290 Change-Id: I883a18445b4bbc8d4db6a2901f61c7eb5bf5f8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826478Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700146}
-
Rune Lillesveen authored
The select popup background uses the "menu" system color as its background color. Make sure it's based on the used color-scheme. Bug: 939811 Change-Id: I2e57ac5fac8938e9bfcbe1460a9e78fdb33191bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824472Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700145}
-
Oriol Brufau authored
The test failed due to issue 942811, which was fixed in https://crrev.com/c/1796323. But it was still marked as failing for non-LayoutNG. Bug: 942811 Change-Id: I8f346f07591709d1abccaabd24505a66864b5321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824113Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#700144}
-
François Beaufort authored
This CL simply set the default value of vertexInput in GPURenderPipelineDescriptor to an empty dictionary as specified in https://gpuweb.github.io/gpuweb/#dom-gpurenderpipelinedescriptor-vertexinput Bug: 877147 Change-Id: I3e8d8fe42217a563b133767319d9695d21683186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824884 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#700143}
-
Fredrik Söderquist authored
It seem unnecessary that every client should need to handle this (potentially forgetting to) - especially since what is needed is to call back into ImageResourceContent which in turn checks with its observers. Move this call so that it happens just after the ImageNotifyFinished() notification, and then merge that whole sequence (which happens twice) into a new method HandleObserverFinished(...). The existing MarkObserverFinished(...) is merged into the new method since it is its only caller. Change-Id: I00fe6c4b31ee7499e7b89c4b2881beaeab95783d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824893Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#700142}
-
hyunjune authored
This patch fix up typo to replace 'becase' with 'because' on the comment. Change-Id: I645c741892531f105189bfac001ff7fb70cd8105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824733 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#700141}
-
Mohamed Amir Yosef authored
After recent refactoring, this class isn't needed anymore! Change-Id: Ib2e4b5c4420ccea6d949d2bfc9fa3d897768b7d5 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823875 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700140}
-
Renato Silva authored
This commit adds an empty space between the cr-toggle and the end of the field in the Polymer element 'oobe-a11y-option'. Without this space, the ripples created by the 'cr-toggle' would overflow to the right, creating an unnecessary horizontal scroller. Tested locally. Bug: 887866 Change-Id: I698da984fa75bae198395aa55150d433ad79d10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825218Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#700139}
-
Rafał Godlewski authored
Fixes wrong range calculation of the bold part of the message in one variant of leak detection dialog. Bug: 1007992 Change-Id: I1fb63a3005ecd442edeb0622e668c7f027a85762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823943Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Rafał Godlewski <rgod@google.com> Cr-Commit-Position: refs/heads/master@{#700138}
-
Mihai Sardarescu authored
In M77, showing the signed-in account view was disabled due to the fact that the preferences used to compute authService->HaveAccountsChanged() were not correctly updated (see crbug.com/1006717). To avoid user confusion, it is important to avoid showing the signed-in accounts dialog on the first session after an update from M77 in order to allow the authentication service to update its internal preferences. Bug: 1007899 Change-Id: I81aa30beee0fe6c108724e83bc62e462c2f92994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824259 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#700137}
-
Henrik Grunell authored
Bug: None Change-Id: I65b1cf1d76e1d29d10179839a17dab635e7db98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825521Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#700136}
-
Xiaocheng Hu authored
Note that the test failures are due to an existing bug crbug.com/1008146 that we fail to sort terms in a summation in the serialization. The bug is orthogonal to the implementation of min/max. Bug: 978682 Change-Id: Ieb04637427bdd7ba30e3bed82036d098598b6bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824835 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#700135}
-
Xiaocheng Hu authored
Note that the test failures are due to an existing bug crbug.com/1008146 that we fail to sort terms in a summation in the serialization. The bug is orthogonal to the implementation of min/max. Bug: 978682 Change-Id: I0407fd40488f8e1a262e697977a9b80e22f9788c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825726Reviewed-by:
-
Fredrik Söderquist authored
The transform for <svg:image> was not being updated properly when the reference box was changed. Bug: 1007146 Change-Id: I39e73105e4a2d284afd1588e38eb8ff90e45c6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824271Reviewed-by:
-
Xiaocheng Hu authored
The existing code is too aggressive in simplifying calc() expressions that, math functions (min/max etc) can be simplified away when they can be directly resolved. This doesn't match the spec (*), and is fixed in this patch. (*) https://drafts.csswg.org/css-values-4/#math-function-simplify-a-calculation Bug: 825895 Change-Id: Id5796299da50e40b09bc38bf0271c8f5cd7897de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825325Reviewed-by:
-
Matthias Körber authored
This reverts commit f15fdded. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Removed unused methods from |ContentPasswordManagerDriver|." > > This reverts commit 97111d78. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Removed unused methods from |ContentPasswordManagerDriver|. > > > > Change-Id: Ie4934e0944504674df6c0963b9004c4f4498a225 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823866 > > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#699743} > > TBR=dvadym@chromium.org,koerber@google.com > > Change-Id: I63b1c20ac9bf2027f7e80932c7af4d71d49bb8ef > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826477 > Reviewed-by: Matthias Körber <koerber@google.com> > Commit-Queue: Matthias Körber <koerber@google.com> > Cr-Commit-Position: refs/heads/master@{#700126} TBR=dvadym@chromium.org,koerber@google.com Change-Id: I7b417d65e225f89c35cf48ce622e4e7b346b77c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823854Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#700131}
-
Alexandre Courbot authored
Make use of the new polling capabilities of V4L2Device brought by V4L2DevicePoller to simplify the code. Bug: 1003223 Test: vdaunittest passing on Kevin. Change-Id: Ibec673fa499cf4726f94e82b5ec124b104a92883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799654 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#700130}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. This CL replaces below ones, - kValidationBadInputForNumber - kValidationBadInputForDateTime - kValidationPatternMismatch - kValidationRangeOverflowDateTime - kValidationRangeUnderflowDateTime Bug: 995644 Change-Id: I76788119ca176603bcd8aaf59c926508deed191b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826062 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#700129}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. This CL replaces below ones, - kValidationTypeMismatch - kValidationTypeMismatchForEmail, - kValidationTypeMismatchForEmailEmpty, - kValidationTypeMismatchForEmailEmptyDomain, - kValidationTypeMismatchForEmailEmptyLocal, - kValidationTypeMismatchForEmailInvalidDomain, - kValidationTypeMismatchForEmailInvalidDots, - kValidationTypeMismatchForEmailInvalidLocal, - kValidationTypeMismatchForEmailNoAtSign, - kValidationTypeMismatchForMultipleEmail, - kValidationTypeMismatchForURL, Bug: 995644 Change-Id: I27362cd5d6adae09983ff43cf34c637ac40eb9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824513Reviewed-by:
-
Rohit Agarwal authored
The deletion of data from StoragePartition is triggered before REMOVE_DATA_MASK_SHADER_CACHE gets written to the deletion mask which led to not deletion of shader cache. The fix was to write to the remove mask before deletion is called. Bug: 960783 Change-Id: I023462d6d419f369286380751746814dbef404a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819438 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#700127}
-
Matthias Körber authored
This reverts commit 97111d78. Reason for revert: <INSERT REASONING HERE> Original change's description: > Removed unused methods from |ContentPasswordManagerDriver|. > > Change-Id: Ie4934e0944504674df6c0963b9004c4f4498a225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823866 > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699743} TBR=dvadym@chromium.org,koerber@google.com Change-Id: I63b1c20ac9bf2027f7e80932c7af4d71d49bb8ef No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826477Reviewed-by:
-
Hiroki Nakagawa authored
This is a cleanup CL, and doesn't change existing behavior. Before this CL, these values were kept as members of WebEmbeddedWorkerImpl, and passed when a new service worker thread starts. After this CL, these are directly passed through WebEmbeddedWorkerImpl as function arguments. Keeping them as members was needed when asynchronous script fetch was done on the initiator thread. Now, script fetch is done on the worker thread, and operations on the initiator thread are synchronous. It's no longer necessary to keep them as members. Bug: n/a Change-Id: Ib401370630e5593702ca05c5dc928baf53e7049d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826304 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700125}
-
Alexandre Courbot authored
Make use of the new polling capabilities of V4L2Device brought by V4L2DevicePoller to simplify the code. Bug: 1003223 Test: vdatests passing on Kevin. Change-Id: Ie44d7d57f5661840f94004f36ac42dae3ebe992f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799653 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Dan Beam authored
Based on https://crrev.com/c/1816916 by Esmael Elmoslimany <aee@chromium.org> R=mahmadi@chromium.org Bug: 1002689 Change-Id: Ia6c95fd406c101efce44b2aed7f1b13b6f522bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824286 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700123}
-
Alexandre Courbot authored
Each of the V4L2 decoder/encoder classes reimplement the same polling mechanism, where a dedicated thread is used to poll() an open V4L2 device and signal the decoder/encoder thread when a buffer or event is ready to be dequeued. This adds considerable amounts of code to each of these classes and complicates them. This CL replicates the polling feature into a dedicated class that is self-contained, properly documented, and easy to understand. This class is not intended to be used directly: instead, V4L2Device now has an EnablePolling() method that will invoke a callback on the client's sequence whenever an event or buffer is ready. This approach considerably simplifies the client's code, which on top of not having to reimplement the polling functionality, also doesn't need to guess when it should schedule polling: V4L2Device has all the information it needs to make this decision when queueing or dequeueing a buffer. Bug: 1003223 Test: vdatests passing on Kevin. Change-Id: I6b8619a89132c34c7424d83613c7681aedfc46ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799652 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
We used object() as a python value for empty dictionary literal "{}". But it doesn't work with (current) make_copy() well. This CL changes the value as dict() to work with make_copy() and describe its actual type better. Bug: 984949, 839389 Change-Id: I3f14319bae91ab3b7510636cca103ca25f6b6424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826067Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#700121}
-
Chih-Yu Huang authored
The GetDmabufId() method is getting an identifier of a Dma-buf VideoFrame. The method is used for all DmabufVideoFramePool implementations, not only PlatformVideoFramePool. This CL moves the method to DmabufVideoFramePool. BUG=b:136716638 TEST=media_unittests --gtest_filter=PlatformVideoFramePoolTest.* Change-Id: I6950c1cf5a5127778a3dba2bbf2475fd4779a679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824501 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38b1a95c532f..1619d75c48d5 Created with: gclient setdep -r src-internal@1619d75c48d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie8f35f721490a0c97df1de84417ffa30e011629a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826208Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700119}
-
Tsuyoshi Horo authored
This CL introduces base_url_override_for_bundled_exchanges field in CommitNavigationParams and WebNavigationParams. This field is set while loading an untrustable bundled exchanges file, and used when DocumentLoader::FinishNavigationCommit() is called. For example, while loading "file:///tmp/test.wbn" file which primary URL is "https://example.com/a.html", InterceptorForLocalFile returns a synthesized redirect response to "file:///tmp/test.wbn?https://example.com/a.html", and RenderFrameHostImpl::CommitNavigation() will set the field of CommitNavigationParams to "https://example.com/a.html". This field is passed to DocumentLoader and used call DocumentLoader::FinishNavigationCommit() as |overriding_url|. Currently this argument is used to set the base URL of the document encoded in the MHTML so relative URLs are resolved properly. This CL reuses this mechanism for bundled exchanges files. (This mechanism was introduced by ea73b35f.) Bug: 995177 Change-Id: I0198bb4a9afd8ee262e470e03c6fa6d2f2a53c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802902Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700118}
-
Jay Harris authored
This reverts the (most obvious) new behavior added in https://crrev.com/692412 while making minimal changes (so as to ease merging). This is the result of some discussion at TPAC here: https://github.com/WICG/badging/issues/55 Changes that this will not revert: * Inheriting the badge of a parent app. Bug: 1006665 Change-Id: I845f56f166f00dd3c7cc76e323be27cb90881e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817999 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#700117}
-
Hiroki Nakagawa authored
Before this CL, WebEmbeddedWorkerImpl on the initiator thread determined whether this service worker is installed, and requested script loading and evaluation based on the decision. After this CL, the decision is made by ServiceWorkerGlobalScope on the worker thread. This enables to remove thread-hop and script evaluation code per service worker type (new or installed). Bug: 938219 Change-Id: I55c49cf18998c80075e75df53c5c9983fddcaf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826301Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#700116}
-
Julie Jeongeun Kim authored
This CL converts HostStatusObserverPtr and HostStatusObserverRequest to new Mojo types using PendingRemote, Remote, RemoteSet, and ReceiverSet. It also update AddHostStatusObserver from multidevice_setup.mojom. Bug: 955171 Change-Id: Ifde21a3512beaf4d67f0bbd03a719ad148cd3ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824725 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#700115}
-
Matthias Körber authored
Bug: 1007974 Change-Id: Ie03062c74dcc6ca6f74b40199f6dfa02fb8a3e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824473 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Ken MacKay authored
By receiving into a threadsafe IOBufferPool, we can avoid extra memory copies for things like audio streaming. Bug: internal b/127963522 Test: cast_net_unittests Change-Id: I86da6e7a5e07a7a3273d53485393468b4481ec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822220 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700113}
-
Julie Jeongeun Kim authored
This CL converts ConnectionDelegatePtr to new Mojo types using PendingRemote or Remote, PendingReceiver, ReceiverSet, and Receiver. It also updates ListenForConnectionFromDevice and InitiateConnectionToDevicefrom secure_channel.mojom. Bug: 955171 Change-Id: Ib0a2ea523450932bff1042fe469c5a45065c72e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820918Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700112}
-
Yoshifumi Inoue authored
This patch gets rid of false |DCHECK_LE(start_offset, item->StartOffset())| from |ReusingTextShaper::CollectReusableShapeResults()| when inserted text starts with newline character as control character, e.g. white-space:pre, <pre>, etc. This DCHECK is wrong when adding newline chracter as control character, e.g. appending "\nX" to "n". In |ReusingTextShaper|, we have two items in |reusable_items_|. * reusable_items_[0] = kText 0-1 "n", shape_result=avaiable * reusable_items_[1] = kText 1-3 "\nX", shape_result=null Shaping items are * items[0] = kText 0-1 "n", shape_result=reused * items[1] = kControl 1-2 "\n", shape_result=n/a * items[2] = kText 2-3 "X", shape_result=new When |ReusingTextShaper| to shape for "X", |DCHECK| hits for handling |reusable_items_[1]|, because |start_offset| is 2 and |item->StartOffset()| is 1. Bug: 1003666 Change-Id: I800fae637ff7a39b0e65d07699c07b204051399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824516 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This change converts KeyboardLockService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I3e6e2e6cb1c50bd83d6f8ccea881c546150eae54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816073 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
