- 16 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d28d4891fbd9..a0c450d5b58f git log d28d4891fbd9..a0c450d5b58f --date=short --first-parent --format='%ad %ae %s' 2020-04-16 aerotwist@chromium.org Adds support for Total Blocking Time in Perf panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@a0c450d5b58f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1054381 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia15e1c11dc65eea015bb7d08ef4b6ac0df6dffe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759677}
-
Jeremy Roman authored
This was missed in crrev.com/c/2013473. Bug: 1040627 Change-Id: I1928292ab7f2d9ae2eab7577899300d995c9ca1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152633Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#759676}
-
Aaron Colwell authored
Removing a field that doesn't appear to be used anywhere and cleaned up all the call sites. Bug: 1015882 Change-Id: Ie6ed3db2a56d0416ec61a7f77da454b2fcc15fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151683 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#759675}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a9c9d66f12c..2d65b73337ee git log 7a9c9d66f12c..2d65b73337ee --date=short --first-parent --format='%ad %ae %s' 2020-04-16 tdenniston@google.com [svg] Fix multiple transforms specified Created with: gclient setdep -r src/third_party/skia@2d65b73337ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I5ee8ec4ee73175c63f4978bc4604075c58bf9f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759674}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/45e5510c53da..ab983012a2d4 git log 45e5510c53da..ab983012a2d4 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 bclayton@google.com Make memoryPageSize() functions thread-safe. 2020-04-16 bclayton@google.com Vulkan: Move SpecializationInfo to own file. Created with: gclient setdep -r src/third_party/swiftshader@ab983012a2d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4a38e4532454daffea0e4690eaa4fe009ed9ee60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759673}
-
Vasiliy Telezhnikov authored
This is a reland of d60e79d1 The problem was that resources were never returned because ScopedBatchReturnResources was in outer scope than ScopedAllowGpuAccess so the state when we don't batch already, but still have access to gpu thread didn't exist. Solution to merge ScopedBatchReturnResources and ScopedAllowGpuAccess to make sure everything happens in right order. Original change's description: > Limit access to gpu thread in DisplayResourceProvider > > This CL makes sure that DisplayResourceProvider return resources only > when GPU Thread is available to make sure ReleaseImageContexts will > complete in finite time. > > This doesn't change anything for Chrome where GPU Thread is always > available, but on webview RenderThread that used for gpu access during > composition is available only during specific times (init, dtor, > DrawAndSwap) > > Bug: 1068716 > > Change-Id: I8fa482ab7399d6ce7639c1d76187be86ce152059 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138551 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757967} Bug: 1068716 Change-Id: Idf531b9ee9e10057b571725a256d2af09efbea69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149377Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#759672}
-
Thomas Guilbert authored
This CL adds/modifies three tests: 1. Updates the chained video.rAF callback test to also verify the required VideoFrameMetadata fields (e.g. dimensions stay constant, time and presented frames are increasing). 2. Adds a test that makes sure that video.rAF callbacks are executed before window.rAF callbacks, and in the same turn of the event loop (as measured by having identical 'time' callback parameters). 3. Adds a test that verifies that all of the WebRTC optional parameters are present when we expect them to be. Bug: 1012063 Change-Id: I72461dd42f6da1a03faaee61355e7c191fe4c116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130643 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#759671}
-
Ehimare Okoyomon authored
For cookie settings specifically, change whether the result of AddExceptionPreference is an allow or block exception, depending on the user's current cookie settings state. Bug: 1060118 Change-Id: If1440909ac649015bd8c97c632e5e4f571a41841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139663Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759670}
-
Erik Staab authored
The large, auto-generated json files can take over ten seconds to parse. Change-Id: I122dc0b7f13bf9bd816a5b6f7fc2f0ad08e0fcc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151844Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#759669}
-
Clemens Arbesser authored
Before this change, going from one ShowGenericUiAction to another one caused a hard layout transition, rather than a smooth one. Bug: b/145043394 Change-Id: I2577c03d9f9c8ebcb9d7f27cb057384f53a3edff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151452Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#759668}
-
Robert Sesek authored
This is a very basic check that can be used to verify that the current process is running under any kind of sandbox. Change-Id: Iaee3f2a97c4dae72714297dcdf23b37ff7c6fdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147677 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#759667}
-
Caitlin Fischer authored
Bug: 1068142 Change-Id: I10ba127779a14c9cfa41bdf875ab65a2e6e38395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151890Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#759666}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/652f83ad..a0a377b4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4956a468109b84a89ac53f892a4f263577ada906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151551Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759665}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d687a1e3e31..3c49531fb490 git log 3d687a1e3e31..3c49531fb490 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 mbonadei@webrtc.org Fix link in documentation. 2020-04-16 mbonadei@webrtc.org Remove deprecated VideoSendStream::StreamStats data members. Created with: gclient setdep -r src/third_party/webrtc@3c49531fb490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0699f5c4147abb41c60cdc560a5c1f9147a8dc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759664}
-
David Roger authored
This histogram is recorded on multilogin requests to Gaia, and can be useful to debug integration issues between Chrome and Gaia. Fixed: 1059817 Change-Id: Ie1c1ef517050ad5c8372bb697d71c2557b1b452f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151456 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759663}
-
Omar Morsi authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/484e71aca63a..14a2fb015f12 $ git log 484e71aca..14a2fb015 --date=short --no-merges --format='%ad %ae %s' 2020-04-07 omorsi system_api: Add constants for chaps 2020-03-25 kglund power: add ChangeRegDomain method to powerd and shill 2020-04-09 jorgelo system_api, chromeos-login, cryptohome: Extract namespace constant. 2020-04-08 ahassani dlcservice: Add Purge API 2020-01-15 hugobenichi arc: net: DBUS API for system-proxy namespace routing Created with: roll-dep src/third_party/cros_system_api Bug: 1045895 Change-Id: I26610fb2b7f7c1dac00779b0bc45f688c5fbeac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151589Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#759662}
-
mhasank authored
Adding support for sending backup_log argument to session manager when stopping ARC container based on error conditions in Chrome. BUG=b:149874690 TEST=deploy chrome, start and stop arc. Change-Id: Ia1388cea39122c9c19f20641d0c299e709ed97b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149635 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#759661}
-
Ioana Pandele authored
Tapping on the toggle in the keyboard accessory will now update the PasswordStore, either by removing the blacklisted entry for the origin if the user re-enables saving, or by re-adding it if the user disables it again. At the moment, the save password infobar is still not shown after saving is enabled via the toggle, because ChromePasswordManagerClient queries the old cache (via PasswordFormManager) which doesn't have the latest store data. This will be changed in the next CL. Bug: 1044930 Change-Id: I0a5cbcc6085fac5070375093b499a3e2ebc7c4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135752 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#759660}
-
Marc Treib authored
Bug: 1034915 Change-Id: I1216bf20521a43d870dd40a30149d490fb41fc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151508Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#759659}
-
Alex Ilin authored
PromoCardCoordinatorTest#testTextImageBinding is failing on an Android K bot. TBR=twellington@chromium.org Bug: 1071414 Change-Id: If244d8c5caa7c9e08229e1bcbece1504d1acc01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151568Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759658}
-
David Roger authored
Remove tangltom who is no longer working on Chrome. Add droger. Change-Id: If7cf2d3ed7417485bab3bbb501e040d3d08e115e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152589 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#759657}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bb63adbd88be..9036394cfefb git log bb63adbd88be..9036394cfefb --date=short --first-parent --format='%ad %ae %s' 2020-04-16 lalitm@google.com Merge "tp: refactor shell main into multiple functions" 2020-04-16 lalitm@google.com tp: don't associate to any process for sde_tracing_mark_write events 2020-04-16 lalitm@google.com Merge "tp: add EXTRACT_ARG function" Created with: gclient setdep -r src/third_party/perfetto@9036394cfefb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:136635390,chromium:154157553 Tbr: perfetto-bugs@google.com Change-Id: Icbe3c9e2cd094871df35be898c248d2ba5726ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152625Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759656}
-
Mihai Sardarescu authored
This CL adds chrome-sign-team@ as owners for histograms Signin.Signin{Started|Completed}AccessPoint. These histograms are used to record how users interact with the Chrome sign-in UIs, and are critical in measuring the CTR for the various UI surfaces. Fixed: 1059819 Change-Id: Ib82fc18a099c6ac69944c610cfdcdc380b51f622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151511 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759655}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id97b7ddfae74389c260639af0131673ba0532006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759654}
-
Javier Ernesto Flores Robles authored
Syncs all passwords if they haven't been sync before. Adds file URL as an arg of CredentialProviderService to test it when app groups are not present. Removes keychainIdentifier from the convenience init. Now it can be grabbed from passwordForm. Adds remove all credentials to the credential store. Moves general credential management to the protocol: add, update and remove. After this sync, observing the password store should be enough to keep data in sync. Coming in a follow up CL. Bug: 1066803 Change-Id: Id5f0289e3fdde908bd9d9be8ae7cc10b26fe5f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149653Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#759653}
-
Monica Basta authored
This CL creates the initial View object to show the new profile picker. It is currently loading the current user manager url. Next steps would be: (1) Create the new profile picker html page (WebUI part). (2) Load the new profile picker in ProfilePickerView Change-Id: I1171799ce9649e4738b543f2676002f48c652c53 Bug: 1063856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141100 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#759652}
-
Danyao Wang authored
This is a reland of b666bbd0 Original patch: https://crrev.com/2141436 Revert: https://crrev.com/2144682 Reason for revert: broke tests: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.payments.ExpandablePaymentHandlerChangePaymentMethodTest%23testThrowBasicCard Reason for reland: fixed broken test (moving a function call outside of DCHECK) Original change's description: > [Web Payments] Use PaymentAppServiceBridge JNI in PaymentAppService. > > This CL contains the final steps to make the Java PaymentAppService > invoke the C++ PaymentAppService: > - Moved remaining PaymentHandlerFinder functionality, namely, > onInstalledPaymentHandlerFounder() and onInstallablePaymentHandler() > from ServiceWorkerPaymentAppBridge to PaymentAppServiceBridge. > - Exposed the native method fireCanMakePaymentEvent() via a static > method on ServiceWorkerPaymentAppBridge so it can be used by > PaymentAppServiceBridge. > - Proxied ServiceWorkerPaymentAppBridge.setCanMakePaymentForTesting > to PaymentAppServiceBridge. This will be cleaned up in a subsequent > CL. > - Fixed a bug from a previous CL to pass payment apps to callbacks by > value instead of by reference. > > Bug: 1063118 > Change-Id: I87e254d6dc11e12f890353c9a0a6dde6cca73c9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141436 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757827} Bug: 1063118 Change-Id: Ib2eceb850368e3247876ab303b54a1c41b8943ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151091 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759651}
-
Colin Blundell authored
As the start of unforking as much as possible of the //weblayer and //chrome implementations of the ExternalNavigationDelegate interface, this CL moves their common implementations of queryIntentActivities() into ExternalNavigationHandler.java itself. We leave the implementation in the test delegate used in ExternalNavigationHandlerTest (no longer overriding the public interface), as this is used by TestPackageManager in those tests to mock out this functionality. This test setup could likely be streamlined, but we will leave such restructuring of the ExternalNavigationHandler test for a followup phase after the dust has completely settled on the unforking of the two delegate implementations in order to separate concerns and avoid the risk of introducing significant noise by continually re-refactoring the test in different ways as the unforking proceeds. Bug: 1071390 Change-Id: Ibceedd3a952a721e2d6fa53f50c11d60d7bf6bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152448Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759650}
-
Clark DuVall authored
This was in c/b/content_settings but seems to make more sense in browsing_data since all the types it holds are in browsing data. This moves CreateCookiesTreeModel() to collected_cookies_views.cc since that's the only place it's used. Bug: 1070825 Change-Id: Ib41e130fc77d492d691538d23cc4ef3e6cf4b696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151328Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759649}
-
Sigurdur Asgeirsson authored
Bug: 1071090 Change-Id: I9e3fc5f6d78050ee819c827abae4ca76cc291f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150059 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#759648}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6e711c377517..d28d4891fbd9 git log 6e711c377517..d28d4891fbd9 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d28d4891fbd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id95c185d88f35d73b3e742427c597d8778c3974d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759647}
-
David Roger authored
These histograms are still useful in particular because we are going to migrate desktop platforms to multilogin, and these histograms will be used to check the success of the migration. We may consider keeping the histograms even after the migration is complete, but we'll see at this time. If we want to keep them indefinitely we should maybe consider renaming them however, because they are specific to multilogin, and it's not really captured in their name. Fixed: 1059815 Change-Id: Iff2860a961945e01abd965a51be9d90a1e121185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151457 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759646}
-
Virender Singh authored
Body element should be the default focused element when a PDF is opened. For both embed and non-embed scenarios body element is the default focus item. Bug: 1041417 Change-Id: I538c434239575a0ff8c6a3ee7368c7c5fe7047f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141997Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759645}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2430d665d3f2..45e5510c53da git log 2430d665d3f2..45e5510c53da --date=short --first-parent --format='%ad %ae %s' 2020-04-16 bclayton@google.com Fix chrome autorollers 2020-04-16 bclayton@google.com Reimplement LRUCache, fold away LRUSnapshotCache, add tests. Created with: gclient setdep -r src/third_party/swiftshader@45e5510c53da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib4e514952c82e33d90061783d7d05a40a1b6dc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759644}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/938b4532b48f..7a9c9d66f12c git log 938b4532b48f..7a9c9d66f12c --date=short --first-parent --format='%ad %ae %s' 2020-04-16 prashant.n@samsung.com Make SkM44 public. 2020-04-16 reed@google.com separate m44 tests Created with: gclient setdep -r src/third_party/skia@7a9c9d66f12c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I51828c78fc6711723fa09457fb673220d544138a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759643}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: Ifc75702730ea9528c431a0245bda488cde370bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151385 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759642}
-
Ross McIlroy authored
BUG=v8:9684 Change-Id: If46fb6e37100f90fb7cc25dcad1824a2f135d8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151506Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759641}
-
sauski authored
This CL aligns the description in the new cookie controls of what may happen when third party cookies are disabled to that already present on the incognito NTP. Bug: 1069687 Change-Id: I75578604cd55d2613b6c73686a92fb5c1835947b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145883Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#759640}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f3889a6dff8..d113c17a489e git log 5f3889a6dff8..d113c17a489e --date=short --first-parent --format='%ad %ae %s' 2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 1be434141625..0d4857ea576a (1 commits) 2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 81e08df29531..2430d665d3f2 (4 commits) 2020-04-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 3f7e3cbf33a7..3682237cb326 (1 commits) Created with: gclient setdep -r src/third_party/angle@d113c17a489e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I9d84e0768f63a4dff23846903b92dccd1d671fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152435Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759639}
-
Gyuyoung Kim authored
This CL migrates flex-sizing-columns-min-max-width.html from fast/css-grid-layout to external/wpt/css/css-grid/grid-definition with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to flex-sizing-columns-min-max-width-001.html to be align with existing tests. Bug: 1063749 Change-Id: Ia88b67bd6ace8b2901990da9da26e5643a2ceaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152127 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759638}
-