GitLab

suid_unsafe_environment_variables.h is included both in C and C++ and is
a little clunky. Clean things up a bit.

BUG=233330

Review URL: https://codereview.chromium.org/14328030

Patch from Julien Tinnes <jln@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229710

Review URL: https://chromiumcodereview.appspot.com/14017003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195065 0039d316-1c4b-4281-b951-d872f2087c98

The cause is very likely that an event-handler is destroyed inside the
event-handling function (OnMouseEvent). Furthermore, this destruction
is not needed due to state variable "in_shutdown_". It was there for a 
very marginal efficiency gain. Removed the handler destruction.

BUG=230872
R=ben@chromium.org
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/13932029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195064 0039d316-1c4b-4281-b951-d872f2087c98

Changes the string and breaks it apart for the Android UI.

BUG=180962

Review URL: https://chromiumcodereview.appspot.com/13918004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195063 0039d316-1c4b-4281-b951-d872f2087c98

$('polling-interval-sec') no longer exists hence causes a JS error.
FWIW, the regression was introduced in crrev.com/194294

BUG=233446
TEST=open chrome:drive-internals; confirm that Delta Update Status section is shown properly.

Review URL: https://codereview.chromium.org/14366011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195062 0039d316-1c4b-4281-b951-d872f2087c98

Remove landing page from history when redirecting to NTP so that the back-button will work as expected.

BUG=180145

Review URL: https://chromiumcodereview.appspot.com/13896009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233039

Review URL: https://chromiumcodereview.appspot.com/13896003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195060 0039d316-1c4b-4281-b951-d872f2087c98

When showning an audio indicator on multiple tabs, the CPU usage on
my machine is:
  1 tab: 1.5%
  2 tab: 2.5%
  3 tab: 3.2%

This CL uses a common animation container for all tabs in a window.
This changes the CPU usage to:
  1 tab: 1.5%
  2 tab: 1.5%
  3 tab: 1.5%

BUG=3541

Review URL: https://chromiumcodereview.appspot.com/13867007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=230997

Review URL: https://chromiumcodereview.appspot.com/13859011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195058 0039d316-1c4b-4281-b951-d872f2087c98

"and" and "xor" are alternate spellings of the "&&" and "^" operators,
and clang doesn't like it if you use them as identifiers.

Clang also doesn't like static_cast<> from void * to a function pointer,
but reinterpret_cast<> works.

R=alexeypa@chromium.org
BUG=82385

Review URL: https://chromiumcodereview.appspot.com/13852007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195057 0039d316-1c4b-4281-b951-d872f2087c98

ArchiveSomeOldHistory() takes an int as last parameter, but this code would
pass numeric_limits<size_t>::max(). Found by clang building in C++11 mode:

../../chrome/browser/history/expire_history_backend.cc:330:25: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion]
                        std::numeric_limits<size_t>::max());
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

BUG=233330

Review URL: https://codereview.chromium.org/14057019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=cjhopman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/13852021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195044 0039d316-1c4b-4281-b951-d872f2087c98

Proposal: https://docs.google.com/a/google.com/document/d/1KxtQCk4SJdAZId8WxtnCxR3kS2KvhFDsU0SdAeP18Xc/edit

The logic of the API is implemented. Add prefernces and policies are added.
The underlying cryptohome_client will be implemented in another CL.

BUG=chromium:219963
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/13132004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/14358006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195039 0039d316-1c4b-4281-b951-d872f2087c98

This seems to be equivalent to SetHoverColor and LabelButton doesn't have/implement
this concept. So to make the life easier just remove it.

BUG=155363
R=msw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14331002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195038 0039d316-1c4b-4281-b951-d872f2087c98

R=rch@chromium.org
BUG=232777

Review URL: https://chromiumcodereview.appspot.com/14328013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195037 0039d316-1c4b-4281-b951-d872f2087c98

Also enable two passed java tests.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13870016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233164
R=pliard@chromium.org

Review URL: https://chromiumcodereview.appspot.com/14315009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195035 0039d316-1c4b-4281-b951-d872f2087c98

PowerStatusView::GetRoundedBatteryPercentage() truncated
rather than rounding, resulting in Chrome frequently
displaying a slightly-lower battery percentage than what
powerd told it to display.

BUG=chromium:221746

Review URL: https://chromiumcodereview.appspot.com/14246015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=233243
R=msw@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/14267007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195033 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/14232014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/14163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195031 0039d316-1c4b-4281-b951-d872f2087c98

On Windows & Chrome OS, pressing Alt+Shift+A will bring focus to the first
control in the first infobar, if any are shown. No reason for 'A' - 'I' is
already taken on Chrome OS, but all other hotkeys to directly focus a given
pane are Alt+Shift+Letter shortcuts.

BUG=226334

Review URL: https://chromiumcodereview.appspot.com/14225016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195030 0039d316-1c4b-4281-b951-d872f2087c98

DuplicateHandle with DUPLICATE_CLOSE_SOURCE always closes the handle, right now on failure
we close it which means we are closing an invalid handle or closing some other handle in
the small race window.

Reported by Ashutosh Mehra from Adobe.

BUG=233251
TEST=none

Review URL: https://chromiumcodereview.appspot.com/13912024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195029 0039d316-1c4b-4281-b951-d872f2087c98

Make View::RequestFocus non-virtual; replace override.
Also add mouse-press/release inhibiting of select-all.
(this prevents a flash of all text selected on click)

BUG=232290
TEST=No find bar focus-related behavior/appearance regressions; switching back to a tab that had the find bar focused (from a tab that didn't have the find bar focused) restores find bar focus and selects the entire text content; clicking the find bar doesn't flash all the text selected before placing the cursor or starting a drag.
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13852009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195028 0039d316-1c4b-4281-b951-d872f2087c98

Broke mouse dodge on Mac, and perhaps isn't correct for Win Aura anyhow.

BUG=233299

> push MouseMove through WebContents and back to delegate to fix status bubble avoid
> 
> This fixes the status bubble not "dodging" the mouse on Aura.
> 
> On non-Aura, the path to get to StatusBubbleViews::MouseMoved is:
> - RenderWidgetHostViewWin::OnMouseEvent
> - SendMessage to the parent window
> - WebContentsViewWin::OnMouseMove
> - Browser::ContentsMouseEvent
> - StatusBubbleViews::MouseMoved
> 
> On Aura, the path is:
> - HWNDMessageHandler
> - DesktkopRootWindowHostWin::HandleMouseEvent
> - RootWindow::OnHostMoustEvent
> - EventDispatcher, etc.
> - content::RenderWidgetHostViewAura::OnMouseEvent
> - RenderViewHostImpl::ForwardMouseEvent
> - WebContentsImpl::HandleMouseMove  // ***
> - Browser::ContentsMoveEvent
> - StatusBubbleViews::MouseMoved.
> 
> This patch implements HandleMouseMove in WebContentsImpl to delegate back to Browser for Aura at ***.
> 
> R=jam@chromium.org
> 
> Review URL: https://codereview.chromium.org/14234020

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/13893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195027 0039d316-1c4b-4281-b951-d872f2087c98

The (harmless) warning was:

../../webkit/plugins/ppapi/message_channel.cc:286:69: error: comparison of constant 2305843009213693951 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
      if (std::numeric_limits<size_t>::max() / sizeof(NPIdentifier) <=
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
1 error generated.

It's always false in 64bit mode, but it's arguably useful in 32bit mode.

BUG=233330

Review URL: https://codereview.chromium.org/14246019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195026 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asargent@chromium.org
BUG=233404

Review URL: https://codereview.chromium.org/14192010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195025 0039d316-1c4b-4281-b951-d872f2087c98

With the fix all numbered address lines after line two are ignored (not just the third line); without the fix line four is classified as the start of a billing section and the form is 'split' in two address areas.

The problem can seen on site https://www.southwesttrains.co.uk/register.aspx

BUG=224601
TEST=Manual test; South West Trains site should fully autocomplete (including Post Code field). New unit test FormStructureTest.SurplusAddressLinesIgnored

Review URL: https://chromiumcodereview.appspot.com/13888008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Tests run.

Review URL: https://codereview.chromium.org/14328023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195022 0039d316-1c4b-4281-b951-d872f2087c98

A small number of devices cannot be paired, but can at least be
connected to insecurely. Support these by marking the devices as
Trusted, which causes BlueZ to remember the device and which allows
future incoming connections from them.

Make IsPaired() return true for these devices, there's no reason in
the UI to treat these any differently than paired devices.

TBR=youngki@chromium.org
BUG=232145
TEST=device_unittests

Review URL: https://codereview.chromium.org/14225017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195021 0039d316-1c4b-4281-b951-d872f2087c98

More standards-comformant, also needed for C++11 on Linux.

BUG=233330

Review URL: https://codereview.chromium.org/14188028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195020 0039d316-1c4b-4281-b951-d872f2087c98

It has been timing out on Vista interactive_ui_tests.
BUG=233372

Review URL: https://codereview.chromium.org/14366006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195019 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195018 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=148651%3A148661&mode=html

TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/13896015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195017 0039d316-1c4b-4281-b951-d872f2087c98

R=jzern
TBR=darin
BUG=none

Review URL: https://codereview.chromium.org/14328020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195016 0039d316-1c4b-4281-b951-d872f2087c98

Missed this during refactoring of:
https://chromiumcodereview.appspot.com/13140006

BUG=179250
NOTRY=true

No try to get this landed ASAP.

Review URL: https://chromiumcodereview.appspot.com/14365005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195015 0039d316-1c4b-4281-b951-d872f2087c98

This was causing renderer crashes when the alternate error page
passed in a NULL WebURLRequest.

> New network error page:  Fix resubmit warning when
> navigating forward / back to a page generated by a
> POST that can not be retrieved from the CACHE.
> 
> This was broken (knowingly) in revision 191712
> (https://codereview.chromium.org/12277011/).
> 
> BUG=174194,226909
> 
> Review URL: https://codereview.chromium.org/13811022

TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/14369002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195014 0039d316-1c4b-4281-b951-d872f2087c98

> Remove reference counting from media::VideoDecoder and friends.
> 
> In addition:
>   * VideoRenderer is now passed a list of decoders via constructor instead of Initialize()
>   * WebMediaPlayerImpl's FilterCollection is now built in one shot instead of incrementally
> 
> BUG=173313
> 
> Review URL: https://codereview.chromium.org/12989009

TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/14320005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195013 0039d316-1c4b-4281-b951-d872f2087c98

This is an update on a fix that landed in r193296 and fixed the ASAN builder. The target folder name can be different from one builder to the next, so I'm switching to using the GYP variable instead.

BUG=233173

Review URL: https://chromiumcodereview.appspot.com/14084004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195012 0039d316-1c4b-4281-b951-d872f2087c98