GitLab

BUG=595206
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2043453002
Cr-Commit-Position: refs/heads/master@{#397895}

BUG=617177

Review-Url: https://codereview.chromium.org/2031373002
Cr-Commit-Position: refs/heads/master@{#397894}

Recombine the two XML layouts and add logic for adjusting them,
depending on what we're displaying.

BUG=603635

Review-Url: https://codereview.chromium.org/2041483002
Cr-Commit-Position: refs/heads/master@{#397893}

BUG=611802
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2041503002
Cr-Commit-Position: refs/heads/master@{#397892}

The first argument to Response constructor should be the body while
currently passing the header. This patch fixed it and updated the
pageset.

BUG=614985

Review-Url: https://codereview.chromium.org/2032893003
Cr-Commit-Position: refs/heads/master@{#397891}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/71d985b3c851..be4159a15b3e

$ git log 71d985b3c..be4159a15 --date=short --no-merges --format='%ad %ae %s'

BUG=613706

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2035133004
Cr-Commit-Position: refs/heads/master@{#397890}

https://chromium.googlesource.com/skia.git/+log/69df0206252c..862dae548a8e

$ git log 69df02062..862dae548 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 robertphillips Add ability to rotate light direction in drawLitAtlas Sample slide

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2034843005
Cr-Commit-Position: refs/heads/master@{#397889}

When there are nested flexboxes, the current code does some O(N^2)
work to update scrolling information after flexing has finished.  This
change streamlines the process for performing flex layout and updating
scrollbars into three distinct phases, controlled by the highest-level
flexbox in the layout tree:

1. Perform flex layout on descendants; any blocks with overflow:auto
scrollbars may add/remove scrollbars, but they will not run the normal
second-pass layout after changing scrollbars, and they will not clamp
their existing scroll positions.

2. If, during the first pass, any descendant added or removed
scrollbars, run a second flex layout pass, but don't allow any
descendants to add or remove scrollbars.

3. After the second pass, go through and clamp the scroll positions
on all scrolling descendants.

BUG=593209,600036

Review-Url: https://codereview.chromium.org/1930183002
Cr-Commit-Position: refs/heads/master@{#397888}

Use context->Global() instead of CreationContext in MainThreadDebugger::memoryInfo.

BUG=616225
R=adamk@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2034203002
Cr-Commit-Position: refs/heads/master@{#397887}

MessagePumpForGpu has been on Canary for a few days and I
am still assessing whether it is better than standard
MessagePumpForUI in terms of reducing [GPU hang] crashes.
While it has eliminated hangs with some signatures the
rate of hangs in WaitForWork has increased.

When experimenting with MsgWaitForMultipleObjectsEx I
realized that it favors messages over events - when an
event is signaled and a message is available in the queue
it returns a result that indicates a message even when
the message doesn't belong to a current thread (e.g. a
browser UI message). With a high volume of messages it
might be possible for WaitForWork to keep looping and
starve the work processing. It is possible with Direct
Composition where some of UI input messages have to go
through the GPU process message loop because its D3D
surface window covers the entire browser window.

The fix is to do an additional check for the event. Please
note that this is a much less common code path so this
shouldn't affect performance much in scenarios like
video playback. Also I've added some diagnostics code to
help with crash dump analysis.

BUG=588798,596190

Review-Url: https://codereview.chromium.org/2036603002
Cr-Commit-Position: refs/heads/master@{#397886}

Also rolls breakpad to pick up an NDK fix.

BUG=599327

Review-Url: https://codereview.chromium.org/1991343002
Cr-Commit-Position: refs/heads/master@{#397885}

Revert of Enable per thread heap for database thread (patchset #12 id:220001 of https://codereview.chromium.org/1909813002/ )

Reason for revert:
This CL is causing a top #1 crasher.

https://bugs.chromium.org/p/chromium/issues/detail?id=617141

Original issue's description:
> Enable per thread heap for database thread
>
> BUG=591606
>
> Committed: https://crrev.com/993e3a74102e0843bebb2f52de1a904f151843d4
> Cr-Commit-Position: refs/heads/master@{#397383}

TBR=oilpan-reviews@chromium.org,keishi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=591606

Review-Url: https://codereview.chromium.org/2037233002
Cr-Commit-Position: refs/heads/master@{#397884}

BUG=580337
NOTRY=true

Review-Url: https://codereview.chromium.org/2035653005
Cr-Commit-Position: refs/heads/master@{#397883}

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG=615904
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2043433002
Cr-Commit-Position: refs/heads/master@{#397882}

BUG=None

Review-Url: https://codereview.chromium.org/2037763002
Cr-Commit-Position: refs/heads/master@{#397881}

This creates a new script called the linker driver, which runs all three
steps of linking: the image link, debug info link, and stripping. In GYP,
the last two steps were handled as postbuilds, but GN lacks those. Instead,
the linker driver performs all three operations in one build step.

BUG=330301,431177
R=mark@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/1999513002
Cr-Commit-Position: refs/heads/master@{#397880}

This wasn't caught because it's not compiled by default.

BUG=

Review-Url: https://codereview.chromium.org/2037213003
Cr-Commit-Position: refs/heads/master@{#397879}

Review-Url: https://codereview.chromium.org/2034303003
Cr-Commit-Position: refs/heads/master@{#397878}

Since we are persisting our GCM Network Manager task across reboots,
we need to switch to a type of time that will work reliably across
reboots.

We consisered SystemClock.elapsedRealtime, but we think that bad UMA
samples will be more likely from reboots than the user adjusting
wall clock time.

BUG=612325

Review-Url: https://codereview.chromium.org/2037213002
Cr-Commit-Position: refs/heads/master@{#397877}

GLImageOzoneNativePixmap used to check that format and internal format
were valid, but didn't check that they were compatible.

This CL restricts the valid internalformats given the buffer format
used to initialize the image (e.g: it's now prohibited to initialize with
an R8 buffer an GL_RGBA image).

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus

Review-Url: https://codereview.chromium.org/2037983003
Cr-Commit-Position: refs/heads/master@{#397876}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a352c80b..9ceb2d30

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2036273003
Cr-Commit-Position: refs/heads/master@{#397875}

Share the same BeginFrameSource implementation with chrome.

The old synchronous begin frame IPC is split into two parts:
an async begin frame IPC (shared with rest of chrome),
and a sync IPC to synchronously retrieve the renderer state.

Note needs_begin_frame is no longer part of the synchronous
state retrieved from renderer. This is ok because input
is already async and that's the only time when having an
up-to-date needs_begin_frame really matters.

This removes the whole synchronous compositor "IsActive"
concept since it's superceded completely by visibility.

BUG=609977

Review-Url: https://codereview.chromium.org/1969263004
Cr-Commit-Position: refs/heads/master@{#397874}

Fixes a regression from https://codereview.chromium.org/2009853002
IDK why it matters or if it relates to [still] broken window dragging.

TODO: Fix wallpaper picker dragging (not broken by same CL)...

BUG=557405
TEST=wallpaper picker shows for "Set wallpaper..." in mash.
R=markdittmer@chromium.org,sky@chromium.org,sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2037013003
Cr-Commit-Position: refs/heads/master@{#397873}

Adding logic to add a column if there wasn't one when upgrading.

BUG=615549

Review-Url: https://codereview.chromium.org/2019333008
Cr-Commit-Position: refs/heads/master@{#397872}

There is no pattern in //components of organizing individual
components by logical module. This patch moved
//components/ui/zoom to top-level under //components.

BUG=615568

Review-Url: https://codereview.chromium.org/2019423005
Cr-Commit-Position: refs/heads/master@{#397871}

BUG=613685

Review-Url: https://codereview.chromium.org/2037223002
Cr-Commit-Position: refs/heads/master@{#397870}

"frame-src" is deprecated, and is replaced by "child-src".

BUG=81636, 336788

Review-Url: https://codereview.chromium.org/2012393003
Cr-Commit-Position: refs/heads/master@{#397869}

This will make the Maps test work on Android bots on the commit queue.

BUG=616297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2037933003
Cr-Commit-Position: refs/heads/master@{#397868}

This patch adds the 'total' field to 'PaymentDetails' and makes
'displayItems' field optional. Additional tests in this patch:

 * 'total' is required.
 * 'total.value' cannot start with '-'.
 * Undefined and empty 'displayItems' are OK.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentdetails-dictionary
https://github.com/w3c/browser-payment-api/commit/9ef1dd251089299fe3a50df6ff77f02821f7663f

This patch also removes the no-longer-used 'id' from display items in
several tests.

BUG=616568

Review-Url: https://codereview.chromium.org/2030193002
Cr-Commit-Position: refs/heads/master@{#397867}

Adds a simple Interstitial API.

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2039613002
Cr-Commit-Position: refs/heads/master@{#397866}

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923

Review-Url: https://codereview.chromium.org/2031833002
Cr-Commit-Position: refs/heads/master@{#397865}

https://boringssl.googlesource.com/boringssl/+log/bbd43b5e90c073a3c8b719d538a273fe683b9944..0fc7df55c04e439e765c32a4dd93e43387fe40be

TBR=svaldez@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2034043003
Cr-Commit-Position: refs/heads/master@{#397864}

This consolidates the certificate parsing from various places in
verify_certificate_chain.cc into a single class that pre-parses all the
important information.
The relevant places are all changed to use the new ParsedCertificate
class, and TrustStore is separated into its own file.

BUG=410574

Review-Url: https://codereview.chromium.org/1976433002
Cr-Commit-Position: refs/heads/master@{#397863}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ccb73566fef2..71d985b3c851

$ git log ccb73566f..71d985b3c --date=short --no-merges --format='%ad %ae %s'

BUG=546021,616832

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2039653002
Cr-Commit-Position: refs/heads/master@{#397862}

Types such as RefPtr<P> provide a custom isEmptyValue function in their
HashTraits. This fixes the std::pair HashTraits to support using such
types in a std::pair.

Review-Url: https://codereview.chromium.org/2042453002
Cr-Commit-Position: refs/heads/master@{#397861}

If a node becomes invalid, the cursor snaps to the nearest valid ancestor.
Fixing this uncovered a lot of places where we were assuming that a cursor's
node must be valid, but it's possible that even with this new check that
a cursor could still be invalid, so I added checks in a lot of places.

BUG=613694
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2007183002
Cr-Commit-Position: refs/heads/master@{#397860}

Revert of Mark some AwContentsClientFullScreenTest tests flaky. (patchset #2 id:20001 of https://codereview.chromium.org/2011453002/ )

Reason for revert:
Avoid disabling these tests on CQ

Original issue's description:
> Mark some AwContentsClientFullScreenTest tests flaky.
>
> BUG=614318
>
> Committed: https://crrev.com/22a7f8467da532e4ab9f07256de4a11e93888341
> Cr-Commit-Position: refs/heads/master@{#395588}

TBR=torne@chromium.org,mvanouwerkerk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=614318

Review-Url: https://codereview.chromium.org/2039463004
Cr-Commit-Position: refs/heads/master@{#397859}

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

This wasn't included in the original CL because the clang tool got
confused when processing this file. It turns out true and false can be
macros!

BUG=581865

Review-Url: https://codereview.chromium.org/2041513002
Cr-Commit-Position: refs/heads/master@{#397858}

NativePixmap unittests were incorrectly using TEXTURE_2D target.

TEST='gl_unittests --gtest_also_run_disabled_tests' on samus

Review-Url: https://codereview.chromium.org/2038133004
Cr-Commit-Position: refs/heads/master@{#397857}

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513

Review-Url: https://codereview.chromium.org/2024303003
Cr-Commit-Position: refs/heads/master@{#397856}