GitLab

When building content_unittests for Cast on Android with mojo_media_host
as "browser", linker complains media::MojoRendererService::Create() is
undefined. Add //media/mojo/services as a dependency when
enable_mojo_media is true to resolve the error.

BUG=Internal b/37086171

Review-Url: https://codereview.chromium.org/2807743002
Cr-Commit-Position: refs/heads/master@{#463310}

The intent of the new algorithm is to allow resolution adjustment if the
resolution range allowed by constraints is a superset of the capabilities.
However, the actual capabilities are not currently known and, in practice,
resolution adjustment was allowed only when no constraints were specified.

This CL relaxes this rule to allow resolution adjustment by treating a max
constraint as if it were the actual capability. This should be updated so
that the actual native screen resolution is used as capability, but, in the
meantime, this fix is more compatible with existing applications that expect
the behavior of the old algorithm. Moreover, this patch does not affect spec
compliance since screen-resolution policies are not regulated by the spec as
long as the output resolution is within the constrained range.

BUG=709915

Review-Url: https://codereview.chromium.org/2800343005
Cr-Commit-Position: refs/heads/master@{#463309}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/af72fd8e..bd228187

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2806393002
Cr-Commit-Position: refs/heads/master@{#463308}

Both are needed for proper accelerate to software conversion.
getImageData wasn't calling needFinalizeFrame, so frames that only
called it, wouldn't be moved to software.
Also, when converting from accelerate, background-color/alpha wasn't
being properly propagated because we didn't updated compositing.

BUG=

Review-Url: https://codereview.chromium.org/2802353002
Cr-Commit-Position: refs/heads/master@{#463307}

The code was not handling a shipping option going away very well.

BUG=707240
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2808883002
Cr-Commit-Position: refs/heads/master@{#463306}

BUG=652781

Review-Url: https://codereview.chromium.org/2802363002
Cr-Commit-Position: refs/heads/master@{#463305}

Ed kindly pointer out that If you quickly tap on the forward or back toolbar navigation
arrow, the App would crash. That was caused since the button doesn't get disabled  fast enough after there's no more pages left to navigate.

This CL fixes that crash.

BUG=683793

Review-Url: https://codereview.chromium.org/2809563002
Cr-Commit-Position: refs/heads/master@{#463304}

BUG=skia:6465

Review-Url: https://codereview.chromium.org/2798413002
Cr-Commit-Position: refs/heads/master@{#463303}

Stop using kSingleProcess, which does not mean what we think it means.
Pass the correct webview process type to breakpad, so that microdumps
contain the correct information.

BUG=708773

Review-Url: https://codereview.chromium.org/2806733002
Cr-Commit-Position: refs/heads/master@{#463302}

Remove references to //ash/common, rewrite the top-level README.md, and
remove unnecessary DEPS.

BUG=none
TEST=checkdeps passes

Review-Url: https://codereview.chromium.org/2811643003
Cr-Commit-Position: refs/heads/master@{#463301}

The context menus API is another that violates the schema is defines
when calling sendRequest() through its custom bindings. Allow these
as well, similar to how we allow them when an API updates its
arguments post validation.

The context menus API also has functions defined as properties on object
parameters, and serializes these into dictionaries. Match the the
serialization into a dictionary, but don't serialize properties of the
function.

Add an end-to-end test for the contextMenus API with native bindings.

BUG=653596

Review-Url: https://codereview.chromium.org/2805123002
Cr-Commit-Position: refs/heads/master@{#463300}

https://skia.googlesource.com/skia.git/+log/f9aa9e51691d..b8ab7f7634fc

$ git log f9aa9e516..b8ab7f763 --date=short --no-merges --format='%ad %ae %s'
2017-04-10 borenet Fix BundleRecipes depending on Release-Shared build
2017-04-10 herb Add multi-stop SkJumper stage.
2017-04-10 bsalomon Move ref counting out of GrProcessor and into subclasses.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: I097954c955bc68e5c33c914740ee043638b16df5
Reviewed-on: https://chromium-review.googlesource.com/472927Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463299}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/658860

https://chromium.googlesource.com/chromium/src/+/112094796a99f

BUG=703971
TBR=tkent@chromium.org

Review-Url: https://codereview.chromium.org/2808903002 .
Cr-Commit-Position: refs/heads/master@{#463298}

The base::IsDirectoryEmpty() method returns true when the directory
doesn't exist or the directory is empty. We need to use
base::DirectoryExists() together with base::IsDirectoryEmpty() to
differentiate these two situations.

BUG=40407, 179576

Review-Url: https://codereview.chromium.org/2806873002
Cr-Commit-Position: refs/heads/master@{#463297}

Background: In order to tell which tests to download -expected.txt files for and which tests to update expectations for, wpt-update-expectations checks the type of the test. Previously TestParser was used to do this, but I want to get rid of TestParser.

This CL replaces TestParser by checking whether a test is a ref tests by calling port.reference_files, which in turn checks the MANIFEST.json for tests in external/wpt.

Review-Url: https://codereview.chromium.org/2805563002
Cr-Commit-Position: refs/heads/master@{#463296}

- Replace LockStateController::OnLockScreenHide with mojo call
  SessionController.RunUnlockAnimation so that it works on mash;
- Implement lock state change detection in SessionController
  and remove relevant part in LoginLockStateNotifier that needs
  to talk directly to Shell;

BUG=679450

Review-Url: https://codereview.chromium.org/2801333002
Cr-Commit-Position: refs/heads/master@{#463295}

The ContentScriptApiTest.ContentScriptOtherExtensions has the following
flow:

1. Register the inject.js content script to run at 'document_end'
   time.
2. Load iframe_content.{html,js} in an iframe.
3. On DOMContentLoaded, set a 10ms timer to report the iframe's contents
   to the test harness.
4. In 'inject.js', rewrite the page's content.
5. In the test harness, verify that the page reports the content mutated
   by inject.js.

The problem is that the timer registered in step 3 races with the
task[1] triggering the injection script since there's no explicit
synchronization between the two. Currently this works by accident, but
an upcoming change[2] in the Blink Scheduler will cause the test to
actually become flaky.

This change fixes the test by making the iframe report its contents
based on the load event rather than DOMContentLoaded. Since this is
guaranteed to happen after the injection has finished, there's no
possibility of out-of-order execution.

BUG=696001,701223

[1] blink::FrameLoader::finishedParsing
    => extensions::ScriptInjection::InjectJs
       => blink::SuspendableScriptExecutor::create
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=701223#c4

Review-Url: https://codereview.chromium.org/2800103002
Cr-Commit-Position: refs/heads/master@{#463294}

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189

Review-Url: https://codereview.chromium.org/2807723002
Cr-Commit-Position: refs/heads/master@{#463293}

In this CL we add histograms for recording how many times the user interacts
with MediaSession sorted by action type.

BUG=708617

Review-Url: https://codereview.chromium.org/2798083002
Cr-Commit-Position: refs/heads/master@{#463292}

https://pdfium.googlesource.com/pdfium.git/+log/d9dad3a19159..84b596d64aab

$ git log d9dad3a19..84b596d64 --date=short --no-merges --format='%ad %ae %s'
2017-04-10 npm Remove unreachable code in CFX_ScanlineCompositor

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2813663002
Cr-Commit-Position: refs/heads/master@{#463291}

The advantage is that if a test expectation like
EXPECT_EQ(alternative_service1, alternative_service2) fails in any test
in any file, then pretty printed contents of both alternative service
structs will be displayed.

The disadvantage is that this helper function is now in production code.
Note that the same approach is already used with a number of formatting
helper methods, for example, for SpdySettingsIds, SpdyFrameType,
Http2FrameType etc.

Repeating PrintTo() definition in every unittest.cc does not work: it
causes a namespace collision.  Moving it into anonymous namespace does
not work: gTest would not find it there, and it indeed fails with unused
function error.  There is no obvious place for this function:
//net/http/http_test_utils.h does not exist,
//net/spdy/spdy_test_utils.h or //net/quic/test_tools/quic_test_utils.h
is not quite the right place.

Review-Url: https://codereview.chromium.org/2808843002
Cr-Commit-Position: refs/heads/master@{#463290}

It is replaced with "Downloading..." string. This prevents the indeterminate progress bar reset on every notification update.
The Download Home behavior si unaffected (still has byte counter), and other state transitions (paused, pending etc) still work
as expected.

BUG=704049

Review-Url: https://codereview.chromium.org/2806143002
Cr-Commit-Position: refs/heads/master@{#463289}

Context menu presentation success relies on performance of
getElementFromPoint. If getElementFromPoint returns after long press
was recognized then Chrome misses the chance to show context menu and
WKWebView context menu shows up.

Merged |fetchWebPageWidthWithCompletionHandler:| and
|__gCrWeb.getElementFromPoint|  together to improve script execution
speed. This should make Chrome context menu failures less frequent.

BUG=542933

Review-Url: https://codereview.chromium.org/2801213004
Cr-Commit-Position: refs/heads/master@{#463288}

Reland of move unreachable code in HttpStreamFactoryImpl::Job::Orphan (patchset #1 id:1 of https://codereview.chromium.org/2806383002/ )

Reason for revert:
The build has stopped failing before this revert landed.

Original issue's description:
> Revert of Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan (patchset #1 id:1 of https://codereview.chromium.org/2801993006/ )
>
> Reason for revert:
> Compilation errors popped up in https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10288:
>
> ```
> [24309/50006] ACTION //net/http:transport_security_state_unittest_data(//build/toolchain/win:x64)
> FAILED: gen/net/http/transport_security_state_static_unittest2.h
> ```
>
> This is the only patch in the range that touches //net, so even though it doesn't look related, let's revert it anyway.
>
> Original issue's description:
> > Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan
> >
> > This CL removes unreachable code that handles WebSockets path in
> > HttpStreamFactoryImpl::Job::Orphan().
> >
> > WebSockets will not have two jobs, so the code is unreachable.
> >
> > This CL adds DCHECK(!for_websockets()) to make sure that the code
> > is indeed not reachable.
> >
> > BUG=475060
> >
> > Review-Url: https://codereview.chromium.org/2801993006
> > Cr-Commit-Position: refs/heads/master@{#463256}
> > Committed: https://chromium.googlesource.com/chromium/src/+/1122620622afb5b96b2c7b3ea907e2a5fb633f27
>
> TBR=bnc@chromium.org,xunjieli@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=475060
>
> Review-Url: https://codereview.chromium.org/2806383002
> Cr-Commit-Position: refs/heads/master@{#463266}
> Committed: https://chromium.googlesource.com/chromium/src/+/293aa6adadde2ee8e5266fb817582f7b7bc20b95

TBR=bnc@chromium.org,xunjieli@chromium.org,mkwst@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475060

Review-Url: https://codereview.chromium.org/2810783002
Cr-Commit-Position: refs/heads/master@{#463287}

BUG=707534
TEST=bug verified by clusterfuzz

Review-Url: https://codereview.chromium.org/2805393004
Cr-Commit-Position: refs/heads/master@{#463286}

TBR=kojii@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2808103002
Cr-Commit-Position: refs/heads/master@{#463285}

In resource_sizes.py, we check for static initializers using readelf
and using dump-static-initializers.py. The latter requires an
unstripped .so file. In some 64 bit APKs (i.e. MonochromePublic.apk), a
32 bit binary is also included but since this binary isn't located in
the normal location ($OUTDIR/lib.unstripped/), we currently just check
the 64 bit binary twice.

This also makes |_VerifyBuildIdsMatch()| fail (which was previously
added incorrectly in https://codereview.chromium.org/2706243013) since
we try to verify the build ids of two different binaries (32 and 64 bit
versions).

To simplify this, we ignore 32 bit .so files when 64 bit .so file are
present since the 32 bit .so files will be checked by other bots.

BUG=708942

Review-Url: https://codereview.chromium.org/2797163006
Cr-Commit-Position: refs/heads/master@{#463284}

PendingHidTransfer does not need to be a MessageLoop destruction
observer because these objects live on the main thread and are freed
synchronously when the HidConnectionWin is closed.

BUG=650723

Review-Url: https://codereview.chromium.org/2802093009
Cr-Commit-Position: refs/heads/master@{#463283}

https://skia.googlesource.com/skia.git/+log/1dd161c83392..f9aa9e51691d

$ git log 1dd161c83..f9aa9e516 --date=short --no-merges --format='%ad %ae %s'
2017-04-10 borenet Clean up no-longer-used recipes stuff
2017-04-07 msarett Add SkImageFilter::makeColorSpace(SkColorSpaceXformer*)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: Ie6f8fc3d6b22ef5784e25465d8b78c14d0b5711b
Reviewed-on: https://chromium-review.googlesource.com/473086Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463282}

The blink rename script renamed some constant const kFoos to k_foos.
Undo that again manually.

No intended behavior change.

BUG=578344,675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2812643002
Cr-Commit-Position: refs/heads/master@{#463281}

Text track needs to derive the default font for the cues from the size
of the <video> area, and currently does this by updating style during
the call to layout() on the LayoutTextTrackContainer, violating the
document lifecycle.

To avoid mutating style during layout, hook up a ResizeObserver from
TextTrackContainer to HTMLVideoElement and rely on the ResizeObserver
logic to iterate on the style and layout.

This eliminates the need to have a special LayoutObject for
TextTrackContainer, so just use a LayoutBlockFlow and remove all traces
of LayoutTextTrackContainer.

The media/track/track-cue-rendering.html test is updated to check sizes
after layout and paint instead of a forced layout.

BUG=372245

Review-Url: https://codereview.chromium.org/2803243002
Cr-Commit-Position: refs/heads/master@{#463280}

This removes almost every scoped nsobject in BVC, with exception of
HeaderDefinition struct that will be removed in the next CL.

R=marq
BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2806483002
Cr-Commit-Position: refs/heads/master@{#463279}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f0198028..af72fd8e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2808083002
Cr-Commit-Position: refs/heads/master@{#463278}

BUG=

Review-Url: https://codereview.chromium.org/2808433003
Cr-Commit-Position: refs/heads/master@{#463277}

Decouple chrome/browser/safe_browsing/threat_details* from the
dependency on the chrome/ layer. Also update the relevant tests.
This is in preparation for moving the reporting code to the
components/safe_browsing/.. to be usable by Android WebView.

Design doc:
https://goo.gl/8zVufq

BUG=700351, 688629

Review-Url: https://codereview.chromium.org/2784253004
Cr-Commit-Position: refs/heads/master@{#463276}

All answer text (other than the suggestion text and positive/negative
text) is now the de-emphasizing gray.

BUG=709101

Review-Url: https://codereview.chromium.org/2805873002
Cr-Commit-Position: refs/heads/master@{#463275}

Updates comments following Blink Rename.

BUG=

Review-Url: https://codereview.chromium.org/2813623002
Cr-Commit-Position: refs/heads/master@{#463274}

Here we are implementing one more IAccessibility method, accNavigate(), in
terms of ui::AXPlatformNodeWin. The idea is that we can forward
IAccessibility calls to ui::AXPlatformNodeWin and then slowly trim down,
and maybe remove, BrowserAccessibilityWin.

Note that this does not forward NAVDIR_. That will be a follow up.

BUG=703369

patch from issue 2789333002 at patchset 40001 (http://crrev.com/2789333002#ps40001)

Review-Url: https://codereview.chromium.org/2806963002
Cr-Commit-Position: refs/heads/master@{#463273}

"Detach the global object OR NOT" doesn't matter much, or it does not
make a good sense.  "detach the global object OR context's frame was
detached from the DOM" makes much more sense.

This CL replaces GlobalDetachmentBehavior with Lifecycle, and
emphasizes the latter point.

BUG=

Review-Url: https://codereview.chromium.org/2808093002
Cr-Commit-Position: refs/heads/master@{#463272}

Only UI code should live in ios/shared/chrome (i.e. all code should
be below ios/shared/chrome/browser/ui), so move WebStateList code to
ios/chrome/browser/web_state_list.

CL automated using tools/git/move_source_files.py and git cl format
plus some editing to fix the name of the target in BUILD.gn files.

BUG=None

Review-Url: https://codereview.chromium.org/2806353002
Cr-Commit-Position: refs/heads/master@{#463271}