- 12 Jul, 2019 40 commits
-
-
Clemens Arbesser authored
A recent change from explicit UMA sizes to implicitly inferred ones is causing an issue with one of our UMA histograms, DropOutReason ('Histogram Android.AutofillAssistant.DropOutReason has mismatched construction arguments'). This CL reverts back to using explicit UMA sizes, which fixes the issue for now. A proper fix will likely require a change of UMA code. Bug: 806868 Change-Id: I9ec291d0ed3f4a8e49b90a4f751ea9e66acc8134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699606 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676861}
-
Luke Zielinski authored
This list was generated manually as part of auditing baseline files for running WPT on CQ. Any baseline that couldn't obviously be mapped to a test was included in this CL, and then some were trimmed away based on trybot results. Bug: 801368 Change-Id: I0d4392aeb2a9297476de16c5aba45fb52bfc244f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697427Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676860}
-
Kuo Jen Wei authored
Fix the bug introduced by crrev/c/1657082 not fallbacking to normal getUserMedia. Test: On HAL v1/v3 device, CCA preview can show normally. Change-Id: I873b99722b262b406e3afd454e08921493d05935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699525Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#676859}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5081512502df..55adf4cf707b git log 5081512502df..55adf4cf707b --date=short --no-merges --format='%ad %ae %s' 2019-07-11 zoddicus@users.noreply.github.com Update execution scope rules for WebGPU (#2730) 2019-07-11 33432579+alan-baker@users.noreply.github.com Extra small storage validation (#2732) 2019-07-11 jbolz@nvidia.com Add validation for SPV_EXT_demote_to_helper_invocation (#2707) Also rolling transitive DEPS: src/third_party/spirv-headers/src de99d4d834ae..123dc278f204 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@55adf4cf707b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Change-Id: Ia1b2ab106f0a87ee40a22e547207b770ec5cf48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676858}
-
Jérôme Lebel authored
The primary identity is now set after loading the accounts. So the reconciler needs to start once the primary identity is set. This patch fixes those failing tests: -[ExternalURLSigninTestCase testSignInAddAccountCommand] -[ExternalURLSigninTestCase testSignInReauthenticate] -[ExternalURLSigninTestCase testSignInOneUser] Bug: 983141 Change-Id: Iaa6c47b64573838b55035d3b78dcb50dc2901d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698506 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676857}
-
Maksim Moskvitin authored
"Upgrade low risk" replaced with "First-time sign in", to make value meaning more clear. "Upgrade high risk" removed, it was never used and we have no plans to use it. Minor changes to align code with modern style guide. Bug: 983183 Change-Id: Ic4c204c2b4bd7684f96c80509fad25090cd65128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698364 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676856}
-
Julian Pastarmov authored
s/https://myaccounts.google.com/https://myaccount.google.com BUG=981550 TBR=ljusten Change-Id: I3c4f701b5ed3d0a3d638ae59e790391a48f26905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698530Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#676855}
-
Mike West authored
We're currently measuring whether or not a document is replaced by the execution of a JavaScript URL (e.g. if the JavaScript resulted in a string during navigation, in which case we navigate to a doc whose body is that string). We should figure out how many pageviews rely on `javascript:` execution generally, as that's going to be a larger number. R=andypaicu@chromium.org Change-Id: I474ed7a5072f99e90ddab56351fbc8e5fe327909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698529 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#676854}
-
Gyuyoung Kim authored
Some files of //ios have been including account_consistency_method.h even though they don't use AccountConsistencyMethod or DiceMethodGreaterOrEqual(). This CL removes all unnecessary account_consistency_method.h includes. Instead, this CL adds the include to the files where AccountConsistencyMethod is used actually. Bug: 970268 Change-Id: I7a7e18614523bd8783b73d09abb0ce0898f9ce9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699564 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#676853}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that the latter is only one subclass of O2TS. It moves ClearCache() and ClearCacheForAccount() into PO2TS and this CL stops exposing O2TS::RegisterTokenResponse() which adds a token to the cache since it's handled inside OAuth2AccessTokenManager. Bug: 967598 Change-Id: I1b05b0ac7fe2e6f8d0b22873d9eadaf370e2b78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699354 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676852}
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I800958a1e853e1c4c23cc76d178c8a64b6563e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698369 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676851}
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I6c02f60414bd525880af64e7edbd9cc3c5fd4c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699603Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#676850}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It moves StartRequest*(), InvalidateAccessToken(), and InvalidateTokenForMultilogin() from O2TS to PO2TS as there is no instance which refers to O2TS and all instances referred to O2TS take PO2TS with a precursor CL [1]. [1] https://crrev.com/c/1699262 Bug: 967598 Change-Id: I05be40a70f2304f72cc0aca53177800f1e4074e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695741 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676849}
-
Eric Stevenson authored
https://chromium-review.googlesource.com/c/chromium/src/+/1695855 will convert all native methods to use @NativeMethod interfaces. This CL updates cronet packaging to ignore SysUtilsJni.class as well as SysUtils.class. Bug: 929661 Change-Id: I7eaa3f76a0362d1c4ce332b5a21e46469a84e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698668 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676848}
-
Mugdha Lakhani authored
manager was disabled. This becomes a problem if the callback is non-trivial. In this case, a barrier closure in BackgroundSyncLauncher was waiting on this to be called. BackgroundSyncManager: :FireReadyEventsImpl() wasn't calling a callback when the Change-Id: I043bdd8bc4b32fd419d8012dd0a127f0a3bd8615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697742 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#676847}
-
Manuel Rego Casasnovas authored
The following tests are failing on Mac because of crbug.com/983503: * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-001.html * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-002.html BUG=983503 Change-Id: I71c33780fd04fd8c1f9bf37187f429ae303cf352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698398Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#676846}
-
Mario Sanchez Prada authored
Convert implementation (RenderFrameHostImpl) in the browser process and the clients in the renderer process (FrameTest & LocalFrameClientImplTest), as well as the definition of the GetFrameHostTestInterface() in the interface blink.mojom.DocumentInterfaceBroker. Bug: 955171, 978694 Change-Id: I718629681aa83a69764a172c52e4d246d89651b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689196Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#676845}
-
Sylvain Defresne authored
Instead of using IdentityTestEnvironmentChromeBrowserState adaptor, convert the tests to work with a real AuthenticationService (backed by a fake ChromeIdentityService). See design doc: https://docs.google.com/document/d/11cqV7S3WCaeOaP63WQWvzNdvSFflgzwZs8GCgdwQ7Bc/preview Bug: 983171 Change-Id: I72b1395c4a0d733a7f37a45845a4520505ed5d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698502 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#676844}
-
Nasko Oskov authored
These histograms don't seem useful at this point in time and I think they can safely be removed. Bug: 975220 Change-Id: Iac6f8f069d97f96865dd88e120d1b58188feed6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697364 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676843}
-
Michael van Ouwerkerk authored
Bug: 972061 Change-Id: I9874fa48ac18e82d79fb1d9353c0174be1313f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697609Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#676842}
-
Ramin Halavati authored
A policy is added to enforce browser to start in guest mode. Bug: 953269 Change-Id: I0e76f40643a5d1dbfe2398247df87c37bcf3c097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657892 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#676841}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5085d9783708..d84fd2677c30 git log 5085d9783708..d84fd2677c30 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 vapier@chromium.org cipd: fix lint errors Created with: gclient setdep -r src/third_party/chromite@d84fd2677c30 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id4ff59ea1b5a31a2aee1128cff1bdd7351432e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676840}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/a53be27c2404..dd575bd308de git log a53be27c2404..dd575bd308de --date=short --no-merges --format='%ad %ae %s' 2019-07-11 andrewoverton@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@dd575bd308de The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I60b265df2a6d9a365a7aff5f893046b00f7b0c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676839}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/58388aa07c17..11820502b840 git log 58388aa07c17..11820502b840 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 mbonadei@webrtc.org Revert "Make new pacer padding more like old one" 2019-07-12 danilchap@webrtc.org Use default task queue factory in fuzzers 2019-07-12 ssilkin@webrtc.org Handle non-integer frame rates in video codec tests. 2019-07-12 qingsi@webrtc.org Use the dummy address 0.0.0.0:9 in the c= and the m= lines if the Created with: gclient setdep -r src/third_party/webrtc@11820502b840 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:927309,chromium:982108 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8b956995dbb9a66d81f999ccf3ff52e6e5263c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699557Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676838}
-
Mike Frysinger authored
Python 3 doesn't support the ur string prefix, and it's not needed: a plain r prefix works in both versions everywhere. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I5628fd57ac59906bd27c94f61aa5ea7e07807b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699353 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676837}
-
Sylvain Defresne authored
As discussed offline, remove the custom TestIdentityManagerObserver that is used to check behaviour instead of public API. Instead test that sign-in adds the accounts from faked system to IdentityManager. Use shared TestIdentityManagerObserver to check that the errors are cleared when the application goes back into foreground (since this test behaviour of AuthenticationService, not IdentityManager). Remove unnecessary FakeSigninClient since it does not override any methods from IOSChromeSigninClient. Instead use the default factory. Bug: none Change-Id: I59f43e83c5caa3aad595361c8144ba4f1ca83895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697014 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676836}
-
Matthias Körber authored
Change-Id: I44ad30be9d24df7de18a2627417a6a34886927c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660662 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676835}
-
Sylvain Defresne authored
This method is unnecessary for two reasons. 1. as IdentityManagerFactory constructor declares dependencies on other KeyedService's factories, this ensures they are built 2. IdentityManagerFactory now only depends on SigninClientFactory that is created from EnsureBrowserStateKeyedServiceFactoriesBuilt Bug: none Change-Id: Icaa1b443519afbab90752d7869957458f5149d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696966 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#676834}
-
Tarun Bansal authored
They seem to be obsoleted in either M-68 or M-69. I did not dig up too deep to get the exact milestone. Change-Id: Ifb72d7e95bdfefcf33bccc39ef1132ae055c2960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699725 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676833}
-
Henrique Ferreiro authored
After all usage of Profile and dependencies on //chrome/browser code have been moved out of ProfileOAuth2TokenServiceBuilder, profile_oauth2_token_service_builder.* can be moved to //components/signin/internal/identity_manager. In this CL, the profile path is added to IdentityManagerBuildParams and the code to build the AccountTrackerService is moved into IdentityManagerBuilder. This CL finishes internalizing the creation of IdentityManager in Linux, Chrome OS and Android platforms. Bug: 974198 Change-Id: I41edeef9a73d7f624ee646052c3814e883e81bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690579 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676832}
-
Abhijeet Kandalkar authored
The primary goal of this CL is to convert usage of MediaControllerImageObserver interface and port dependent files to adopt new implementation. Bug: 955171 Change-Id: I15e76a25eee48513594c223128b83846c7061f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686710 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#676831}
-
Sylvain Defresne authored
Downstream usage has been removed, the overload can now be deleted safely without breaking the autoroller. Bug: 982681 Change-Id: Ibee48b9071cd8c3ae7b473a3e5bef7a4d1a90399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695308 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#676830}
-
Hajime Hoshi authored
WebGL uses GPU resources. If a page in the back forward cache uses WebGL, the page would keep the resources on GPU and this might be problematic for other pages as GPU resources are limited. Another option would be to cause context lost, but this is still controversial. Most websites don't prepare for context lost and increasing possibility of context lost might break websites. Bug: 981740 Change-Id: Ib04680d9be76258c220d2f0e385eb10a17de567d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697189Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#676829}
-
Fergal Daly authored
This describes the implementation of the current prototype and the various other approaches we are considering. Change-Id: I1538d0fe6f5668fa1e05f05c9ed7b161f6559aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698361Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676828}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. AccountInfoFetcher and AccessTokenFetcher take PO2TS instead of O2TS as they have used PO2TS instances and O2TS is supposed to be folded into PO2TS. Bug: 967598 Change-Id: I8cdad9a435a62253665babac1e5188f92818eb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699262Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#676827}
-
Fergal Daly authored
Change-Id: Ia5da0520e1d4aa444ba6f04a37fc9771eb0b4d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698023Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676826}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/05439f5cc69e..12e4307dc7b4 git log 05439f5cc69e..12e4307dc7b4 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 bungeman@google.com Properly handle phantom points for variation fonts (#56601). Created with: gclient setdep -r src/third_party/freetype/src@12e4307dc7b4 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: 981443 Change-Id: I9c9de723d302a9e42ec5ed3fd5354233fab76c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699550Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676825}
-
Yutaka Hirano authored
To make StrongAlias<Tag, bool> more attractive for replacing enum used for boolean params, introduce explicit conversion to the underlying type to StrongAlias. Bug: 983022 Change-Id: I14599f05c558dbce9d0d86256079eddc6cea0a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697401 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#676824}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that the latter is only one subclass of O2TS. It moves oauth2_token_service_unittest.cc to profile_oauth2_token_service_unittest.cc since O2TS works only with PO2TS. Bug: 967598 Change-Id: I37aaa7ac759b24dacf4b8dd48b20d47b5305abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697066 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676823}
-
arthursonzogni authored
Pages in the BackForwardCache and the current one need to use a different set of RenderView. The RenderView manages a WebView object from blink, which hosts a blink frame tree. Two differents pages can't be in the same frame tree. They need to use a different set of blink::Page. This CL requires the old page to live in a different BrowsingInstance than any other page in order to enter the BackForwardCache. Bug: 977562 Change-Id: I2ec5c4d39f7f546991f4a890e81cc2968e045e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683521 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676822}
-